)]}'
{".gitignore":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"6010dfe4a8f89762e8855ae9f4a15377ce4896d5","unresolved":true,"context_lines":[{"line_number":1,"context_line":".tox"},{"line_number":2,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"6ec9413f_51083b77","line":2,"updated":"2022-06-21 12:38:58.000000000","message":"Is it really required?","commit_id":"0f8629c79bd23860387174ae5d4de8290c92d1ca"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"45a85f88a95ea3eff40c2fd9929151ce16aefc31","unresolved":false,"context_lines":[{"line_number":1,"context_line":".tox"},{"line_number":2,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"51f91de6_e3ab65d6","line":2,"in_reply_to":"225d45b4_bb942fad","updated":"2022-06-21 13:55:31.000000000","message":"This is a git improvement to facilitate design work. No worries.","commit_id":"0f8629c79bd23860387174ae5d4de8290c92d1ca"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"e13ceb9f4c233fc073486199c1c0685db19595eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":".tox"},{"line_number":2,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"a039ccbd_c0d7ede6","line":2,"in_reply_to":"6ec9413f_51083b77","updated":"2022-06-21 12:59:50.000000000","message":"This is an improvement for git to ignore the PyCharm auto-generated .idea folder.\nOtherwise git will mark it as untracked, and we have to either manually delete it everytime, and lose the PyCharm config, or we have to add each changed file individually.","commit_id":"0f8629c79bd23860387174ae5d4de8290c92d1ca"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"b39157ad6617d093b1943ba878972b2f6709768b","unresolved":true,"context_lines":[{"line_number":1,"context_line":".tox"},{"line_number":2,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"225d45b4_bb942fad","line":2,"in_reply_to":"a039ccbd_c0d7ede6","updated":"2022-06-21 13:44:54.000000000","message":"I don\u0027t think this is really required.\nThe PyCharm is an specific IDE that one can use or not, that\u0027s a personal choice and we should not mix specific IDE code to the repo code here, IMHO.\n\nAbout git, what\u0027s the big deal on having that IDE specific dir untracked? One could simply not add the .idea/ files to any commit and life will go on.","commit_id":"0f8629c79bd23860387174ae5d4de8290c92d1ca"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"fa7bdd2766d98b2a8a1ee3ad5489400b7be2f369","unresolved":true,"context_lines":[{"line_number":1,"context_line":".gitignore"},{"line_number":2,"context_line":".tox"},{"line_number":3,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"e50b051c_9377274c","line":1,"updated":"2022-06-22 13:17:45.000000000","message":"remove .gitignore from the gitignore or the changes on it will never get to the repository","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2d2ca3d88b33d00cf4af7a725482817e9297b4fb","unresolved":true,"context_lines":[{"line_number":1,"context_line":".gitignore"},{"line_number":2,"context_line":".tox"},{"line_number":3,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"6f643489_873cb2d3","line":1,"in_reply_to":"1d1473ee_5792378c","updated":"2022-06-22 13:50:05.000000000","message":"Marking as unresolved, this last version of gerrit assumes too much.","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2635897a5d568e1b7835d8d78316aa5e8fca040b","unresolved":false,"context_lines":[{"line_number":1,"context_line":".gitignore"},{"line_number":2,"context_line":".tox"},{"line_number":3,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"1d1473ee_5792378c","line":1,"in_reply_to":"5c9d6b0a_226f1bc7","updated":"2022-06-22 13:48:45.000000000","message":"But if someone have the intention to actually add a new folder to .gitignore it [1] won\u0027t be staged and/or [2]will conflict with the .gitignore a user has on every pull/sync. We don\u0027t want either of that happening.\n\nBtw, I\u0027m not against the .idea on the .gitignore. Anything that would avoid me wasting time with unwanted things on a review LGTM.","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"5a352b71fe382af9cefa1f7b05ed95d9f53c23b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":".gitignore"},{"line_number":2,"context_line":".tox"},{"line_number":3,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"49a69ea1_3f6d3fde","line":1,"in_reply_to":"6f643489_873cb2d3","updated":"2022-06-22 14:11:15.000000000","message":"OK, while we dont have a better solution, lets keep tracking the .gitignore","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"9d80e1adb07c2b801d543005fb140d0325becc5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":".gitignore"},{"line_number":2,"context_line":".tox"},{"line_number":3,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"5c9d6b0a_226f1bc7","line":1,"in_reply_to":"e50b051c_9377274c","updated":"2022-06-22 13:35:25.000000000","message":"As per git documentation, a gitignore file specifies *intentionally untracked* files that Git should ignore. Files already tracked by Git are not affected. \n\nHaving said that, marking .gitignore as untracked means that one can mantain the list of intentionally untracked files, without being tracked by git. There is no need to track the files (in repository) which are  *intentionally untracked*. From git repository perspective, these will simply \"not exist\".","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"}],"/COMMIT_MSG":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"52dcfc8d13875b9baa86283687ac835719e71dbf","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  OpenStack removal is performed sequentially for this"},{"line_number":45,"context_line":"  group, in the reverse order, compared to the OpenStack"},{"line_number":46,"context_line":"  Armada App manifest."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Signed-off-by: rferraz \u003cRogerioOliveira.Ferraz@windriver.com\u003e"},{"line_number":49,"context_line":"Change-Id: I268ab75a849734874646b5f23b0bcdbe5faae1ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1742a544_4710ad25","line":47,"updated":"2022-06-02 18:50:13.000000000","message":"Is there a Story/Task/Bug associated with this?","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"69ea62d04e080b16be67f75f0d2aeb86003fc18f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  OpenStack removal is performed sequentially for this"},{"line_number":45,"context_line":"  group, in the reverse order, compared to the OpenStack"},{"line_number":46,"context_line":"  Armada App manifest."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Signed-off-by: rferraz \u003cRogerioOliveira.Ferraz@windriver.com\u003e"},{"line_number":49,"context_line":"Change-Id: I268ab75a849734874646b5f23b0bcdbe5faae1ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"4708d211_b419e7df","line":47,"in_reply_to":"1742a544_4710ad25","updated":"2022-06-07 14:34:53.000000000","message":"The proposed change is actually a system improvement in order to prevent from bugs such as the one reported below.\nhttps://bugs.launchpad.net/nova/+bug/1892659","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"87c66369693e736c16d0cf78a606e6f35e8d0c6e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  OpenStack removal is performed sequentially for this"},{"line_number":45,"context_line":"  group, in the reverse order, compared to the OpenStack"},{"line_number":46,"context_line":"  Armada App manifest."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Signed-off-by: rferraz \u003cRogerioOliveira.Ferraz@windriver.com\u003e"},{"line_number":49,"context_line":"Change-Id: I268ab75a849734874646b5f23b0bcdbe5faae1ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f182887c_41355a53","line":47,"in_reply_to":"4708d211_b419e7df","updated":"2022-06-07 14:37:12.000000000","message":"Done","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"47149d270cc92ca2ec99474cdf98de25c4d0b4fe","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TESTS                                                       STATUS"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- After a fresh deployment of existing OpenStack codebase   PASSED"},{"line_number":15,"context_line":"  check that VMs can be launched successfully"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Delete VMs and remove OpenStack, without a cleanup of     PASSED"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"05d3fb2a_b370d6e7","line":14,"updated":"2022-06-08 12:27:34.000000000","message":"nit: \"OpenStack codebase\" is the stx-openstack application in this context, correct? Isn\u0027t better to call the application by its name to easy this message reading?\n\nIMO this comment applies to all the following \"OpenStack\" references","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"7766f7c63b7108b2db23261821de4898c9fa93e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TESTS                                                       STATUS"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- After a fresh deployment of existing OpenStack codebase   PASSED"},{"line_number":15,"context_line":"  check that VMs can be launched successfully"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Delete VMs and remove OpenStack, without a cleanup of     PASSED"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"355dbdbd_e7ea0acc","line":14,"in_reply_to":"05d3fb2a_b370d6e7","updated":"2022-06-13 17:15:34.000000000","message":"Done","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"47149d270cc92ca2ec99474cdf98de25c4d0b4fe","unresolved":true,"context_lines":[{"line_number":14,"context_line":"- After a fresh deployment of existing OpenStack codebase   PASSED"},{"line_number":15,"context_line":"  check that VMs can be launched successfully"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Delete VMs and remove OpenStack, without a cleanup of     PASSED"},{"line_number":18,"context_line":"  network resources. After re-deploying OpenStack, verify"},{"line_number":19,"context_line":"  that an error scenario arises where new VMs can not be"},{"line_number":20,"context_line":"  launched, with the following error message:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ec0203d0_a8932392","line":17,"updated":"2022-06-08 12:27:34.000000000","message":"This seems to me like the original issue description, not a test.\nShould be placed in this commit message \"explanatory text\" and/or in a related launchpad bug","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"7766f7c63b7108b2db23261821de4898c9fa93e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- After a fresh deployment of existing OpenStack codebase   PASSED"},{"line_number":15,"context_line":"  check that VMs can be launched successfully"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Delete VMs and remove OpenStack, without a cleanup of     PASSED"},{"line_number":18,"context_line":"  network resources. After re-deploying OpenStack, verify"},{"line_number":19,"context_line":"  that an error scenario arises where new VMs can not be"},{"line_number":20,"context_line":"  launched, with the following error message:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"58aa325a_33db8234","line":17,"in_reply_to":"ec0203d0_a8932392","updated":"2022-06-13 17:15:34.000000000","message":"I added a explanatory text indicating that this is a system improvement to prevent from similar bugs as the one I listed.","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"47149d270cc92ca2ec99474cdf98de25c4d0b4fe","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- Verify that the OpenStack removal sequence of the charts  PASSED"},{"line_number":37,"context_line":"  corresponds to the reverse of the deployment sequence,"},{"line_number":38,"context_line":"  except for the OpenStack compute-kit group, for which"},{"line_number":39,"context_line":"  the charts are deployed in parallel, as per definition"},{"line_number":40,"context_line":"  in the OpenStack Armada App manifest."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"2fd4adcf_ca1ba1ee","line":38,"updated":"2022-06-08 12:27:34.000000000","message":"The compute-kit chart group is deployed in parallel but removed in sequence, is that what you mean here? It\u0027s not so clear IMO","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"7766f7c63b7108b2db23261821de4898c9fa93e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- Verify that the OpenStack removal sequence of the charts  PASSED"},{"line_number":37,"context_line":"  corresponds to the reverse of the deployment sequence,"},{"line_number":38,"context_line":"  except for the OpenStack compute-kit group, for which"},{"line_number":39,"context_line":"  the charts are deployed in parallel, as per definition"},{"line_number":40,"context_line":"  in the OpenStack Armada App manifest."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"53e93028_0c239e95","line":38,"in_reply_to":"2fd4adcf_ca1ba1ee","updated":"2022-06-13 17:15:34.000000000","message":"Yes indeed, but the removal sequence is sequencial for all charts (as from design base), not only for the charts in compute-kit group.","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"47149d270cc92ca2ec99474cdf98de25c4d0b4fe","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  OpenStack removal is performed sequentially for this"},{"line_number":45,"context_line":"  group, in the reverse order, compared to the OpenStack"},{"line_number":46,"context_line":"  Armada App manifest."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Signed-off-by: rferraz \u003cRogerioOliveira.Ferraz@windriver.com\u003e"},{"line_number":49,"context_line":"Change-Id: I268ab75a849734874646b5f23b0bcdbe5faae1ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7987b5c2_537575bb","line":47,"updated":"2022-06-08 12:27:34.000000000","message":"Is there a launchpad bug or story/task related to this change?","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"7766f7c63b7108b2db23261821de4898c9fa93e8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  OpenStack removal is performed sequentially for this"},{"line_number":45,"context_line":"  group, in the reverse order, compared to the OpenStack"},{"line_number":46,"context_line":"  Armada App manifest."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Signed-off-by: rferraz \u003cRogerioOliveira.Ferraz@windriver.com\u003e"},{"line_number":49,"context_line":"Change-Id: I268ab75a849734874646b5f23b0bcdbe5faae1ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"24ddd399_c87faa3e","line":47,"in_reply_to":"283f9970_a1e22bf4","updated":"2022-06-13 17:15:34.000000000","message":"Yes, this system improvement prevents from bugs like this one.","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"b2a54f4f20b183c7285374c3cf3eaa88f5bfbb52","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  OpenStack removal is performed sequentially for this"},{"line_number":45,"context_line":"  group, in the reverse order, compared to the OpenStack"},{"line_number":46,"context_line":"  Armada App manifest."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Signed-off-by: rferraz \u003cRogerioOliveira.Ferraz@windriver.com\u003e"},{"line_number":49,"context_line":"Change-Id: I268ab75a849734874646b5f23b0bcdbe5faae1ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"283f9970_a1e22bf4","line":47,"in_reply_to":"7987b5c2_537575bb","updated":"2022-06-08 12:48:09.000000000","message":"Sorry, just saw your answer to Steven\u0027s comment. \nWould https://bugs.launchpad.net/nova/+bug/1892659 be a Partil-Bug: for this change? \nIf not I still think that we should create a bug describing the issue that this change is fixing.","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"f57826e16da1e0445c67aed640f84927d1dbf564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dee9ced7_f0b17786","updated":"2022-05-11 15:14:21.000000000","message":"I don\u0027t think you should be doing those patches that uses neutron on openstack-helm-infra since this is not the helm app that installs neutron after all.","commit_id":"a957883835ad350aa6685a5d00db9256b32da139"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"c5ea3abb4481dfe3eeb77a3811842eb43b8fe56f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2ee8b56_5f348cec","updated":"2022-05-11 15:11:23.000000000","message":"If there is no test plan yet, please set as Work in Progress","commit_id":"a957883835ad350aa6685a5d00db9256b32da139"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"842fc35d2bbb8824149239315b13ed97094cd33f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f794911e_4a0801b1","in_reply_to":"dee9ced7_f0b17786","updated":"2022-05-11 17:12:29.000000000","message":"Hi Thiago,\n\nThanks for your comment.\n\nIndeed, the selection of the Ingress chart was due to the fact that it is the first chart to be deleted in WRO removal time sequence.\n\nInitially we tried this change on the Neutron chart located in OpenStack Helm, but we got a problem that the Neutron chart is deleted after Keystone and other services were already removed when the helm pre-delete hook was triggered, so the OpenStack commands are not available to be executed at that point in time. Lets talk more about this, so we can see what are our alternatives, and agree on the solution","commit_id":"a957883835ad350aa6685a5d00db9256b32da139"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"2b451b61a1767e65899d2d0aa96327f1683c5d2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2044d8a4_c83e8de9","updated":"2022-05-25 12:45:30.000000000","message":"This is a preliminary version, so you can get familiar with the proposed change.\n\nIt is only missing the automated testing.","commit_id":"3271c31728746c4ba342d0a9f6d73b701c227c31"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"6eb5241a558aafb11f3f7f32e23d0450737294e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"197f3e55_bd252a21","updated":"2022-06-02 13:43:37.000000000","message":"The code has been improved for robustness. The testing part is a WIP.","commit_id":"0c566af0d14ec1a27137569fb40e5fa4104e17c2"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"87c66369693e736c16d0cf78a606e6f35e8d0c6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"185ac389_00b39ce8","updated":"2022-06-07 14:37:12.000000000","message":"Thanks for your comments Steven! I published a new patchset.","commit_id":"24d980ae4b8d6d59a2fa9fd49d36921a6e6ca29f"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"61cd748a3eade974e002431fb8c8532df4a8678d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b850f5ab_5fa188a4","updated":"2022-06-13 20:17:43.000000000","message":"Added more reviewers","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"ece26a84aaf29c9e674f20959c25fb5bf40373e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a9f0d1cf_017277d0","updated":"2022-06-13 18:11:59.000000000","message":"Now the solution is complete, including the automated unit tests.\n\nPlease help to review.","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"e3639fb4874a9b5f078d8c03f5352b6dfa76e739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"81d3429a_3bb55cd3","updated":"2022-06-14 14:25:49.000000000","message":"Overall it seems ok\nWould like to get Steven and Thiago views on it though","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"aaaf9adc54e5f23dc5b02e090b3ca47f0f8762c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"89cf9828_d9f579c0","updated":"2022-06-20 18:14:53.000000000","message":"If you don\u0027t mind, I\u0027d like and explanation about why you are using a privileged container. There are a few nits on the import order that I\u0027m baffled flake8 didn\u0027t get. Almost good to go.","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"9167e033aea4be070bd61e81eb05834a9e3a8aa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4619f19e_5650dcb9","updated":"2022-06-16 20:45:28.000000000","message":"LGTM","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"3b8a3e0c35e1c1c171b69004351a1c9735979869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"85b6ac70_ecb1cb6e","in_reply_to":"89cf9828_d9f579c0","updated":"2022-06-21 21:16:29.000000000","message":"I had based this code on other existing jobs from Neutron chart, but I reckon that it was not really necessary.","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"c54e6a11ebd71720de6d64d790bdbbeedb813072","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"22568f73_0cae5c1d","updated":"2022-06-22 15:12:14.000000000","message":"Bob Church, Lucas C., please can you help to review ?","commit_id":"b5b4cc562a4c7d705d108a8280dc1b246159d90b"}],"openstack-helm/debian/deb_folder/patches/0016-Network-Resources-Cleanup-before-OpenStack-Removal.patch":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"149c3b670f200f62881c9e9d8ac95739ca7ce4a6","unresolved":true,"context_lines":[{"line_number":6,"context_line":"This patch introduces a new helm pre-delete hook for the purpose"},{"line_number":7,"context_line":"to cleanup network resources before OpenStack removal."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test Plan: TBD"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"       new file:   neutron/templates/bin/_neutron-resources-cleanup.sh.tpl"},{"line_number":12,"context_line":"       new file:   neutron/templates/job-resources-cleanup.yaml"}],"source_content_type":"text/x-diff","patch_set":12,"id":"56db60d0_0dcc7ce9","line":9,"updated":"2022-06-15 02:52:51.000000000","message":"Can you update this","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"df5866affea55a51995b58ad57fe2ebe6c698b89","unresolved":false,"context_lines":[{"line_number":6,"context_line":"This patch introduces a new helm pre-delete hook for the purpose"},{"line_number":7,"context_line":"to cleanup network resources before OpenStack removal."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test Plan: TBD"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"       new file:   neutron/templates/bin/_neutron-resources-cleanup.sh.tpl"},{"line_number":12,"context_line":"       new file:   neutron/templates/job-resources-cleanup.yaml"}],"source_content_type":"text/x-diff","patch_set":12,"id":"fd135ec9_b620de61","line":9,"in_reply_to":"56db60d0_0dcc7ce9","updated":"2022-06-16 10:38:01.000000000","message":"Done","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"aaaf9adc54e5f23dc5b02e090b3ca47f0f8762c1","unresolved":true,"context_lines":[{"line_number":393,"context_line":"+      container:"},{"line_number":394,"context_line":"+        neutron_resources_cleanup:"},{"line_number":395,"context_line":"+          readOnlyRootFilesystem: true"},{"line_number":396,"context_line":"+          privileged: true"},{"line_number":397,"context_line":"   affinity:"},{"line_number":398,"context_line":"     anti:"},{"line_number":399,"context_line":"       type:"}],"source_content_type":"text/x-diff","patch_set":13,"id":"e796d035_b8cd582f","line":396,"updated":"2022-06-20 18:14:53.000000000","message":"Are you sure you need a privileged container to run this? Since this is only calls to the CLI, I would imagine you don\u0027t...","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"3b8a3e0c35e1c1c171b69004351a1c9735979869","unresolved":false,"context_lines":[{"line_number":393,"context_line":"+      container:"},{"line_number":394,"context_line":"+        neutron_resources_cleanup:"},{"line_number":395,"context_line":"+          readOnlyRootFilesystem: true"},{"line_number":396,"context_line":"+          privileged: true"},{"line_number":397,"context_line":"   affinity:"},{"line_number":398,"context_line":"     anti:"},{"line_number":399,"context_line":"       type:"}],"source_content_type":"text/x-diff","patch_set":13,"id":"a186ed4d_18f4a93a","line":396,"in_reply_to":"9162a3fd_e2fe2c44","updated":"2022-06-21 21:16:29.000000000","message":"Thanks for your comments. It is fixed now.","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"0983c297a0bd3f70b775990919696eaec480a250","unresolved":true,"context_lines":[{"line_number":393,"context_line":"+      container:"},{"line_number":394,"context_line":"+        neutron_resources_cleanup:"},{"line_number":395,"context_line":"+          readOnlyRootFilesystem: true"},{"line_number":396,"context_line":"+          privileged: true"},{"line_number":397,"context_line":"   affinity:"},{"line_number":398,"context_line":"     anti:"},{"line_number":399,"context_line":"       type:"}],"source_content_type":"text/x-diff","patch_set":13,"id":"9162a3fd_e2fe2c44","line":396,"in_reply_to":"e796d035_b8cd582f","updated":"2022-06-21 12:49:56.000000000","message":"I second that. From what I read form the script you at most need to add capabilites, not all privileges","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"fc8e57d111656789cdb6cd728f6db6122c5bdcd0","unresolved":true,"context_lines":[{"line_number":393,"context_line":"+      container:"},{"line_number":394,"context_line":"+        neutron_resources_cleanup:"},{"line_number":395,"context_line":"+          readOnlyRootFilesystem: true"},{"line_number":396,"context_line":"+          privileged: false"},{"line_number":397,"context_line":"   affinity:"},{"line_number":398,"context_line":"     anti:"},{"line_number":399,"context_line":"       type:"}],"source_content_type":"text/x-diff","patch_set":16,"id":"cd12ff46_0ac3c533","line":396,"updated":"2022-06-22 12:50:13.000000000","message":"nit: this has the same effect than removing the key, which would generate less code to maintain","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"5a352b71fe382af9cefa1f7b05ed95d9f53c23b1","unresolved":false,"context_lines":[{"line_number":393,"context_line":"+      container:"},{"line_number":394,"context_line":"+        neutron_resources_cleanup:"},{"line_number":395,"context_line":"+          readOnlyRootFilesystem: true"},{"line_number":396,"context_line":"+          privileged: false"},{"line_number":397,"context_line":"   affinity:"},{"line_number":398,"context_line":"     anti:"},{"line_number":399,"context_line":"       type:"}],"source_content_type":"text/x-diff","patch_set":16,"id":"5366ba4b_663b84ab","line":396,"in_reply_to":"9f5ac0d1_4817ebd0","updated":"2022-06-22 14:11:15.000000000","message":"Done","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"9d80e1adb07c2b801d543005fb140d0325becc5d","unresolved":true,"context_lines":[{"line_number":393,"context_line":"+      container:"},{"line_number":394,"context_line":"+        neutron_resources_cleanup:"},{"line_number":395,"context_line":"+          readOnlyRootFilesystem: true"},{"line_number":396,"context_line":"+          privileged: false"},{"line_number":397,"context_line":"   affinity:"},{"line_number":398,"context_line":"     anti:"},{"line_number":399,"context_line":"       type:"}],"source_content_type":"text/x-diff","patch_set":16,"id":"9f5ac0d1_4817ebd0","line":396,"in_reply_to":"cd12ff46_0ac3c533","updated":"2022-06-22 13:35:25.000000000","message":"I will fix it next patchset.","commit_id":"a76604615cb6f59dd7f541682a7eb6c82912efa9"}],"openstack-helm/files/0016-Network-Resources-Cleanup-before-OpenStack-Removal.patch":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"52dcfc8d13875b9baa86283687ac835719e71dbf","unresolved":true,"context_lines":[{"line_number":72,"context_line":"+    return 0"},{"line_number":73,"context_line":"+}"},{"line_number":74,"context_line":"+"},{"line_number":75,"context_line":"+function cleanup_vm_instances()"},{"line_number":76,"context_line":"+{"},{"line_number":77,"context_line":"+    local VMLIST\u003d\"\""},{"line_number":78,"context_line":"+    local ID\u003d\"\""}],"source_content_type":"text/x-diff","patch_set":7,"id":"268fc6f4_5e9acd60","line":75,"updated":"2022-06-02 18:50:13.000000000","message":"Although technically not a network resource, I understand the need for this in order to remove the ports.","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"69ea62d04e080b16be67f75f0d2aeb86003fc18f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"+    return 0"},{"line_number":73,"context_line":"+}"},{"line_number":74,"context_line":"+"},{"line_number":75,"context_line":"+function cleanup_vm_instances()"},{"line_number":76,"context_line":"+{"},{"line_number":77,"context_line":"+    local VMLIST\u003d\"\""},{"line_number":78,"context_line":"+    local ID\u003d\"\""}],"source_content_type":"text/x-diff","patch_set":7,"id":"cb02253b_d75af8d1","line":75,"in_reply_to":"268fc6f4_5e9acd60","updated":"2022-06-07 14:34:53.000000000","message":"Yes, the VMs need to be deleted as part of the process, and on a specific sequence, after the removal of trunk resources, otherwise, if the VMs are deleted before, it may happen that associated trunk resources get hanging, as explained in the following article.\nhttps://access.redhat.com/solutions/4993961","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"87c66369693e736c16d0cf78a606e6f35e8d0c6e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"+    return 0"},{"line_number":73,"context_line":"+}"},{"line_number":74,"context_line":"+"},{"line_number":75,"context_line":"+function cleanup_vm_instances()"},{"line_number":76,"context_line":"+{"},{"line_number":77,"context_line":"+    local VMLIST\u003d\"\""},{"line_number":78,"context_line":"+    local ID\u003d\"\""}],"source_content_type":"text/x-diff","patch_set":7,"id":"7dceb3ca_ca768b71","line":75,"in_reply_to":"cb02253b_d75af8d1","updated":"2022-06-07 14:37:12.000000000","message":"Done","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"149c3b670f200f62881c9e9d8ac95739ca7ce4a6","unresolved":true,"context_lines":[{"line_number":256,"context_line":"@@ -95,6 +95,8 @@ data:"},{"line_number":257,"context_line":" {{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":258,"context_line":"   neutron-test-force-cleanup.sh: |"},{"line_number":259,"context_line":" {{ tuple \"bin/_neutron-test-force-cleanup.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":260,"context_line":"+  neutron-resources-cleanup.sh: |"},{"line_number":261,"context_line":"+{{ tuple \"bin/_neutron-resources-cleanup.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":262,"context_line":" {{- if ( has \"tungstenfabric\" .Values.network.backend ) }}"}],"source_content_type":"text/x-diff","patch_set":12,"id":"d249b025_a6c4915b","line":259,"updated":"2022-06-15 02:52:51.000000000","message":"Is this _neutron-test-force-cleanup.sh related at all? I know you haven\u0027t added it here","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"df5866affea55a51995b58ad57fe2ebe6c698b89","unresolved":false,"context_lines":[{"line_number":256,"context_line":"@@ -95,6 +95,8 @@ data:"},{"line_number":257,"context_line":" {{- include \"helm-toolkit.scripts.rabbit_init\" . | indent 4 }}"},{"line_number":258,"context_line":"   neutron-test-force-cleanup.sh: |"},{"line_number":259,"context_line":" {{ tuple \"bin/_neutron-test-force-cleanup.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":260,"context_line":"+  neutron-resources-cleanup.sh: |"},{"line_number":261,"context_line":"+{{ tuple \"bin/_neutron-resources-cleanup.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":262,"context_line":" {{- if ( has \"tungstenfabric\" .Values.network.backend ) }}"}],"source_content_type":"text/x-diff","patch_set":12,"id":"885c4557_e3d1cdb1","line":259,"in_reply_to":"d249b025_a6c4915b","updated":"2022-06-16 10:38:01.000000000","message":"This job is related to the pod-rally-test.\nIt does not clean the network resources. It is","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/armada/manifest_openstack.py":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"47149d270cc92ca2ec99474cdf98de25c4d0b4fe","unresolved":true,"context_lines":[{"line_number":50,"context_line":"import ruamel.yaml as yaml"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"KEY_SCHEMA \u003d \u0027schema\u0027"},{"line_number":53,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \u0027armada/ChartGroup/v1\u0027"},{"line_number":54,"context_line":"VAL_SCHEMA_MANIFEST \u003d \u0027armada/Manifest/v1\u0027"},{"line_number":55,"context_line":"KEY_METADATA \u003d \u0027metadata\u0027"},{"line_number":56,"context_line":"KEY_METADATA_NAME \u003d \u0027name\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"c5e02693_815c9cc9","line":53,"updated":"2022-06-08 12:27:34.000000000","message":"Can\u0027t we make this constant version agnostic? Just wondering the impact on code maintenance that it would have...","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"7766f7c63b7108b2db23261821de4898c9fa93e8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"import ruamel.yaml as yaml"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"KEY_SCHEMA \u003d \u0027schema\u0027"},{"line_number":53,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \u0027armada/ChartGroup/v1\u0027"},{"line_number":54,"context_line":"VAL_SCHEMA_MANIFEST \u003d \u0027armada/Manifest/v1\u0027"},{"line_number":55,"context_line":"KEY_METADATA \u003d \u0027metadata\u0027"},{"line_number":56,"context_line":"KEY_METADATA_NAME \u003d \u0027name\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"c3c4224c_3f172ee2","line":53,"in_reply_to":"c5e02693_815c9cc9","updated":"2022-06-13 17:15:34.000000000","message":"Done","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"47149d270cc92ca2ec99474cdf98de25c4d0b4fe","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"KEY_SCHEMA \u003d \u0027schema\u0027"},{"line_number":53,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \u0027armada/ChartGroup/v1\u0027"},{"line_number":54,"context_line":"VAL_SCHEMA_MANIFEST \u003d \u0027armada/Manifest/v1\u0027"},{"line_number":55,"context_line":"KEY_METADATA \u003d \u0027metadata\u0027"},{"line_number":56,"context_line":"KEY_METADATA_NAME \u003d \u0027name\u0027"},{"line_number":57,"context_line":"KEY_DATA \u003d \u0027data\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"b1f10f92_af40bfd8","line":54,"updated":"2022-06-08 12:27:34.000000000","message":"ditto","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"7766f7c63b7108b2db23261821de4898c9fa93e8","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"KEY_SCHEMA \u003d \u0027schema\u0027"},{"line_number":53,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \u0027armada/ChartGroup/v1\u0027"},{"line_number":54,"context_line":"VAL_SCHEMA_MANIFEST \u003d \u0027armada/Manifest/v1\u0027"},{"line_number":55,"context_line":"KEY_METADATA \u003d \u0027metadata\u0027"},{"line_number":56,"context_line":"KEY_METADATA_NAME \u003d \u0027name\u0027"},{"line_number":57,"context_line":"KEY_DATA \u003d \u0027data\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"00f04ba4_7170d93e","line":54,"in_reply_to":"b1f10f92_af40bfd8","updated":"2022-06-13 17:15:34.000000000","message":"Done","commit_id":"a89d03d3c41629defd426ba7b126d4255e600544"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"aaaf9adc54e5f23dc5b02e090b3ca47f0f8762c1","unresolved":true,"context_lines":[{"line_number":44,"context_line":"from sysinv.common import constants"},{"line_number":45,"context_line":"from sysinv.common import exception"},{"line_number":46,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":47,"context_line":"from copy import deepcopy"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"import os"},{"line_number":50,"context_line":"import ruamel.yaml as yaml"}],"source_content_type":"text/x-python","patch_set":13,"id":"da376ef1_70afb9c1","line":47,"updated":"2022-06-20 18:14:53.000000000","message":"Place stdlib imports on the top of the import section","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"faa4c2aba267ed4c9f8c4ed613b8668dd9980fc4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from sysinv.common import constants"},{"line_number":45,"context_line":"from sysinv.common import exception"},{"line_number":46,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":47,"context_line":"from copy import deepcopy"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"import os"},{"line_number":50,"context_line":"import ruamel.yaml as yaml"}],"source_content_type":"text/x-python","patch_set":13,"id":"28060263_b5475df9","line":47,"in_reply_to":"da376ef1_70afb9c1","updated":"2022-06-21 13:57:30.000000000","message":"Done","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"aaaf9adc54e5f23dc5b02e090b3ca47f0f8762c1","unresolved":true,"context_lines":[{"line_number":46,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":47,"context_line":"from copy import deepcopy"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"import os"},{"line_number":50,"context_line":"import ruamel.yaml as yaml"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"KEY_SCHEMA \u003d \u0027schema\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"a81ea7ee_82891085","line":49,"updated":"2022-06-20 18:14:53.000000000","message":"ditto","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"faa4c2aba267ed4c9f8c4ed613b8668dd9980fc4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":47,"context_line":"from copy import deepcopy"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"import os"},{"line_number":50,"context_line":"import ruamel.yaml as yaml"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"KEY_SCHEMA \u003d \u0027schema\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"343d1fcc_75d8659b","line":49,"in_reply_to":"a81ea7ee_82891085","updated":"2022-06-21 13:57:30.000000000","message":"Done","commit_id":"ffb6b1dfbe63db9c4179c27f3b83d6dc4afeb3d1"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"38ae6b3d1bc1237e2617eb67f0d1a2f03bfcd78a","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# fmt:off"},{"line_number":13,"context_line":"import os"},{"line_number":14,"context_line":"from copy import deepcopy"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"83d6efe1_515186f6","line":12,"updated":"2022-06-21 13:47:38.000000000","message":"What does this comment mean?","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"45a85f88a95ea3eff40c2fd9929151ce16aefc31","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# fmt:off"},{"line_number":13,"context_line":"import os"},{"line_number":14,"context_line":"from copy import deepcopy"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"984abd0d_107909b3","line":12,"in_reply_to":"83d6efe1_515186f6","updated":"2022-06-21 13:55:31.000000000","message":"These are not commments, but instead directives to prevent the black tool to change this part of the code. Otherwise black will change it in a non-compliant way with the isort tool. fmt:off disables black, and fmt:on enables black.","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"b2c8fb5929226c24b3f2d7b9166f8d082e358a14","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# fmt:off"},{"line_number":13,"context_line":"import os"},{"line_number":14,"context_line":"from copy import deepcopy"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa6eefd_f7a26146","line":12,"in_reply_to":"984abd0d_107909b3","updated":"2022-06-21 13:56:37.000000000","message":"Done","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"38ae6b3d1bc1237e2617eb67f0d1a2f03bfcd78a","unresolved":true,"context_lines":[{"line_number":49,"context_line":"from sysinv.common import constants, exception"},{"line_number":50,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# fmt:on"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"KEY_SCHEMA \u003d \"schema\""},{"line_number":55,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \"armada/ChartGroup/v\""}],"source_content_type":"text/x-python","patch_set":15,"id":"337f4033_a86d3d7d","line":52,"updated":"2022-06-21 13:47:38.000000000","message":"ditto","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"b2c8fb5929226c24b3f2d7b9166f8d082e358a14","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from sysinv.common import constants, exception"},{"line_number":50,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# fmt:on"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"KEY_SCHEMA \u003d \"schema\""},{"line_number":55,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \"armada/ChartGroup/v\""}],"source_content_type":"text/x-python","patch_set":15,"id":"7d24e549_a4ec9a8c","line":52,"in_reply_to":"0ca3bd73_f35ec874","updated":"2022-06-21 13:56:37.000000000","message":"Done","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"45a85f88a95ea3eff40c2fd9929151ce16aefc31","unresolved":true,"context_lines":[{"line_number":49,"context_line":"from sysinv.common import constants, exception"},{"line_number":50,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# fmt:on"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"KEY_SCHEMA \u003d \"schema\""},{"line_number":55,"context_line":"VAL_SCHEMA_CHART_GROUP \u003d \"armada/ChartGroup/v\""}],"source_content_type":"text/x-python","patch_set":15,"id":"0ca3bd73_f35ec874","line":52,"in_reply_to":"337f4033_a86d3d7d","updated":"2022-06-21 13:55:31.000000000","message":"See previous comment.","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/tests/test_plugins.py":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"38ae6b3d1bc1237e2617eb67f0d1a2f03bfcd78a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# fmt:off"},{"line_number":6,"context_line":"import mock"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from k8sapp_openstack.armada.manifest_openstack import \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"511acc8f_19701879","line":5,"updated":"2022-06-21 13:47:38.000000000","message":"What does this comment mean?","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"b2c8fb5929226c24b3f2d7b9166f8d082e358a14","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# fmt:off"},{"line_number":6,"context_line":"import mock"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from k8sapp_openstack.armada.manifest_openstack import \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"d8bbf3d0_1e84dcd5","line":5,"in_reply_to":"1f780612_7d341164","updated":"2022-06-21 13:56:37.000000000","message":"Done","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"45a85f88a95ea3eff40c2fd9929151ce16aefc31","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# fmt:off"},{"line_number":6,"context_line":"import mock"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from k8sapp_openstack.armada.manifest_openstack import \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f780612_7d341164","line":5,"in_reply_to":"511acc8f_19701879","updated":"2022-06-21 13:55:31.000000000","message":"See previous comment.","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"38ae6b3d1bc1237e2617eb67f0d1a2f03bfcd78a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from sysinv.tests.helm import base"},{"line_number":16,"context_line":"from sysinv.tests.helm.test_helm import HelmOperatorTestSuiteMixin"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# fmt:on"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"KEY_SCHEMA \u003d \"schema\""},{"line_number":21,"context_line":"KEY_METADATA \u003d \"metadata\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5134fcc5_7958a82e","line":18,"updated":"2022-06-21 13:47:38.000000000","message":"ditto","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"45a85f88a95ea3eff40c2fd9929151ce16aefc31","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from sysinv.tests.helm import base"},{"line_number":16,"context_line":"from sysinv.tests.helm.test_helm import HelmOperatorTestSuiteMixin"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# fmt:on"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"KEY_SCHEMA \u003d \"schema\""},{"line_number":21,"context_line":"KEY_METADATA \u003d \"metadata\""}],"source_content_type":"text/x-python","patch_set":15,"id":"1c89c5c7_b8bd3136","line":18,"in_reply_to":"5134fcc5_7958a82e","updated":"2022-06-21 13:55:31.000000000","message":"See previous comment.","commit_id":"f5b532f187178d6afbb7d44484dd22ccc747b0b6"}],"stx-openstack-helm/stx-openstack-helm/manifests/manifest.yaml":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"52dcfc8d13875b9baa86283687ac835719e71dbf","unresolved":true,"context_lines":[{"line_number":1793,"context_line":"        neutron_bagpipe_bgp: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1794,"context_line":"        neutron_ironic_agent: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1795,"context_line":"        neutron_netns_cleanup_cron: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1796,"context_line":"        neutron_resources_cleanup: docker.io/wind-river/wro-networking-avs-heat:WRO-22.02-14.2.1.dev7"},{"line_number":1797,"context_line":"    network:"},{"line_number":1798,"context_line":"      interface:"},{"line_number":1799,"context_line":"        tunnel: docker0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"10b6e6c3_2e17c383","line":1796,"updated":"2022-06-02 18:50:13.000000000","message":"This doesn\u0027t look right ...","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"69ea62d04e080b16be67f75f0d2aeb86003fc18f","unresolved":true,"context_lines":[{"line_number":1793,"context_line":"        neutron_bagpipe_bgp: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1794,"context_line":"        neutron_ironic_agent: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1795,"context_line":"        neutron_netns_cleanup_cron: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1796,"context_line":"        neutron_resources_cleanup: docker.io/wind-river/wro-networking-avs-heat:WRO-22.02-14.2.1.dev7"},{"line_number":1797,"context_line":"    network:"},{"line_number":1798,"context_line":"      interface:"},{"line_number":1799,"context_line":"        tunnel: docker0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4ce54014_dbf3d7e5","line":1796,"in_reply_to":"10b6e6c3_2e17c383","updated":"2022-06-07 14:34:53.000000000","message":"Fixed in patchset 8","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"87c66369693e736c16d0cf78a606e6f35e8d0c6e","unresolved":false,"context_lines":[{"line_number":1793,"context_line":"        neutron_bagpipe_bgp: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1794,"context_line":"        neutron_ironic_agent: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1795,"context_line":"        neutron_netns_cleanup_cron: docker.io/starlingx/stx-neutron:master-centos-stable-latest"},{"line_number":1796,"context_line":"        neutron_resources_cleanup: docker.io/wind-river/wro-networking-avs-heat:WRO-22.02-14.2.1.dev7"},{"line_number":1797,"context_line":"    network:"},{"line_number":1798,"context_line":"      interface:"},{"line_number":1799,"context_line":"        tunnel: docker0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"69d2e025_3b04a9d3","line":1796,"in_reply_to":"4ce54014_dbf3d7e5","updated":"2022-06-07 14:37:12.000000000","message":"Done","commit_id":"80ba0a3cbea4ff4c05ad4fa03a150da6c176ede8"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"149c3b670f200f62881c9e9d8ac95739ca7ce4a6","unresolved":true,"context_lines":[{"line_number":4093,"context_line":"  description: \"Deploy nova and neutron, as well as supporting services\""},{"line_number":4094,"context_line":"  sequenced: false"},{"line_number":4095,"context_line":"  chart_group:"},{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b19c8ac0_e9a4cd00","line":4096,"updated":"2022-06-15 02:52:51.000000000","message":"It appears this chartgroup is sequenced: false?  Is this ok, considering this statement?","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"ec3c97abbe7d8090e8d2d455002fd53d1f37be6e","unresolved":false,"context_lines":[{"line_number":4093,"context_line":"  description: \"Deploy nova and neutron, as well as supporting services\""},{"line_number":4094,"context_line":"  sequenced: false"},{"line_number":4095,"context_line":"  chart_group:"},{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"41761e3a_65e9b329","line":4096,"in_reply_to":"4565f6b4_ce358b42","updated":"2022-06-16 12:10:20.000000000","message":"Rephrasing\u003e The *sequenced* property is false because deployment must go in parallel, since there are mutual dependency between the charts within the compute-kit group. By other hand, the removal sequence is built automatically by reversing the deployment-sequence, with *sequenced* property \u003d true.","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"df5866affea55a51995b58ad57fe2ebe6c698b89","unresolved":false,"context_lines":[{"line_number":4093,"context_line":"  description: \"Deploy nova and neutron, as well as supporting services\""},{"line_number":4094,"context_line":"  sequenced: false"},{"line_number":4095,"context_line":"  chart_group:"},{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4565f6b4_ce358b42","line":4096,"in_reply_to":"b19c8ac0_e9a4cd00","updated":"2022-06-16 10:38:01.000000000","message":"The sequece property is false because the deployment sequence must go in parallel, as there are mutual dependency between the charts within the compute-kit group. But the reverse sequence, as stated here, is used in the delete manifest, with the sequece property \u003d true.","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"149c3b670f200f62881c9e9d8ac95739ca7ce4a6","unresolved":true,"context_lines":[{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"},{"line_number":4100,"context_line":"  - openstack-nova"},{"line_number":4101,"context_line":"  - openstack-nova-api-proxy"},{"line_number":4102,"context_line":"  - openstack-pci-irq-affinity-agent"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7284ff59_985b3945","line":4099,"updated":"2022-06-15 02:52:51.000000000","message":"Any reason to move this up to 2nd?","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"df5866affea55a51995b58ad57fe2ebe6c698b89","unresolved":false,"context_lines":[{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"},{"line_number":4100,"context_line":"  - openstack-nova"},{"line_number":4101,"context_line":"  - openstack-nova-api-proxy"},{"line_number":4102,"context_line":"  - openstack-pci-irq-affinity-agent"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"de11643c_1a0c1e6e","line":4099,"in_reply_to":"7284ff59_985b3945","updated":"2022-06-16 10:38:01.000000000","message":"The placement chart provides features that are used for the other charts, so this should be one of the last ones to be removed.","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"ec3c97abbe7d8090e8d2d455002fd53d1f37be6e","unresolved":false,"context_lines":[{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"},{"line_number":4100,"context_line":"  - openstack-nova"},{"line_number":4101,"context_line":"  - openstack-nova-api-proxy"},{"line_number":4102,"context_line":"  - openstack-pci-irq-affinity-agent"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"477f5fb1_07519c5d","line":4099,"in_reply_to":"de11643c_1a0c1e6e","updated":"2022-06-16 12:10:20.000000000","message":"Just complementing, placement provides a REST API stack and data model used to track resource provider inventories and usages, along with different classes of resources. For example, a resource provider can be a compute node, a shared storage pool, or an IP allocation pool. The placement service tracks the inventory and usage of each provider.","commit_id":"5f64e12c79d4b80a2a19ebf95ff1677f06be68d8"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"0983c297a0bd3f70b775990919696eaec480a250","unresolved":true,"context_lines":[{"line_number":4093,"context_line":"  description: \"Deploy nova and neutron, as well as supporting services\""},{"line_number":4094,"context_line":"  sequenced: false"},{"line_number":4095,"context_line":"  chart_group:"},{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5e6ac5d4_b89fc84a","line":4096,"updated":"2022-06-21 12:49:56.000000000","message":"funny that the delete is sequenced and deployment isnt","commit_id":"0f8629c79bd23860387174ae5d4de8290c92d1ca"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"e13ceb9f4c233fc073486199c1c0685db19595eb","unresolved":false,"context_lines":[{"line_number":4093,"context_line":"  description: \"Deploy nova and neutron, as well as supporting services\""},{"line_number":4094,"context_line":"  sequenced: false"},{"line_number":4095,"context_line":"  chart_group:"},{"line_number":4096,"context_line":"  # Keep this sequence, because OpenStack is deleted on reverse deployment-sequence."},{"line_number":4097,"context_line":"  # The Neutron chart is the first one to be deleted due to the neutron resources cleanup job."},{"line_number":4098,"context_line":"  - openstack-libvirt"},{"line_number":4099,"context_line":"  - openstack-placement"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5f774249_f96b742c","line":4096,"in_reply_to":"5e6ac5d4_b89fc84a","updated":"2022-06-21 12:59:50.000000000","message":"There are mutual dependencies between the charts, so the compute-kit group must be deployed in parallel, but release must be in sequence.","commit_id":"0f8629c79bd23860387174ae5d4de8290c92d1ca"}]}