)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"d360af397a8fe724919930b7cb85cdb592c28225","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"75362903_b6fc9122","updated":"2022-06-22 15:03:23.000000000","message":"I actually renamed our flake8 to be pep8 since we don\u0027t need 2 testenvs doing exactly the same checks. One thing that I didn\u0027t mention is that I choose to use google style over cryptography (that is the default) just because that\u0027s what most of the openinfra projects use (and I really like it), not a hard requirement though.","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"9f589e41b55bce63023f81d83e2b9c492be76479","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"72196896_1e129ab2","updated":"2022-06-22 14:36:16.000000000","message":"I\u0027m OK with the change, just asked the question out of curiosity","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"a3218740c24fb4610072211ae58e89dcbb15de71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf0c583b_da41ea61","updated":"2022-06-22 12:40:47.000000000","message":"LGTM!\nSeems to be an important addition to our code checks. Thanks Thiago","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"40a4bc225a3831c5352ee21551ebc0c54d363a60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99de8635_a230d7bc","updated":"2022-06-22 14:40:04.000000000","message":"Thanks","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a3fef2331bb1d2db764a2008b60634634a579d47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1e2dba94_028946e0","updated":"2022-06-22 14:41:29.000000000","message":"We don\u0027t normally remove pep8 from the tox.ini  which is why most of our tox.ini just have pep8 calling the same target as flake8\nthe reason we had been leaving that, is that the base zuul-jobs  templates provided by openstack  expect the pep8 target,  \n\nHowever it doesnt really matter since almost all of our projects are not able to use that template due to how we were still supporting python2 and were slow to adopt python3","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"cb131de29800343b39dcb89b3ee633c84f9155d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7246adc_89dc2d42","updated":"2022-06-22 16:51:27.000000000","message":"nice work","commit_id":"dceba419435f9d377bf28b96bf7981d0bf809870"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/armada/manifest_openstack.py":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"a8cacf0c3ccb03335d5b394364559de37b254c1e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"from oslo_log import log as logging"},{"line_number":12,"context_line":"from sysinv.common import constants"},{"line_number":13,"context_line":"from sysinv.common import exception"},{"line_number":14,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from k8sapp_openstack.common import constants as app_constants"},{"line_number":17,"context_line":"from k8sapp_openstack.helm.aodh import AodhHelm"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea414fa3_4acea6bf","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":45},"updated":"2022-06-22 14:34:32.000000000","message":"I understood that you reordered the imports alphabetically, but just checking: the idea behind bringing sysinv imports before k8sapp_openstack imports is to bring external imports before internal imports?\n\nThis comment applies to most files, I\u0027m not commenting this on every one of them.","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"d360af397a8fe724919930b7cb85cdb592c28225","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"from oslo_log import log as logging"},{"line_number":12,"context_line":"from sysinv.common import constants"},{"line_number":13,"context_line":"from sysinv.common import exception"},{"line_number":14,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from k8sapp_openstack.common import constants as app_constants"},{"line_number":17,"context_line":"from k8sapp_openstack.helm.aodh import AodhHelm"}],"source_content_type":"text/x-python","patch_set":5,"id":"847fa72c_3b2a2fe5","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"00802605_aee77d5a","updated":"2022-06-22 15:03:23.000000000","message":"Just a small correction, it\u0027s stdlib imports first, then 3rd party (that would include libs on requirements.txt since they come from pip) and then project-level imports.","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"40a4bc225a3831c5352ee21551ebc0c54d363a60","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"from oslo_log import log as logging"},{"line_number":12,"context_line":"from sysinv.common import constants"},{"line_number":13,"context_line":"from sysinv.common import exception"},{"line_number":14,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from k8sapp_openstack.common import constants as app_constants"},{"line_number":17,"context_line":"from k8sapp_openstack.helm.aodh import AodhHelm"}],"source_content_type":"text/x-python","patch_set":5,"id":"c82a158a_b3925f5c","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"a42e155d_f566c269","updated":"2022-06-22 14:40:04.000000000","message":"Done","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"fc8ccf71d10af054bdb5fae21d8963b22807e51b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"from oslo_log import log as logging"},{"line_number":12,"context_line":"from sysinv.common import constants"},{"line_number":13,"context_line":"from sysinv.common import exception"},{"line_number":14,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from k8sapp_openstack.common import constants as app_constants"},{"line_number":17,"context_line":"from k8sapp_openstack.helm.aodh import AodhHelm"}],"source_content_type":"text/x-python","patch_set":5,"id":"a42e155d_f566c269","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"ea414fa3_4acea6bf","updated":"2022-06-22 14:39:20.000000000","message":"Exactly, please check the flake8-import-order documentation for the \"google\" style at https://google.github.io/styleguide/pyguide.html?showone\u003dImports_formatting#s3.13-imports-formatting","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a3fef2331bb1d2db764a2008b60634634a579d47","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\"\"\" System inventory Armada manifest operator.\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"from oslo_log import log as logging"},{"line_number":12,"context_line":"from sysinv.common import constants"},{"line_number":13,"context_line":"from sysinv.common import exception"},{"line_number":14,"context_line":"from sysinv.helm import manifest_base as base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from k8sapp_openstack.common import constants as app_constants"},{"line_number":17,"context_line":"from k8sapp_openstack.helm.aodh import AodhHelm"}],"source_content_type":"text/x-python","patch_set":5,"id":"00802605_aee77d5a","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"ea414fa3_4acea6bf","updated":"2022-06-22 14:41:29.000000000","message":"Its because k8sapp_openstack is this package.\n\nThe way we typically do import order is\n\nsystem level imports first (ie:  import os) (these can also be whatever we have in requirements.txt)\n\n3rdparty imports next (this would include sysinv)\n\nlocal imports last","commit_id":"8aded9e2b60aabe2a03993988b1e6409cfae31f8"}]}