)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Story: 2009138"},{"line_number":24,"context_line":"Task: 45465"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/openstack-armada-app/+/855028"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Signed-off-by: Rafael Falcao \u003crafael.vieirafalcao@windriver.com\u003e"},{"line_number":29,"context_line":"Co-Authored-by: Thales Elero Cervi \u003cthaleselero.cervi@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"60578325_5558e5d9","line":26,"updated":"2022-08-29 19:32:46.000000000","message":"nit: Depends-On should only be used for cross-repo dependencies[1], for same repo, you need just to put all change on the same commit chain when submitting\n\n[1]https://www.mediawiki.org/wiki/Gerrit/Cross-repo_dependencies","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Story: 2009138"},{"line_number":24,"context_line":"Task: 45465"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/openstack-armada-app/+/855028"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Signed-off-by: Rafael Falcao \u003crafael.vieirafalcao@windriver.com\u003e"},{"line_number":29,"context_line":"Co-Authored-by: Thales Elero Cervi \u003cthaleselero.cervi@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"47dc791d_da258d67","line":26,"in_reply_to":"60578325_5558e5d9","updated":"2022-08-30 19:32:53.000000000","message":"Got it, tks for the tip!","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"4b7bb3154f28cd84ca42a78458c65b4acbd21355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6ec6711_35775179","updated":"2022-08-25 18:53:08.000000000","message":"Still awaiting for tests to be performed","commit_id":"1a4c358f88fcdf6a42699cd5b3229188351abdd2"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"f3e6a6c0e72b7a030a8ba4f8644a77ec9506b72f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8b22700f_a89375ca","updated":"2022-08-26 20:45:48.000000000","message":"We found a lib issue that will be approached in other review","commit_id":"ebb4b16fcb665322d79ea03397b9ffb5d16d6151"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"f0a3e07478ed01809396298bb074801f0e94c051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cd33e3f5_2ef7db47","updated":"2022-08-29 13:40:09.000000000","message":"This review depends-on the solution for the following review: https://review.opendev.org/c/starlingx/openstack-armada-app/+/855028","commit_id":"ecec3a807435225129cc10d04fb2c27858398d7f"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2f4929fa0abc885ea4c86dd4bfdc1cdb00adb7cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4d2c0eb3_e05c1846","updated":"2022-08-29 13:52:36.000000000","message":"Holding the review for now. Zuul will not give +1 until https://review.opendev.org/c/starlingx/openstack-armada-app/+/855028 (depends-on) is merged ","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"f2a7f94584b2fe244d525127af8a53483c7318f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7570707e_c7db94e1","updated":"2022-08-29 14:21:09.000000000","message":"Oh ok. So apparently Zuul is smart enough to get the Depends-on changes before running the tests. Awesome 😄 \nThis change should be ready for review in this case!","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"9a767ba4a110c41ccce2131406fc51f036495e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dc1b6fec_fb46c6ba","updated":"2022-08-29 17:02:57.000000000","message":"recheck","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"935d92c00a8fc9fde2053ff321b14001c6c75111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"148bd03f_6bb4f04c","updated":"2022-08-31 12:19:22.000000000","message":"LGTM","commit_id":"15a38b183624b02506e63fb47fc1a62c2b2e0360"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/dcdbsync.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":42,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"},{"line_number":43,"context_line":"                            common.HELM_NS_OPENSTACK):"},{"line_number":44,"context_line":"            # TODO: implement this insertion"},{"line_number":45,"context_line":"            pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_overrides(self, namespace\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff68657d_2d18d8d3","line":44,"updated":"2022-08-29 19:32:46.000000000","message":"Can we use the implementation on the base class?","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":42,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"},{"line_number":43,"context_line":"                            common.HELM_NS_OPENSTACK):"},{"line_number":44,"context_line":"            # TODO: implement this insertion"},{"line_number":45,"context_line":"            pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_overrides(self, namespace\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"6b5a192c_e57d64fd","line":44,"in_reply_to":"ff68657d_2d18d8d3","updated":"2022-08-30 19:32:53.000000000","message":"Done","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/garbd.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        # On application load this chart is enabled"},{"line_number":52,"context_line":"        if not self._is_enabled(operator.APP, self.CHART,"},{"line_number":53,"context_line":"                                common.HELM_NS_OPENSTACK):"},{"line_number":54,"context_line":"            operator.helm_release_resource_delete(self.CHART)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_overrides(self, namespace\u003dNone):"},{"line_number":57,"context_line":"        overrides \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"d9635a54_4f0f4399","line":54,"updated":"2022-08-29 19:32:46.000000000","message":"I noticed now that this is identical to the implementation on OpenstackBaseHelm, but this one doesn\u0027t inherit from it.","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        # On application load this chart is enabled"},{"line_number":52,"context_line":"        if not self._is_enabled(operator.APP, self.CHART,"},{"line_number":53,"context_line":"                                common.HELM_NS_OPENSTACK):"},{"line_number":54,"context_line":"            operator.helm_release_resource_delete(self.CHART)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_overrides(self, namespace\u003dNone):"},{"line_number":57,"context_line":"        overrides \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"38b9ae7d_f5e6d80c","line":54,"in_reply_to":"d9635a54_4f0f4399","updated":"2022-08-30 19:32:53.000000000","message":"Done","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/ironic.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":true,"context_lines":[{"line_number":40,"context_line":"                operator.CHART_GROUPS_LUT[self.CHART],"},{"line_number":41,"context_line":"                operator.CHARTS_LUT[self.CHART])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":44,"context_line":"        # On application load, this chart is disabled in the metadata. Insert as"},{"line_number":45,"context_line":"        # needed."},{"line_number":46,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ee9a1386_b0f60ea5","line":43,"updated":"2022-08-29 19:32:46.000000000","message":"Not as concerning as openvswitch, but it would be good not to leave this behind","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                operator.CHART_GROUPS_LUT[self.CHART],"},{"line_number":41,"context_line":"                operator.CHARTS_LUT[self.CHART])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":44,"context_line":"        # On application load, this chart is disabled in the metadata. Insert as"},{"line_number":45,"context_line":"        # needed."},{"line_number":46,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"}],"source_content_type":"text/x-python","patch_set":14,"id":"6ed6cabd_e770c6a9","line":43,"in_reply_to":"ee9a1386_b0f60ea5","updated":"2022-08-30 19:32:53.000000000","message":"Done","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/keystone_api_proxy.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                operator.ARMADA_MANIFEST,"},{"line_number":42,"context_line":"                operator.CHART_GROUPS_LUT[self.CHART])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":45,"context_line":"        # This chart group is not included by default in the manifest. Insert as"},{"line_number":46,"context_line":"        # needed."},{"line_number":47,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"}],"source_content_type":"text/x-python","patch_set":14,"id":"09195ee5_615c5ee3","line":44,"updated":"2022-08-29 19:32:46.000000000","message":"Concerned about this one as well, see comment on openvswitch.py","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                operator.ARMADA_MANIFEST,"},{"line_number":42,"context_line":"                operator.CHART_GROUPS_LUT[self.CHART])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":45,"context_line":"        # This chart group is not included by default in the manifest. Insert as"},{"line_number":46,"context_line":"        # needed."},{"line_number":47,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"}],"source_content_type":"text/x-python","patch_set":14,"id":"232135ab_141fd96b","line":44,"in_reply_to":"09195ee5_615c5ee3","updated":"2022-08-30 19:32:53.000000000","message":"Done","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/openstack.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        app_constants.HELM_CHART_KEYSTONE_API_PROXY,"},{"line_number":66,"context_line":"    ]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @property"},{"line_number":69,"context_line":"    def CHART(self):"},{"line_number":70,"context_line":"        # subclasses must define the property: CHART\u003d\u0027name of chart\u0027"},{"line_number":71,"context_line":"        # if an author of a new chart forgets this, NotImplementedError is raised"},{"line_number":72,"context_line":"        raise NotImplementedError"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_service_config(self, service):"},{"line_number":75,"context_line":"        configs \u003d self.context.setdefault(\u0027_service_configs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":14,"id":"e9f66d2c_2182bd21","line":72,"range":{"start_line":68,"start_character":4,"end_line":72,"end_character":33},"updated":"2022-08-29 19:32:46.000000000","message":"nit: now that you are inheriting from base.FluxCDBaseHelm, this is redundant [1].\n\n[1]https://github.com/starlingx/config/blob/7db502de15f0daacc7e59150d61461ce4902f862/sysinv/sysinv/sysinv/sysinv/helm/base.py#L474","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        app_constants.HELM_CHART_KEYSTONE_API_PROXY,"},{"line_number":66,"context_line":"    ]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @property"},{"line_number":69,"context_line":"    def CHART(self):"},{"line_number":70,"context_line":"        # subclasses must define the property: CHART\u003d\u0027name of chart\u0027"},{"line_number":71,"context_line":"        # if an author of a new chart forgets this, NotImplementedError is raised"},{"line_number":72,"context_line":"        raise NotImplementedError"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_service_config(self, service):"},{"line_number":75,"context_line":"        configs \u003d self.context.setdefault(\u0027_service_configs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":14,"id":"91317dae_14a69b2b","line":72,"range":{"start_line":68,"start_character":4,"end_line":72,"end_character":33},"in_reply_to":"e9f66d2c_2182bd21","updated":"2022-08-30 19:32:53.000000000","message":"Done","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"ba6912bb68d8be9145018b21d24bb4c7af9e731b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FluxCDBaseHelm(base.FluxCDBaseHelm):"},{"line_number":51,"context_line":"    \"\"\"Class to encapsulate Openstack related service operations for helm\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    SUPPORTED_NAMESPACES \u003d \\"}],"source_content_type":"text/x-python","patch_set":16,"id":"49fb1ea8_b8243351","line":50,"updated":"2022-08-30 19:34:23.000000000","message":"Doesn\u0027t it break the Armada application?","commit_id":"86e553222ce6c3e235aa77cce415f4d6b36c7e64"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"e407a8ba1d08832773b755be61f959ac60e71a35","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FluxCDBaseHelm(base.FluxCDBaseHelm):"},{"line_number":51,"context_line":"    \"\"\"Class to encapsulate Openstack related service operations for helm\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    SUPPORTED_NAMESPACES \u003d \\"}],"source_content_type":"text/x-python","patch_set":16,"id":"140c55ef_f796c5b3","line":50,"in_reply_to":"49fb1ea8_b8243351","updated":"2022-08-31 12:01:16.000000000","message":"Nope. Just checked the hierarchy tree and stx/config code :)","commit_id":"86e553222ce6c3e235aa77cce415f4d6b36c7e64"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/openvswitch.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e1d439dedae74aa243e8e7f878b28b1e922198ee","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":43,"context_line":"        # On application load, this chart in not included. Insert as needed."},{"line_number":44,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"},{"line_number":45,"context_line":"                            common.HELM_NS_OPENSTACK):"},{"line_number":46,"context_line":"            # TODO: implement this insertion"},{"line_number":47,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":14,"id":"dc82ab4b_f0ca6ae3","line":44,"updated":"2022-08-29 19:32:46.000000000","message":"I\u0027m concerned that this is not implemented and might get lost in the middle of other works. Can\u0027t we just use the approach used on [1]?\n\n[1]https://github.com/starlingx/platform-armada-app/blob/a733c009ffb632735abd6b567b26d9a26923f39c/python-k8sapp-platform/k8sapp_platform/k8sapp_platform/helm/ceph_pools_audit.py#L39","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"5558508ee717fe57c9171e705820f566c5f4e6cb","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":43,"context_line":"        # On application load, this chart in not included. Insert as needed."},{"line_number":44,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"},{"line_number":45,"context_line":"                            common.HELM_NS_OPENSTACK):"},{"line_number":46,"context_line":"            # TODO: implement this insertion"},{"line_number":47,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":14,"id":"538462c0_c934bbe0","line":44,"in_reply_to":"68b96412_559d14b2","updated":"2022-08-31 12:35:25.000000000","message":"\u003e Solved using the reserved logic (if not enable, remove it).\n\nreverse*","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"506b3fd7ff417ed80f229dd28e58eb685d0c7cfd","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":43,"context_line":"        # On application load, this chart in not included. Insert as needed."},{"line_number":44,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"},{"line_number":45,"context_line":"                            common.HELM_NS_OPENSTACK):"},{"line_number":46,"context_line":"            # TODO: implement this insertion"},{"line_number":47,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":14,"id":"68b96412_559d14b2","line":44,"in_reply_to":"d51c63a6_d09cfa03","updated":"2022-08-30 19:32:53.000000000","message":"Solved using the reserved logic (if not enable, remove it).","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"8f9ab0ee4a0016e0bbbdce36dcbe3d4834ee4447","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def execute_kustomize_updates(self, operator):"},{"line_number":43,"context_line":"        # On application load, this chart in not included. Insert as needed."},{"line_number":44,"context_line":"        if self._is_enabled(operator.APP, self.CHART,"},{"line_number":45,"context_line":"                            common.HELM_NS_OPENSTACK):"},{"line_number":46,"context_line":"            # TODO: implement this insertion"},{"line_number":47,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":14,"id":"d51c63a6_d09cfa03","line":44,"in_reply_to":"dc82ab4b_f0ca6ae3","updated":"2022-08-30 17:10:23.000000000","message":"We are using the implementation on the base class [1] for updates that remove a chart/release, like the garbd plugin.The remaining 4 updates cases (dcdbsync, keystone-api-proxy, ironic and openvswitch) need to _insert_ a chart/release and there is no such method yet implemented on the base class (kustomize_base).\n\nSince it would require this implementation on stx/config [1] and none of the 4 charts are already ported to the fluxcd app (alpha version), we thought this could be marked #TODO and be done later (we do have an internal track of this task). But I understand your concern that this get lost in the middle of everything else...\n\n[1] https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/helm/kustomize_base.py","commit_id":"fbb376f7619049c809238ac4854371f92ac6c6af"}]}