)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"f1ab7c21e2fe294dc87d2cb557c2e1bef8d6e3e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51686be6_f335d697","updated":"2023-06-14 21:35:42.000000000","message":"Good job here Lucas! It is indeed an XL change request but also a necessary step towards decoupling the stx-openstack application from the platform. Thanks for submitting it.\n\nJust have a couple of comments before bumping my +2 here.\n\n1) I\u0027m not sure if it is strictly necessary to bring the old centos build structure for those packages since StarlingX already only supports Debian based builds for new releases.\n\n2) Would like to take this opportunity to discuss about the directory name. \"openstack\" can be not enough self-explanatory and we might want to go with a structure that makes it more clear to a first reader to understand what is inside this directory.\nIn this directory we hold all the references to upstream openstack packages that we have to build, so we might consider:\n - ./upstream/openstack/\n - ./upstream-openstack/\n - \u003copen to new suggestions\u003e\n\n3) Also, I know the other directories on this repo do note have README files or any txt file explaining what is contained within, but I would like to start this practice with this new dir.\nLet\u0027s create a simple text file explaining that this is a directory in which we hold all the references to upstream openstack packages that we have to build to delivery as part of our stx-debian Docker images. Also mention that we have one degree of freedom here to add patches on top of those packages to tweak it for StarlingX use case when the change is not accepted/merged upstream (yet).","commit_id":"32d0e9a19535b36a38535ac516bce226b69e7bb0"},{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"6259beaf83f98aa67bd2f039511861a65b5b2b5d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eaa6a489_5aaff46f","in_reply_to":"51686be6_f335d697","updated":"2023-06-15 12:03:39.000000000","message":"1) I agree, there are even some folders that I think can be abandoned (cinder_conf_dummy and openstack_os_vif for example), since I was just making sure the packages would build I didn\u0027t alter anything, but it makes sense to abandon all centos folders.\n\n2) Will wait for a resolution before changing that (I like upstream-openstack)\n\n3) Will update this on the next patchset","commit_id":"32d0e9a19535b36a38535ac516bce226b69e7bb0"},{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"fb6a5b17ea80b513a5780214fa3414b2b98e76b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"955fe696_81982253","in_reply_to":"eaa6a489_5aaff46f","updated":"2023-06-15 15:36:52.000000000","message":"1) Done, centos folders and centos-only packages were removed\n2) Done, folder was changed to ./upstream/openstack\n3) Done","commit_id":"32d0e9a19535b36a38535ac516bce226b69e7bb0"},{"author":{"_account_id":35467,"name":"Luan Utimura","display_name":"Luan Utimura","email":"luan.utimura@luizalabs.com","username":"lutimura"},"change_message_id":"550a10474b25df0d37b7e2c382892c5748711a88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1378434d_327fdb4c","updated":"2023-06-16 11:28:52.000000000","message":"Good job, Lucas!\n\nI like the idea of having multiple READMEs in this repository, especially for those upstream projects patched by us. Over time, we may improve these READMEs and extend this practice to other repositories as well.","commit_id":"f7f7690444f349444c375110c9b6ab4a08586942"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"10cc38d528df62810d99168c77d6cbf0205bef9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"69922697_7b6152f6","updated":"2023-06-15 17:34:02.000000000","message":"Looks good to me! Nice first step towards the decoupling of openstack clients between platform and stx-openstack application.\nIt seems safe since those packages are still commented on the debian_pkg_dirs, so developers can locally switch and work on Antelope upversion later. Same applies for debian_stable_docker_images.inc. Whenever we have the manifest and build split we will be able to remove the commentary markers for all of it.\n\nNice work Lucas","commit_id":"f7f7690444f349444c375110c9b6ab4a08586942"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"f1df9a32fbbc3d459220b552b36aa0579787dd6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3124372_320a6e59","updated":"2023-06-19 20:46:05.000000000","message":"Thanks Lucas, good job.\n\nIt would be good to split the massive commit into smaller ones, it makes easier to review (e.g. split one commit per service), keep that in mind for future commits please.","commit_id":"f7f7690444f349444c375110c9b6ab4a08586942"},{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"81dffc640114240074879e6aa70470a7adea1bcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19080529_cdfd168c","updated":"2023-06-15 17:13:02.000000000","message":"recheck","commit_id":"f7f7690444f349444c375110c9b6ab4a08586942"}]}