)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-12-12 11:31:54 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added ingress-nginx-helm integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the deprecation of the Ingress Helm chart, this change"},{"line_number":10,"context_line":"replaces it with a community-supported version. This commit"},{"line_number":11,"context_line":"introduces the base ingress-nginx-helm package to the project,"},{"line_number":12,"context_line":"allowing future updates to be easily integrated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"- PASS: Successfully built the ingress-nginx-helm package."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"22951628_177a45bc","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":47},"updated":"2024-12-13 15:31:02.000000000","message":"Please add the reference to the \"Ingress Helm Chart\" deprecated. Furthermore, add another paragraph below this with the information from where this new package came from and the debian packaging guideline followed to review it. Final description could be something like:\n\nWith the deprecation of the Ingress Helm chart [1], this change\nreplaces it with a community-supported version. This commit\nintroduces the base ingress-nginx-helm package to the project,\nallowing future updates to be easily integrated\n\nThe ingress-nginx-helm package was copied from [2] and \nreviewed based on Starling Packaging Reference doc [3].\n\n[1] https://kubernetes.github.io/ingress-nginx\n[2] https://opendev.org/starlingx/nginx-ingress-controller-armada-app/src/branch/master/helm-charts/upstream/ingress-nginx-helm \n[3] https://docs.starlingx.io/developer_resources/packaging_ref.html","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-12-12 11:31:54 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added ingress-nginx-helm integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the deprecation of the Ingress Helm chart, this change"},{"line_number":10,"context_line":"replaces it with a community-supported version. This commit"},{"line_number":11,"context_line":"introduces the base ingress-nginx-helm package to the project,"},{"line_number":12,"context_line":"allowing future updates to be easily integrated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"- PASS: Successfully built the ingress-nginx-helm package."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b5d329cd_ecaf0d2c","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":47},"in_reply_to":"22951628_177a45bc","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"04de16d1b7ca4a95d08a7a5f4f78278284001068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77467c0d_407a490d","updated":"2024-12-10 13:58:45.000000000","message":"This looks like it was copied and pasted from an already existing package. If that\u0027s the case, I\u0027m not sure doing this is the best idea.","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2aa9926d_8b70bea1","updated":"2024-12-13 15:31:02.000000000","message":"It looks good, but I think we can improve. Please refer to my suggestions.","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"863310cf9a5e582ffdf9169f3d2fba5a57b08aed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4168a8e1_aa1884ae","updated":"2024-12-13 20:23:31.000000000","message":"Great job @joaopedro.barbozalioneza@windriver.com! Thanks for addressing all my comments.","commit_id":"088b2159e28cb10fbe131a488f56d3ae426547b3"},{"author":{"_account_id":37229,"name":"Murillo Arantes","display_name":"Murillo Arantes","email":"murillo.arantes@windriver.com","username":"marantes"},"change_message_id":"9b42f05f1e1fbf546808fb1cbf438370261ea1d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c9dabfc9_9654e91e","updated":"2024-12-13 20:38:33.000000000","message":"In the changelog file, the version is 4.11-2, but in the rules and meta_data files, the version is 4.11-1. The version should be 4.11-2 in all of them","commit_id":"088b2159e28cb10fbe131a488f56d3ae426547b3"},{"author":{"_account_id":36340,"name":"Vinícius Fernando Rocha Lobo","display_name":"Vinicius Lobo","email":"Vinicius.RochaLobo@windriver.com","username":"vrochalo"},"change_message_id":"23310bdc733ef467b4b1cbc1e40efde737fee9e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d567453c_c093cdb3","updated":"2024-12-13 20:31:46.000000000","message":"lgtm","commit_id":"088b2159e28cb10fbe131a488f56d3ae426547b3"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"b0707f43c299493c154900afc3c7f3422a7cfd60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97529726_615ac196","in_reply_to":"c9dabfc9_9654e91e","updated":"2024-12-13 20:42:30.000000000","message":"Done","commit_id":"088b2159e28cb10fbe131a488f56d3ae426547b3"}],"debian_pkg_dirs":[{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"04de16d1b7ca4a95d08a7a5f4f78278284001068","unresolved":true,"context_lines":[{"line_number":2,"context_line":"openstack-helm-infra"},{"line_number":3,"context_line":"python3-k8sapp-openstack"},{"line_number":4,"context_line":"stx-openstack-helm-fluxcd"},{"line_number":5,"context_line":"upstream/helm-charts/ingress-nginx-helm"},{"line_number":6,"context_line":"upstream/openstack/openstack-pkg-tools"},{"line_number":7,"context_line":"upstream/openstack/python-aodhclient"},{"line_number":8,"context_line":"upstream/openstack/python-barbicanclient"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aacfaecd_3d20dc05","line":5,"updated":"2024-12-10 13:58:45.000000000","message":"I don\u0027t think this package should be in the upstream folder. This folder exists because all packages that are inside of it were brought to this repository from the upstream one [1]. I would simply put it in the root dir of the repo, same as the openstack-helm and openstack-helm-infra ones.\n\n[1] - https://opendev.org/starlingx/upstream/src/branch/master/openstack","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"43b1c60b35ac025f4976d25b76225feec7c0aefd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"openstack-helm-infra"},{"line_number":3,"context_line":"python3-k8sapp-openstack"},{"line_number":4,"context_line":"stx-openstack-helm-fluxcd"},{"line_number":5,"context_line":"upstream/helm-charts/ingress-nginx-helm"},{"line_number":6,"context_line":"upstream/openstack/openstack-pkg-tools"},{"line_number":7,"context_line":"upstream/openstack/python-aodhclient"},{"line_number":8,"context_line":"upstream/openstack/python-barbicanclient"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dac8236b_fe8dbc29","line":5,"in_reply_to":"aacfaecd_3d20dc05","updated":"2024-12-12 14:34:51.000000000","message":"Thanks for the tip!","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"}],"ingress-nginx-helm/debian/deb_folder/changelog":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":1,"context_line":"ingress-nginx-helm (4.11-1) unstable; urgency\u003dmedium"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * App upversion"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5c749ac2_b9e470b3","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":27},"updated":"2024-12-13 15:31:02.000000000","message":"This is the same version as the previous changelog entry from \"amantri \u003cayyappa.mantri@windriver.com\u003e\". Therefore, this changelog entry description should not be \"App upversion\". You should change the description to really match what you changed in the package and also increase the \"patch\" field in the version identifier (e.g. 4.11-2). If nothing has changed, please remove this changelog entry.\n\nIf needed, please refer to debian/changelog guideline [1]\n\n[1] https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#writing-useful-changelog-entries","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ingress-nginx-helm (4.11-1) unstable; urgency\u003dmedium"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * App upversion"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8882f9d2_a28c01f7","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":27},"in_reply_to":"5c749ac2_b9e470b3","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * App upversion"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" --  jbarboza \u003cjoaopedro.barbozalioneza@windriver.com\u003e  Wed 04 Dec 2024 14:10:00 -0300 "},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ingress-nginx-helm (4.11-1) unstable; urgency\u003dmedium"},{"line_number":8,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"60bf5051_62c8edf1","line":5,"range":{"start_line":5,"start_character":86,"end_line":5,"end_character":87},"updated":"2024-12-13 15:31:02.000000000","message":"nit: remove trailing whitespace","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * App upversion"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" --  jbarboza \u003cjoaopedro.barbozalioneza@windriver.com\u003e  Wed 04 Dec 2024 14:10:00 -0300 "},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ingress-nginx-helm (4.11-1) unstable; urgency\u003dmedium"},{"line_number":8,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2be2b3ff_80603fe7","line":5,"range":{"start_line":5,"start_character":86,"end_line":5,"end_character":87},"in_reply_to":"60bf5051_62c8edf1","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"}],"ingress-nginx-helm/debian/deb_folder/rules":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/make -f"},{"line_number":2,"context_line":"# export DH_VERBOSE \u003d 1"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"export DEB_VERSION \u003d $(shell dpkg-parsechangelog | egrep \u0027^Version:\u0027 | cut -f 2 -d \u0027 \u0027)"},{"line_number":5,"context_line":"export PATCH_VERSION \u003d $(shell echo $(DEB_VERSION) | cut -f 4 -d \u0027.\u0027)"},{"line_number":6,"context_line":"export CHART_BASE_VERSION \u003d $(shell echo $(DEB_VERSION) | sed \u0027s/-/./\u0027 | cut -d \u0027.\u0027 -f 1-3)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"export ROOT \u003d debian/tmp"},{"line_number":9,"context_line":"export APP_FOLDER \u003d $(ROOT)/usr/lib/helm"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"f25788f3_b3a39094","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":91},"updated":"2024-12-13 15:31:02.000000000","message":"Instead of pulling the version from the changelog, please hard code the version. This is similar to what is already done for other packages/helm charts, include the deprecated Ingress Helm CHart from Openstack Helm Infra [1].  Suggestion:\n\nexport CHART_BASE_VERSION \u003d 4.11.1 \nexport PATCH_VERSION \u003d 1\nexport CHART_VERSION \u003d $(CHART_BASE_VERSION)+STX.$(PATCH_VERSION)\n\n\n[1] https://opendev.org/openstack/openstack-helm-infra/src/branch/master/tools/deployment/common/ingress.sh","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/make -f"},{"line_number":2,"context_line":"# export DH_VERBOSE \u003d 1"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"export DEB_VERSION \u003d $(shell dpkg-parsechangelog | egrep \u0027^Version:\u0027 | cut -f 2 -d \u0027 \u0027)"},{"line_number":5,"context_line":"export PATCH_VERSION \u003d $(shell echo $(DEB_VERSION) | cut -f 4 -d \u0027.\u0027)"},{"line_number":6,"context_line":"export CHART_BASE_VERSION \u003d $(shell echo $(DEB_VERSION) | sed \u0027s/-/./\u0027 | cut -d \u0027.\u0027 -f 1-3)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"export ROOT \u003d debian/tmp"},{"line_number":9,"context_line":"export APP_FOLDER \u003d $(ROOT)/usr/lib/helm"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"80a271d4_92ba762c","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":91},"in_reply_to":"f25788f3_b3a39094","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\tdh $@"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"override_dh_auto_build:"},{"line_number":15,"context_line":"\tmkdir -p ingress-nginx"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\t# Copy ingress-nginx charts"},{"line_number":18,"context_line":"\tcp -r charts/* ingress-nginx"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\tcp Makefile ingress-nginx"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\tif [ -z \"$(PATCH_VERSION)\" ]; then \\"},{"line_number":23,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION) ingress-nginx; \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"f0dc2ed3_938c67c9","line":20,"range":{"start_line":15,"start_character":0,"end_line":20,"end_character":26},"updated":"2024-12-13 15:31:02.000000000","message":"Is this required? Did you try to build in the current path just like is done for both openstack-helm [1] and openstack-helm-infra [2]?\n\n[1] https://opendev.org/starlingx/openstack-armada-app/src/branch/master/openstack-helm/debian/deb_folder/rules\n[2] https://opendev.org/starlingx/openstack-armada-app/src/branch/master/openstack-helm-infra/debian/deb_folder/rules","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\tdh $@"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"override_dh_auto_build:"},{"line_number":15,"context_line":"\tmkdir -p ingress-nginx"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\t# Copy ingress-nginx charts"},{"line_number":18,"context_line":"\tcp -r charts/* ingress-nginx"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\tcp Makefile ingress-nginx"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\tif [ -z \"$(PATCH_VERSION)\" ]; then \\"},{"line_number":23,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION) ingress-nginx; \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"b66c513b_cdac5ead","line":20,"range":{"start_line":15,"start_character":0,"end_line":20,"end_character":26},"in_reply_to":"d3d2c72e_9e744c06","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"3698e46510c481bba4aa181726aeba7dc359e331","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\tdh $@"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"override_dh_auto_build:"},{"line_number":15,"context_line":"\tmkdir -p ingress-nginx"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\t# Copy ingress-nginx charts"},{"line_number":18,"context_line":"\tcp -r charts/* ingress-nginx"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\tcp Makefile ingress-nginx"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\tif [ -z \"$(PATCH_VERSION)\" ]; then \\"},{"line_number":23,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION) ingress-nginx; \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"d3d2c72e_9e744c06","line":20,"range":{"start_line":15,"start_character":0,"end_line":20,"end_character":26},"in_reply_to":"f0dc2ed3_938c67c9","updated":"2024-12-13 16:30:38.000000000","message":"Based on what I checked in ingress-nginx-helm-chart-4.11.1, you could replace that by \"mv charts/ingress-nginx .\". The final \"override_dh_auto_build\" would be much simpler and follow the standard of the other charts:\n\noverride_dh_auto_build:\n\tmv charts/ingress-nginx .\n\tmake CHART_VERSION\u003d$(CHART_VERSION) ingress-nginx","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\tcp Makefile ingress-nginx"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\tif [ -z \"$(PATCH_VERSION)\" ]; then \\"},{"line_number":23,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION) ingress-nginx; \\"},{"line_number":24,"context_line":"\telse \\"},{"line_number":25,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION)+STX.$(PATCH_VERSION) ingress-nginx; \\"},{"line_number":26,"context_line":"\tfi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"override_dh_auto_install:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"0c698429_242f4765","line":26,"range":{"start_line":22,"start_character":0,"end_line":26,"end_character":3},"updated":"2024-12-13 15:31:02.000000000","message":"Based on previous comment, please change to the same approach used in the original package [1]:\n\ncd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_VERSION) ingress-nginx\n\n[1] https://opendev.org/starlingx/nginx-ingress-controller-armada-app/src/branch/master/helm-charts/upstream/ingress-nginx-helm/debian/deb_folder/rules","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\tcp Makefile ingress-nginx"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\tif [ -z \"$(PATCH_VERSION)\" ]; then \\"},{"line_number":23,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION) ingress-nginx; \\"},{"line_number":24,"context_line":"\telse \\"},{"line_number":25,"context_line":"\t\tcd ingress-nginx \u0026\u0026 make CHART_VERSION\u003d$(CHART_BASE_VERSION)+STX.$(PATCH_VERSION) ingress-nginx; \\"},{"line_number":26,"context_line":"\tfi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"override_dh_auto_install:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"d2dd1dac_c3225c20","line":26,"range":{"start_line":22,"start_character":0,"end_line":26,"end_character":3},"in_reply_to":"0c698429_242f4765","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":29,"context_line":"override_dh_auto_install:"},{"line_number":30,"context_line":"\t# Install the app tar file."},{"line_number":31,"context_line":"\tinstall -d -m 755 $(APP_FOLDER)"},{"line_number":32,"context_line":"\tinstall -p -D -m 755 ingress-nginx/ingress-nginx*.tgz $(APP_FOLDER)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"override_dh_auto_test:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"41127654_de61658c","line":32,"updated":"2024-12-13 15:31:02.000000000","message":"For both openstack-helm [1] and openstack-helm-infra [2] we are using \"install -p -D -m 755 *.tgz $(APP_FOLDER)\". Can we do the same here to maintain the standard?\n\n[1] https://opendev.org/starlingx/openstack-armada-app/src/branch/master/openstack-helm/debian/deb_folder/rules\n[2] https://opendev.org/starlingx/openstack-armada-app/src/branch/master/openstack-helm-infra/debian/deb_folder/rules","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"override_dh_auto_install:"},{"line_number":30,"context_line":"\t# Install the app tar file."},{"line_number":31,"context_line":"\tinstall -d -m 755 $(APP_FOLDER)"},{"line_number":32,"context_line":"\tinstall -p -D -m 755 ingress-nginx/ingress-nginx*.tgz $(APP_FOLDER)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"override_dh_auto_test:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3ff82250_5bcb7f30","line":32,"in_reply_to":"41127654_de61658c","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"}],"ingress-nginx-helm/debian/meta_data.yaml":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  sha256sum: 1c528e262989f883e101e04bd44e3f3fb432d5df1fdc2f98332ff7ee2bbc8ea4"},{"line_number":8,"context_line":"src_files:"},{"line_number":9,"context_line":"  - ingress-nginx-helm/files/Makefile"},{"line_number":10,"context_line":"revision:"},{"line_number":11,"context_line":"  dist: $STX_DIST"},{"line_number":12,"context_line":"  GITREVCOUNT:"},{"line_number":13,"context_line":"    BASE_SRCREV: 6f1700287e8239ba88a24f153a9fad75d3475955"},{"line_number":14,"context_line":"    SRC_DIR: ${MY_REPO}/stx/openstack-armada-app/ingress-nginx-helm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0c85f517_4e673833","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":67},"updated":"2024-12-13 15:31:02.000000000","message":"Please review following the references [1] and [2].\n\n[1] https://docs.starlingx.io/developer_resources/packaging_ref.html\n[2] https://storyboard.openstack.org/#!/story/2010550","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  sha256sum: 1c528e262989f883e101e04bd44e3f3fb432d5df1fdc2f98332ff7ee2bbc8ea4"},{"line_number":8,"context_line":"src_files:"},{"line_number":9,"context_line":"  - ingress-nginx-helm/files/Makefile"},{"line_number":10,"context_line":"revision:"},{"line_number":11,"context_line":"  dist: $STX_DIST"},{"line_number":12,"context_line":"  GITREVCOUNT:"},{"line_number":13,"context_line":"    BASE_SRCREV: 6f1700287e8239ba88a24f153a9fad75d3475955"},{"line_number":14,"context_line":"    SRC_DIR: ${MY_REPO}/stx/openstack-armada-app/ingress-nginx-helm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"58cd7607_bc0865d1","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":67},"in_reply_to":"0c85f517_4e673833","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"8e6e77c040635dc232cd836d79b3794d629a82e8"}],"openstack-helm-infra/debian/deb_folder/control":[{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"2a44949c13bcbb9625018a0002c9b60e25b737b1","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13),"},{"line_number":6,"context_line":" helm,"},{"line_number":7,"context_line":" procps,"},{"line_number":8,"context_line":" ingress-nginx-helm"},{"line_number":9,"context_line":"Standards-Version: 4.5.1"},{"line_number":10,"context_line":"Homepage: https://www.starlingx.io"},{"line_number":11,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"0d2355ee_099e70b2","line":8,"updated":"2024-12-10 11:03:23.000000000","message":"Not sure I understand the requirement here. Could you explain?","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"43b1c60b35ac025f4976d25b76225feec7c0aefd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13),"},{"line_number":6,"context_line":" helm,"},{"line_number":7,"context_line":" procps,"},{"line_number":8,"context_line":" ingress-nginx-helm"},{"line_number":9,"context_line":"Standards-Version: 4.5.1"},{"line_number":10,"context_line":"Homepage: https://www.starlingx.io"},{"line_number":11,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ea61835c_8efb1f7e","line":8,"in_reply_to":"0d2355ee_099e70b2","updated":"2024-12-12 14:34:51.000000000","message":"Done","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"}],"openstack-helm-infra/debian/deb_folder/rules":[{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"2a44949c13bcbb9625018a0002c9b60e25b737b1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"%:"},{"line_number":8,"context_line":"\tdh $@"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"override_dh_auto_build:"},{"line_number":11,"context_line":"\tmake helm-toolkit"},{"line_number":12,"context_line":"\tmake gnocchi"},{"line_number":13,"context_line":"\tmake ingress"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"85cfbdd7_f47ae164","line":10,"updated":"2024-12-10 11:03:23.000000000","message":"I believe this can be dropped, I guess that this should not be here right?","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"43b1c60b35ac025f4976d25b76225feec7c0aefd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"%:"},{"line_number":8,"context_line":"\tdh $@"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"override_dh_auto_build:"},{"line_number":11,"context_line":"\tmake helm-toolkit"},{"line_number":12,"context_line":"\tmake gnocchi"},{"line_number":13,"context_line":"\tmake ingress"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"48f7e388_54438fa2","line":10,"in_reply_to":"85cfbdd7_f47ae164","updated":"2024-12-12 14:34:51.000000000","message":"Done","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e0b67e94f686b6d1d578de39461c3a9a7ad3e358","unresolved":true,"context_lines":[{"line_number":8,"context_line":"\tdh $@"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"override_dh_auto_build:"},{"line_number":11,"context_line":"\t# Create the chart TGZ files."},{"line_number":12,"context_line":"\tmake helm-toolkit"},{"line_number":13,"context_line":"\tmake gnocchi"},{"line_number":14,"context_line":"\tmake ingress"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ef7a7f54_5806b409","side":"PARENT","line":11,"updated":"2024-12-13 15:31:02.000000000","message":"Why did you remove this comment?","commit_id":"aa7be591e62f9aada40b393a5271e233d0d8c035"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"28414ee1973bd3999e902121b746439b9b2a3f8e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\tdh $@"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"override_dh_auto_build:"},{"line_number":11,"context_line":"\t# Create the chart TGZ files."},{"line_number":12,"context_line":"\tmake helm-toolkit"},{"line_number":13,"context_line":"\tmake gnocchi"},{"line_number":14,"context_line":"\tmake ingress"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9ef3e787_a712c04a","side":"PARENT","line":11,"in_reply_to":"ef7a7f54_5806b409","updated":"2024-12-13 19:57:58.000000000","message":"Done","commit_id":"aa7be591e62f9aada40b393a5271e233d0d8c035"}],"upstream/helm-charts/ingress-nginx-helm/debian/deb_folder/changelog":[{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"04de16d1b7ca4a95d08a7a5f4f78278284001068","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  * App upversion"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" --  amantri \u003cayyappa.mantri@windriver.com\u003e  Thu 03 Oct 2024 10:33:50 AM EDT"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"ingress-nginx-helm (4.10-1) unstable; urgency\u003dmedium"},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ab9b5ee3_f39f8c10","line":11,"updated":"2024-12-10 13:58:45.000000000","message":"So you basically copied what\u0027s already present in [1]? If the package already exists, and we\u0027re not making any changes to it, do we really need to recreate it entirely?\n\n[1] - https://opendev.org/starlingx/nginx-ingress-controller-armada-app/src/branch/master/helm-charts/upstream/ingress-nginx-helm/debian","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"43b1c60b35ac025f4976d25b76225feec7c0aefd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  * App upversion"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" --  amantri \u003cayyappa.mantri@windriver.com\u003e  Thu 03 Oct 2024 10:33:50 AM EDT"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"ingress-nginx-helm (4.10-1) unstable; urgency\u003dmedium"},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"486058ce_676b96bb","line":11,"in_reply_to":"ab9b5ee3_f39f8c10","updated":"2024-12-12 14:34:51.000000000","message":"Done","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"}],"upstream/helm-charts/ingress-nginx-helm/debian/meta_data.yaml":[{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"2a44949c13bcbb9625018a0002c9b60e25b737b1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  - ingress-nginx-helm/files/Makefile"},{"line_number":10,"context_line":"revision:"},{"line_number":11,"context_line":"  dist: $STX_DIST"},{"line_number":12,"context_line":"  stx_patch: 0"},{"line_number":13,"context_line":"  GITREVCOUNT:"},{"line_number":14,"context_line":"    BASE_SRCREV: 6f1700287e8239ba88a24f153a9fad75d3475955"},{"line_number":15,"context_line":"    SRC_DIR: ${MY_REPO}/stx/openstack-armada-app/upstream/helm-charts/ingress-nginx-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5699807e_85684a82","line":12,"updated":"2024-12-10 11:03:23.000000000","message":"What does this stx_patch do?","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"},{"author":{"_account_id":37265,"name":"João Pedro Barboza Lioneza","display_name":"João Pedro","email":"joaopedro.barbozalioneza@windriver.com","username":"jbarboza"},"change_message_id":"43b1c60b35ac025f4976d25b76225feec7c0aefd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - ingress-nginx-helm/files/Makefile"},{"line_number":10,"context_line":"revision:"},{"line_number":11,"context_line":"  dist: $STX_DIST"},{"line_number":12,"context_line":"  stx_patch: 0"},{"line_number":13,"context_line":"  GITREVCOUNT:"},{"line_number":14,"context_line":"    BASE_SRCREV: 6f1700287e8239ba88a24f153a9fad75d3475955"},{"line_number":15,"context_line":"    SRC_DIR: ${MY_REPO}/stx/openstack-armada-app/upstream/helm-charts/ingress-nginx-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"45ba85a3_0b32dfb2","line":12,"in_reply_to":"5699807e_85684a82","updated":"2024-12-12 14:34:51.000000000","message":"This is basically a revision counter, I decided to remove because, as the counter is set to 0, there is no need to config like this","commit_id":"be8817c56a27ca06515aab092cbbda7e76952d98"}]}