)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"cf5fa5015124bcc4de4b0299e3cf1f5de91840ab","unresolved":false,"context_lines":[{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"},{"line_number":40,"context_line":"the Test Plan does not include the apply and proper functioning of"},{"line_number":41,"context_line":"the application. The last review of the relation chain will have a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"53e01001_c87d7951","line":38,"updated":"2025-01-21 17:30:35.000000000","message":"Thanks for the warning. I will WF-1 this change until all the changes on the chain are ready to be merged. This way we can merge all of it together.","commit_id":"a31914d21b72165ecc59f3f772053067a21d0ada"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Test Plan:"},{"line_number":33,"context_line":"PASS - Build OSH-I"},{"line_number":34,"context_line":"PASS - OSH-I is on the desired version"},{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bea682ab_3c78c0ef","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":38},"updated":"2025-01-28 12:41:12.000000000","message":"Could you please point the desired version here?","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Test Plan:"},{"line_number":33,"context_line":"PASS - Build OSH-I"},{"line_number":34,"context_line":"PASS - OSH-I is on the desired version"},{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"38f3cf7f_225f651d","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":38},"in_reply_to":"bea682ab_3c78c0ef","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"PASS - Build OSH-I"},{"line_number":34,"context_line":"PASS - OSH-I is on the desired version"},{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"a8cbd99c_8a32f904","line":36,"updated":"2025-01-28 12:41:12.000000000","message":"To PASS in this test, I think you need to add a Depend-On to the OSH upversion change. I know that we have a relation-chain, but in this case we have a cyclic dependency. Therefore, please add:\n\nDepends-On: https://review.opendev.org/c/starlingx/openstack-armada-app/+/939086/17","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"PASS - Build OSH-I"},{"line_number":34,"context_line":"PASS - OSH-I is on the desired version"},{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d3cdce7a_97bd8b7f","line":36,"in_reply_to":"2b977897_d0777b87","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[{"line_number":33,"context_line":"PASS - Build OSH-I"},{"line_number":34,"context_line":"PASS - OSH-I is on the desired version"},{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2b977897_d0777b87","line":36,"in_reply_to":"a8cbd99c_8a32f904","updated":"2025-01-28 16:00:16.000000000","message":"You could also detail that which builds you are testing here: which debian packages were explicitly built from scratch before the tarball build","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"8d1446ca7ed778878075ecec893fc0314a598d07","unresolved":false,"context_lines":[{"line_number":33,"context_line":"PASS - Build OSH-I"},{"line_number":34,"context_line":"PASS - OSH-I is on the desired version"},{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"0aaeffda_0947bb78","line":36,"in_reply_to":"d3cdce7a_97bd8b7f","updated":"2025-01-29 17:53:10.000000000","message":"It seems like Zuul doesn\u0027t allow circular depencies. After I added it, the zuul check failed. Because of that it was removed.","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"},{"line_number":40,"context_line":"the Test Plan does not include the apply and proper functioning of"},{"line_number":41,"context_line":"the application. The last review of the relation chain will have a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5ae3e65e_c52f2375","line":38,"updated":"2025-01-28 16:00:16.000000000","message":"You can add this as the explanation fro the Depends-On suggested by Alex above here","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"PASS - All OSH-I patches are applied"},{"line_number":36,"context_line":"PASS - STX-O is built"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"With this change STX-Openstack will stop applying until the all"},{"line_number":39,"context_line":"reviews in the relation chain are merged as well. Because of that,"},{"line_number":40,"context_line":"the Test Plan does not include the apply and proper functioning of"},{"line_number":41,"context_line":"the application. The last review of the relation chain will have a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"67edf30c_945ad529","line":38,"in_reply_to":"5ae3e65e_c52f2375","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"89f19c3a4fbd0f8a5fd2420c8040dcddc8995b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09ec39db_2e84a525","updated":"2025-01-13 19:33:07.000000000","message":"Nice work :)","commit_id":"3e11bcd341de3b0ca4d26775780add2dde91ba11"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"cf5fa5015124bcc4de4b0299e3cf1f5de91840ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5cc50f42_9d1dbd41","updated":"2025-01-21 17:30:35.000000000","message":"Thanks for the effort here, Caires.\n\nCode looks good. WF-1 until all changes on this chain are ready to merge together.","commit_id":"a31914d21b72165ecc59f3f772053067a21d0ada"},{"author":{"_account_id":36340,"name":"Vinícius Fernando Rocha Lobo","display_name":"Vinicius Lobo","email":"Vinicius.RochaLobo@windriver.com","username":"vrochalo"},"change_message_id":"78f759168e4e92727c7c81a3ffe2cc1867c82423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c62fefcc_5731adc4","updated":"2025-01-21 17:42:26.000000000","message":"lgtm","commit_id":"a31914d21b72165ecc59f3f772053067a21d0ada"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4193dbbf_58301501","updated":"2025-01-28 12:41:12.000000000","message":"Great work, Caires. But I have some comments. Please take a look.","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37229,"name":"Murillo Arantes","display_name":"Murillo Arantes","email":"murillo.arantes@windriver.com","username":"marantes"},"change_message_id":"6f9280f7fc4f243ea4d33382b59602316862c74c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5699a56e_dec4a9e3","updated":"2025-01-29 18:29:57.000000000","message":"Great work!","commit_id":"5cf2d44334b244088f90d9a0945d8bced3fb9c63"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"a9d9599c1a57de56fcf94d455ffeaeea7ca04c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b770d4c1_9bbf905b","updated":"2025-01-30 12:02:56.000000000","message":"Nice Job, Caires!","commit_id":"5cf2d44334b244088f90d9a0945d8bced3fb9c63"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"384e2130cc01a2660f7fddcb4a04e866d48e9e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ad075e64_b6a8542b","updated":"2025-01-29 19:57:50.000000000","message":"WF+1 based on multiple code reviews.\nThis is merging along with all changes in its chain","commit_id":"5cf2d44334b244088f90d9a0945d8bced3fb9c63"}],"openstack-helm-infra/debian/deb_folder/patches/0004-Add-io_thread_pool-for-rabbitmq.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Date: Tue, 13 Aug 2019 10:15:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] add io_thread_pool for rabbitmq"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: Bin Yang \u003cbin.yang@intel.com\u003e"},{"line_number":7,"context_line":"---"},{"line_number":8,"context_line":" rabbitmq/templates/statefulset.yaml | 8 ++++++++"},{"line_number":9,"context_line":" rabbitmq/values.yaml                | 4 ++++"}],"source_content_type":"text/x-diff","patch_set":7,"id":"39a37297_a65f0331","line":6,"updated":"2025-01-28 16:00:16.000000000","message":"Apparently you had to update the readiness and liveness approach here due to the upversion. Please add and editorial note that the patch was modified now and why","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"cb38e8afd82a519db90adbc03245004621d7a098","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Date: Tue, 13 Aug 2019 10:15:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] add io_thread_pool for rabbitmq"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: Bin Yang \u003cbin.yang@intel.com\u003e"},{"line_number":7,"context_line":"---"},{"line_number":8,"context_line":" rabbitmq/templates/statefulset.yaml | 8 ++++++++"},{"line_number":9,"context_line":" rabbitmq/values.yaml                | 4 ++++"}],"source_content_type":"text/x-diff","patch_set":7,"id":"4bc6d7df_f7ffb4cd","line":6,"in_reply_to":"39a37297_a65f0331","updated":"2025-01-29 10:38:38.000000000","message":"I mean, not really. The patch is doing the exact same thing. The template which is being altered by this patch is the one that changed. Even so, should I add an editorial note? Since what is being added did not changed","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2a0e5b73b5ea7363bd4bbbb41d7dbbd6779512c0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Date: Tue, 13 Aug 2019 10:15:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] add io_thread_pool for rabbitmq"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: Bin Yang \u003cbin.yang@intel.com\u003e"},{"line_number":7,"context_line":"---"},{"line_number":8,"context_line":" rabbitmq/templates/statefulset.yaml | 8 ++++++++"},{"line_number":9,"context_line":" rabbitmq/values.yaml                | 4 ++++"}],"source_content_type":"text/x-diff","patch_set":7,"id":"c9d03ce7_a878056d","line":6,"in_reply_to":"4bc6d7df_f7ffb4cd","updated":"2025-01-29 14:25:25.000000000","message":"Sorry, my mistake. You are correct.","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"}],"openstack-helm-infra/debian/deb_folder/patches/0005-Enable-override-of-mariadb-server-probe-parameters.patch":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"33d7433efd4a062367b7fc397cb4f6d60cf2f313","unresolved":true,"context_lines":[{"line_number":33,"context_line":"                   - /tmp/stop.sh"},{"line_number":34,"context_line":" {{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"readiness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":35,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"startup\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":36,"context_line":" {{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"liveness\" \"probeTemplate\" (include \"mariadbLivenessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":37,"context_line":"           volumeMounts:"},{"line_number":38,"context_line":"             - name: pod-tmp"},{"line_number":39,"context_line":"diff --git a/mariadb/values.yaml b/mariadb/values.yaml"}],"source_content_type":"text/x-diff","patch_set":1,"id":"6215b7c6_516dd69d","line":36,"updated":"2025-01-13 14:18:07.000000000","message":"Why did you change from mariadbReadinessProbe to mariadbLivenessProbe on this specific case?","commit_id":"3e11bcd341de3b0ca4d26775780add2dde91ba11"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"78c095c959670845de0f7cc367d52f680f57ecca","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                   - /tmp/stop.sh"},{"line_number":34,"context_line":" {{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"readiness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":35,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"startup\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":36,"context_line":" {{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"liveness\" \"probeTemplate\" (include \"mariadbLivenessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":37,"context_line":"           volumeMounts:"},{"line_number":38,"context_line":"             - name: pod-tmp"},{"line_number":39,"context_line":"diff --git a/mariadb/values.yaml b/mariadb/values.yaml"}],"source_content_type":"text/x-diff","patch_set":1,"id":"65fc6a25_0c1708c3","line":36,"in_reply_to":"6215b7c6_516dd69d","updated":"2025-01-13 14:23:55.000000000","message":"It wasn\u0027t exactly me, it just reflects changes made to the upstream helm chart. Why this was done I don\u0027t know","commit_id":"3e11bcd341de3b0ca4d26775780add2dde91ba11"}],"openstack-helm-infra/debian/deb_folder/patches/0005-Enable-override-of-rabbitmq-probe-parameters.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 132df9829fa4c697e0b9701871888708973f9123 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: Gerry Kopec \u003cGerry.Kopec@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Fri, 16 Aug 2019 14:29:46 -0400"},{"line_number":4,"context_line":"Subject: [PATCH] Enable override of rabbitmq probe parameters"}],"source_content_type":"text/x-diff","patch_set":7,"id":"84d998a3_b02afc55","side":"PARENT","line":1,"updated":"2025-01-28 16:00:16.000000000","message":"From commit message:  \"Patch 0005 was removed because upstream OSH-I implemented the same config. Additional configurations set on the patch was translated\ninto a change in the static-overrides\"\n\nlgtm","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/patches/0010-Fix-tls-in-openstack-helm-infra.patch":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"-  - values: |"},{"line_number":22,"context_line":"-      annotations:"},{"line_number":23,"context_line":"-        secret:"},{"line_number":24,"context_line":"+values: |"},{"line_number":25,"context_line":"+  secrets:"},{"line_number":26,"context_line":"+    tls:"},{"line_number":27,"context_line":"+      key_manager:"},{"line_number":28,"context_line":"+        api:"},{"line_number":29,"context_line":"+          public: barbican-tls-public"},{"line_number":30,"context_line":"+  endpoints:"},{"line_number":31,"context_line":"+    key_manager:"},{"line_number":32,"context_line":"+      host_fqdn_override:"},{"line_number":33,"context_line":"+        public:"},{"line_number":34,"context_line":"           tls:"},{"line_number":35,"context_line":"-            key_manager_api_public:"},{"line_number":36,"context_line":"-              custom.tld/key: \"value\""},{"line_number":37,"context_line":"-      secrets:"}],"source_content_type":"text/x-diff","patch_set":7,"id":"52c4f938_234d1372","line":34,"range":{"start_line":24,"start_character":0,"end_line":34,"end_character":15},"updated":"2025-01-28 12:41:12.000000000","message":"It seems you are adding what was previously removed by the patch. Is this correct?","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"-  - values: |"},{"line_number":22,"context_line":"-      annotations:"},{"line_number":23,"context_line":"-        secret:"},{"line_number":24,"context_line":"+values: |"},{"line_number":25,"context_line":"+  secrets:"},{"line_number":26,"context_line":"+    tls:"},{"line_number":27,"context_line":"+      key_manager:"},{"line_number":28,"context_line":"+        api:"},{"line_number":29,"context_line":"+          public: barbican-tls-public"},{"line_number":30,"context_line":"+  endpoints:"},{"line_number":31,"context_line":"+    key_manager:"},{"line_number":32,"context_line":"+      host_fqdn_override:"},{"line_number":33,"context_line":"+        public:"},{"line_number":34,"context_line":"           tls:"},{"line_number":35,"context_line":"-            key_manager_api_public:"},{"line_number":36,"context_line":"-              custom.tld/key: \"value\""},{"line_number":37,"context_line":"-      secrets:"}],"source_content_type":"text/x-diff","patch_set":7,"id":"ca4314b5_094e07d3","line":34,"range":{"start_line":24,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"0ab3dd3a_1b6eba76","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[{"line_number":21,"context_line":"-  - values: |"},{"line_number":22,"context_line":"-      annotations:"},{"line_number":23,"context_line":"-        secret:"},{"line_number":24,"context_line":"+values: |"},{"line_number":25,"context_line":"+  secrets:"},{"line_number":26,"context_line":"+    tls:"},{"line_number":27,"context_line":"+      key_manager:"},{"line_number":28,"context_line":"+        api:"},{"line_number":29,"context_line":"+          public: barbican-tls-public"},{"line_number":30,"context_line":"+  endpoints:"},{"line_number":31,"context_line":"+    key_manager:"},{"line_number":32,"context_line":"+      host_fqdn_override:"},{"line_number":33,"context_line":"+        public:"},{"line_number":34,"context_line":"           tls:"},{"line_number":35,"context_line":"-            key_manager_api_public:"},{"line_number":36,"context_line":"-              custom.tld/key: \"value\""},{"line_number":37,"context_line":"-      secrets:"}],"source_content_type":"text/x-diff","patch_set":7,"id":"9d543244_9f1b63fa","line":34,"range":{"start_line":24,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"52c4f938_234d1372","updated":"2025-01-28 16:00:16.000000000","message":"Additionally, if something is added/modified please add and editorial note that the patch was modified now and why","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"cb38e8afd82a519db90adbc03245004621d7a098","unresolved":true,"context_lines":[{"line_number":21,"context_line":"-  - values: |"},{"line_number":22,"context_line":"-      annotations:"},{"line_number":23,"context_line":"-        secret:"},{"line_number":24,"context_line":"+values: |"},{"line_number":25,"context_line":"+  secrets:"},{"line_number":26,"context_line":"+    tls:"},{"line_number":27,"context_line":"+      key_manager:"},{"line_number":28,"context_line":"+        api:"},{"line_number":29,"context_line":"+          public: barbican-tls-public"},{"line_number":30,"context_line":"+  endpoints:"},{"line_number":31,"context_line":"+    key_manager:"},{"line_number":32,"context_line":"+      host_fqdn_override:"},{"line_number":33,"context_line":"+        public:"},{"line_number":34,"context_line":"           tls:"},{"line_number":35,"context_line":"-            key_manager_api_public:"},{"line_number":36,"context_line":"-              custom.tld/key: \"value\""},{"line_number":37,"context_line":"-      secrets:"}],"source_content_type":"text/x-diff","patch_set":7,"id":"0ab3dd3a_1b6eba76","line":34,"range":{"start_line":24,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"9d543244_9f1b63fa","updated":"2025-01-29 10:38:38.000000000","message":"Not really, I had to update the patch because what was being removed changed. But when I created the new patch GIT decided to organize the patch this way. If you take a look a the end of this changed on the before you will see that this here is the same, is just organized differently. But it does seem that I made a mistake at the end of this patch. I will fix it","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"}],"openstack-helm-infra/debian/deb_folder/patches/0011-Remove-mariadb-tls.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[{"line_number":34,"context_line":" {{- end }}"},{"line_number":35,"context_line":"       volumes:"},{"line_number":36,"context_line":"         - name: pod-tmp"},{"line_number":37,"context_line":"@@ -152,9 +148,6 @@ spec:"},{"line_number":38,"context_line":"             name: {{ $configMapBin | quote }}"},{"line_number":39,"context_line":"             defaultMode: 0555"},{"line_number":40,"context_line":" {{- end }}"}],"source_content_type":"text/x-diff","patch_set":7,"id":"fa6a789f_23e69780","line":37,"updated":"2025-01-28 16:00:16.000000000","message":"If something is added/modified/re-ordered please add and editorial note that the patch was modified now and why","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":34,"context_line":" {{- end }}"},{"line_number":35,"context_line":"       volumes:"},{"line_number":36,"context_line":"         - name: pod-tmp"},{"line_number":37,"context_line":"@@ -152,9 +148,6 @@ spec:"},{"line_number":38,"context_line":"             name: {{ $configMapBin | quote }}"},{"line_number":39,"context_line":"             defaultMode: 0555"},{"line_number":40,"context_line":" {{- end }}"}],"source_content_type":"text/x-diff","patch_set":7,"id":"006ee4e9_388c0a44","line":37,"in_reply_to":"fa6a789f_23e69780","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"}],"openstack-helm-infra/debian/deb_folder/patches/0013-Update-openstack-Ingress-for-networking-api-v1.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"49bc58ae_100f6f25","side":"PARENT","line":28,"updated":"2025-01-28 16:00:16.000000000","message":"If something is added/modified/re-ordered/removed please add and editorial note that the patch was modified now and why","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36d43e98_83413d32","side":"PARENT","line":28,"in_reply_to":"49bc58ae_100f6f25","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/patches/0015-Add-app.starlingx.io-component-label-to-pods.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bbf8a841_d9c5ecda","side":"PARENT","line":55,"updated":"2025-01-28 16:00:16.000000000","message":"If something is added/modified/re-ordered/removed please add and editorial note that the patch was modified now and why","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a951109_c9d1187b","side":"PARENT","line":55,"in_reply_to":"bbf8a841_d9c5ecda","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/patches/0016-Add-ServiceAccount-to-openvswitch-pod.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 1a16da4ed0913c2de36b070326277a3aa555e376 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: Thales Elero Cervi \u003cthaleselero.cervi@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 13 Jul 2023 16:35:40 -0300"},{"line_number":4,"context_line":"Subject: [PATCH] Add ServiceAccount to openvswitch pod"}],"source_content_type":"text/x-diff","patch_set":7,"id":"3ea280a3_ca1d9731","side":"PARENT","line":1,"updated":"2025-01-28 16:00:16.000000000","message":"From commit message: \"the changes in the patch 0016 were also merged on upstream OSH-I, so with the upversion they can be dropped.\"\n\nlgtm","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/patches/0016-Add-pre-apply-cleanup-Job-to-STX-O-Helm-charts.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cb0e9d65_d75ceee5","side":"PARENT","line":26,"updated":"2025-01-28 16:00:16.000000000","message":"If something is added/modified/re-ordered/removed please add and editorial note that the patch was modified now and why","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"78984e24_9f817cba","side":"PARENT","line":26,"in_reply_to":"cb0e9d65_d75ceee5","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/patches/0017-Add-Kubernetes-name-label-to-helm-toolkit-template.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4728e58_e5b0eaed","side":"PARENT","line":28,"updated":"2025-01-28 16:00:16.000000000","message":"If something is added/modified/re-ordered/removed please add and editorial note that the patch was modified now and why","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2889f47f_89d408a5","side":"PARENT","line":28,"in_reply_to":"f4728e58_e5b0eaed","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/patches/0018-Remove-nginx-configuration-snippet.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"949fae92b718a36206c29ac4f5264554e59ba1eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From fb3efbc55f9933910ab4dffa58d36fc2921b5b97 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: Romulo Leite \u003cromulo.leite@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 11 Jul 2024 14:30:20 -0300"},{"line_number":4,"context_line":"Subject: [PATCH] Remove nginx configuration-snippet"}],"source_content_type":"text/x-diff","patch_set":7,"id":"ff2d9f81_bb7e9c7b","side":"PARENT","line":1,"updated":"2025-01-28 16:00:16.000000000","message":"From commit message: \"Patch 0018 was dropped because the Ingress Helm chart was removed from upstream OSH-I.\"\n\nlgtm","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/deb_folder/rules":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"cf5fa5015124bcc4de4b0299e3cf1f5de91840ab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\t# Create the chart TGZ files."},{"line_number":12,"context_line":"\tmake helm-toolkit"},{"line_number":13,"context_line":"\tmake gnocchi"},{"line_number":14,"context_line":"\tmake ingress"},{"line_number":15,"context_line":"\tmake libvirt"},{"line_number":16,"context_line":"\tmake mariadb"},{"line_number":17,"context_line":"\tmake memcached"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"f2a44895_45f2736f","side":"PARENT","line":14,"updated":"2025-01-21 17:30:35.000000000","message":"Makes sense, the ingress chart is now built separately and added as a build dependency on the OSH-I Debian package: https://review.opendev.org/c/starlingx/openstack-armada-app/+/937396/8/openstack-helm-infra/debian/deb_folder/control#8","commit_id":"438ee26ee55d39b2cb8b131bad4a704a50d45f19"}],"openstack-helm-infra/debian/meta_data.yaml":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: openstack-helm-infra"},{"line_number":3,"context_line":"debver: 1.0-1"},{"line_number":4,"context_line":"dl_path:"},{"line_number":5,"context_line":"  name: openstack-helm-infra-05f2f45971abcf483189358d663e2b46c3fc2fe8.tar.gz"},{"line_number":6,"context_line":"  url: https://github.com/openstack/openstack-helm-infra/archive/05f2f45971abcf483189358d663e2b46c3fc2fe8.tar.gz"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"243953fb_fffe95b6","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":13},"updated":"2025-01-28 12:41:12.000000000","message":"Shouldn\u0027t the package version be updated? Furthermore, I think you should also update the changelog and copyright in \"openstack-helm-infra/debian/deb_folder/\".","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: openstack-helm-infra"},{"line_number":3,"context_line":"debver: 1.0-1"},{"line_number":4,"context_line":"dl_path:"},{"line_number":5,"context_line":"  name: openstack-helm-infra-05f2f45971abcf483189358d663e2b46c3fc2fe8.tar.gz"},{"line_number":6,"context_line":"  url: https://github.com/openstack/openstack-helm-infra/archive/05f2f45971abcf483189358d663e2b46c3fc2fe8.tar.gz"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f07af825_dc24cf17","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":13},"in_reply_to":"243953fb_fffe95b6","updated":"2025-01-29 13:30:29.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"}],"stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/mariadb/mariadb-static-overrides.yaml":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"40094643b32bc036b0f73c840697c9b25fe7e0c1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    prometheus_mysql_exporter: null"},{"line_number":30,"context_line":"    prometheus_mysql_exporter_helm_tests: null"},{"line_number":31,"context_line":"    ks_user: docker.io/starlingx/stx-heat:master-debian-stable-latest"},{"line_number":32,"context_line":"    mariadb: docker.io/openstackhelm/mariadb:ubuntu_xenial-20200303"},{"line_number":33,"context_line":"    mariadb_backup: docker.io/openstackhelm/mariadb:10.2.18"},{"line_number":34,"context_line":"    pre_apply_cleanup: docker.io/starlingx/stx-vault-manager:master-debian-stable-latest"},{"line_number":35,"context_line":"    scripted_test: null"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6dc7811a_bf6f68be","line":32,"updated":"2025-01-20 18:47:16.000000000","message":"The new commit used for OSH-I [1] set this mariadb image tag to \"mariadb:latest-ubuntu_focal\". Therefore, I think it should be update to \"mariadb:ubuntu_focal-20250111\":\n\n\n\n[1] https://opendev.org/openstack/openstack-helm-infra/src/commit/05f2f45971abcf483189358d663e2b46c3fc2fe8/mariadb/values.yaml#L23\n```suggestion\n    mariadb: docker.io/openstackhelm/mariadb:ubuntu_focal-20250111\n```","commit_id":"50bf277adc400ea826b0ef03afd67b7f0f90d6a6"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"cf5fa5015124bcc4de4b0299e3cf1f5de91840ab","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    prometheus_mysql_exporter: null"},{"line_number":30,"context_line":"    prometheus_mysql_exporter_helm_tests: null"},{"line_number":31,"context_line":"    ks_user: docker.io/starlingx/stx-heat:master-debian-stable-latest"},{"line_number":32,"context_line":"    mariadb: docker.io/openstackhelm/mariadb:ubuntu_xenial-20200303"},{"line_number":33,"context_line":"    mariadb_backup: docker.io/openstackhelm/mariadb:10.2.18"},{"line_number":34,"context_line":"    pre_apply_cleanup: docker.io/starlingx/stx-vault-manager:master-debian-stable-latest"},{"line_number":35,"context_line":"    scripted_test: null"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b3e45c13_c95bbc7e","line":32,"in_reply_to":"6dc7811a_bf6f68be","updated":"2025-01-21 17:30:35.000000000","message":"Makes sense. Although I don\u0027t think this should gate the current code change, as long as the application is still working as it is.\nImages updates/upstream alignment can be handled on a separate (follow-up) task.","commit_id":"50bf277adc400ea826b0ef03afd67b7f0f90d6a6"}],"stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/rabbitmq/rabbitmq-static-overrides.yaml":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    rabbitmq:"},{"line_number":54,"context_line":"      rabbitmq:"},{"line_number":55,"context_line":"        readiness:"},{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2a58aecd_1b67905e","line":56,"updated":"2025-01-28 12:41:12.000000000","message":"Based on chart values.yaml [1], the config seems to be wrong. The \"periodSeconds\" should appear inside a \"params\" section:\n\n\n```suggestion\n          params:\n            periodSeconds: 10\n```\n\n[1] https://opendev.org/openstack/openstack-helm-infra/src/commit/5c1709d5bd86728d7f5453c68a251d4946cb6989/rabbitmq/values.yaml#L77","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    rabbitmq:"},{"line_number":54,"context_line":"      rabbitmq:"},{"line_number":55,"context_line":"        readiness:"},{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6a753109_6262d1e2","line":56,"in_reply_to":"2a58aecd_1b67905e","updated":"2025-01-29 13:30:29.000000000","message":"Missed that, Sorry!","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        readiness:"},{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"},{"line_number":60,"context_line":"# TODO: Revert to upstream defaults once the following LP is resolved:"},{"line_number":61,"context_line":"# https://bugs.launchpad.net/starlingx/+bug/1814595. By changing this PV"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"75dbc0a7_a27b0d32","line":58,"updated":"2025-01-28 12:41:12.000000000","message":"The initialDelaySeconds for the liveness probe was previously set to 60 seconds (default value) [1]. Why are you reducing this value to 30 seconds?\n\n[1] https://opendev.org/openstack/openstack-helm-infra/src/commit/6b6ca9e26c5193e1920f65adfac2fd4b15c2f341/rabbitmq/values.yaml#L84","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"cb38e8afd82a519db90adbc03245004621d7a098","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        readiness:"},{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"},{"line_number":60,"context_line":"# TODO: Revert to upstream defaults once the following LP is resolved:"},{"line_number":61,"context_line":"# https://bugs.launchpad.net/starlingx/+bug/1814595. By changing this PV"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f92ca63_e0367179","line":58,"in_reply_to":"75dbc0a7_a27b0d32","updated":"2025-01-29 10:38:38.000000000","message":"Did not realize that, I was using the values defined on the patch that was doing this up until now. Should I just leave the 60 seconds? Or keep the same values as is was being done until now?","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"6b7abeede93578f0baf913ccc854f6ae21199c1d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        readiness:"},{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"},{"line_number":60,"context_line":"# TODO: Revert to upstream defaults once the following LP is resolved:"},{"line_number":61,"context_line":"# https://bugs.launchpad.net/starlingx/+bug/1814595. By changing this PV"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"69ec7500_991c82af","line":58,"in_reply_to":"9f92ca63_e0367179","updated":"2025-01-29 16:26:21.000000000","message":"Done","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"73290b1e3da8c3bb0500a8947c86bc629ae0dc1a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"},{"line_number":60,"context_line":"# TODO: Revert to upstream defaults once the following LP is resolved:"},{"line_number":61,"context_line":"# https://bugs.launchpad.net/starlingx/+bug/1814595. By changing this PV"},{"line_number":62,"context_line":"# size to 1Gi from the default 265Mi, this avoids the kernel hang from the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d6a36318_20805ed8","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":27},"updated":"2025-01-28 12:41:12.000000000","message":"Based on chart values.yaml [1], the config seems to be wrong. The \"periodSeconds\" should appear inside a \"params\" section:\n\n\n```suggestion\n          params:\n            periodSeconds: 10\n```\n\n[1] https://opendev.org/openstack/openstack-helm-infra/src/commit/5c1709d5bd86728d7f5453c68a251d4946cb6989/rabbitmq/values.yaml#L85","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"fff44534da21bb7aca5b04f18858652c9a7cf9cb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          periodSeconds: 30"},{"line_number":57,"context_line":"        liveness:"},{"line_number":58,"context_line":"          initialDelaySeconds: 30"},{"line_number":59,"context_line":"          periodSeconds: 30"},{"line_number":60,"context_line":"# TODO: Revert to upstream defaults once the following LP is resolved:"},{"line_number":61,"context_line":"# https://bugs.launchpad.net/starlingx/+bug/1814595. By changing this PV"},{"line_number":62,"context_line":"# size to 1Gi from the default 265Mi, this avoids the kernel hang from the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d319eed2_c0e9dd51","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":27},"in_reply_to":"d6a36318_20805ed8","updated":"2025-01-29 13:30:29.000000000","message":"thanks!","commit_id":"d9695b6611f7edda23eff217b64af36199ef1963"}]}