)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-02 13:21:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CephFS provisioner for k8sapp_platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":10,"context_line":"Change-Id: Ic4270e401b2c3e51c3aecfab23af1e874e733831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f621f24_21ec2028","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"updated":"2020-11-03 16:11:24.000000000","message":"please add more details such as, what is the reference (rbd-provisioner), why RBD provisioner is not enough and what it provides (i.e. shared mount from different PVCs, FS mount) + list of tests.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-02 13:21:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CephFS provisioner for k8sapp_platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":10,"context_line":"Change-Id: Ic4270e401b2c3e51c3aecfab23af1e874e733831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f621f24_8e3c2fc0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"in_reply_to":"1f621f24_21ec2028","updated":"2020-11-23 12:59:10.000000000","message":"\u003e please add more details such as, what is the reference\n \u003e (rbd-provisioner), why RBD provisioner is not enough and what it\n \u003e provides (i.e. shared mount from different PVCs, FS mount) + list\n \u003e of tests.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"8f6a1ccacfffc383d6f1daa6b29c0c885371e2f7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-02 13:21:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CephFS provisioner for k8sapp_platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":10,"context_line":"Change-Id: Ic4270e401b2c3e51c3aecfab23af1e874e733831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f621f24_ac35c048","line":8,"updated":"2020-11-03 23:04:23.000000000","message":"Please add tasks to https://storyboard.openstack.org/#!/story/2008162 add to the commit message\n\nStory: 2008162\nTask: XXXXX","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CephFS provisioner for k8sapp_platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit implements CephFS Provisioner as a helm chart in platform-integ-apps."},{"line_number":10,"context_line":"CephFS Provisioner implements the same design as RBD Provisioner,"},{"line_number":11,"context_line":"but with CephFS Provisioner we can have mounts shared by differents components,"},{"line_number":12,"context_line":"such as pods."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fffc6b78_e3ff0a32","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":81},"updated":"2020-11-20 04:20:06.000000000","message":"nit: A few long lines here. Keep to the 72 character limit.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":16,"context_line":"Story: 2008162"},{"line_number":17,"context_line":"Task: 40908"},{"line_number":18,"context_line":"Change-Id: Ic4270e401b2c3e51c3aecfab23af1e874e733831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fffc6b78_63503a34","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":11},"updated":"2020-11-20 04:20:06.000000000","message":"nit: Typically I try to add a specific task (for the repo that the commit aligns) in the Storyboard for each commit needed to deliver the story content.  This provides visibility in the storyboard to the extent of the required changes across repos.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"python-k8sapp-platform/k8sapp_platform/k8sapp_platform/armada/manifest_platform.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    CHARTS_LUT \u003d {"},{"line_number":32,"context_line":"        CephPoolsAuditHelm.CHART: \u0027kube-system-ceph-pools-audit\u0027,"},{"line_number":33,"context_line":"        RbdProvisionerHelm.CHART: \u0027kube-system-rbd-provisioner\u0027,"},{"line_number":34,"context_line":"        CephFSProvisionerHelm.CHART: \u0027kube-system-cephfs-provisioner\u0027,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def platform_mode_manifest_updates(self, dbapi, mode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fffc6b78_ba9ec304","line":34,"range":{"start_line":34,"start_character":69,"end_line":34,"end_character":70},"updated":"2020-11-20 04:20:06.000000000","message":"nit: extra comma","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    CHARTS_LUT \u003d {"},{"line_number":32,"context_line":"        CephPoolsAuditHelm.CHART: \u0027kube-system-ceph-pools-audit\u0027,"},{"line_number":33,"context_line":"        RbdProvisionerHelm.CHART: \u0027kube-system-rbd-provisioner\u0027,"},{"line_number":34,"context_line":"        CephFSProvisionerHelm.CHART: \u0027kube-system-cephfs-provisioner\u0027,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def platform_mode_manifest_updates(self, dbapi, mode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"f5e872bb_ba711322","line":34,"range":{"start_line":34,"start_character":69,"end_line":34,"end_character":70},"in_reply_to":"fffc6b78_ba9ec304","updated":"2020-11-23 12:59:10.000000000","message":"solved","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"python-k8sapp-platform/k8sapp_platform/k8sapp_platform/helm/ceph_fs_provisioner.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"from sysinv.common import constants"},{"line_number":10,"context_line":"from sysinv.common import exception"},{"line_number":11,"context_line":"from sysinv.common.storage_backend_conf import K8CephFSProvisioner"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from sysinv.helm import base"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fffc6b78_952630b7","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"updated":"2020-11-20 04:20:06.000000000","message":"Looks like all the methods of this class are self contained and not used any other place. So move the class to this file or add the methods of it to CephFSProvisionerHelm and call accordingly. No reason to place K8CephFSProvisioner code in the sysinv package in the platform.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"from sysinv.common import constants"},{"line_number":10,"context_line":"from sysinv.common import exception"},{"line_number":11,"context_line":"from sysinv.common.storage_backend_conf import K8CephFSProvisioner"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from sysinv.helm import base"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"a34e181c_b7cbeb38","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"in_reply_to":"fffc6b78_952630b7","updated":"2020-11-23 12:59:10.000000000","message":"solved","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \"provisionerConfigName\": app_constants.HELM_CHART_CEPH_FS_PROVISIONER"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Get tier info."},{"line_number":63,"context_line":"        tiers \u003d self.dbapi.storage_tier_get_list()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        classes \u003d []"},{"line_number":66,"context_line":"        for bk in ceph_bks:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fffc6b78_3a2e53a5","line":63,"range":{"start_line":62,"start_character":1,"end_line":63,"end_character":50},"updated":"2020-11-20 04:20:06.000000000","message":"Have you tried a storage tier configuration?","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \"provisionerConfigName\": app_constants.HELM_CHART_CEPH_FS_PROVISIONER"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Get tier info."},{"line_number":63,"context_line":"        tiers \u003d self.dbapi.storage_tier_get_list()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        classes \u003d []"},{"line_number":66,"context_line":"        for bk in ceph_bks:"}],"source_content_type":"text/x-python","patch_set":11,"id":"64085804_8e8a74f7","line":63,"range":{"start_line":62,"start_character":1,"end_line":63,"end_character":50},"in_reply_to":"fffc6b78_3a2e53a5","updated":"2020-11-23 12:59:10.000000000","message":"yes. it works","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/.helmignore":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_26ff60ab","updated":"2020-11-20 04:20:06.000000000","message":"Is this file needed?","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/Chart.yaml":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: v1"},{"line_number":2,"context_line":"appVersion: \"1.0\""},{"line_number":3,"context_line":"description: CephFs provisioner for Kubernetes"},{"line_number":4,"context_line":"name: cephfs-provisioner"},{"line_number":5,"context_line":"version: 0.1.0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_fc1c8b6b","line":3,"range":{"start_line":3,"start_character":17,"end_line":3,"end_character":19},"updated":"2020-11-03 16:11:24.000000000","message":"nit: FS instead of Fs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_06733c82","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5bbeb3b0_00d1124b","in_reply_to":"fffc6b78_06733c82","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/requirements.yaml":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2019 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_3c28c384","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":20},"updated":"2020-11-03 16:11:24.000000000","message":"2020","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/bin/_ceph-pools-create.sh.tpl":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1f621f24_fc35abdb","updated":"2020-11-03 16:11:24.000000000","message":"Rename it to _storage_init.sh.tpl","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":2,"context_line":"set -x"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{{ $classes :\u003d .Values.classes}}"},{"line_number":5,"context_line":"KEYRING_DIR\u003d/var/lib/ceph/mds/ceph-controller-0"},{"line_number":6,"context_line":"KEYRING_FILE\u003d/var/lib/ceph/mds/ceph-controller-0/keyring"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Create keyring directory"},{"line_number":9,"context_line":"if [ -d \"$KEYRING_DIR\" ]; then"},{"line_number":10,"context_line":"    echo \"keyring directory exists\""},{"line_number":11,"context_line":"    echo \"skipping...\""},{"line_number":12,"context_line":"else"},{"line_number":13,"context_line":"    mkdir -p $KEYRING_DIR"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Create keyring in the directory created above"},{"line_number":17,"context_line":"if [ -f \"$KEYRING_FILE\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_fc4acb52","line":14,"range":{"start_line":5,"start_character":0,"end_line":14,"end_character":2},"updated":"2020-11-03 16:11:24.000000000","message":"this is not needed. Admin key is already present. Do a:\ntouch /etc/ceph/ceph.client.admin.keyring instead.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":12,"context_line":"else"},{"line_number":13,"context_line":"    mkdir -p $KEYRING_DIR"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Create keyring in the directory created above"},{"line_number":17,"context_line":"if [ -f \"$KEYRING_FILE\" ]; then"},{"line_number":18,"context_line":"    echo \"keyring file exists\""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_1c6347b3","line":15,"updated":"2020-11-03 16:11:24.000000000","message":"Add a check for ceph, this helps to debug errors on the field:\n\n    # Check if ceph is accessible\n    echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\"\n    ceph -s\n    if [ $? -ne 0 ]; then\n      echo \"Error: Ceph cluster is not accessible, check Pod logs for details.\"\n      exit 1\n    fi","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    mkdir -p $KEYRING_DIR"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Create keyring in the directory created above"},{"line_number":17,"context_line":"if [ -f \"$KEYRING_FILE\" ]; then"},{"line_number":18,"context_line":"    echo \"keyring file exists\""},{"line_number":19,"context_line":"    echo \"skipping...\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    ceph-authtool --create-keyring $KEYRING_FILE --gen-key -n mds.controller-0"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Add permissions for mds.controller-0"},{"line_number":25,"context_line":"ceph auth add mds.controller-0 osd \"allow rwx\" mds \"allow\" mon \"allow profile mds\" -i $KEYRING_FILE"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_7c707ba6","line":22,"range":{"start_line":16,"start_character":0,"end_line":22,"end_character":2},"updated":"2020-11-03 16:11:24.000000000","message":"most likely not needed","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    ceph-authtool --create-keyring $KEYRING_FILE --gen-key -n mds.controller-0"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Add permissions for mds.controller-0"},{"line_number":25,"context_line":"ceph auth add mds.controller-0 osd \"allow rwx\" mds \"allow\" mon \"allow profile mds\" -i $KEYRING_FILE"},{"line_number":26,"context_line":"key\u003d$(ceph --cluster ceph auth get-key mds.controller-0)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Create k8s secret for cephfs provisioner"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_bcae93e4","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":99},"updated":"2020-11-03 16:11:24.000000000","message":"not needed","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Add permissions for mds.controller-0"},{"line_number":25,"context_line":"ceph auth add mds.controller-0 osd \"allow rwx\" mds \"allow\" mon \"allow profile mds\" -i $KEYRING_FILE"},{"line_number":26,"context_line":"key\u003d$(ceph --cluster ceph auth get-key mds.controller-0)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Create k8s secret for cephfs provisioner"},{"line_number":29,"context_line":"kubectl create secret generic $SECRET_NAME --type\u003d\"kubernetes.io/cephfs\" --from-literal\u003dkey\u003d\"$key\" --namespace\u003d$NAMESPACE"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ range $index, $element :\u003d $classes}}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_1c87c763","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":120},"updated":"2020-11-03 16:11:24.000000000","message":"replace with:\n\nset -ex\n    KEYRING\u003d$(ceph auth get-or-create client.${USER_ID} mon \"allow r\" osd \"allow rwx pool\u003d${POOL_NAME}\" | sed -n \u0027s/^[[:blank:]]*key[[:blank:]]\\+\u003d[[:blank:]]\\(.*\\)/\\1/p\u0027)\n    # Set up pool key in Ceph format\n    CEPH_USER_KEYRING\u003d/etc/ceph/ceph.client.${USER_ID}.keyring\n    echo $KEYRING \u003e $CEPH_USER_KEYRING\n    set +ex\n\n    if [ -n \"${CEPH_USER_SECRET}\" ]; then\n      kubectl get secret -n ${NAMESPACE} ${CEPH_USER_SECRET} 2\u003e/dev/null\n      if [ $? -ne 0 ]; then\n        echo \"Create ${CEPH_USER_SECRET} secret\"\n        kubectl create secret generic -n ${NAMESPACE} ${CEPH_USER_SECRET} --type\u003d\"kubernetes.io/rbd\" --from-literal\u003dkey\u003d$KEYRING\n        if [ $? -ne 0 ]; then\n          echo\"Error creating secret ${CEPH_USER_SECRET} in ${NAMESPACE}, exit\"\n          exit 1\n        fi\n      else\n        echo \"Secret ${CEPH_USER_SECRET} already exists\"\n      fi\n\n      # Support creating namespaces and Ceph user secrets for additional\n      # namespaces other than that which the provisioner is installed. This\n      # allows the provisioner to set up and provide PVs for multiple\n      # applications across many namespaces.\n      if [ -n \"${ADDITIONAL_NAMESPACES}\" ]; then\n        for ns in $(IFS\u003d,; echo ${ADDITIONAL_NAMESPACES}); do\n          kubectl get namespace $ns  2\u003e/dev/null\n          if [ $? -ne 0 ]; then\n            kubectl create namespace $ns\n            if [ $? -ne 0 ]; then\n              echo \"Error creating namespace $ns, exit\"\n              continue\n            fi\n          fi\n\n          kubectl get secret -n $ns ${CEPH_USER_SECRET} 2\u003e/dev/null\n          if [ $? -ne 0 ]; then\n            echo \"Creating secret ${CEPH_USER_SECRET} for namespace $ns\"\n            kubectl create secret generic -n $ns ${CEPH_USER_SECRET} --type\u003d\"kubernetes.io/rbd\" --from-literal\u003dkey\u003d$KEYRING\n            if [ $? -ne 0 ]; then\n              echo \"Error creating secret ${CEPH_USER_SECRET} in $ns, exit\"\n            fi\n          else\n            echo \"Secret ${CEPH_USER_SECRET} for namespace $ns already exists\"\n          fi\n        done\n      fi\n    fi","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Add permissions for mds.controller-0"},{"line_number":25,"context_line":"ceph auth add mds.controller-0 osd \"allow rwx\" mds \"allow\" mon \"allow profile mds\" -i $KEYRING_FILE"},{"line_number":26,"context_line":"key\u003d$(ceph --cluster ceph auth get-key mds.controller-0)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Create k8s secret for cephfs provisioner"},{"line_number":29,"context_line":"kubectl create secret generic $SECRET_NAME --type\u003d\"kubernetes.io/cephfs\" --from-literal\u003dkey\u003d\"$key\" --namespace\u003d$NAMESPACE"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ range $index, $element :\u003d $classes}}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_a2e14eff","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":120},"in_reply_to":"1f621f24_1c87c763","updated":"2020-11-23 12:59:10.000000000","message":"\u003e replace with:\n \u003e \n \u003e set -ex\n \u003e KEYRING\u003d$(ceph auth get-or-create client.${USER_ID} mon \"allow r\"\n \u003e osd \"allow rwx pool\u003d${POOL_NAME}\" | sed -n \u0027s/^[[:blank:]]*key[[:blank:]]\\+\u003d[[:blank:]]\\(.*\\)/\\1/p\u0027)\n \u003e # Set up pool key in Ceph format\n \u003e CEPH_USER_KEYRING\u003d/etc/ceph/ceph.client.${USER_ID}.keyring\n \u003e echo $KEYRING \u003e $CEPH_USER_KEYRING\n \u003e set +ex\n \u003e \n \u003e if [ -n \"${CEPH_USER_SECRET}\" ]; then\n \u003e kubectl get secret -n ${NAMESPACE} ${CEPH_USER_SECRET} 2\u003e/dev/null\n \u003e if [ $? -ne 0 ]; then\n \u003e echo \"Create ${CEPH_USER_SECRET} secret\"\n \u003e kubectl create secret generic -n ${NAMESPACE} ${CEPH_USER_SECRET}\n \u003e --type\u003d\"kubernetes.io/rbd\" --from-literal\u003dkey\u003d$KEYRING\n \u003e if [ $? -ne 0 ]; then\n \u003e echo\"Error creating secret ${CEPH_USER_SECRET} in ${NAMESPACE},\n \u003e exit\"\n \u003e exit 1\n \u003e fi\n \u003e else\n \u003e echo \"Secret ${CEPH_USER_SECRET} already exists\"\n \u003e fi\n \u003e \n \u003e # Support creating namespaces and Ceph user secrets for additional\n \u003e # namespaces other than that which the provisioner is installed.\n \u003e This\n \u003e # allows the provisioner to set up and provide PVs for multiple\n \u003e # applications across many namespaces.\n \u003e if [ -n \"${ADDITIONAL_NAMESPACES}\" ]; then\n \u003e for ns in $(IFS\u003d,; echo ${ADDITIONAL_NAMESPACES}); do\n \u003e kubectl get namespace $ns  2\u003e/dev/null\n \u003e if [ $? -ne 0 ]; then\n \u003e kubectl create namespace $ns\n \u003e if [ $? -ne 0 ]; then\n \u003e echo \"Error creating namespace $ns, exit\"\n \u003e continue\n \u003e fi\n \u003e fi\n \u003e \n \u003e kubectl get secret -n $ns ${CEPH_USER_SECRET} 2\u003e/dev/null\n \u003e if [ $? -ne 0 ]; then\n \u003e echo \"Creating secret ${CEPH_USER_SECRET} for namespace $ns\"\n \u003e kubectl create secret generic -n $ns ${CEPH_USER_SECRET}\n \u003e --type\u003d\"kubernetes.io/rbd\" --from-literal\u003dkey\u003d$KEYRING\n \u003e if [ $? -ne 0 ]; then\n \u003e echo \"Error creating secret ${CEPH_USER_SECRET} in $ns, exit\"\n \u003e fi\n \u003e else\n \u003e echo \"Secret ${CEPH_USER_SECRET} for namespace $ns already exists\"\n \u003e fi\n \u003e done\n \u003e fi\n \u003e fi","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Create k8s secret for cephfs provisioner"},{"line_number":29,"context_line":"kubectl create secret generic $SECRET_NAME --type\u003d\"kubernetes.io/cephfs\" --from-literal\u003dkey\u003d\"$key\" --namespace\u003d$NAMESPACE"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ range $index, $element :\u003d $classes}}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ceph osd pool stats {{ $element.data_pool_name }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_fc912b9b","line":30,"updated":"2020-11-03 16:11:24.000000000","message":"Add a check that credential are valid, this helps when debugging:\n\n    # Check if pool is accessible using provided credentials\n    echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\"\n    timeout --preserve-status 10  rbd -p ${POOL_NAME} --user ${USER_ID} ls -K $CEPH_USER_KEYRING\n    if [ $? -ne 143 ]; then\n      if [ $? -ne 0 ]; then\n        echo \"Error: Ceph pool ${POOL_NAME} is not accessible using credentials for user ${USER_ID}, check Pod logs for details.\"\n        exit 1\n      else\n        echo \"Pool ${POOL_NAME} accessible\"\n      fi\n    else\n      echo \"rbd command timed out and was sent a SIGTERM.  Make sure OSDs have been provisioned.\"\n    fi\n\n    ceph -s","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":41,"context_line":"then"},{"line_number":42,"context_line":"    ceph osd pool create {{ $element.metadata_pool_name }} {{ $element.chunk_size }}"},{"line_number":43,"context_line":"fi"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"ceph fs ls | grep {{ $element.fs_name }}"},{"line_number":46,"context_line":"if [ $? -ne 0 ]"},{"line_number":47,"context_line":"then"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_9ce11700","line":44,"updated":"2020-11-03 16:11:24.000000000","message":"you also need to set size in case replication changes and crush_rule for both pools:\n\nset -ex\nceph osd pool set ${POOL_NAME} size ${POOL_REPLICATION}\nceph osd pool set ${POOL_NAME} crush_rule ${POOL_CRUSH_RULE_NAME}\nset +ex","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/bin/_storage_init.sh.tpl":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_b46c1a09","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8bfd0a7d_6d69be74","in_reply_to":"fffc6b78_b46c1a09","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{{ $classes :\u003d .Values.classes}}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    touch /etc/ceph/ceph.client.admin.keyring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    # Check if ceph is accessible"},{"line_number":10,"context_line":"    echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""}],"source_content_type":"text/x-smarty","patch_set":11,"id":"fffc6b78_e6cb986f","line":7,"updated":"2020-11-20 04:20:06.000000000","message":"Why are lines 7-64 indented?","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        exit 1"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  set -ex"},{"line_number":18,"context_line":"    KEYRING\u003d$(ceph auth get-or-create client.${USER_ID} mon \"allow r\" osd \"allow rwx pool\u003d${DATA_POOL_NAME}\" | sed -n \u0027s/^[[:blank:]]*key[[:blank:]]\\+\u003d[[:blank:]]\\(.*\\)/\\1/p\u0027)"},{"line_number":19,"context_line":"    # Set up pool key in Ceph format"},{"line_number":20,"context_line":"    CEPH_USER_KEYRING\u003d/etc/ceph/ceph.client.${USER_ID}.keyring"}],"source_content_type":"text/x-smarty","patch_set":11,"id":"fffc6b78_668e882f","line":17,"updated":"2020-11-20 04:20:06.000000000","message":"Inconsistent indentation.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    set +ex"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if [ -n \"${CEPH_USER_SECRET}\" ]; then"},{"line_number":25,"context_line":"      kubectl get secret -n ${NAMESPACE} ${CEPH_USER_SECRET} 2\u003e/dev/null"},{"line_number":26,"context_line":"      if [ $? -ne 0 ]; then"},{"line_number":27,"context_line":"        echo \"Create ${CEPH_USER_SECRET} secret\""},{"line_number":28,"context_line":"        kubectl create secret generic -n ${NAMESPACE} ${CEPH_USER_SECRET} --type\u003d\"kubernetes.io/cephfs\" --from-literal\u003dkey\u003d$KEYRING"}],"source_content_type":"text/x-smarty","patch_set":11,"id":"fffc6b78_8689ec27","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":6},"updated":"2020-11-20 04:20:06.000000000","message":"Keep consistent indentation. Use indentation of 4 across the file.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"ceph osd pool stats ${DATA_POOL_NAME}"},{"line_number":68,"context_line":"if [ $? -ne 0 ]"},{"line_number":69,"context_line":"then"},{"line_number":70,"context_line":"    ceph osd pool create ${DATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":71,"context_line":"fi"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":11,"id":"fffc6b78_4677043c","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"updated":"2020-11-20 04:20:06.000000000","message":"Keep consistent as above code. Put on the same like as the if. A couple more instances below","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"ceph osd pool stats ${DATA_POOL_NAME}"},{"line_number":68,"context_line":"if [ $? -ne 0 ]"},{"line_number":69,"context_line":"then"},{"line_number":70,"context_line":"    ceph osd pool create ${DATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":71,"context_line":"fi"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ceph osd pool stats ${METADATA_POOL_NAME}"},{"line_number":74,"context_line":"if [ $? -ne 0 ]"},{"line_number":75,"context_line":"then"},{"line_number":76,"context_line":"    ceph osd pool create ${METADATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":77,"context_line":"fi"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"ceph fs ls | grep ${FS_NAME}"},{"line_number":80,"context_line":"if [ $? -ne 0 ]"},{"line_number":81,"context_line":"then"},{"line_number":82,"context_line":"    ceph fs new ${FS_NAME} ${METADATA_POOL_NAME} ${DATA_POOL_NAME}"},{"line_number":83,"context_line":"fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"ceph -s"}],"source_content_type":"text/x-smarty","patch_set":11,"id":"fffc6b78_e979ab2f","line":83,"range":{"start_line":67,"start_character":0,"end_line":83,"end_character":2},"updated":"2020-11-20 04:20:06.000000000","message":"I think this is missing some things (crush_rule, application enable). In the rbd-provisioner, we do the following. We should be doing the same thing here except we are creating a second pool.\n\n    set -ex\n    # Make sure the pool exists.\n    ceph osd pool stats ${POOL_NAME} || ceph osd pool create ${POOL_NAME} ${POOL_CHUNK_SIZE}\n    # Set pool configuration.\n    ceph osd pool application enable $POOL_NAME rbd\n    ceph osd pool set ${POOL_NAME} size ${POOL_REPLICATION}\n    ceph osd pool set ${POOL_NAME} crush_rule ${POOL_CRUSH_RULE_NAME}\n    set +ex\n\n    if [[ -z \"${USER_ID}\" \u0026\u0026 -z \"${CEPH_USER_SECRET}\" ]]; then\n      echo \"No need to create secrets for pool ${POOL_NAME}\"\n      exit 0\n    fi","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"33517011264eba4fefc122cdec704382476cf62d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"ceph osd pool stats ${DATA_POOL_NAME}"},{"line_number":68,"context_line":"if [ $? -ne 0 ]"},{"line_number":69,"context_line":"then"},{"line_number":70,"context_line":"    ceph osd pool create ${DATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":71,"context_line":"fi"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ceph osd pool stats ${METADATA_POOL_NAME}"},{"line_number":74,"context_line":"if [ $? -ne 0 ]"},{"line_number":75,"context_line":"then"},{"line_number":76,"context_line":"    ceph osd pool create ${METADATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":77,"context_line":"fi"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"ceph fs ls | grep ${FS_NAME}"},{"line_number":80,"context_line":"if [ $? -ne 0 ]"},{"line_number":81,"context_line":"then"},{"line_number":82,"context_line":"    ceph fs new ${FS_NAME} ${METADATA_POOL_NAME} ${DATA_POOL_NAME}"},{"line_number":83,"context_line":"fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"ceph -s"}],"source_content_type":"text/x-smarty","patch_set":11,"id":"34c1eef9_79a30e63","line":83,"range":{"start_line":67,"start_character":0,"end_line":83,"end_character":2},"in_reply_to":"fffc6b78_e979ab2f","updated":"2020-11-24 09:04:18.000000000","message":"Done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"8f9e1c040fc66cc3c2d5a0a7e9caa536a6d23459","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  fi"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"ceph osd pool stats ${DATA_POOL_NAME} || ceph osd pool create ${DATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":75,"context_line":"ceph osd pool set ${DATA_POOL_NAME} size ${POOL_REPLICATION}"},{"line_number":76,"context_line":"ceph osd pool set ${DATA_POOL_NAME} crush_rule ${POOL_CRUSH_RULE_NAME}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"74d28948_bc5df255","line":74,"updated":"2020-12-02 04:32:45.000000000","message":"I realize that the pools are automaticallyassigned to cephfs, but for clarity we should explicitly enable the application for the pool (https://docs.ceph.com/en/latest/rados/operations/pools/#id1) unless there is a problem doing so.\n\n  ceph osd pool application enable ${DATA_POOL_NAME} cephfs\n\nand same for the metadata pool below","commit_id":"939d1281fff20dc48bb8ae54f95372f4d4648646"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"0f3c156eca36f8afe4a64259eebe9252ccd6752d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  fi"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"ceph osd pool stats ${DATA_POOL_NAME} || ceph osd pool create ${DATA_POOL_NAME} ${CHUNK_SIZE}"},{"line_number":75,"context_line":"ceph osd pool set ${DATA_POOL_NAME} size ${POOL_REPLICATION}"},{"line_number":76,"context_line":"ceph osd pool set ${DATA_POOL_NAME} crush_rule ${POOL_CRUSH_RULE_NAME}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"7717137e_2435f67b","line":74,"in_reply_to":"74d28948_bc5df255","updated":"2020-12-02 22:42:53.000000000","message":"Done","commit_id":"939d1281fff20dc48bb8ae54f95372f4d4648646"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/conf/_ceph-conf.tpl":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[global]"},{"line_number":2,"context_line":"\t# Unique ID for the cluster."},{"line_number":3,"context_line":"\tfsid \u003d 4980cb67-3ff3-4847-85e3-9ffb10127d46"},{"line_number":4,"context_line":"\t# Public network where the monitor is connected to, i.e, 128.224.0.0/16"},{"line_number":5,"context_line":"\t#public network \u003d 127.0.0.1/24"},{"line_number":6,"context_line":"\t# For version 0.55 and beyond, you must explicitly enable"},{"line_number":7,"context_line":"\t# or disable authentication with \"auth\" entries in [global]."},{"line_number":8,"context_line":"\tauth_cluster_required \u003d none"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"1f621f24_bccfb37d","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":31},"updated":"2020-11-03 16:11:24.000000000","message":"not needed, especially fsid","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_f47502ce","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8e321a1b_440191aa","in_reply_to":"fffc6b78_f47502ce","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/config-provisioner.yaml":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  name: ceph-pools-create-bin"},{"line_number":18,"context_line":"  namespace: {{ $defaults.cephFSNamespace }}"},{"line_number":19,"context_line":"data:"},{"line_number":20,"context_line":"  cephfs-pools-create.sh: |"},{"line_number":21,"context_line":"{{ tuple \"bin/_ceph-pools-create.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_1c8d0731","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":24},"updated":"2020-11-03 16:11:24.000000000","message":"update to storage-init.sh","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  namespace: {{ $defaults.cephFSNamespace }}"},{"line_number":19,"context_line":"data:"},{"line_number":20,"context_line":"  cephfs-pools-create.sh: |"},{"line_number":21,"context_line":"{{ tuple \"bin/_ceph-pools-create.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"---"},{"line_number":24,"context_line":"apiVersion: batch/v1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_3c060388","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":32},"updated":"2020-11-03 16:11:24.000000000","message":"update","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  cephfs-pools-create.sh: |"},{"line_number":21,"context_line":"{{ tuple \"bin/_ceph-pools-create.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"---"},{"line_number":24,"context_line":"apiVersion: batch/v1"},{"line_number":25,"context_line":"kind: Job"},{"line_number":26,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_5ceadfab","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":3},"updated":"2020-11-03 16:11:24.000000000","message":"guard this with an if on: job_storage_init to keep the same approach as rbd-provisioner or remove from values.yaml.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":24,"context_line":"apiVersion: batch/v1"},{"line_number":25,"context_line":"kind: Job"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: ceph-pools-create"},{"line_number":28,"context_line":"  namespace: {{ $defaults.cephFSNamespace }}"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_5c03ff73","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":25},"updated":"2020-11-03 16:11:24.000000000","message":"update to cephfs-storage-init","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    spec:"},{"line_number":32,"context_line":"      serviceAccountName: {{ $defaults.rbacConfigName }}"},{"line_number":33,"context_line":"      volumes:"},{"line_number":34,"context_line":"      - name: ceph-pools-create"},{"line_number":35,"context_line":"        configMap:"},{"line_number":36,"context_line":"          name: ceph-pools-create-bin"},{"line_number":37,"context_line":"          defaultMode: 0555"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_fcf3eb9c","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":31},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs-storage-init","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      volumes:"},{"line_number":34,"context_line":"      - name: ceph-pools-create"},{"line_number":35,"context_line":"        configMap:"},{"line_number":36,"context_line":"          name: ceph-pools-create-bin"},{"line_number":37,"context_line":"          defaultMode: 0555"},{"line_number":38,"context_line":"      - name: ceph-config"},{"line_number":39,"context_line":"        configMap:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_dceeefb2","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":33},"updated":"2020-11-03 16:11:24.000000000","message":"update","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          name: ceph-config-file"},{"line_number":41,"context_line":"          defaultMode: 0555"},{"line_number":42,"context_line":"      containers:"},{"line_number":43,"context_line":"      - name: ceph-pools-create"},{"line_number":44,"context_line":"        image: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":45,"context_line":"        command: [\"/bin/bash\", \"/tmp/cephfs-pools-create.sh\"]"},{"line_number":46,"context_line":"        env:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_1c2ea7f9","line":43,"range":{"start_line":43,"start_character":14,"end_line":43,"end_character":31},"updated":"2020-11-03 16:11:24.000000000","message":"update to cephfs-storage-init","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        env:"},{"line_number":47,"context_line":"            - name: NAMESPACE"},{"line_number":48,"context_line":"              value: {{ $defaults.cephFSNamespace }}"},{"line_number":49,"context_line":"            - name: SECRET_NAME "},{"line_number":50,"context_line":"              value: ceph-secret-admin"},{"line_number":51,"context_line":"        volumeMounts:"},{"line_number":52,"context_line":"          - name: ceph-pools-create"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_bc94d345","line":49,"range":{"start_line":49,"start_character":31,"end_line":49,"end_character":32},"updated":"2020-11-03 16:11:24.000000000","message":"nit: remove space","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            - name: SECRET_NAME "},{"line_number":50,"context_line":"              value: ceph-secret-admin"},{"line_number":51,"context_line":"        volumeMounts:"},{"line_number":52,"context_line":"          - name: ceph-pools-create"},{"line_number":53,"context_line":"            mountPath: /tmp/cephfs-pools-create.sh"},{"line_number":54,"context_line":"            subPath: cephfs-pools-create.sh"},{"line_number":55,"context_line":"            readOnly: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_5c381f3c","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":34},"updated":"2020-11-03 16:11:24.000000000","message":"update","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":50,"context_line":"              value: ceph-secret-admin"},{"line_number":51,"context_line":"        volumeMounts:"},{"line_number":52,"context_line":"          - name: ceph-pools-create"},{"line_number":53,"context_line":"            mountPath: /tmp/cephfs-pools-create.sh"},{"line_number":54,"context_line":"            subPath: cephfs-pools-create.sh"},{"line_number":55,"context_line":"            readOnly: true"},{"line_number":56,"context_line":"          - name: ceph-config"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_bc3e9326","line":53,"range":{"start_line":53,"start_character":28,"end_line":53,"end_character":47},"updated":"2020-11-03 16:11:24.000000000","message":"update","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        volumeMounts:"},{"line_number":52,"context_line":"          - name: ceph-pools-create"},{"line_number":53,"context_line":"            mountPath: /tmp/cephfs-pools-create.sh"},{"line_number":54,"context_line":"            subPath: cephfs-pools-create.sh"},{"line_number":55,"context_line":"            readOnly: true"},{"line_number":56,"context_line":"          - name: ceph-config"},{"line_number":57,"context_line":"            mountPath: /etc/ceph/ceph.conf"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_9c391741","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":40},"updated":"2020-11-03 16:11:24.000000000","message":"update","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_d4727ee3","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7d1cc334_77c9ba43","in_reply_to":"fffc6b78_d4727ee3","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        - name: storage-init-{{- $classConfig.name }}"},{"line_number":45,"context_line":"          image: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":46,"context_line":"          command: [\"/bin/bash\", \"/tmp/storage-init.sh\"]"},{"line_number":47,"context_line":"          env:"},{"line_number":48,"context_line":"            - name: NAMESPACE"},{"line_number":49,"context_line":"              value: {{ $defaults.cephFSNamespace }}"},{"line_number":50,"context_line":"            - name: ADDITIONAL_NAMESPACES"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_bae9a381","line":47,"range":{"start_line":47,"start_character":10,"end_line":47,"end_character":13},"updated":"2020-11-20 04:20:06.000000000","message":"We should also be providing and using a replication factor and crush rule name (see rbd-provisioner) so that we can support ceph tiering where each tier has a different rule name","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        - name: storage-init-{{- $classConfig.name }}"},{"line_number":45,"context_line":"          image: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":46,"context_line":"          command: [\"/bin/bash\", \"/tmp/storage-init.sh\"]"},{"line_number":47,"context_line":"          env:"},{"line_number":48,"context_line":"            - name: NAMESPACE"},{"line_number":49,"context_line":"              value: {{ $defaults.cephFSNamespace }}"},{"line_number":50,"context_line":"            - name: ADDITIONAL_NAMESPACES"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2063da1c_ebd68cf2","line":47,"range":{"start_line":47,"start_character":10,"end_line":47,"end_character":13},"in_reply_to":"fffc6b78_bae9a381","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/provisioner.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_147d26b1","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    metadata:"},{"line_number":18,"context_line":"      labels:"},{"line_number":19,"context_line":"        app: {{ $defaults.provisionerConfigName }}"},{"line_number":20,"context_line":"    spec:"},{"line_number":21,"context_line":"      containers:"},{"line_number":22,"context_line":"      - name: {{ $defaults.provisionerConfigName }}"},{"line_number":23,"context_line":"        image: \"quay.io/external_storage/{{ $defaults.provisionerConfigName }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_7a057b7a","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":8},"updated":"2020-11-20 04:20:06.000000000","message":"This is missing podAntiAffinity, nodeSelector, tolerations, and resource settings","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    metadata:"},{"line_number":18,"context_line":"      labels:"},{"line_number":19,"context_line":"        app: {{ $defaults.provisionerConfigName }}"},{"line_number":20,"context_line":"    spec:"},{"line_number":21,"context_line":"      containers:"},{"line_number":22,"context_line":"      - name: {{ $defaults.provisionerConfigName }}"},{"line_number":23,"context_line":"        image: \"quay.io/external_storage/{{ $defaults.provisionerConfigName }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f0738a4e_014190f9","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":8},"in_reply_to":"fffc6b78_7a057b7a","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    spec:"},{"line_number":21,"context_line":"      containers:"},{"line_number":22,"context_line":"      - name: {{ $defaults.provisionerConfigName }}"},{"line_number":23,"context_line":"        image: \"quay.io/external_storage/{{ $defaults.provisionerConfigName }}:latest\""},{"line_number":24,"context_line":"        env:"},{"line_number":25,"context_line":"        - name: PROVISIONER_NAME"},{"line_number":26,"context_line":"          value: {{ $defaults.provisionerName }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_baffe365","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":86},"updated":"2020-11-20 04:20:06.000000000","message":"This should be a fully configurable value so it can be overridden in overrides","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    spec:"},{"line_number":21,"context_line":"      containers:"},{"line_number":22,"context_line":"      - name: {{ $defaults.provisionerConfigName }}"},{"line_number":23,"context_line":"        image: \"quay.io/external_storage/{{ $defaults.provisionerConfigName }}:latest\""},{"line_number":24,"context_line":"        env:"},{"line_number":25,"context_line":"        - name: PROVISIONER_NAME"},{"line_number":26,"context_line":"          value: {{ $defaults.provisionerName }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a09a69b_a7d099ef","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":86},"in_reply_to":"fffc6b78_baffe365","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/rbac-secrets.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_744bd286","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1d12526a_6b438041","in_reply_to":"fffc6b78_744bd286","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  name: {{ $defaults.provisionerConfigName }}"},{"line_number":127,"context_line":"---"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"apiVersion: v1"},{"line_number":130,"context_line":"kind: ServiceAccount"},{"line_number":131,"context_line":"metadata:"},{"line_number":132,"context_line":"  name: {{ $defaults.provisionerConfigName }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_dad627c4","line":129,"updated":"2020-11-20 04:20:06.000000000","message":"I believe this is missing imagePullSecrets to be able to pull from registry.local. \n\nMake sure that when the application is applying that it is pulling the image from registry.local and not quay.io.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  name: {{ $defaults.provisionerConfigName }}"},{"line_number":127,"context_line":"---"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"apiVersion: v1"},{"line_number":130,"context_line":"kind: ServiceAccount"},{"line_number":131,"context_line":"metadata:"},{"line_number":132,"context_line":"  name: {{ $defaults.provisionerConfigName }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d5690ec9_1aebc32b","line":129,"in_reply_to":"fffc6b78_dad627c4","updated":"2020-11-23 12:59:10.000000000","message":"implemented. further testing is needed.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/templates/storageclass.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fffc6b78_54504e33","updated":"2020-11-20 04:20:06.000000000","message":"Add a header with Copyright/SPDX-License-Identifier","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"kind: StorageClass"},{"line_number":6,"context_line":"apiVersion: storage.k8s.io/v1"},{"line_number":7,"context_line":"metadata:"},{"line_number":8,"context_line":"  name: {{ $classConfig.name }}"},{"line_number":9,"context_line":"provisioner: {{ $defaults.provisionerName }}"},{"line_number":10,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_dae2a701","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2020-11-20 04:20:06.000000000","message":"We should include a configurable annotation here to set this as a default storage class","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"8f9e1c040fc66cc3c2d5a0a7e9caa536a6d23459","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"kind: StorageClass"},{"line_number":6,"context_line":"apiVersion: storage.k8s.io/v1"},{"line_number":7,"context_line":"metadata:"},{"line_number":8,"context_line":"  name: {{ $classConfig.name }}"},{"line_number":9,"context_line":"provisioner: {{ $defaults.provisionerName }}"},{"line_number":10,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d5080d83_0c434d95","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"in_reply_to":"1a069372_49319c0e","updated":"2020-12-02 04:32:45.000000000","message":"Follow the model done for the rbd provisioner. We can enable/disable by coordinating overrides for both the rbd-provisioner and cephfs-provisioner. Basically, based on the overrides we\u0027ll pick one or the other with the default still being the rbd-provisioner.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"kind: StorageClass"},{"line_number":6,"context_line":"apiVersion: storage.k8s.io/v1"},{"line_number":7,"context_line":"metadata:"},{"line_number":8,"context_line":"  name: {{ $classConfig.name }}"},{"line_number":9,"context_line":"provisioner: {{ $defaults.provisionerName }}"},{"line_number":10,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a069372_49319c0e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"in_reply_to":"fffc6b78_dae2a701","updated":"2020-11-23 12:59:10.000000000","message":"we should discuss more on this issue","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":6,"context_line":"apiVersion: storage.k8s.io/v1"},{"line_number":7,"context_line":"metadata:"},{"line_number":8,"context_line":"  name: {{ $classConfig.name }}"},{"line_number":9,"context_line":"provisioner: {{ $defaults.provisionerName }}"},{"line_number":10,"context_line":"parameters:"},{"line_number":11,"context_line":"    monitors: \"{{ $monitors :\u003d or $classConfig.monitors $defaults.monitors }}{{ join \",\" $monitors}}\""},{"line_number":12,"context_line":"    adminId: {{ or $classConfig.adminId $defaults.adminId }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_1aed4fef","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":44},"updated":"2020-11-20 04:20:06.000000000","message":"Shouldn\u0027t this be? {{ .Values.global.provisioner_name }}?\n\nDoes this chart install with the defaults using both the helm (v3) and helmv2-cli commands?","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"apiVersion: storage.k8s.io/v1"},{"line_number":7,"context_line":"metadata:"},{"line_number":8,"context_line":"  name: {{ $classConfig.name }}"},{"line_number":9,"context_line":"provisioner: {{ $defaults.provisionerName }}"},{"line_number":10,"context_line":"parameters:"},{"line_number":11,"context_line":"    monitors: \"{{ $monitors :\u003d or $classConfig.monitors $defaults.monitors }}{{ join \",\" $monitors}}\""},{"line_number":12,"context_line":"    adminId: {{ or $classConfig.adminId $defaults.adminId }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d964d031_abacc215","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":44},"in_reply_to":"fffc6b78_1aed4fef","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    adminSecretName: {{ or $classConfig.adminSecretName $defaults.adminSecretName }}"},{"line_number":14,"context_line":"    adminSecretNamespace:  {{ or $classConfig.adminSecretNamespace $defaults.adminSecretNamespace }}"},{"line_number":15,"context_line":"    claimRoot: {{ $classConfig.claim_root }}"},{"line_number":16,"context_line":"---"},{"line_number":17,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_bab523f1","line":16,"updated":"2020-11-20 04:20:06.000000000","message":"Add the following:\n    \n  mountOptions:\n   - discard","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"8f9e1c040fc66cc3c2d5a0a7e9caa536a6d23459","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    adminSecretName: {{ or $classConfig.adminSecretName $defaults.adminSecretName }}"},{"line_number":14,"context_line":"    adminSecretNamespace:  {{ or $classConfig.adminSecretNamespace $defaults.adminSecretNamespace }}"},{"line_number":15,"context_line":"    claimRoot: {{ $classConfig.claim_root }}"},{"line_number":16,"context_line":"---"},{"line_number":17,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a3180658_b225fefa","line":16,"in_reply_to":"3e15ddb6_d7bacb6c","updated":"2020-12-02 04:32:45.000000000","message":"I\u0027m not seeing the change in the latest patch set.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    adminSecretName: {{ or $classConfig.adminSecretName $defaults.adminSecretName }}"},{"line_number":14,"context_line":"    adminSecretNamespace:  {{ or $classConfig.adminSecretNamespace $defaults.adminSecretNamespace }}"},{"line_number":15,"context_line":"    claimRoot: {{ $classConfig.claim_root }}"},{"line_number":16,"context_line":"---"},{"line_number":17,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3e15ddb6_d7bacb6c","line":16,"in_reply_to":"fffc6b78_bab523f1","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}],"stx-platform-helm/stx-platform-helm/helm-charts/cephfs-provisioner/values.yaml":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_96ea9872","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"updated":"2020-11-03 16:11:24.000000000","message":"2020","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  #"},{"line_number":16,"context_line":"  # Defines the name of the provisioner associated with a set of storage classes"},{"line_number":17,"context_line":"  #"},{"line_number":18,"context_line":"  provisioner_name: \"ceph.com/rbd\""},{"line_number":19,"context_line":"  #"},{"line_number":20,"context_line":"  # Execute initialization job to verify external Ceph cluster access"},{"line_number":21,"context_line":"  # and setup additional dependencies assumed by dependent helm charts"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_b6feb435","line":18,"range":{"start_line":18,"start_character":30,"end_line":18,"end_character":33},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs ?","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  #"},{"line_number":41,"context_line":"  # Enable this storage class as the system default storage class"},{"line_number":42,"context_line":"  #"},{"line_number":43,"context_line":"  defaultStorageClass: fast-rbd"},{"line_number":44,"context_line":"  #"},{"line_number":45,"context_line":"  # Choose if rbd-provisioner pod should be deployed as deplyment or DaemonSet"},{"line_number":46,"context_line":"  # Values: none, Deployment, DaemonSet"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_76a25c4d","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":31},"updated":"2020-11-03 16:11:24.000000000","message":"fast-cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  #"},{"line_number":43,"context_line":"  defaultStorageClass: fast-rbd"},{"line_number":44,"context_line":"  #"},{"line_number":45,"context_line":"  # Choose if rbd-provisioner pod should be deployed as deplyment or DaemonSet"},{"line_number":46,"context_line":"  # Values: none, Deployment, DaemonSet"},{"line_number":47,"context_line":"  #"},{"line_number":48,"context_line":"  deployAs: Deployment"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_b68354a9","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":17},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  defaultStorageClass: fast-rbd"},{"line_number":44,"context_line":"  #"},{"line_number":45,"context_line":"  # Choose if rbd-provisioner pod should be deployed as deplyment or DaemonSet"},{"line_number":46,"context_line":"  # Values: none, Deployment, DaemonSet"},{"line_number":47,"context_line":"  #"},{"line_number":48,"context_line":"  deployAs: Deployment"},{"line_number":49,"context_line":"  #"},{"line_number":50,"context_line":"  # If configured, tolerations will add a toleration field to the Pod."},{"line_number":51,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_7c999b6c","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":22},"updated":"2020-11-03 16:11:24.000000000","message":"unused, remove it.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  #"},{"line_number":89,"context_line":"  # Cluster Role name"},{"line_number":90,"context_line":"  #"},{"line_number":91,"context_line":"  clusterRole: rbd-provisioner"},{"line_number":92,"context_line":"  #"},{"line_number":93,"context_line":"  # Cluster Role Binding name"},{"line_number":94,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_36c104e6","line":91,"range":{"start_line":91,"start_character":15,"end_line":91,"end_character":18},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  #"},{"line_number":93,"context_line":"  # Cluster Role Binding name"},{"line_number":94,"context_line":"  #"},{"line_number":95,"context_line":"  clusterRoleBinding: rbd-provisioner"},{"line_number":96,"context_line":"  #"},{"line_number":97,"context_line":"  # Role name"},{"line_number":98,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_96b8d876","line":95,"range":{"start_line":95,"start_character":22,"end_line":95,"end_character":25},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  #"},{"line_number":97,"context_line":"  # Role name"},{"line_number":98,"context_line":"  #"},{"line_number":99,"context_line":"  role: rbd-provisioner"},{"line_number":100,"context_line":"  #"},{"line_number":101,"context_line":"  # Role Binding name"},{"line_number":102,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_76bb7c71","line":99,"range":{"start_line":99,"start_character":8,"end_line":99,"end_character":11},"updated":"2020-11-03 16:11:24.000000000","message":"vephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  #"},{"line_number":101,"context_line":"  # Role Binding name"},{"line_number":102,"context_line":"  #"},{"line_number":103,"context_line":"  roleBinding: rbd-provisioner"},{"line_number":104,"context_line":"  #"},{"line_number":105,"context_line":"  # Defines a name of the service account which Provisioner will use to communicate with API server."},{"line_number":106,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_b6acf435","line":103,"range":{"start_line":103,"start_character":15,"end_line":103,"end_character":18},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  #"},{"line_number":105,"context_line":"  # Defines a name of the service account which Provisioner will use to communicate with API server."},{"line_number":106,"context_line":"  #"},{"line_number":107,"context_line":"  serviceAccount: rbd-provisioner"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# Configure storage classes."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_16acc832","line":107,"range":{"start_line":107,"start_character":18,"end_line":107,"end_character":21},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  adminId: admin"},{"line_number":122,"context_line":"  # K8 secret name for the admin context"},{"line_number":123,"context_line":"  adminSecretName: ceph-secret"},{"line_number":124,"context_line":"  # Ceph RBD image format version"},{"line_number":125,"context_line":"  imageFormat: 2"},{"line_number":126,"context_line":"  # Ceph RBD image features."},{"line_number":127,"context_line":"  imageFeatures: layering"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# Configure storage classes."},{"line_number":130,"context_line":"# This section should be tailored to your setup. It allows you to define multiple storage"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_966d7806","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":25},"updated":"2020-11-03 16:11:24.000000000","message":"these two are for rbd only","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":131,"context_line":"# classes for the same cluster (e.g. if you have tiers of drives with different speeds)."},{"line_number":132,"context_line":"# If you have multiple Ceph clusters take attributes from classdefaults and add them here."},{"line_number":133,"context_line":"classes:"},{"line_number":134,"context_line":"- name: fast-rbd # Name of storage class."},{"line_number":135,"context_line":"  # Ceph pool name"},{"line_number":136,"context_line":"  pool_name: kube"},{"line_number":137,"context_line":"  # Ceph user name to access this pool"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_76709cdd","line":134,"range":{"start_line":134,"start_character":13,"end_line":134,"end_character":16},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  - default"},{"line_number":152,"context_line":"  - kube-public"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# Configuration data for the ephemeral pool(s)"},{"line_number":155,"context_line":"ephemeral_pools:"},{"line_number":156,"context_line":"- chunk_size: 8"},{"line_number":157,"context_line":"  crush_rule_name: storage_tier_ruleset"},{"line_number":158,"context_line":"  pool_name: ephemeral"},{"line_number":159,"context_line":"  replication: 1"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"monitors:"},{"line_number":162,"context_line":"- name: mon.controller"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_564c809d","line":159,"range":{"start_line":154,"start_character":0,"end_line":159,"end_character":16},"updated":"2020-11-03 16:11:24.000000000","message":"this seems like a nova settings. Please remove.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  pool_name: ephemeral"},{"line_number":159,"context_line":"  replication: 1"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"monitors:"},{"line_number":162,"context_line":"- name: mon.controller"},{"line_number":163,"context_line":"  mon_addr: 192.168.204.1:6789"},{"line_number":164,"context_line":"  host: controller"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Defines:"},{"line_number":167,"context_line":"# - Provisioner\u0027s image name including container registry."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_b65a344d","line":164,"range":{"start_line":161,"start_character":0,"end_line":164,"end_character":18},"updated":"2020-11-03 16:11:24.000000000","message":"aren\u0027t these configured in storageclass?","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":169,"context_line":"#"},{"line_number":170,"context_line":"images:"},{"line_number":171,"context_line":"  tags:"},{"line_number":172,"context_line":"    rbd_provisioner: quay.io/external_storage/rbd-provisioner:v2.1.1-k8s1.11"},{"line_number":173,"context_line":"    rbd_provisioner_storage_init: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":174,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":175,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_f654ac23","line":172,"range":{"start_line":172,"start_character":4,"end_line":172,"end_character":7},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs?","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":169,"context_line":"#"},{"line_number":170,"context_line":"images:"},{"line_number":171,"context_line":"  tags:"},{"line_number":172,"context_line":"    rbd_provisioner: quay.io/external_storage/rbd-provisioner:v2.1.1-k8s1.11"},{"line_number":173,"context_line":"    rbd_provisioner_storage_init: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":174,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":175,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_763edcda","line":172,"range":{"start_line":172,"start_character":46,"end_line":172,"end_character":76},"updated":"2020-11-03 16:11:24.000000000","message":"even if it is overriten, add the image for cephfs-provisioner please.","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"ec10a69aa5fc8c194f48923b0aeb53615e5ce808","unresolved":false,"context_lines":[{"line_number":170,"context_line":"images:"},{"line_number":171,"context_line":"  tags:"},{"line_number":172,"context_line":"    rbd_provisioner: quay.io/external_storage/rbd-provisioner:v2.1.1-k8s1.11"},{"line_number":173,"context_line":"    rbd_provisioner_storage_init: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":174,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":175,"context_line":"  local_registry:"},{"line_number":176,"context_line":"    active: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f621f24_363464fb","line":173,"range":{"start_line":173,"start_character":4,"end_line":173,"end_character":7},"updated":"2020-11-03 16:11:24.000000000","message":"cephfs?","commit_id":"89d2a3255276bea93fafa1a0a5173b7b011b6a63"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  #"},{"line_number":12,"context_line":"  # Defines the application name of the provisioner."},{"line_number":13,"context_line":"  #"},{"line_number":14,"context_line":"  name: \"cephfs-provisioner\""},{"line_number":15,"context_line":"  #"},{"line_number":16,"context_line":"  # Defines the name of the provisioner associated with a set of storage classes"},{"line_number":17,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_5a935750","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":6},"updated":"2020-11-20 04:20:06.000000000","message":"is this used?","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  #"},{"line_number":12,"context_line":"  # Defines the application name of the provisioner."},{"line_number":13,"context_line":"  #"},{"line_number":14,"context_line":"  name: \"cephfs-provisioner\""},{"line_number":15,"context_line":"  #"},{"line_number":16,"context_line":"  # Defines the name of the provisioner associated with a set of storage classes"},{"line_number":17,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"75badb03_2be25180","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":6},"in_reply_to":"fffc6b78_5a935750","updated":"2020-11-23 12:59:10.000000000","message":"I have used this for testing purposes, I will try to remove it","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  # (i.e. configmap and secrets)."},{"line_number":23,"context_line":"  # Skipping is not recommended."},{"line_number":24,"context_line":"  #"},{"line_number":25,"context_line":"  job_storage_init: true"},{"line_number":26,"context_line":"  #"},{"line_number":27,"context_line":"  # Defines whether to reuse an already defined RBAC policy."},{"line_number":28,"context_line":"  # Make sure that the serviceAccount defined in the RBAC section matches the one"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_faa16b97","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":18},"updated":"2020-11-20 04:20:06.000000000","message":"Is this used?","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  # (i.e. configmap and secrets)."},{"line_number":23,"context_line":"  # Skipping is not recommended."},{"line_number":24,"context_line":"  #"},{"line_number":25,"context_line":"  job_storage_init: true"},{"line_number":26,"context_line":"  #"},{"line_number":27,"context_line":"  # Defines whether to reuse an already defined RBAC policy."},{"line_number":28,"context_line":"  # Make sure that the serviceAccount defined in the RBAC section matches the one"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6a4420b2_8b278acc","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":18},"in_reply_to":"fffc6b78_faa16b97","updated":"2020-11-23 12:59:10.000000000","message":"removed","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  # Make sure that the serviceAccount defined in the RBAC section matches the one"},{"line_number":29,"context_line":"  # in the policy you reuse."},{"line_number":30,"context_line":"  #"},{"line_number":31,"context_line":"  reuseRbac: false"},{"line_number":32,"context_line":"  #"},{"line_number":33,"context_line":"  # Defines whether to generate service account and role bindings."},{"line_number":34,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_7ab73bda","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":11},"updated":"2020-11-20 04:20:06.000000000","message":"I don\u0027t see this used either? Anything in this file that is not needed should be removed or is indicative of some missing functionality","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  # Make sure that the serviceAccount defined in the RBAC section matches the one"},{"line_number":29,"context_line":"  # in the policy you reuse."},{"line_number":30,"context_line":"  #"},{"line_number":31,"context_line":"  reuseRbac: false"},{"line_number":32,"context_line":"  #"},{"line_number":33,"context_line":"  # Defines whether to generate service account and role bindings."},{"line_number":34,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c567148d_ce451d91","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":11},"in_reply_to":"fffc6b78_7ab73bda","updated":"2020-11-23 12:59:10.000000000","message":"removed","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"images:"},{"line_number":150,"context_line":"  tags:"},{"line_number":151,"context_line":"    cephfs_provisioner: quay.io/external_storage/cephfs-provisioner:latest"},{"line_number":152,"context_line":"    cephfs_provisioner_storage_init: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":153,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":154,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_c30da691","line":151,"range":{"start_line":151,"start_character":68,"end_line":151,"end_character":74},"updated":"2020-11-20 04:20:06.000000000","message":"Should be v2.1.0-k8s1.11","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"images:"},{"line_number":150,"context_line":"  tags:"},{"line_number":151,"context_line":"    cephfs_provisioner: quay.io/external_storage/cephfs-provisioner:latest"},{"line_number":152,"context_line":"    cephfs_provisioner_storage_init: docker.io/starlingx/ceph-config-helper:v1.15.0"},{"line_number":153,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":154,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a35ca89b_53d52319","line":151,"range":{"start_line":151,"start_character":68,"end_line":151,"end_character":74},"in_reply_to":"fffc6b78_c30da691","updated":"2020-11-23 12:59:10.000000000","message":"done","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0ddbd209496483b4749da0f1a65101bffdf4d267","unresolved":false,"context_lines":[{"line_number":157,"context_line":"      - dep_check"},{"line_number":158,"context_line":"      - image_repo_sync"},{"line_number":159,"context_line":"manifests:"},{"line_number":160,"context_line":"  job_ceph_pools_audit: true"},{"line_number":161,"context_line":"  configmap_bin: true"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fffc6b78_7aef3b87","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":28},"updated":"2020-11-20 04:20:06.000000000","message":"Should not be relevant here.","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a996d9ccea15bd7927a97ef5698b5c3a8f2eb78b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"      - dep_check"},{"line_number":158,"context_line":"      - image_repo_sync"},{"line_number":159,"context_line":"manifests:"},{"line_number":160,"context_line":"  job_ceph_pools_audit: true"},{"line_number":161,"context_line":"  configmap_bin: true"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"94ea226c_cdfa2acb","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":28},"in_reply_to":"fffc6b78_7aef3b87","updated":"2020-11-23 12:59:10.000000000","message":"removed","commit_id":"9061efc234a8de72c321268c148ef0f2803ea29c"}]}