)]}'
{".zuul.yaml":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - openstack-tox-linters"},{"line_number":6,"context_line":"    gate:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9f560f44_d3a895da","line":5,"updated":"2020-08-18 13:30:12.000000000","message":"It would be nice to include the appropriate pep8/flake8/pylint/py27/py36 jobs that are defined in the tox.ini of the python component  for the check and gate","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - openstack-tox-linters"},{"line_number":6,"context_line":"    gate:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9f560f44_0728fd83","line":5,"in_reply_to":"9f560f44_d3a895da","updated":"2020-08-19 11:49:41.000000000","message":"already add","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"992ea605951fd3835763865a68273a1eea54ff69","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      - starlingx/update"},{"line_number":33,"context_line":"      - starlingx/utilities"},{"line_number":34,"context_line":"    files:"},{"line_number":35,"context_line":"      - python-k8sapp-rook/* "},{"line_number":36,"context_line":"    vars:"},{"line_number":37,"context_line":"      tox_envlist: py27"},{"line_number":38,"context_line":"      tox_extra_args: -c python-k8sapp-rook/k8sapp_rook/tox.ini"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"9f560f44_10382c3b","line":35,"updated":"2020-08-19 15:14:07.000000000","message":"nit: trailing whitespace","commit_id":"d0b796e8c8a8f99395f1af7b148fab2f21cdd302"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4455ce0fbc59b4b3408fea72dc884b394d0453ff","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - starlingx/update"},{"line_number":33,"context_line":"      - starlingx/utilities"},{"line_number":34,"context_line":"    files:"},{"line_number":35,"context_line":"      - python-k8sapp-rook/* "},{"line_number":36,"context_line":"    vars:"},{"line_number":37,"context_line":"      tox_envlist: py27"},{"line_number":38,"context_line":"      tox_extra_args: -c python-k8sapp-rook/k8sapp_rook/tox.ini"}],"source_content_type":"text/x-yaml","patch_set":87,"id":"60fb7231_a4ce6ed3","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":29},"updated":"2020-12-27 20:00:51.000000000","message":"nit: trailing whitespace","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"776cb4c29850f61b60ba447c91f777e9fb3c65ca","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - starlingx/update"},{"line_number":33,"context_line":"      - starlingx/utilities"},{"line_number":34,"context_line":"    files:"},{"line_number":35,"context_line":"      - python-k8sapp-rook/* "},{"line_number":36,"context_line":"    vars:"},{"line_number":37,"context_line":"      tox_envlist: py27"},{"line_number":38,"context_line":"      tox_extra_args: -c python-k8sapp-rook/k8sapp_rook/tox.ini"}],"source_content_type":"text/x-yaml","patch_set":87,"id":"1c201939_552762a6","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":29},"in_reply_to":"60fb7231_a4ce6ed3","updated":"2021-01-08 01:29:08.000000000","message":"fixed","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"}],"HACKING.rst":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"StarlingX Platform-Armada-App Style Commandments"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- Step 1: Read the OpenStack style commandments"}],"source_content_type":"text/x-rst","patch_set":26,"id":"9f560f44_90a7330c","line":1,"range":{"start_line":1,"start_character":10,"end_line":1,"end_character":29},"updated":"2020-08-18 13:30:12.000000000","message":"I think you want this to be rook-ceph  since this file is intended for per-repo style, in this case the rook-ceph repo.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":1,"context_line":"StarlingX Platform-Armada-App Style Commandments"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- Step 1: Read the OpenStack style commandments"}],"source_content_type":"text/x-rst","patch_set":26,"id":"9f560f44_272541ac","line":1,"range":{"start_line":1,"start_character":10,"end_line":1,"end_character":29},"in_reply_to":"9f560f44_90a7330c","updated":"2020-08-19 11:49:41.000000000","message":"fixed","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  https://docs.openstack.org/hacking/latest/"},{"line_number":6,"context_line":"- Step 2: Read on"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Platform-Armada-App Specific Commandments"},{"line_number":9,"context_line":"-----------------------------------------"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"None so far"}],"source_content_type":"text/x-rst","patch_set":26,"id":"9f560f44_d0a88bda","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":19},"updated":"2020-08-18 13:30:12.000000000","message":"rook-ceph","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  https://docs.openstack.org/hacking/latest/"},{"line_number":6,"context_line":"- Step 2: Read on"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Platform-Armada-App Specific Commandments"},{"line_number":9,"context_line":"-----------------------------------------"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"None so far"}],"source_content_type":"text/x-rst","patch_set":26,"id":"9f560f44_873b6dcf","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":19},"in_reply_to":"9f560f44_d0a88bda","updated":"2020-08-19 11:49:41.000000000","message":"fixed","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"}],"python-k8sapp-rook/centos/build_srpm.data":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# TIS_BASE_SRCREV changes. This version should align with the version of the"},{"line_number":7,"context_line":"# helm charts in stx-platform-helm"},{"line_number":8,"context_line":"TIS_BASE_SRCREV\u003d10c623509a68acad945d4e0c06a86b3e8486ad5b"},{"line_number":9,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+7"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_d0d6cb53","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":27},"updated":"2020-08-18 13:30:12.000000000","message":"I think you can use PKG_GITREVCOUNT and probably remove the TIS_BASE_SRCREV","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# TIS_BASE_SRCREV changes. This version should align with the version of the"},{"line_number":7,"context_line":"# helm charts in stx-platform-helm"},{"line_number":8,"context_line":"TIS_BASE_SRCREV\u003d10c623509a68acad945d4e0c06a86b3e8486ad5b"},{"line_number":9,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+7"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_a73031ea","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":27},"in_reply_to":"9f560f44_d0d6cb53","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":1,"context_line":"SRC_DIR\u003d\"k8sapp_rook\""},{"line_number":2,"context_line":"TIS_BASE_SRCREV\u003d10c623509a68acad945d4e0c06a86b3e8486ad5b"},{"line_number":3,"context_line":"TIS_PATCH_VER\u003dPKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":68,"id":"b6beb943_f43234b4","line":2,"range":{"start_line":2,"start_character":51,"end_line":2,"end_character":56},"updated":"2020-12-03 15:07:19.000000000","message":"wondering if this SHA needs to change once this merges with the initial code.","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"}],"python-k8sapp-rook/centos/python-k8sapp-rook.spec":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"255168f3678e9a1142a85f70766ee7d99034de67","unresolved":false,"context_lines":[{"line_number":37,"context_line":"export PBR_VERSION\u003d%{version}"},{"line_number":38,"context_line":"%{__python2} setup.py build"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"%py2_build_wheel"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"%install"},{"line_number":43,"context_line":"export PBR_VERSION\u003d%{version}.%{tis_patch_ver}"}],"source_content_type":"text/x-rpm-spec","patch_set":45,"id":"9f560f44_8633abf6","line":40,"updated":"2020-08-31 19:35:18.000000000","message":"Do you need py3 wheel here? I think most of the images are now being built with py3 modules","commit_id":"74637c9bb20e0435e10f24413bb69bec479b7909"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"1ffaa9ef67692177fc0a76c7cf6b998ce8fa82c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"export PBR_VERSION\u003d%{version}"},{"line_number":38,"context_line":"%{__python2} setup.py build"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"%py2_build_wheel"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"%install"},{"line_number":43,"context_line":"export PBR_VERSION\u003d%{version}.%{tis_patch_ver}"}],"source_content_type":"text/x-rpm-spec","patch_set":45,"id":"9f560f44_c41ab16d","line":40,"in_reply_to":"9f560f44_8633abf6","updated":"2020-09-01 13:19:30.000000000","message":"This is build wheel for helm plugin. Same as other applications, such as stx-openstack and oidc-auth-apps, now all build py3 wheel. We can update with py3 wheel together with all apps.","commit_id":"74637c9bb20e0435e10f24413bb69bec479b7909"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Summary:        StarlingX sysinv extensions: Rook Ceph K8S app"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Requires:       python-pbr \u003e\u003d 2.0.0"},{"line_number":26,"context_line":"Requires:       sysinv \u003e\u003d 1.0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"%description -n python2-%{pypi_name}"},{"line_number":29,"context_line":"StarlingX sysinv extensions: Rook Ceph K8S app"}],"source_content_type":"text/x-rpm-spec","patch_set":68,"id":"1e335648_52f23097","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":28},"updated":"2020-12-03 15:07:19.000000000","message":"This is fine, although we tend to not enforce sysinv rpm versions in our spec files. But, that might be something we should be doing.","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"0cf546402c882285a8f390058d139f8351663c83","unresolved":true,"context_lines":[{"line_number":19,"context_line":"%description"},{"line_number":20,"context_line":"StarlingX sysinv extensions: Rook Ceph K8S app"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"%package -n     python2-%{pypi_name}"},{"line_number":23,"context_line":"Summary:        StarlingX sysinv extensions: Rook Ceph K8S app"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Requires:       python-pbr \u003e\u003d 2.0.0"},{"line_number":26,"context_line":"Requires:       sysinv \u003e\u003d 1.0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"%description -n python2-%{pypi_name}"},{"line_number":29,"context_line":"StarlingX sysinv extensions: Rook Ceph K8S app"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"%prep"},{"line_number":32,"context_line":"%setup"}],"source_content_type":"text/x-rpm-spec","patch_set":87,"id":"6a165725_589356d4","line":29,"range":{"start_line":22,"start_character":0,"end_line":29,"end_character":46},"updated":"2021-01-06 19:53:13.000000000","message":"Remove these lines. This package has no files assigned to it and does not get built, resulting in the build tools rebuilding it every time even with no change. I\u0027ve raised a Launchpad and posted reviews to fix the other similar occurrences:\nhttps://bugs.launchpad.net/starlingx/+bug/1910439\nhttps://review.opendev.org/c/starlingx/openstack-armada-app/+/769607","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"}],"python-k8sapp-rook/k8sapp_rook/.stestr.conf":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"test_path\u003d./k8sapp_platform/tests"},{"line_number":3,"context_line":"top_dir\u003d./k8sapp_platform"},{"line_number":4,"context_line":"#parallel_class\u003dTrue"}],"source_content_type":"text/plain","patch_set":26,"id":"9f560f44_b00eb7e2","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":27},"updated":"2020-08-18 13:30:12.000000000","message":"I do not see this folder in this repo","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"test_path\u003d./k8sapp_platform/tests"},{"line_number":3,"context_line":"top_dir\u003d./k8sapp_platform"},{"line_number":4,"context_line":"#parallel_class\u003dTrue"}],"source_content_type":"text/plain","patch_set":26,"id":"9f560f44_074d9d71","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":27},"in_reply_to":"9f560f44_b00eb7e2","updated":"2020-08-19 11:49:41.000000000","message":"fixed","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"}],"python-k8sapp-rook/k8sapp_rook/README.rst":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"k8sapp-platform"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This project contains StarlingX Kubernetes application specific python plugins"}],"source_content_type":"text/x-rst","patch_set":26,"id":"9f560f44_5030fb9e","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":15},"updated":"2020-08-18 13:30:12.000000000","message":"I suspect this name changed at some point during the many revisions/changesets.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":1,"context_line":"k8sapp-platform"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This project contains StarlingX Kubernetes application specific python plugins"}],"source_content_type":"text/x-rst","patch_set":26,"id":"9f560f44_275a6129","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":15},"in_reply_to":"9f560f44_5030fb9e","updated":"2020-08-19 11:49:41.000000000","message":"fixed","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"}],"python-k8sapp-rook/k8sapp_rook/k8sapp_rook/armada/manifest_rook_ceph.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        :param dbapi: DB api object"},{"line_number":39,"context_line":"        :param mode: mode to control how to apply the application manifest"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_30f0e7c9","line":41,"updated":"2020-08-18 13:30:12.000000000","message":"is this still a work in progress, or does the parent class do the work?","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        :param dbapi: DB api object"},{"line_number":39,"context_line":"        :param mode: mode to control how to apply the application manifest"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_67a9f9db","line":41,"in_reply_to":"9f560f44_30f0e7c9","updated":"2020-08-19 11:49:41.000000000","message":"update with derived from GenericArmadaManifestOperator","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2020 Intel Corporation, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":68,"id":"e835b3df_73763105","line":1,"updated":"2020-12-03 15:07:19.000000000","message":"Would be nice to not have these vim entries","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"}],"python-k8sapp-rook/k8sapp_rook/k8sapp_rook/helm/rook_ceph.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _get_mon_count(self):"},{"line_number":84,"context_line":"        # change it with deployment configs:"},{"line_number":85,"context_line":"        # AIO simplex/duplex have 1 mon, multi-node has 3 mons, 2 controllers + first mon (and cannot reconfig)"},{"line_number":86,"context_line":"        if cutils.is_aio_simplex_system(self.dbapi):"},{"line_number":87,"context_line":"            return 1"},{"line_number":88,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_90b8d3e5","line":85,"updated":"2020-08-18 13:30:12.000000000","message":"line width","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _get_mon_count(self):"},{"line_number":84,"context_line":"        # change it with deployment configs:"},{"line_number":85,"context_line":"        # AIO simplex/duplex have 1 mon, multi-node has 3 mons, 2 controllers + first mon (and cannot reconfig)"},{"line_number":86,"context_line":"        if cutils.is_aio_simplex_system(self.dbapi):"},{"line_number":87,"context_line":"            return 1"},{"line_number":88,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_07763da5","line":85,"in_reply_to":"9f560f44_90b8d3e5","updated":"2020-08-19 11:49:41.000000000","message":"fixed","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"f49e21449becc6288453e80cf8b26b4967044726","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _get_network_override(self):"},{"line_number":70,"context_line":"        return not cutils.is_aio_duplex_system(self.dbapi)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_mon_count(self):"},{"line_number":73,"context_line":"        # change it with deployment configs:"},{"line_number":74,"context_line":"        # AIO simplex/duplex have 1 mon, multi-node has 3 mons,"},{"line_number":75,"context_line":"        # 2 controllers + first mon (and cannot reconfig)"},{"line_number":76,"context_line":"        if cutils.is_aio_simplex_system(self.dbapi):"},{"line_number":77,"context_line":"            return 1"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            return 3"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _get_mon_hosts(self):"},{"line_number":82,"context_line":"        ceph_mon_label \u003d \"ceph-mon-placement\u003denabled\""}],"source_content_type":"text/x-python","patch_set":54,"id":"1f621f24_760c1c3b","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":20},"updated":"2020-11-03 14:03:02.000000000","message":"is_aio_simplex_system checks for AIO-SX, is_aio_duplex_system is used for DX.\n\nThis should be: if cutils.is_aio_simplex_system(self.dbapi) and cutils.is_aio_duplex_system(self.dbapi)\n\nAIO-DX has a single floating monitor DRBD mounted. You should check this behavior. Or do you have another approach for AIO-DX?","commit_id":"f7ce4e6e01336d7dbe55af14d1706d803a09cf36"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            hosts \u003d self.dbapi.ihost_get_by_personality("},{"line_number":105,"context_line":"                constants.CONTROLLER)"},{"line_number":106,"context_line":"            for host in hosts:"},{"line_number":107,"context_line":"                if host[\u0027hostname\u0027] \u003d\u003d socket.gethostname():"},{"line_number":108,"context_line":"                    duplex.update({\u0027activeController\u0027: host[\u0027hostname\u0027].encode(\u0027utf8\u0027, \u0027strict\u0027)})"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            pools \u003d self.dbapi.address_pools_get_all()"}],"source_content_type":"text/x-python","patch_set":68,"id":"d500c399_d97f6291","line":107,"updated":"2020-12-03 15:07:19.000000000","message":"OK this is fine.  I was wondering why we do this, its because the existing utility does the same thing.  https://opendev.org/starlingx/config/src/commit/e0f6b2d1dc9e395a92d644792a42b65319bfe6cc/sysinv/sysinv/sysinv/sysinv/api/controllers/v1/utils.py#L232","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"}],"python-k8sapp-rook/k8sapp_rook/k8sapp_rook/helm/rook_ceph_provisioner.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            if len(pods) \u003e 0:"},{"line_number":125,"context_line":"                return True"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            pass"},{"line_number":128,"context_line":"        return False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _get_monitors(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_3077473d","line":127,"updated":"2020-08-18 13:30:12.000000000","message":"I feel like there should at least be a debug log here.  for troubleshooting  unexpected exceptions","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4455ce0fbc59b4b3408fea72dc884b394d0453ff","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                \"host_provision\": {"},{"line_number":83,"context_line":"                    \"controller_hosts\": self._get_controller_hosts(),"},{"line_number":84,"context_line":"                },"},{"line_number":85,"context_line":"                \"ceph_mon_audit_jobs\": self._get_ceph_mon_audit(),"},{"line_number":86,"context_line":"            }"},{"line_number":87,"context_line":"        }"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":87,"id":"9f52f603_a3bc8735","line":85,"updated":"2020-12-27 20:00:51.000000000","message":"I will assume this is fine when it returns an empty dictionary","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"776cb4c29850f61b60ba447c91f777e9fb3c65ca","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                \"host_provision\": {"},{"line_number":83,"context_line":"                    \"controller_hosts\": self._get_controller_hosts(),"},{"line_number":84,"context_line":"                },"},{"line_number":85,"context_line":"                \"ceph_mon_audit_jobs\": self._get_ceph_mon_audit(),"},{"line_number":86,"context_line":"            }"},{"line_number":87,"context_line":"        }"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":87,"id":"8173172a_8a384865","line":85,"in_reply_to":"9f52f603_a3bc8735","updated":"2021-01-08 01:29:08.000000000","message":"For simplex and multi node, it will return an empty dictionary. For duplex, it will return {\"floatP\": xxx.xxx.xxx.2}","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"}],"python-k8sapp-rook/k8sapp_rook/k8sapp_rook/helm/rook_operator.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4455ce0fbc59b4b3408fea72dc884b394d0453ff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Intel Corporation, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":87,"id":"e7a91866_72858dc7","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":21},"updated":"2020-12-27 20:00:51.000000000","message":"nit: 2020 (or 2021)","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"776cb4c29850f61b60ba447c91f777e9fb3c65ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Intel Corporation, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":87,"id":"c3a1cc5a_99e9149f","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":21},"in_reply_to":"e7a91866_72858dc7","updated":"2021-01-08 01:29:08.000000000","message":"updated","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"}],"python-k8sapp-rook/k8sapp_rook/k8sapp_rook/tests/test_plugins.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# - Controller"},{"line_number":20,"context_line":"# - rook-ceph-apps app"},{"line_number":21,"context_line":"class K8SAppRookControllerTestCase(K8SAppRookAppMixin,"},{"line_number":22,"context_line":"                                       HelmOperatorTestSuiteMixin,"},{"line_number":23,"context_line":"                                       dbbase.ControllerHostTestCase):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_90d3b3d5","line":22,"updated":"2020-08-18 13:30:12.000000000","message":"usually the indent here would align with K8SAppRookAppMixin\n\n\nsame for other class declarations in this file.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# - Controller"},{"line_number":20,"context_line":"# - rook-ceph-apps app"},{"line_number":21,"context_line":"class K8SAppRookControllerTestCase(K8SAppRookAppMixin,"},{"line_number":22,"context_line":"                                       HelmOperatorTestSuiteMixin,"},{"line_number":23,"context_line":"                                       dbbase.ControllerHostTestCase):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_679299a1","line":22,"in_reply_to":"9f560f44_90d3b3d5","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"}],"python-k8sapp-rook/k8sapp_rook/pylint.rc":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"# E1102: not-callable"},{"line_number":90,"context_line":"# E1120: no-value-for-parameter"},{"line_number":91,"context_line":"# E1121: too-many-function-args"},{"line_number":92,"context_line":"disable\u003dC, R, fixme, W0101, W0105, W0106, W0107, W0108, W0110, W0123, W0150,"},{"line_number":93,"context_line":"        W0201, W0211, W0212, W0221, W0223, W0231, W0235, W0311, W0402, W0403,"},{"line_number":94,"context_line":"        W0404, W0603, W0612, W0613, W0621, W0622, W0631, W0632, W0701, W0703,"},{"line_number":95,"context_line":"        W1113, W1201, W1401, W1505,"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_b0b7d786","line":92,"updated":"2020-08-18 13:30:12.000000000","message":"I suspect not all of these need to be supressed.  Have you tried commenting out these \u0027disable\u0027 values and see which ones show up in the pylint report?","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":89,"context_line":"# E1102: not-callable"},{"line_number":90,"context_line":"# E1120: no-value-for-parameter"},{"line_number":91,"context_line":"# E1121: too-many-function-args"},{"line_number":92,"context_line":"disable\u003dC, R, fixme, W0101, W0105, W0106, W0107, W0108, W0110, W0123, W0150,"},{"line_number":93,"context_line":"        W0201, W0211, W0212, W0221, W0223, W0231, W0235, W0311, W0402, W0403,"},{"line_number":94,"context_line":"        W0404, W0603, W0612, W0613, W0621, W0622, W0631, W0632, W0701, W0703,"},{"line_number":95,"context_line":"        W1113, W1201, W1401, W1505,"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_c7e60545","line":92,"in_reply_to":"9f560f44_b0b7d786","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"[FORMAT]"},{"line_number":131,"context_line":"# Maximum number of characters on a single line."},{"line_number":132,"context_line":"max-line-length\u003d85"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Maximum number of lines in a module"},{"line_number":135,"context_line":"max-module-lines\u003d1000"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_d0824ba5","line":132,"updated":"2020-08-18 13:30:12.000000000","message":"Should set this to 80, since this is a new repo.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"[FORMAT]"},{"line_number":131,"context_line":"# Maximum number of characters on a single line."},{"line_number":132,"context_line":"max-line-length\u003d85"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Maximum number of lines in a module"},{"line_number":135,"context_line":"max-module-lines\u003d1000"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_67d73951","line":132,"in_reply_to":"9f560f44_d0824ba5","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"}],"python-k8sapp-rook/k8sapp_rook/setup.cfg":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.4"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.5"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[files]"},{"line_number":24,"context_line":"packages \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":26,"id":"9f560f44_d0ab6b1b","line":21,"updated":"2020-08-18 13:30:12.000000000","message":"I would suggest we add 3.6 (and probably remove 3.4, though not necessary)","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.4"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.5"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[files]"},{"line_number":24,"context_line":"packages \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":26,"id":"9f560f44_67457915","line":21,"in_reply_to":"9f560f44_d0ab6b1b","updated":"2020-08-19 11:49:41.000000000","message":"fixed","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4455ce0fbc59b4b3408fea72dc884b394d0453ff","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.5"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[files]"},{"line_number":24,"context_line":"packages \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":87,"id":"c6bca6fd_04859a3d","line":21,"updated":"2020-12-27 20:00:51.000000000","message":"feel free to include 3.7 and 3.8 in this list, if you want.","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"776cb4c29850f61b60ba447c91f777e9fb3c65ca","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.5"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[files]"},{"line_number":24,"context_line":"packages \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":87,"id":"e421aebb_f6f5beb4","line":21,"in_reply_to":"c6bca6fd_04859a3d","updated":"2021-01-08 01:29:08.000000000","message":"updated","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"}],"python-k8sapp-rook/k8sapp_rook/test-requirements.txt":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":17,"context_line":"oslosphinx\u003c2.6.0,\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":18,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":19,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":20,"context_line":"testrepository\u003e\u003d0.0.18"},{"line_number":21,"context_line":"testtools!\u003d1.2.0,\u003e\u003d0.9.36"},{"line_number":22,"context_line":"tempest-lib\u003c0.5.0,\u003e\u003d0.4.0"},{"line_number":23,"context_line":"ipaddr"}],"source_content_type":"text/plain","patch_set":68,"id":"f1b02e93_5a6ca731","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":14},"updated":"2020-12-03 15:07:19.000000000","message":"surprised we need testrepository if we are using stestr","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"}],"python-k8sapp-rook/k8sapp_rook/tox.ini":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"       -e{[tox]stxdir}/config/tsconfig/tsconfig"},{"line_number":49,"context_line":"       -e{[tox]stxdir}/fault/fm-api"},{"line_number":50,"context_line":"       -e{[tox]stxdir}/fault/python-fmclient/fmclient"},{"line_number":51,"context_line":"       -e{[tox]stxdir}/update/cgcs-patch/cgcs-patch"},{"line_number":52,"context_line":"       -e{[tox]stxdir}/utilities/ceph/python-cephclient/python-cephclient"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":26,"id":"9f560f44_9048d387","line":51,"updated":"2020-08-18 13:30:12.000000000","message":"Not sure you need all of these","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":48,"context_line":"       -e{[tox]stxdir}/config/tsconfig/tsconfig"},{"line_number":49,"context_line":"       -e{[tox]stxdir}/fault/fm-api"},{"line_number":50,"context_line":"       -e{[tox]stxdir}/fault/python-fmclient/fmclient"},{"line_number":51,"context_line":"       -e{[tox]stxdir}/update/cgcs-patch/cgcs-patch"},{"line_number":52,"context_line":"       -e{[tox]stxdir}/utilities/ceph/python-cephclient/python-cephclient"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":26,"id":"9f560f44_f39dc7bb","line":51,"in_reply_to":"9f560f44_9048d387","updated":"2020-08-19 11:49:41.000000000","message":"this is must, otherwise, zuul fail","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# E402 module level import not at top of file"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"ignore \u003d H101,H102,H104,H105,H306,H401,H403,H404,H405,H701,H702,H703,"},{"line_number":95,"context_line":"         B006,B007,B009,B010,B012,B014,B301,B306,"},{"line_number":96,"context_line":"         W503,W504,W605,"},{"line_number":97,"context_line":"         E117,E126,E127,E128,E402"},{"line_number":98,"context_line":"exclude \u003d build,dist,tools,.eggs"}],"source_content_type":"text/x-properties","patch_set":26,"id":"9f560f44_b0451773","line":95,"updated":"2020-08-18 13:30:12.000000000","message":"I suspect a lot of these do not apply to this repo and can be removed.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# E402 module level import not at top of file"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"ignore \u003d H101,H102,H104,H105,H306,H401,H403,H404,H405,H701,H702,H703,"},{"line_number":95,"context_line":"         B006,B007,B009,B010,B012,B014,B301,B306,"},{"line_number":96,"context_line":"         W503,W504,W605,"},{"line_number":97,"context_line":"         E117,E126,E127,E128,E402"},{"line_number":98,"context_line":"exclude \u003d build,dist,tools,.eggs"}],"source_content_type":"text/x-properties","patch_set":26,"id":"9f560f44_73a9b7db","line":95,"in_reply_to":"9f560f44_b0451773","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"#"},{"line_number":157,"context_line":"# Note: \u0027skips\u0027 entry cannot be split across multiple lines"},{"line_number":158,"context_line":"#"},{"line_number":159,"context_line":"skips \u003d B101,B103,B104,B105,B108,B110,B303,B307,B310,B311,B314,B318,B320,B404,B405,B408,B410,B506,B602,B603,B604,B605,B607"},{"line_number":160,"context_line":"exclude \u003d tests"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"[testenv:bandit]"}],"source_content_type":"text/x-properties","patch_set":26,"id":"9f560f44_f0230fbd","line":159,"updated":"2020-08-18 13:30:12.000000000","message":"I suspect you dont need to suppress all of these.  I think they are sysinv bandit errors we still have not cleaned up in that repo, but I dont think you would have all of these here.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":156,"context_line":"#"},{"line_number":157,"context_line":"# Note: \u0027skips\u0027 entry cannot be split across multiple lines"},{"line_number":158,"context_line":"#"},{"line_number":159,"context_line":"skips \u003d B101,B103,B104,B105,B108,B110,B303,B307,B310,B311,B314,B318,B320,B404,B405,B408,B410,B506,B602,B603,B604,B605,B607"},{"line_number":160,"context_line":"exclude \u003d tests"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"[testenv:bandit]"}],"source_content_type":"text/x-properties","patch_set":26,"id":"9f560f44_1384bb5d","line":159,"in_reply_to":"9f560f44_f0230fbd","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4455ce0fbc59b4b3408fea72dc884b394d0453ff","unresolved":true,"context_lines":[{"line_number":36,"context_line":"         LANG\u003den_US.UTF-8"},{"line_number":37,"context_line":"         LANGUAGE\u003den_US:en"},{"line_number":38,"context_line":"         LC_ALL\u003dC"},{"line_number":39,"context_line":"         EVENTS_YAML\u003d./k8sapp_rook/tests/events_for_testing.yaml"},{"line_number":40,"context_line":"         SYSINV_TEST_ENV\u003dTrue"},{"line_number":41,"context_line":"         TOX_WORK_DIR\u003d{toxworkdir}"},{"line_number":42,"context_line":"         PYLINTHOME\u003d{toxworkdir}"}],"source_content_type":"text/x-properties","patch_set":87,"id":"0011ca6a_b7b50de6","line":39,"updated":"2020-12-27 20:00:51.000000000","message":"I think you can remove this line.  I do not believe you are using this env value, and do not have this file.","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"776cb4c29850f61b60ba447c91f777e9fb3c65ca","unresolved":true,"context_lines":[{"line_number":36,"context_line":"         LANG\u003den_US.UTF-8"},{"line_number":37,"context_line":"         LANGUAGE\u003den_US:en"},{"line_number":38,"context_line":"         LC_ALL\u003dC"},{"line_number":39,"context_line":"         EVENTS_YAML\u003d./k8sapp_rook/tests/events_for_testing.yaml"},{"line_number":40,"context_line":"         SYSINV_TEST_ENV\u003dTrue"},{"line_number":41,"context_line":"         TOX_WORK_DIR\u003d{toxworkdir}"},{"line_number":42,"context_line":"         PYLINTHOME\u003d{toxworkdir}"}],"source_content_type":"text/x-properties","patch_set":87,"id":"38c9a648_197505ff","line":39,"in_reply_to":"0011ca6a_b7b50de6","updated":"2021-01-08 01:29:08.000000000","message":"updated","commit_id":"57084fe9230091d542e63b901f3d5706966aff5a"}],"stx-rook-ceph/centos/build_srpm.data":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"846501daf8882d9cb7dfcf6c1cab991fd07f27d9","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"COPY_LIST_TO_TAR\u003d\"\\"},{"line_number":4,"context_line":"\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"TIS_PATCH_VER\u003d1"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_90161355","line":5,"updated":"2020-08-18 13:30:12.000000000","message":"You might want to consider adding:\nEXCLUDE_LIST_FROM_TAR\u003d\".stestr\"\n\nsince if you run tox in this folder, even though it will use /tmp for the .tox files, it will still create a .stestr folder in your src folder, which will get included in the src rpm.","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8c9e7ab40926fd656a0f9fb2e3f7841199657985","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"COPY_LIST_TO_TAR\u003d\"\\"},{"line_number":4,"context_line":"\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"TIS_PATCH_VER\u003d1"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"9f560f44_9340cb37","line":5,"in_reply_to":"9f560f44_90161355","updated":"2020-08-19 11:49:41.000000000","message":"updated","commit_id":"5d8f1c41b9deaff635c55fa25ceda637f6b5781e"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"052cbe6b43b514c60b2fa91447de7773a5f83fec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"SRC_DIR\u003d\"stx-rook-ceph\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"COPY_LIST_TO_TAR\u003d\"\\"},{"line_number":4,"context_line":"\""},{"line_number":5,"context_line":"EXCLUDE_LIST_FROM_TAR\u003d\".stestr\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TIS_PATCH_VER\u003d1"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"9f560f44_afb916cc","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":1},"updated":"2020-09-04 15:31:23.000000000","message":"This seems to do nothing.","commit_id":"0408c293fb126538f9070a41fc50e5b89f647af9"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"b90d1cafba2f133e5c50aced09ec95101ce02433","unresolved":false,"context_lines":[{"line_number":1,"context_line":"SRC_DIR\u003d\"stx-rook-ceph\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"COPY_LIST_TO_TAR\u003d\"\\"},{"line_number":4,"context_line":"\""},{"line_number":5,"context_line":"EXCLUDE_LIST_FROM_TAR\u003d\".stestr\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TIS_PATCH_VER\u003d1"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"9f560f44_7366bbbd","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":1},"in_reply_to":"9f560f44_afb916cc","updated":"2020-09-07 01:23:27.000000000","message":"fixed","commit_id":"0408c293fb126538f9070a41fc50e5b89f647af9"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"052cbe6b43b514c60b2fa91447de7773a5f83fec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\""},{"line_number":5,"context_line":"EXCLUDE_LIST_FROM_TAR\u003d\".stestr\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TIS_PATCH_VER\u003d1"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"9f560f44_0f980268","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"updated":"2020-09-04 15:31:23.000000000","message":"Is there a reason you didn\u0027t go with PKG_GITREVCOUNT ?","commit_id":"0408c293fb126538f9070a41fc50e5b89f647af9"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"b90d1cafba2f133e5c50aced09ec95101ce02433","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\""},{"line_number":5,"context_line":"EXCLUDE_LIST_FROM_TAR\u003d\".stestr\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TIS_PATCH_VER\u003d1"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"9f560f44_d304e7c8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"in_reply_to":"9f560f44_0f980268","updated":"2020-09-07 01:23:27.000000000","message":"fixed","commit_id":"0408c293fb126538f9070a41fc50e5b89f647af9"}],"stx-rook-ceph/files/rook-mon-exit.sh":[{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"61f62683f64c7263d1d0a9fbcf5fd91a521c25f6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"################################################################################"},{"line_number":11,"context_line":"# Start Action"},{"line_number":12,"context_line":"################################################################################"},{"line_number":13,"context_line":"function start() {"},{"line_number":14,"context_line":"    return"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":61,"id":"95a725bf_155f9b54","line":13,"in_reply_to":"14fb2223_3ff7e01c","updated":"2020-11-30 00:09:14.000000000","message":"\u003e linters: E020 Function declaration not in format ^function name {$\n\nPlease fix.","commit_id":"f64123eee8599ab62b46539587e853091cb750de"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"776cb4c29850f61b60ba447c91f777e9fb3c65ca","unresolved":true,"context_lines":[{"line_number":17,"context_line":"################################################################################"},{"line_number":18,"context_line":"# Stop Action"},{"line_number":19,"context_line":"################################################################################"},{"line_number":20,"context_line":"function stop() {"},{"line_number":21,"context_line":"    pgrep ceph-mon"},{"line_number":22,"context_line":"    if [ $? ]; then"},{"line_number":23,"context_line":"        kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf delete        \\"}],"source_content_type":"text/x-sh","patch_set":61,"id":"ab26d9e2_8be8d553","line":20,"in_reply_to":"92cc5e40_7f0cb6fd","updated":"2021-01-08 01:29:08.000000000","message":"\u003e linters: E020 Function declaration not in format ^function name {$\n\nPlease fix.","commit_id":"f64123eee8599ab62b46539587e853091cb750de"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":11,"context_line":"# Start Action"},{"line_number":12,"context_line":"################################################################################"},{"line_number":13,"context_line":"function start {"},{"line_number":14,"context_line":"    return"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"################################################################################"}],"source_content_type":"text/x-sh","patch_set":68,"id":"94ce6348_5dafbaa9","line":14,"updated":"2020-12-03 15:07:19.000000000","message":"I guess there is no start for this method?","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# Status Action"},{"line_number":42,"context_line":"################################################################################"},{"line_number":43,"context_line":"function status {"},{"line_number":44,"context_line":"    pgrep sysinv-api"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    RETVAL\u003d$?"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":68,"id":"9fd57e55_ec6e0e5b","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":20},"updated":"2020-12-03 15:07:19.000000000","message":"So we don\u0027t check ceph-mon or ceph-osd ?","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"}],"stx-rook-ceph/stx-rook-ceph/helm-charts/rook-ceph-provisioner/requirements.yaml":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f19a9df1368395a9436bbd1f673a9c20ddd16c69","unresolved":true,"context_lines":[{"line_number":1,"context_line":"dependencies:"},{"line_number":2,"context_line":"    #  - name: rook-ceph"},{"line_number":3,"context_line":"    #repository: http://localhost:8879"},{"line_number":4,"context_line":"    #version: 0.1.0"},{"line_number":5,"context_line":"    #alias: rook-operator"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"e9de4d2a_c9957320","line":3,"updated":"2020-12-03 15:07:19.000000000","message":"Are these indended to be left commented out?","commit_id":"ab0b2393b58907b400162e2a80ca5a851b436c3c"}],"stx-rook-ceph/stx-rook-ceph/helm-charts/rook-ceph-provisioner/templates/NOTES.txt":[{"author":{"_account_id":28747,"name":"Ovidiu Poncea","email":"ovidiu.poncea@outlook.com","username":"ovidiu.poncea"},"change_message_id":"f49e21449becc6288453e80cf8b26b4967044726","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The rook-ceph-provisioner has been installed."},{"line_number":2,"context_line":""}],"source_content_type":"text/plain","patch_set":54,"id":"1f621f24_933bcae9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":45},"updated":"2020-11-03 14:03:02.000000000","message":"This is NOTES.txt, do we use it somewhere?","commit_id":"f7ce4e6e01336d7dbe55af14d1706d803a09cf36"}],"stx-rook-ceph/stx-rook-ceph/helm-charts/rook-ceph-provisioner/templates/job-ceph-mon-audit.yaml":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"92b3bf64219ee4a8b38988143e4376b45d535394","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    #!/bin/bash"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    node\u003d$(hostname)"},{"line_number":20,"context_line":"    stat /opt/platform/.keyring/20.12/.CREDENTIAL \u003e /dev/null 2\u003e\u00261"},{"line_number":21,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":22,"context_line":"        if [ x\"$node\" \u003d x\"controller-0\" ]; then"},{"line_number":23,"context_line":"            active\u003d\"controller-1\""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"f5c3bb6d_2e6a5aff","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":37},"updated":"2020-12-16 15:57:10.000000000","message":"We can\u0027t use hardcoded versions\n\nsource /etc/build.info\nthen use ${SW_VERSION}","commit_id":"9584a757bf9b7dc39616dbcb244767a896de52ee"}],"stx-rook-ceph/stx-rook-ceph/helm-charts/rook-ceph-provisioner/templates/pre-install-ceph-mgr-provision.yaml":[{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"5d52fbad02aa0e04a2e66bf2b032e84232401dd0","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        ceph config-key set mgr/restful/$i/crt -i /tmp/controller.crt"},{"line_number":62,"context_line":"        ceph config-key set mgr/restful/$i/key -i /tmp/controller.key"},{"line_number":63,"context_line":"    done"},{"line_number":64,"context_line":"    ceph config set mgr mgr/restful/server_port 7999"},{"line_number":65,"context_line":"    ceph mgr module disable restful"},{"line_number":66,"context_line":"    ceph mgr module enable restful"},{"line_number":67,"context_line":"    ceph restful create-key admin"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"56bda787_7c69fd56","line":64,"range":{"start_line":64,"start_character":48,"end_line":64,"end_character":52},"updated":"2020-12-02 11:53:53.000000000","message":"is this configable ? or static ?","commit_id":"c127110eff80d5ebf7434df2eb6dd29f6a175822"}],"stx-rook-ceph/stx-rook-ceph/helm-charts/rook-ceph-provisioner/values.yaml":[{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"d26e5168f4082773056ccc8f9eabc8a7ce9d6307","unresolved":true,"context_lines":[{"line_number":167,"context_line":"  audit:"},{"line_number":168,"context_line":"    cron: \"*/3 * * * *\""},{"line_number":169,"context_line":"    history:"},{"line_number":170,"context_line":"      success: 1 "},{"line_number":171,"context_line":"      failed: 1"},{"line_number":172,"context_line":"  labels:"},{"line_number":173,"context_line":"    node_selector_key: node-role.kubernetes.io/master"}],"source_content_type":"text/x-yaml","patch_set":62,"id":"bb938d74_50a76bb4","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":17},"updated":"2020-11-30 02:05:56.000000000","message":"nic: better remove this space.","commit_id":"f898b488df7d956a2b6ab3948aed4dbb985b4831"}],"test-requirements.txt":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"e750dd59c99931881169c6dce3301c17c09bd310","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# hacking pulls in flake8"},{"line_number":2,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":3,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":47,"id":"9f560f44_19a9de7b","line":2,"updated":"2020-09-14 14:50:32.000000000","message":"I think these constraints will need to be dropped (or modified). This results in flake8\u003d\u003d2.5.5, which we saw last week fails on the new ubuntu-focal zuul machines (running ptyhon3.8, which only the latest flake8 release seems to work on)","commit_id":"6ef0dfe7c8a7baf00dcbea2ed9b9013c74770331"}]}