)]}'
{"build-tools/srpm-utils":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"964ac09e7bba4476b1b135fa614771eda03cacd1","unresolved":false,"context_lines":[{"line_number":3203,"context_line":"       TIS_PATCH_INC\u003d${TIS_PATCH_VER//[A-Z \\+]/}"},{"line_number":3204,"context_line":"       TIS_PATCH_VER\u003d$(srpm_git_revision_count_pkg $PKG_BASE $TIS_BASE_SRCREV)"},{"line_number":3205,"context_line":"       if [ $? -ne 0 ] || [ \"$TIS_PATCH_VER\" \u003d\u003d \"\" ]; then"},{"line_number":3206,"context_line":"          \u003e\u00262 echo \"ERROR: $FUNCNAME (${LINENO}): Invalid TIS_BASE_SRCREV \u0027$TIS_BASE_SRCREV\u0027\""},{"line_number":3207,"context_line":"          return 1"},{"line_number":3208,"context_line":"       fi"},{"line_number":3209,"context_line":"       if [[ \"$TIS_PATCH_INC\" \u003d~ ^-?[0-9]+$ ]]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ff570b3c_57d59542","line":3206,"updated":"2020-05-13 17:48:16.000000000","message":"Error message copy/pasted from GITREVCOUNT... I\u0027ll update it","commit_id":"24faa784f03335c98cbe948f7891307e9d3e106b"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"517e0cb01c960945fe9cd724cb85d3b990d1a191","unresolved":false,"context_lines":[{"line_number":3170,"context_line":"        COUNT\u003d$(git rev-list --count $BASE_SRCREV..HEAD -- .)"},{"line_number":3171,"context_line":"    fi"},{"line_number":3172,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":3173,"context_line":"        return 1"},{"line_number":3174,"context_line":"    fi"},{"line_number":3175,"context_line":"    DIRTY\u003d$(git status --porcelain . | wc -l)"},{"line_number":3176,"context_line":"    if [ \"$DIRTY\" -ne 0 ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ff570b3c_401db00d","line":3173,"updated":"2020-05-14 20:33:25.000000000","message":"shouldn\u0027t we \"popd\" before returning?","commit_id":"0a287a8ab6dfb1766919a73d3e1bde82592d4c17"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"4b7cf316ee07cdc22a9d75e3eada42f8f456caf0","unresolved":false,"context_lines":[{"line_number":3170,"context_line":"        COUNT\u003d$(git rev-list --count $BASE_SRCREV..HEAD -- .)"},{"line_number":3171,"context_line":"    fi"},{"line_number":3172,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":3173,"context_line":"        return 1"},{"line_number":3174,"context_line":"    fi"},{"line_number":3175,"context_line":"    DIRTY\u003d$(git status --porcelain . | wc -l)"},{"line_number":3176,"context_line":"    if [ \"$DIRTY\" -ne 0 ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ff570b3c_40f5b082","line":3173,"in_reply_to":"ff570b3c_401db00d","updated":"2020-05-14 20:38:29.000000000","message":"Sure. I\u0027ll update the original srpm_git_revision_count as well","commit_id":"0a287a8ab6dfb1766919a73d3e1bde82592d4c17"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"517e0cb01c960945fe9cd724cb85d3b990d1a191","unresolved":false,"context_lines":[{"line_number":3207,"context_line":"          return 1"},{"line_number":3208,"context_line":"       fi"},{"line_number":3209,"context_line":"       if [[ \"$TIS_PATCH_INC\" \u003d~ ^-?[0-9]+$ ]]; then"},{"line_number":3210,"context_line":"           TIS_PATCH_VER\u003d$((TIS_PATCH_VER+${TIS_PATCH_INC}))"},{"line_number":3211,"context_line":"       fi"},{"line_number":3212,"context_line":"   elif [[ \"$TIS_PATCH_VER\" \u003d\u003d GITREVCOUNT* ]]; then"},{"line_number":3213,"context_line":"       # Calculate the patch version dynamically based on the number of commits"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ff570b3c_c08d4032","line":3210,"updated":"2020-05-14 20:33:25.000000000","message":"nit: I think $ is unnecessary around ${TIS_PATCH_INC}","commit_id":"0a287a8ab6dfb1766919a73d3e1bde82592d4c17"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"ffcfa8b1b2a5924d4933a8d9476a3c1ecc11c8b0","unresolved":false,"context_lines":[{"line_number":3207,"context_line":"          return 1"},{"line_number":3208,"context_line":"       fi"},{"line_number":3209,"context_line":"       if [[ \"$TIS_PATCH_INC\" \u003d~ ^-?[0-9]+$ ]]; then"},{"line_number":3210,"context_line":"           TIS_PATCH_VER\u003d$((TIS_PATCH_VER+${TIS_PATCH_INC}))"},{"line_number":3211,"context_line":"       fi"},{"line_number":3212,"context_line":"   elif [[ \"$TIS_PATCH_VER\" \u003d\u003d GITREVCOUNT* ]]; then"},{"line_number":3213,"context_line":"       # Calculate the patch version dynamically based on the number of commits"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ff570b3c_935a814c","line":3210,"in_reply_to":"ff570b3c_c08d4032","updated":"2020-05-15 02:59:09.000000000","message":"Done","commit_id":"0a287a8ab6dfb1766919a73d3e1bde82592d4c17"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"db7448191ff989a7f4629a9f71b10c55c6502a8e","unresolved":false,"context_lines":[{"line_number":3205,"context_line":"       # an additional increment (e.g., TIS_PATCH_VER\u003dPKG_GITREVCOUNT+1)"},{"line_number":3206,"context_line":"       # If TIS_BASE_SRCREV is not set, srpm_git_revision_count_pkg will count from the first commit"},{"line_number":3207,"context_line":"       TIS_PATCH_INC\u003d${TIS_PATCH_VER//[A-Z_ \\+]/}"},{"line_number":3208,"context_line":"       TIS_PATCH_VER\u003d$(srpm_git_revision_count_pkg $PKG_BASE $TIS_BASE_SRCREV)"},{"line_number":3209,"context_line":"       if [ $? -ne 0 ] || [ \"$TIS_PATCH_VER\" \u003d\u003d \"\" ]; then"},{"line_number":3210,"context_line":"          \u003e\u00262 echo \"ERROR: $FUNCNAME (${LINENO}): Unable to calculate PKG_GITREVCOUNT for PKG_BASE\u003d\u0027${PKG_BASE}\u0027\""},{"line_number":3211,"context_line":"          return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ff570b3c_f8eb910f","line":3208,"range":{"start_line":3208,"start_character":62,"end_line":3208,"end_character":77},"updated":"2020-05-19 14:56:18.000000000","message":"Please use PKG_BASE_SRCREV.  Let\u0027s not overload TIS_BASE_SRCREV.  THis will allow the two rev counts to be used in parallel with a future update.","commit_id":"566555b759672389a43b10b21ceeba16ea911408"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"6602053a77a6f6551ac741d15b57284c6123ae64","unresolved":false,"context_lines":[{"line_number":3205,"context_line":"       # an additional increment (e.g., TIS_PATCH_VER\u003dPKG_GITREVCOUNT+1)"},{"line_number":3206,"context_line":"       # If TIS_BASE_SRCREV is not set, srpm_git_revision_count_pkg will count from the first commit"},{"line_number":3207,"context_line":"       TIS_PATCH_INC\u003d${TIS_PATCH_VER//[A-Z_ \\+]/}"},{"line_number":3208,"context_line":"       TIS_PATCH_VER\u003d$(srpm_git_revision_count_pkg $PKG_BASE $TIS_BASE_SRCREV)"},{"line_number":3209,"context_line":"       if [ $? -ne 0 ] || [ \"$TIS_PATCH_VER\" \u003d\u003d \"\" ]; then"},{"line_number":3210,"context_line":"          \u003e\u00262 echo \"ERROR: $FUNCNAME (${LINENO}): Unable to calculate PKG_GITREVCOUNT for PKG_BASE\u003d\u0027${PKG_BASE}\u0027\""},{"line_number":3211,"context_line":"          return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ff570b3c_59f27c07","line":3208,"range":{"start_line":3208,"start_character":62,"end_line":3208,"end_character":77},"in_reply_to":"ff570b3c_f8eb910f","updated":"2020-05-19 18:37:36.000000000","message":"Done","commit_id":"566555b759672389a43b10b21ceeba16ea911408"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"3fd64a32a5195f4068103fdf3c24c3b1ec226a23","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_7210354f","line":3221,"range":{"start_line":3221,"start_character":73,"end_line":3221,"end_character":88},"updated":"2020-05-19 20:22:25.000000000","message":"Do we need to make sure this has a sane default value?","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"3fd64a32a5195f4068103fdf3c24c3b1ec226a23","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_92434942","line":3221,"range":{"start_line":3221,"start_character":16,"end_line":3221,"end_character":31},"updated":"2020-05-19 20:22:25.000000000","message":"Is there another change that uses PKG_GITREVCOUNT or GITREVCOUNT below?  Is the magic somehow in the evaluation of $((TIS_PATCH_VER))?","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"93b06ca5b71234bc351b12bb3676334fdf535b2a","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_883e78b5","line":3221,"range":{"start_line":3221,"start_character":73,"end_line":3221,"end_character":88},"in_reply_to":"ff570b3c_12d61929","updated":"2020-05-19 21:32:46.000000000","message":"Yes, for sanity","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"f8a7f6c8b675cf1e5934328145785577d549c008","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_12d61929","line":3221,"range":{"start_line":3221,"start_character":73,"end_line":3221,"end_character":88},"in_reply_to":"ff570b3c_7210354f","updated":"2020-05-19 20:37:59.000000000","message":"I can add back the $? check that I inadvertently dropped when I revised this function on the last updated.","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"60a66a6f8984eb5852795afcea4b06ccf43d4dce","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_63aa2585","line":3221,"range":{"start_line":3221,"start_character":73,"end_line":3221,"end_character":88},"in_reply_to":"ff570b3c_883e78b5","updated":"2020-05-19 22:33:21.000000000","message":"Done","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"f8a7f6c8b675cf1e5934328145785577d549c008","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_92e989e7","line":3221,"range":{"start_line":3221,"start_character":16,"end_line":3221,"end_character":31},"in_reply_to":"ff570b3c_92434942","updated":"2020-05-19 20:37:59.000000000","message":"Yes. Bash expands these variables for us, and handles the arithmetic.","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"93b06ca5b71234bc351b12bb3676334fdf535b2a","unresolved":false,"context_lines":[{"line_number":3218,"context_line":"        for varname in ${TIS_PATCH_VER//[+-]/ }; do"},{"line_number":3219,"context_line":"            if [ \"${varname}\" \u003d \"PKG_GITREVCOUNT\" ]; then"},{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"},{"line_number":3223,"context_line":"                # Calculate GITREVCOUNT"},{"line_number":3224,"context_line":"                if [ -z \"$TIS_BASE_SRCREV\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff570b3c_4872a0ae","line":3221,"range":{"start_line":3221,"start_character":16,"end_line":3221,"end_character":31},"in_reply_to":"ff570b3c_92e989e7","updated":"2020-05-19 21:32:46.000000000","message":"Might be a good idea to just mention that in the assignment line below so someone not as familiar with that magic understands what\u0027s going on","commit_id":"d3e735a7703a38f3aae99c64bfc52f8d7006a8a4"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"60a66a6f8984eb5852795afcea4b06ccf43d4dce","unresolved":false,"context_lines":[{"line_number":3220,"context_line":"                # Calculate PKG_GITREVCOUNT, with optional PKG_BASE_SRCREV"},{"line_number":3221,"context_line":"                PKG_GITREVCOUNT\u003d$(srpm_git_revision_count_pkg $PKG_BASE $PKG_BASE_SRCREV)"},{"line_number":3222,"context_line":"                if [ $? -ne 0 ]; then"},{"line_number":3223,"context_line":"                    \u003e\u00262 echo \"ERROR: $FUNCNAME (${LINENO}): Failed to calculate PKG_GITREVCOUNT\""},{"line_number":3224,"context_line":"                    return 1"},{"line_number":3225,"context_line":"                fi"},{"line_number":3226,"context_line":"            elif [ \"${varname}\" \u003d \"GITREVCOUNT\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ff570b3c_23a4adb9","line":3223,"updated":"2020-05-19 22:33:21.000000000","message":"Adding a bad git ref results in a failure like:\n\n18:12:09 b7: \u003d\u003d\u003d\u003d\u003d Build SRPM for \u0027tsconfig\u0027 \u003d\u003d\u003d\u003d\u003d\n18:12:09 b7: PKG_BASE\u003d/localdisk/designer/dpenney/starlingx-6/cgcs-root/stx/config/tsconfig\n18:12:09 b7: WORK_BASE\u003d/localdisk/loadbuild/dpenney/starlingx-6/std/inputs/stx/config/tsconfig\n18:12:09 b7: RPMBUILD_BASE\u003d/localdisk/loadbuild/dpenney/starlingx-6/std/inputs/stx/config/tsconfig/rpmbuild\n18:12:09 b7: fatal: bad revision \u00271234..HEAD\u0027\n18:12:09 b7: ERROR: srpm_source_build_data (3223): Failed to calculate PKG_GITREVCOUNT\n18:12:09 b7: ERROR: build_dir_spec (981): failed to source centos/build_srpm.data","commit_id":"89543b25b4f2733968e4a17fbc6e791f4eaa25cd"}]}