)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"25e2fd5932c6d2529fc140497734b09363a08467","unresolved":true,"context_lines":[{"line_number":7,"context_line":"WIP: installer: Allow usage without root and add v5.10 kernel compat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow the use of update-pxe-network-installer/make-installer-images.sh"},{"line_number":10,"context_line":"without root privileges, via the use of guestmount/guestunmount."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also add compatibility with the newer v5.10-based kernel\u0027s packaging,"},{"line_number":13,"context_line":"which places %ghost files in /boot and places the original files in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2d2557ad_874ec6ce","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":50},"updated":"2021-07-19 19:27:31.000000000","message":"It looks like it is possible to use \"udisksctl loop-setup/loop-delete/mount/unmount\" to achieve the same goal without the need for a VM.","commit_id":"4b4492e5305e931ccad940cda2befbb21070a5b9"}],"build-tools/make-installer-images.sh":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"c9d6c8bece4f50c63cbfd9b066557dbedc768157","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    echo \"old version is $old_version\""},{"line_number":71,"context_line":"    # remove old files in original initrd.img"},{"line_number":72,"context_line":"    # do this in chroot to avoid accidentialy wrong operations on host root"},{"line_number":73,"context_line":"    if [ ${EUID} -eq 0 ]; then"},{"line_number":74,"context_line":"        chroot $rootfs_dir /bin/bash -x \u003c\u003cEOF"},{"line_number":75,"context_line":"    rm -rf ./boot/ ./etc/modules-load.d/"},{"line_number":76,"context_line":"    if [ -n $old_version ] \u0026\u0026  [ -f ./etc/ld.so.conf.d/kernel-${old_version}.conf ]; then"},{"line_number":77,"context_line":"        rm -rf ./etc/ld.so.conf.d/kernel-${old_version}.conf"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ab5b2e22_310e893f","line":74,"range":{"start_line":73,"start_character":1,"end_line":74,"end_character":45},"updated":"2021-07-29 18:31:07.000000000","message":"seems backward, I would expec ...\n\nif NOT root then chroot","commit_id":"4b4492e5305e931ccad940cda2befbb21070a5b9"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"1e6a386b15df0f1fb587925a11e0e3f2f6674cfe","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    echo \"old version is $old_version\""},{"line_number":71,"context_line":"    # remove old files in original initrd.img"},{"line_number":72,"context_line":"    # do this in chroot to avoid accidentialy wrong operations on host root"},{"line_number":73,"context_line":"    if [ ${EUID} -eq 0 ]; then"},{"line_number":74,"context_line":"        chroot $rootfs_dir /bin/bash -x \u003c\u003cEOF"},{"line_number":75,"context_line":"    rm -rf ./boot/ ./etc/modules-load.d/"},{"line_number":76,"context_line":"    if [ -n $old_version ] \u0026\u0026  [ -f ./etc/ld.so.conf.d/kernel-${old_version}.conf ]; then"},{"line_number":77,"context_line":"        rm -rf ./etc/ld.so.conf.d/kernel-${old_version}.conf"}],"source_content_type":"text/x-sh","patch_set":2,"id":"552fd5b3_5f1823ee","line":74,"range":{"start_line":73,"start_character":1,"end_line":74,"end_character":45},"in_reply_to":"ab5b2e22_310e893f","updated":"2021-07-29 18:33:54.000000000","message":"chroot requires root permissions, unfortunately. I added an alternative in case the running user does not have root access.","commit_id":"4b4492e5305e931ccad940cda2befbb21070a5b9"}]}
