)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"d0900844d055313eaeb13af186dbb893faea9874","unresolved":true,"context_lines":[{"line_number":20,"context_line":"package from upload \"directory\"."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Not delete the upload \"directory\" to avoid this error."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Story: 2008862"},{"line_number":25,"context_line":"Task: 45031"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cd5d0564_59e2e8e6","line":23,"updated":"2022-04-12 16:09:43.000000000","message":"I understand how this addresses a bug introduced by afe3b76e6f55d96 [aptly_deb_usage: Remove file folders before upload packages] but it doesn\u0027t describe how the issue that change was attempted to fix is not impacted. Are we just doing circles here?","commit_id":"c6246292d4143463c5920dc3518cd86abaf94263"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"6747fa3119dc9761b656bc95a225abab02104411","unresolved":false,"context_lines":[{"line_number":20,"context_line":"package from upload \"directory\"."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Not delete the upload \"directory\" to avoid this error."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Story: 2008862"},{"line_number":25,"context_line":"Task: 45031"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5b86f154_359d7311","line":23,"in_reply_to":"9ab40a2d_c3803ff7","updated":"2022-04-14 18:50:35.000000000","message":"Thanks for the explanation.","commit_id":"c6246292d4143463c5920dc3518cd86abaf94263"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"8dce6c9a9ed15633b96194109b38fba472b2fcd6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"package from upload \"directory\"."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Not delete the upload \"directory\" to avoid this error."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Story: 2008862"},{"line_number":25,"context_line":"Task: 45031"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ab40a2d_c3803ff7","line":23,"in_reply_to":"cd5d0564_59e2e8e6","updated":"2022-04-12 23:11:55.000000000","message":"HaHa, it is not a circle. :-)\nThe purpose of the previous commit is to fix a bug that a binary package of deb-local-build been placed in deb-local-binary. Before that commit, all repositories share one upload file directory. Suppose we just upload a binary package of deb-local-build, before we insert it into the repository the process been interrupted. That very package file will leave in the upload file directory by thin interruption. Next time when we upload a package into deb-local-binary, this package will also be inserted into deb-local-binary. Commit afe3b76e6f55d96 use different file directory for different repository. Thus deb-local-binary use a file directory called \"deb-local-binary\", while deb-local-build use a file directory called \"deb-local-build\". This can avoid package been inserted into wrong repository. Another modification of that very commit is remove all file directories each time before we upload files to avoid old package file left in it. The purpose of this modification is to make the package-upload more clean. Even the package of this very repository, if the process been interrupted, it will be abandon. While as I said in this commit, this operation is not fit for source package that contains several files. So revert this very part to make it.\nWith this commit, still, packages of repo-A will not been placed into repo-B.","commit_id":"c6246292d4143463c5920dc3518cd86abaf94263"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"1f2ef9b335c497e16af7d65e189fd0a826d1c458","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3bddf08b_6cd469a2","updated":"2022-04-21 03:51:19.000000000","message":"Actually, I do like these two lines that remove the file folder. 😞\nLater I will add them back with another modification, with all related files been uploaded through one function call.","commit_id":"c6246292d4143463c5920dc3518cd86abaf94263"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"8bbfdc71c92871bbfcf85f59b6c993a70ac97434","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8264e573_241f5cae","updated":"2022-04-12 08:19:30.000000000","message":"Later, all files of a source package should be uploaded in one function call. Should not been uploaded one by one:\ndef upload_pkg_local(self, pkg_name, repo_name)\nVs\ndef upload_pkg_local(self, pkg_file, repo_name)\nHere the \"pkg_file\" should be a list instead of one single file(pkg_name).","commit_id":"c6246292d4143463c5920dc3518cd86abaf94263"}]}