)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"d7a7edc9c3b516a4b4d2c7794bcab205b1e8329c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Xiao \u003cxiao.zhang@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-25 16:48:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: aptly_deb_usage: improve the principle in merg_repos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In repo merge operation, for each package, if there are several"},{"line_number":10,"context_line":"versions, we just keep one of them into the destination repository."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dad77336_971e13b9","line":7,"updated":"2022-09-07 20:25:47.000000000","message":"s/principle/principal/\n\nbut in general this shortlog is confusing. Maybe instead use\n\"Debian: aplty_deb_usage: improve package selection in merg_repos\"","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"cf52b5e0ec5d728431d85587bccd0d9d35334bc3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Xiao \u003cxiao.zhang@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-25 16:48:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: aptly_deb_usage: improve the principle in merg_repos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In repo merge operation, for each package, if there are several"},{"line_number":10,"context_line":"versions, we just keep one of them into the destination repository."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f834285_417ae855","line":7,"in_reply_to":"dad77336_971e13b9","updated":"2022-09-08 10:50:37.000000000","message":"Done","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b985edd25d0dc85eec186d3a22cd7b48e24af0c5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Xiao \u003cxiao.zhang@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-08 18:42:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: aplty_deb_usage: improve package selection in merg_repos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In repo merge operation, for each package, if there are several"},{"line_number":10,"context_line":"versions, we just keep one of them into the destination repository."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bc723509_d4e1c718","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":23},"updated":"2022-09-11 17:00:32.000000000","message":"typo:  aptly_deb_usage","commit_id":"85ab76c104f5c795e73738029285f11a13141b7a"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b985edd25d0dc85eec186d3a22cd7b48e24af0c5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Xiao \u003cxiao.zhang@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-08 18:42:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: aplty_deb_usage: improve package selection in merg_repos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In repo merge operation, for each package, if there are several"},{"line_number":10,"context_line":"versions, we just keep one of them into the destination repository."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2332c67b_eb808f6b","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":64},"updated":"2022-09-11 17:00:32.000000000","message":"typo: merge_repos","commit_id":"85ab76c104f5c795e73738029285f11a13141b7a"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"2d3df6f52a38d6046c0c86e262e4c8150882ace5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Xiao \u003cxiao.zhang@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-08 18:42:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: aplty_deb_usage: improve package selection in merg_repos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In repo merge operation, for each package, if there are several"},{"line_number":10,"context_line":"versions, we just keep one of them into the destination repository."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"05aea746_a19174dd","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":64},"in_reply_to":"2332c67b_eb808f6b","updated":"2022-09-13 01:05:47.000000000","message":"Done","commit_id":"85ab76c104f5c795e73738029285f11a13141b7a"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"2d3df6f52a38d6046c0c86e262e4c8150882ace5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Xiao \u003cxiao.zhang@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-08 18:42:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: aplty_deb_usage: improve package selection in merg_repos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In repo merge operation, for each package, if there are several"},{"line_number":10,"context_line":"versions, we just keep one of them into the destination repository."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7d2148e0_770164f4","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":23},"in_reply_to":"bc723509_d4e1c718","updated":"2022-09-13 01:05:47.000000000","message":"Done","commit_id":"85ab76c104f5c795e73738029285f11a13141b7a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"63793177bd70e52e90fe2197568b9de1c65da710","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ac9617e_6c6d68f2","updated":"2022-08-25 09:16:02.000000000","message":"Background: repo merge is used to merge several repositories into one. Designed for LAT\u0027s bootstrap stage. The key reason is bootstrap can only use one repository, without package version specified. So we have to merge related repositories into one and avoid release multi version packages.\n\nOriginal realization just set the priority on repository level. This time we also check the version number: version number contains \"tis\" means local build, it has higher priority; beside that, higher version has higher priority.","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"dc189bf5018bda555f067701167ab46d3bb5cab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35027d3f_a2898ae6","in_reply_to":"2ac9617e_6c6d68f2","updated":"2022-09-07 13:49:24.000000000","message":"\u003e version number contains \"tis\" means local build\nI don\u0027t see any mention of \"tis\" in the change. Did you mean ${STX_DIST} ?","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"cf52b5e0ec5d728431d85587bccd0d9d35334bc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37b687ef_84871ca6","in_reply_to":"35027d3f_a2898ae6","updated":"2022-09-08 10:50:37.000000000","message":"Yes, \".tis\" is the key word. And we store it with environment ${STX_DIST} .","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"}],"build-tools/stx/aptly_deb_usage.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"6ff202a0f7dac93f2a1bfeacd73b3c05b8ffa40f","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# Realization of its real RESTAPI(go)"},{"line_number":22,"context_line":"# https://github.com/molior-dbs/aptly"},{"line_number":23,"context_line":"from aptly_api import Client"},{"line_number":24,"context_line":"from debian import debian_support"},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import time"},{"line_number":27,"context_line":"from typing import Optional"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4e30b18_224ab9aa","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":33},"updated":"2022-09-07 16:45:11.000000000","message":"debian imports come from python-debian python module.\n\nNot strictly required, but you might need to add to the comment above (around line 17)  that now this env:   \u0027Requires python-debian\u0027","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"cf52b5e0ec5d728431d85587bccd0d9d35334bc3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Realization of its real RESTAPI(go)"},{"line_number":22,"context_line":"# https://github.com/molior-dbs/aptly"},{"line_number":23,"context_line":"from aptly_api import Client"},{"line_number":24,"context_line":"from debian import debian_support"},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import time"},{"line_number":27,"context_line":"from typing import Optional"}],"source_content_type":"text/x-python","patch_set":1,"id":"d36212f7_782c9bef","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":33},"in_reply_to":"c4e30b18_224ab9aa","updated":"2022-09-08 10:50:37.000000000","message":"For the comment about aptly_api, it is somehow special and critical. While debian is not. :-)","commit_id":"cd00ec300737eba1526ffc6b1e1d2b4195b0fe33"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"55632f772d544e71aac02041772ea693b5ecc5e4","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    # name : string, the name of new build snapshot"},{"line_number":136,"context_line":"    # source_snapshots: list of snapshots to be merge, order matters, snapshot at front of"},{"line_number":137,"context_line":"    #                   list has higher priority than snapshot later in the list."},{"line_number":138,"context_line":"    # For each package, only the one with higher priority can be selected:"},{"line_number":139,"context_line":"    # String STX_DIST in version has higher priority; Higher version has higher priority."},{"line_number":140,"context_line":"    # Return False on failure"},{"line_number":141,"context_line":"    def __merge_snapshot(self, name, source_snapshots):"},{"line_number":142,"context_line":"        \u0027\u0027\u0027Merge several snapshots into one, prepare for later deploy.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"031c82ae_25d14e9d","line":139,"range":{"start_line":138,"start_character":2,"end_line":139,"end_character":89},"updated":"2022-09-26 19:17:46.000000000","message":"Why?\n\nWe have in the past retired STX built packages in favor of newer upstream packages with higher versions that incorporate fixes we need.  This would seem to block that possibilty.","commit_id":"a7ec51137872f05aa18762e396cb166bf46681d8"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"af63711ceec6c9c98f4d000343ab924478640c0c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # name : string, the name of new build snapshot"},{"line_number":136,"context_line":"    # source_snapshots: list of snapshots to be merge, order matters, snapshot at front of"},{"line_number":137,"context_line":"    #                   list has higher priority than snapshot later in the list."},{"line_number":138,"context_line":"    # For each package, only the one with higher priority can be selected:"},{"line_number":139,"context_line":"    # String STX_DIST in version has higher priority; Higher version has higher priority."},{"line_number":140,"context_line":"    # Return False on failure"},{"line_number":141,"context_line":"    def __merge_snapshot(self, name, source_snapshots):"},{"line_number":142,"context_line":"        \u0027\u0027\u0027Merge several snapshots into one, prepare for later deploy.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f321157_bfe2fca6","line":139,"range":{"start_line":138,"start_character":2,"end_line":139,"end_character":89},"in_reply_to":"031c82ae_25d14e9d","updated":"2022-09-27 03:27:15.000000000","message":"So, for one package, if we have version 3 from Debian upstream and 2.stx been build locally, which one we should choose? I think 2.stx should be chosen.\n\nYou mean we should choose v-3 from upstream?","commit_id":"a7ec51137872f05aa18762e396cb166bf46681d8"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"3301b525a9fe25383f18c20e5b3844f57417ab30","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # name : string, the name of new build snapshot"},{"line_number":136,"context_line":"    # source_snapshots: list of snapshots to be merge, order matters, snapshot at front of"},{"line_number":137,"context_line":"    #                   list has higher priority than snapshot later in the list."},{"line_number":138,"context_line":"    # For each package, only the one with higher priority can be selected:"},{"line_number":139,"context_line":"    # String STX_DIST in version has higher priority; Higher version has higher priority."},{"line_number":140,"context_line":"    # Return False on failure"},{"line_number":141,"context_line":"    def __merge_snapshot(self, name, source_snapshots):"},{"line_number":142,"context_line":"        \u0027\u0027\u0027Merge several snapshots into one, prepare for later deploy.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"a09a5f47_cfa55e45","line":139,"range":{"start_line":138,"start_character":2,"end_line":139,"end_character":89},"in_reply_to":"2f321157_bfe2fca6","updated":"2022-09-28 17:50:20.000000000","message":"Yes, Choose v-3 from upstream.  Ideally you should issue a warning that a stx package has been eclipsed by a higher versioned package from upstream.","commit_id":"a7ec51137872f05aa18762e396cb166bf46681d8"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"d0af9b58febdfa98186420258b69e23f5f4c30a1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # name : string, the name of new build snapshot"},{"line_number":136,"context_line":"    # source_snapshots: list of snapshots to be merge, order matters, snapshot at front of"},{"line_number":137,"context_line":"    #                   list has higher priority than snapshot later in the list."},{"line_number":138,"context_line":"    # For each package, only the one with higher priority can be selected:"},{"line_number":139,"context_line":"    # String STX_DIST in version has higher priority; Higher version has higher priority."},{"line_number":140,"context_line":"    # Return False on failure"},{"line_number":141,"context_line":"    def __merge_snapshot(self, name, source_snapshots):"},{"line_number":142,"context_line":"        \u0027\u0027\u0027Merge several snapshots into one, prepare for later deploy.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2c3538a_77539168","line":139,"range":{"start_line":138,"start_character":2,"end_line":139,"end_character":89},"in_reply_to":"a09a5f47_cfa55e45","updated":"2022-09-29 11:37:47.000000000","message":"Copy. Done.","commit_id":"a7ec51137872f05aa18762e396cb166bf46681d8"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"55632f772d544e71aac02041772ea693b5ecc5e4","unresolved":true,"context_lines":[{"line_number":174,"context_line":"                                if STX_DIST in key_list[2] and debian_support.version_compare(key_list[2], orig_version) \u003e 0:"},{"line_number":175,"context_line":"                                    need_replace \u003d True"},{"line_number":176,"context_line":"                            else:"},{"line_number":177,"context_line":"                                if STX_DIST in key_list[2]:"},{"line_number":178,"context_line":"                                    need_replace \u003d True"},{"line_number":179,"context_line":"                                elif debian_support.version_compare(key_list[2], orig_version) \u003e 0:"},{"line_number":180,"context_line":"                                    need_replace \u003d True"},{"line_number":181,"context_line":"                            if need_replace:"}],"source_content_type":"text/x-python","patch_set":3,"id":"e08eb018_ac8502a9","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":55},"updated":"2022-09-26 19:17:46.000000000","message":"Again why does the presence of \u0027.stx\u0027 in the version override the normal version comparison?","commit_id":"a7ec51137872f05aa18762e396cb166bf46681d8"},{"author":{"_account_id":32651,"name":"ZhangXiao","display_name":"Zhang Xiao","email":"xiao.zhang@windriver.com","username":"xzhang1"},"change_message_id":"d0af9b58febdfa98186420258b69e23f5f4c30a1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                if STX_DIST in key_list[2] and debian_support.version_compare(key_list[2], orig_version) \u003e 0:"},{"line_number":175,"context_line":"                                    need_replace \u003d True"},{"line_number":176,"context_line":"                            else:"},{"line_number":177,"context_line":"                                if STX_DIST in key_list[2]:"},{"line_number":178,"context_line":"                                    need_replace \u003d True"},{"line_number":179,"context_line":"                                elif debian_support.version_compare(key_list[2], orig_version) \u003e 0:"},{"line_number":180,"context_line":"                                    need_replace \u003d True"},{"line_number":181,"context_line":"                            if need_replace:"}],"source_content_type":"text/x-python","patch_set":3,"id":"864f8952_d1113c58","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":55},"in_reply_to":"e08eb018_ac8502a9","updated":"2022-09-29 11:37:47.000000000","message":"Done","commit_id":"a7ec51137872f05aa18762e396cb166bf46681d8"}]}
