)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34021,"name":"Luis Sampaio","display_name":"Luis Sampaio","email":"luis.sampaio@windriver.com","username":"lsampaio"},"change_message_id":"f799e1c873a3c979349db2b445202e2e58187368","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"325952b0_02fd10d8","updated":"2023-03-02 19:17:42.000000000","message":"@Yue, I was checking this review and I think your update will throw an error because this package has src_path and src_files and the src_files are in a different git so when it does the rev-count it won\u0027t find the sha in the src_file dir:\nhttps://review.opendev.org/c/starlingx/oidc-auth-armada-app/+/875008\n\n","commit_id":"a608480725d57a4877066952707495859ecb7268"},{"author":{"_account_id":32685,"name":"Yue Tao","display_name":"Yue Tao","email":"yue.tao@windriver.com","username":"ytao"},"change_message_id":"7d4b0f1f25dc5e77fa9167d58d88d791d5a3fdd3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f08ec02b_663407ad","in_reply_to":"325952b0_02fd10d8","updated":"2023-03-03 01:55:53.000000000","message":"I am not aware both src_path and src_files are defined in meta_data, and src_files in in different git. Hold on this review. I will think how to cover this situation.","commit_id":"a608480725d57a4877066952707495859ecb7268"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"83f7ccf337ee72993ef937ae3c809871b5e3d81b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"33f3155d_653da63c","updated":"2023-03-10 13:18:44.000000000","message":"If Luis is OK with this approach, so am I","commit_id":"16a8d89c370fedc840e652e392d2ac56e1b1bd3b"}],"build-tools/stx/debrepack.py":[{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"f2e3e0060c17bbaa3bdd22560bcbcabdb1ad80a3","unresolved":true,"context_lines":[{"line_number":300,"context_line":"            revision +\u003d int(run_shell_cmd(git_status % self.pkginfo[\"debfolder\"], self.logger))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if \"SRC_GITREVCOUNT\" in revision_data:"},{"line_number":303,"context_line":"            if \"src_path\" not in self.meta_data:"},{"line_number":304,"context_line":"                self.logger.error(\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":305,"context_line":"                raise Exception(f\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":306,"context_line":"            src_path \u003d self.meta_data[\"src_path\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"40c2bc33_267909c8","side":"PARENT","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":47},"updated":"2023-02-28 14:36:21.000000000","message":"I think the sense of this test should be maintained but for both src_path and src_files combined - one or the other or both should be present.","commit_id":"c110a016bc9a23cf09da2100235c2c120559beb1"},{"author":{"_account_id":32685,"name":"Yue Tao","display_name":"Yue Tao","email":"yue.tao@windriver.com","username":"ytao"},"change_message_id":"1c17052b7c852198c54a7ec9412a84633fb8d7c4","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            revision +\u003d int(run_shell_cmd(git_status % self.pkginfo[\"debfolder\"], self.logger))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if \"SRC_GITREVCOUNT\" in revision_data:"},{"line_number":303,"context_line":"            if \"src_path\" not in self.meta_data:"},{"line_number":304,"context_line":"                self.logger.error(\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":305,"context_line":"                raise Exception(f\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":306,"context_line":"            src_path \u003d self.meta_data[\"src_path\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"8d8dc4a2_0397278e","side":"PARENT","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":47},"in_reply_to":"40c2bc33_267909c8","updated":"2023-03-01 06:15:28.000000000","message":"I intends to remove the \"src_path\". If neither \"src_path\" nor \"src_files\" in meta_data.yaml, it does nothing rather than raising a failure. The SRC_BASE_SRCREV is mandatory.","commit_id":"c110a016bc9a23cf09da2100235c2c120559beb1"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"016fd2631c69bbb520c00bc00b5ee803f0067ca0","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            revision +\u003d int(run_shell_cmd(git_status % self.pkginfo[\"debfolder\"], self.logger))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if \"SRC_GITREVCOUNT\" in revision_data:"},{"line_number":303,"context_line":"            if \"src_path\" not in self.meta_data:"},{"line_number":304,"context_line":"                self.logger.error(\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":305,"context_line":"                raise Exception(f\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":306,"context_line":"            src_path \u003d self.meta_data[\"src_path\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"e0c62e95_bba4ade7","side":"PARENT","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":47},"in_reply_to":"8d8dc4a2_0397278e","updated":"2023-03-01 13:33:33.000000000","message":"Why do you intend to do this?\n\nIt be more helpful to let the author know they made a mistake.","commit_id":"c110a016bc9a23cf09da2100235c2c120559beb1"},{"author":{"_account_id":32685,"name":"Yue Tao","display_name":"Yue Tao","email":"yue.tao@windriver.com","username":"ytao"},"change_message_id":"193a3380a9c2bfb2087bc218550be95ea67ccb9f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            revision +\u003d int(run_shell_cmd(git_status % self.pkginfo[\"debfolder\"], self.logger))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if \"SRC_GITREVCOUNT\" in revision_data:"},{"line_number":303,"context_line":"            if \"src_path\" not in self.meta_data:"},{"line_number":304,"context_line":"                self.logger.error(\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":305,"context_line":"                raise Exception(f\"SRC_GITREVCOUNT is set, but no \\\"src_path\\\" in meta_data.yaml\")"},{"line_number":306,"context_line":"            src_path \u003d self.meta_data[\"src_path\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c101590_4e600e72","side":"PARENT","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":47},"in_reply_to":"e0c62e95_bba4ade7","updated":"2023-03-02 15:44:48.000000000","message":"I added it back.","commit_id":"c110a016bc9a23cf09da2100235c2c120559beb1"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"2e54e853c22ce9a228bbd3ccf783e75d0c3d4513","unresolved":true,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            files_commits \u003d dict()"},{"line_number":313,"context_line":"            for i in range(0, len(self.meta_data[\"src_files\"])):"},{"line_number":314,"context_line":"                f  \u003d self.meta_data[\"src_files\"][i]"},{"line_number":315,"context_line":"                if os.path.isfile(f):"},{"line_number":316,"context_line":"                    f \u003d os.path.dirname(f)"},{"line_number":317,"context_line":"                if f not in files_commits:"}],"source_content_type":"text/x-python","patch_set":6,"id":"62868ca9_600eae97","line":314,"range":{"start_line":314,"start_character":18,"end_line":314,"end_character":19},"updated":"2023-03-03 20:42:40.000000000","message":"extra space should prompt a linter error... but zuul seems happy.\n\nThe algorithm looks good to me.","commit_id":"5d2a41fc8248339492b283d601d0bdddf003ee87"},{"author":{"_account_id":32685,"name":"Yue Tao","display_name":"Yue Tao","email":"yue.tao@windriver.com","username":"ytao"},"change_message_id":"78c32dd8f231a7ff755eac1147dc4a5a98b0409c","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            files_commits \u003d dict()"},{"line_number":313,"context_line":"            for i in range(0, len(self.meta_data[\"src_files\"])):"},{"line_number":314,"context_line":"                f  \u003d self.meta_data[\"src_files\"][i]"},{"line_number":315,"context_line":"                if os.path.isfile(f):"},{"line_number":316,"context_line":"                    f \u003d os.path.dirname(f)"},{"line_number":317,"context_line":"                if f not in files_commits:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a11102c9_ddd006c1","line":314,"range":{"start_line":314,"start_character":18,"end_line":314,"end_character":19},"in_reply_to":"62868ca9_600eae97","updated":"2023-03-06 02:05:13.000000000","message":"Done","commit_id":"5d2a41fc8248339492b283d601d0bdddf003ee87"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"83f7ccf337ee72993ef937ae3c809871b5e3d81b","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        if \"FILES_GITREVCOUNT\" in revision_data:"},{"line_number":303,"context_line":"            if \"src_files\" not in self.meta_data:"},{"line_number":304,"context_line":"                self.logger.error(\"FILES_GITREVCOUNT is set, but no \\\"src_files\\\" in meta_data.yaml\")"},{"line_number":305,"context_line":"                raise Exception(f\"FILES_GITREVCOUNT is set, but no \\\"src_files\\\" in meta_data.yaml\")"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            base_commits \u003d revision_data[\"FILES_GITREVCOUNT\"]"},{"line_number":308,"context_line":"            if len(self.meta_data[\"src_files\"]) \u003e len(base_commits):"}],"source_content_type":"text/x-python","patch_set":7,"id":"0df7c2b3_5d85c21a","line":305,"range":{"start_line":305,"start_character":32,"end_line":305,"end_character":33},"updated":"2023-03-10 13:18:44.000000000","message":"nit: you are sometimes using f-strings and sometimes not.  see the line 304 and 309\nNote that none of your f-strings are actually using {var}  \npylint would report that as  f-string-without-interpolation","commit_id":"16a8d89c370fedc840e652e392d2ac56e1b1bd3b"}]}