)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2b2e6d90b9a7fe001994ca248a74b51b6f39871b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stefan Dinescu \u003cstefan.dinescu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-07 12:41:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make Ceph an optional service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes in this commit:"},{"line_number":10,"context_line":"- create by default SM storage-groups"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_15e9b716","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"updated":"2020-02-11 05:47:12.000000000","message":"nit: Make Ceph storage backend optional","commit_id":"5ce94646336364a40ee4037d3e4c4eed7a51b94f"}],"puppet-manifests/src/modules/platform/manifests/ceph.pp":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2b2e6d90b9a7fe001994ca248a74b51b6f39871b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"      ensure       \u003d\u003e present,"},{"line_number":209,"context_line":"      volume_group \u003d\u003e $::platform::filesystem::params::vg_name,"},{"line_number":210,"context_line":"      size         \u003d\u003e \"${mon_lv_size_reserved}G\","},{"line_number":211,"context_line":"    } -\u003e Class[\u0027platform::filesystem::docker\u0027]"},{"line_number":212,"context_line":"  }"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"  if $configure_ceph_mon {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_35c7139a","side":"PARENT","line":211,"range":{"start_line":211,"start_character":6,"end_line":211,"end_character":46},"updated":"2020-02-11 05:47:12.000000000","message":"Q: Why are we removing these docker dependencies for the worker?","commit_id":"4f7f40c8609c92dd42251b3901891ad66fd0afdc"},{"author":{"_account_id":28707,"name":"Stefan Dinescu","email":"stefan.dinescu@windriver.com","username":"stefan.dinescu"},"change_message_id":"d66bf2ded877dde786094840d294a4c88e9216af","unresolved":false,"context_lines":[{"line_number":208,"context_line":"      ensure       \u003d\u003e present,"},{"line_number":209,"context_line":"      volume_group \u003d\u003e $::platform::filesystem::params::vg_name,"},{"line_number":210,"context_line":"      size         \u003d\u003e \"${mon_lv_size_reserved}G\","},{"line_number":211,"context_line":"    } -\u003e Class[\u0027platform::filesystem::docker\u0027]"},{"line_number":212,"context_line":"  }"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"  if $configure_ceph_mon {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_139a2f5f","side":"PARENT","line":211,"range":{"start_line":211,"start_character":6,"end_line":211,"end_character":46},"in_reply_to":"3fa7e38b_35c7139a","updated":"2020-02-11 08:53:22.000000000","message":"I remember I had some issue with this dependency.\n\nI also looked around the code and saw no reason for this dependency in particular as it shouldn\u0027t matter in what order LVs are created.\n\nAlso asked ovidiu about this and he said he didn\u0027t know either why this dependency is present. If you happen to know why the dependency is needed, I will put it back and re-test.","commit_id":"4f7f40c8609c92dd42251b3901891ad66fd0afdc"}],"puppet-manifests/src/modules/platform/manifests/sm.pp":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2b2e6d90b9a7fe001994ca248a74b51b6f39871b","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    command \u003d\u003e \u0027sm-provision service registry-token-server\u0027,"},{"line_number":673,"context_line":"  }"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"  # Even when ceph is not configured, service domain members must be present"},{"line_number":676,"context_line":"  # because we can\u0027t configure them at runtime."},{"line_number":677,"context_line":"  exec { \u0027Provision (service-domain-member storage-services)\u0027:"},{"line_number":678,"context_line":"    command \u003d\u003e \u0027sm-provision service-domain-member controller storage-services\u0027,"},{"line_number":679,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_151e970e","line":676,"range":{"start_line":675,"start_character":1,"end_line":676,"end_character":47},"updated":"2020-02-11 05:47:12.000000000","message":"If we didn\u0027t do this then we would still have to restart SM in order to provision these during runtime?","commit_id":"5ce94646336364a40ee4037d3e4c4eed7a51b94f"},{"author":{"_account_id":28707,"name":"Stefan Dinescu","email":"stefan.dinescu@windriver.com","username":"stefan.dinescu"},"change_message_id":"d66bf2ded877dde786094840d294a4c88e9216af","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    command \u003d\u003e \u0027sm-provision service registry-token-server\u0027,"},{"line_number":673,"context_line":"  }"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"  # Even when ceph is not configured, service domain members must be present"},{"line_number":676,"context_line":"  # because we can\u0027t configure them at runtime."},{"line_number":677,"context_line":"  exec { \u0027Provision (service-domain-member storage-services)\u0027:"},{"line_number":678,"context_line":"    command \u003d\u003e \u0027sm-provision service-domain-member controller storage-services\u0027,"},{"line_number":679,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_d39fb74b","line":676,"range":{"start_line":675,"start_character":1,"end_line":676,"end_character":47},"in_reply_to":"3fa7e38b_151e970e","updated":"2020-02-11 08:53:22.000000000","message":"Yes, exactly. SM supports runtime-provisoning of services, not service groups.","commit_id":"5ce94646336364a40ee4037d3e4c4eed7a51b94f"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2b2e6d90b9a7fe001994ca248a74b51b6f39871b","unresolved":false,"context_lines":[{"line_number":996,"context_line":"}"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"class platform::sm::ceph::runtime {"},{"line_number":999,"context_line":"  $ceph_configured               \u003d $::platform::ceph::params::service_enabled"},{"line_number":1000,"context_line":"  $system_mode                   \u003d $::platform::params::system_mode"},{"line_number":1001,"context_line":"  $system_type                   \u003d $::platform::params::system_type"},{"line_number":1002,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_75bb4be3","line":999,"range":{"start_line":999,"start_character":19,"end_line":999,"end_character":33},"updated":"2020-02-11 05:47:12.000000000","message":"nit: excessive spaces...","commit_id":"5ce94646336364a40ee4037d3e4c4eed7a51b94f"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2b2e6d90b9a7fe001994ca248a74b51b6f39871b","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"    -\u003e exec { \u0027Provision Ceph-Manager --apply (service-group-member ceph-manager)\u0027:"},{"line_number":1025,"context_line":"      command \u003d\u003e \u0027sm-provision service-group-member storage-monitoring-services ceph-manager --apply\u0027,"},{"line_number":1026,"context_line":"    }"},{"line_number":1027,"context_line":"    # The wait is 120 seconds because the standby controller finished applying manifests much faster"},{"line_number":1028,"context_line":"    # and has to wait for the active controller to also reach this point. The active controller"},{"line_number":1029,"context_line":"    # usually waits here for about 20 seconds, while the standby has to wait for about 60 seconds."},{"line_number":1030,"context_line":"    # Putting the actual timeout to 120 is a safety measure and in 99% of cases it will not wait that long."},{"line_number":1031,"context_line":"    -\u003e exec { \u0027Wait for mgr-restful-plugin to be configured\u0027:"},{"line_number":1032,"context_line":"      command   \u003d\u003e \u0027for i in $(seq 1 12); do ceph config-key get mgr/restful/keys/admin \u0026\u0026 \\"},{"line_number":1033,"context_line":"                    rc\u003d0 \u0026\u0026 break || rc\u003d$? \u0026\u0026 sleep 10; done; (exit $rc)\u0027,"},{"line_number":1034,"context_line":"      provider  \u003d\u003e shell,"},{"line_number":1035,"context_line":"      logoutput \u003d\u003e true,"},{"line_number":1036,"context_line":"    }"},{"line_number":1037,"context_line":"  }"},{"line_number":1038,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_b56a234d","line":1036,"range":{"start_line":1027,"start_character":0,"end_line":1036,"end_character":5},"updated":"2020-02-11 05:47:12.000000000","message":"Since puppet applies are serialized, I don\u0027t think we should be blocking this here.\n\nWhat happens if we don\u0027t wait for it here and instead move it to the _init_ceph_cluster_info() greenthread in the sysinv conductor? In there we can wait 120s and then raise an alarm, set the storage backend to error, and exit the green thread.","commit_id":"5ce94646336364a40ee4037d3e4c4eed7a51b94f"},{"author":{"_account_id":28707,"name":"Stefan Dinescu","email":"stefan.dinescu@windriver.com","username":"stefan.dinescu"},"change_message_id":"d66bf2ded877dde786094840d294a4c88e9216af","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"    -\u003e exec { \u0027Provision Ceph-Manager --apply (service-group-member ceph-manager)\u0027:"},{"line_number":1025,"context_line":"      command \u003d\u003e \u0027sm-provision service-group-member storage-monitoring-services ceph-manager --apply\u0027,"},{"line_number":1026,"context_line":"    }"},{"line_number":1027,"context_line":"    # The wait is 120 seconds because the standby controller finished applying manifests much faster"},{"line_number":1028,"context_line":"    # and has to wait for the active controller to also reach this point. The active controller"},{"line_number":1029,"context_line":"    # usually waits here for about 20 seconds, while the standby has to wait for about 60 seconds."},{"line_number":1030,"context_line":"    # Putting the actual timeout to 120 is a safety measure and in 99% of cases it will not wait that long."},{"line_number":1031,"context_line":"    -\u003e exec { \u0027Wait for mgr-restful-plugin to be configured\u0027:"},{"line_number":1032,"context_line":"      command   \u003d\u003e \u0027for i in $(seq 1 12); do ceph config-key get mgr/restful/keys/admin \u0026\u0026 \\"},{"line_number":1033,"context_line":"                    rc\u003d0 \u0026\u0026 break || rc\u003d$? \u0026\u0026 sleep 10; done; (exit $rc)\u0027,"},{"line_number":1034,"context_line":"      provider  \u003d\u003e shell,"},{"line_number":1035,"context_line":"      logoutput \u003d\u003e true,"},{"line_number":1036,"context_line":"    }"},{"line_number":1037,"context_line":"  }"},{"line_number":1038,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_b3bb1bbd","line":1036,"range":{"start_line":1027,"start_character":0,"end_line":1036,"end_character":5},"in_reply_to":"3fa7e38b_b56a234d","updated":"2020-02-11 08:53:22.000000000","message":"I don\u0027t think this part is needed anymore since the conductor greenthread introduced for CephOperator already retries until ceph rest api is responsive.\n\nThis function was a workaround because sysinv expected ceph to respond immediately when configured at runtime, otherwise it would generate a lot of exceptions.","commit_id":"5ce94646336364a40ee4037d3e4c4eed7a51b94f"}]}