)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"93873533e65dd3ee3fc0cd2eebc2f560a6e69406","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change includes:"},{"line_number":10,"context_line":"1. create aio.pp for AIO controller nodes"},{"line_number":11,"context_line":"2. execute aio.pp for nodes with subfunctions of \u0027controller,worker\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54b90a76454c6c545bf2891b81225bbf2ba15b03"},{"line_number":14,"context_line":"Partial-Bug: 1918139"},{"line_number":15,"context_line":"Signed-off-by: Bin Qian \u003cbin.qian@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ec2f4a55_4b9bee03","line":12,"updated":"2021-03-17 21:44:49.000000000","message":"These following should also be verified with these changes; since the following also call puppet-manifest-apply.sh:\n* upgrade from N-1 release to this\n* backup and restore AIO  (though playbookconfig/src/playbooks/rols/recover-ceph-data/tasks/main.yml appears to reference as \u0027controller\u0027 only","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"36f14116a45677c5674b374ab398d06a5c57075a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change includes:"},{"line_number":10,"context_line":"1. create aio.pp for AIO controller nodes"},{"line_number":11,"context_line":"2. execute aio.pp for nodes with subfunctions of \u0027controller,worker\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54b90a76454c6c545bf2891b81225bbf2ba15b03"},{"line_number":14,"context_line":"Partial-Bug: 1918139"},{"line_number":15,"context_line":"Signed-off-by: Bin Qian \u003cbin.qian@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"0e82dc36_f797343e","line":12,"updated":"2021-04-12 14:19:51.000000000","message":"This should also mention that some key dependencies to require SRiIOV device plugin restart are no longer needed with the move to AIO manifest  (i.e. see commit ca6546f56 \"Enable SR-IOV device plugin restart\")","commit_id":"8e10c9d21868d2267fad503861bdc32a8676e8b2"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"28119264e988c739538d6af178d2b91242b68a85","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change includes:"},{"line_number":10,"context_line":"1. create aio.pp for AIO controller nodes"},{"line_number":11,"context_line":"2. execute aio.pp for nodes with subfunctions of \u0027controller,worker\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I54b90a76454c6c545bf2891b81225bbf2ba15b03"},{"line_number":14,"context_line":"Partial-Bug: 1918139"},{"line_number":15,"context_line":"Signed-off-by: Bin Qian \u003cbin.qian@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"12855aea_e244cc3d","line":12,"in_reply_to":"0e82dc36_f797343e","updated":"2021-04-13 20:50:27.000000000","message":"I see this comment from John now, which would explain why some SRIOV stuff is removed in the update. Please add this to the commit message description, as John requested.","commit_id":"8e10c9d21868d2267fad503861bdc32a8676e8b2"}],"a.diff":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da101e76_2b59a314","updated":"2021-03-18 19:42:00.000000000","message":"Looks like this was included by mistake.","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f59fec61_90b34085","in_reply_to":"da101e76_2b59a314","updated":"2021-03-31 14:09:35.000000000","message":"Done","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"}],"puppet-manifests/src/bin/puppet-manifest-apply.sh":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"93873533e65dd3ee3fc0cd2eebc2f560a6e69406","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"HIERADATA\u003d$1"},{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfuncions, seperated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"IFS\u003d, read PERSONALITY SUBFUNCTION \u003c\u003c\u003c $SUBFUNCTIONS"},{"line_number":21,"context_line":"if [ \"${SUBFUNCTION}\" \u003d \"worker\" ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"454e6676_89e0e9da","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":51},"updated":"2021-03-17 21:44:49.000000000","message":"nit: separated","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"2235f0bc2d0b8d650d7024609d9d8e23f5ae2ad6","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"HIERADATA\u003d$1"},{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfuncions, seperated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"IFS\u003d, read PERSONALITY SUBFUNCTION \u003c\u003c\u003c $SUBFUNCTIONS"},{"line_number":21,"context_line":"if [ \"${SUBFUNCTION}\" \u003d \"worker\" ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ac7c1288_7f2921b0","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":39},"updated":"2021-03-18 15:06:56.000000000","message":"typo: subfunctions","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"2235f0bc2d0b8d650d7024609d9d8e23f5ae2ad6","unresolved":true,"context_lines":[{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfuncions, seperated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"IFS\u003d, read PERSONALITY SUBFUNCTION \u003c\u003c\u003c $SUBFUNCTIONS"},{"line_number":21,"context_line":"if [ \"${SUBFUNCTION}\" \u003d \"worker\" ]; then"},{"line_number":22,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":23,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6bc3cc31_70fdad3a","line":20,"updated":"2021-03-18 15:06:56.000000000","message":"Why not just check \"${SUBFUNCTIONS}\" \u003d \"controller,worker\" like you\u0027ve done further below?","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfuncions, seperated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"IFS\u003d, read PERSONALITY SUBFUNCTION \u003c\u003c\u003c $SUBFUNCTIONS"},{"line_number":21,"context_line":"if [ \"${SUBFUNCTION}\" \u003d \"worker\" ]; then"},{"line_number":22,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":23,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fc4d39de_8376b581","line":20,"in_reply_to":"6bc3cc31_70fdad3a","updated":"2021-03-31 14:09:35.000000000","message":"yes, I can do that","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"93873533e65dd3ee3fc0cd2eebc2f560a6e69406","unresolved":true,"context_lines":[{"line_number":27,"context_line":"RUNTIMEDATA\u003d$5"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"logger -t $0 \"puppet-manifest-apply ${HIERADATA} ${HOST} ${PERSONALITY} ${MANIFEST} ${RUNTIMEDATA}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"PUPPET_MODULES_PATH\u003d/usr/share/puppet/modules:/usr/share/openstack-puppet/modules"}],"source_content_type":"text/x-sh","patch_set":2,"id":"0c0a7a77_91e647cd","line":30,"range":{"start_line":30,"start_character":59,"end_line":30,"end_character":70},"updated":"2021-03-17 21:44:49.000000000","message":"consider also logging ${SUBFUNCTIONS}","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":28439,"name":"Matt Peters","email":"matt.peters@windriver.com","username":"mpeters-wrs"},"change_message_id":"90251a13ccd9bc0f9a228832f50f0865bdfea3fc","unresolved":true,"context_lines":[{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfunctions, separated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"if [ \"${SUBFUNCTIONS}\" \u003d \"controller,worker\" ]; then"},{"line_number":21,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":22,"context_line":"    PERSONALITY\u003d\u0027controller\u0027"},{"line_number":23,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"4486a13e_d47533cb","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":52},"updated":"2021-03-30 20:56:02.000000000","message":"This would need to check for separate subfunctions since the current check will fail the lowlatency profile.","commit_id":"83f3c69e9b9015554ae9f5b6cdfcba9b4ab9c810"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"893d27a8532ac5ea37bb1981c9ea6984e8d00430","unresolved":false,"context_lines":[{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfunctions, separated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"if [ \"${SUBFUNCTIONS}\" \u003d \"controller,worker\" ]; then"},{"line_number":21,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":22,"context_line":"    PERSONALITY\u003d\u0027controller\u0027"},{"line_number":23,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"b9063ee8_864cdd46","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":52},"in_reply_to":"4486a13e_d47533cb","updated":"2021-03-31 17:19:46.000000000","message":"lowlatency does not have a separate manifest, controller_config calls puppet-manifest-apply.sh with subfunctions either \"controller\" or \"controller,worker\".","commit_id":"83f3c69e9b9015554ae9f5b6cdfcba9b4ab9c810"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"22757293cce34a2e15e4c8324842b95096c0624b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfunctions, separated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"if [ \"${SUBFUNCTIONS}\" \u003d \"controller,worker\" ]; then"},{"line_number":21,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":22,"context_line":"    PERSONALITY\u003d\u0027controller\u0027"},{"line_number":23,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"68b81b60_7066e858","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":52},"in_reply_to":"5fb167f7_cf8dff6d","updated":"2021-04-05 18:57:43.000000000","message":"Done","commit_id":"83f3c69e9b9015554ae9f5b6cdfcba9b4ab9c810"},{"author":{"_account_id":28439,"name":"Matt Peters","email":"matt.peters@windriver.com","username":"mpeters-wrs"},"change_message_id":"0003ca4d0b23a0f9d5d777977c4156a292e65e66","unresolved":true,"context_lines":[{"line_number":17,"context_line":"HOST\u003d$2"},{"line_number":18,"context_line":"# subfunctions is a list of subfunctions, separated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"if [ \"${SUBFUNCTIONS}\" \u003d \"controller,worker\" ]; then"},{"line_number":21,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":22,"context_line":"    PERSONALITY\u003d\u0027controller\u0027"},{"line_number":23,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5fb167f7_cf8dff6d","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":52},"in_reply_to":"b9063ee8_864cdd46","updated":"2021-03-31 19:40:22.000000000","message":"SUBFUNCTIONS would have the value \"controller,worker,lowlatency\" and would not be caught in this condition resulting in only the controller manifest to be applied.","commit_id":"83f3c69e9b9015554ae9f5b6cdfcba9b4ab9c810"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":18,"context_line":"# subfunctions is a list of subfunctions, separated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"IFS\u003d, read PERSONALITY SUBFUNCTION \u003c\u003c\u003c $SUBFUNCTIONS"},{"line_number":21,"context_line":"if [ \"${SUBFUNCTION}\" \u003d \"worker\" ]; then"},{"line_number":22,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":23,"context_line":"else"},{"line_number":24,"context_line":"    PERSONALITY\u003d${SUBFUNCTIONS}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"6820cf1c_8d88ea23","line":21,"updated":"2021-04-13 20:48:50.000000000","message":"What about lowlatency AIO? In platform.conf, its subfunctions list would be \"controller,worker,lowlatency\". I guess this code is predicated on lowlatency not being included in the subfunction list passed to the apply script?","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":true,"context_lines":[{"line_number":18,"context_line":"# subfunctions is a list of subfunctions, separated by comma"},{"line_number":19,"context_line":"SUBFUNCTIONS\u003d$3"},{"line_number":20,"context_line":"IFS\u003d, read PERSONALITY SUBFUNCTION \u003c\u003c\u003c $SUBFUNCTIONS"},{"line_number":21,"context_line":"if [ \"${SUBFUNCTION}\" \u003d \"worker\" ]; then"},{"line_number":22,"context_line":"    MANIFEST\u003d\"aio\""},{"line_number":23,"context_line":"else"},{"line_number":24,"context_line":"    PERSONALITY\u003d${SUBFUNCTIONS}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"03359f23_5cc6e049","line":21,"in_reply_to":"6820cf1c_8d88ea23","updated":"2021-04-14 03:03:04.000000000","message":"Currently caller only passes \u0027controller\u0027 or \u0027controller,worker\u0027 here. so it is ok. But I will make the change to avoid a hidden bug for the future.","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":66,"context_line":"cp /etc/puppet/hieradata/global.yaml ${PUPPET_TMP}/hieradata/global.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [ \"${MANIFEST}\" \u003d \u0027aio\u0027 ]; then"},{"line_number":69,"context_line":"    cat /etc/puppet/hieradata/controller.yaml /etc/puppet/hieradata/worker.yaml \u003e ${PUPPET_TMP}/hieradata/personality.yaml"},{"line_number":70,"context_line":"else"},{"line_number":71,"context_line":"    cp /etc/puppet/hieradata/${PERSONALITY}.yaml ${PUPPET_TMP}/hieradata/personality.yaml"},{"line_number":72,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ce93d684_41f46ff3","line":69,"updated":"2021-04-13 20:48:50.000000000","message":"Is there potential for conflicts here? If a value is in both controller.yaml and worker.yaml, does the worker.yaml value override the controller.yaml?","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":true,"context_lines":[{"line_number":66,"context_line":"cp /etc/puppet/hieradata/global.yaml ${PUPPET_TMP}/hieradata/global.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [ \"${MANIFEST}\" \u003d \u0027aio\u0027 ]; then"},{"line_number":69,"context_line":"    cat /etc/puppet/hieradata/controller.yaml /etc/puppet/hieradata/worker.yaml \u003e ${PUPPET_TMP}/hieradata/personality.yaml"},{"line_number":70,"context_line":"else"},{"line_number":71,"context_line":"    cp /etc/puppet/hieradata/${PERSONALITY}.yaml ${PUPPET_TMP}/hieradata/personality.yaml"},{"line_number":72,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"60e7cfcd_e8641262","line":69,"in_reply_to":"ce93d684_41f46ff3","updated":"2021-04-14 03:03:04.000000000","message":"Thanks for the yaml that the later value silently overwrites the previous ones. As long as we don\u0027t use the same key on controller and worker manifest for different purpose then it should be fine.","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"}],"puppet-manifests/src/manifests/aio.pp":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"93873533e65dd3ee3fc0cd2eebc2f560a6e69406","unresolved":true,"context_lines":[{"line_number":101,"context_line":"include ::platform::pciirqaffinity"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"include ::platform::lvm::compute"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class { \u0027::platform::config::aio::post\u0027:"},{"line_number":107,"context_line":"  stage \u003d\u003e post,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"997b61eb_ca366743","line":104,"updated":"2021-03-17 21:44:49.000000000","message":"in worker.pp this was above \u0027include ::platform::compute\u0027 ?\n\nAlso, the following are in worker.pp - are they required in aio.pp?\n::platform::kubernetes::worker\n::platform::ceph::worker\n::platform::rook","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":32,"context_line":"include ::platform::grub"},{"line_number":33,"context_line":"include ::platform::etcd"},{"line_number":34,"context_line":"include ::platform::docker::controller"},{"line_number":35,"context_line":"include ::platform::dockerdistribution"},{"line_number":36,"context_line":"include ::platform::containerd::controller"},{"line_number":37,"context_line":"include ::platform::kubernetes::master"},{"line_number":38,"context_line":"include ::platform::helm"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"86c8a7c0_d03c5b9c","line":35,"updated":"2021-03-18 19:42:00.000000000","message":"Looks like AIO hosts would have had ::platform::docker::login as well - is that no longer needed?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"include ::platform::grub"},{"line_number":33,"context_line":"include ::platform::etcd"},{"line_number":34,"context_line":"include ::platform::docker::controller"},{"line_number":35,"context_line":"include ::platform::dockerdistribution"},{"line_number":36,"context_line":"include ::platform::containerd::controller"},{"line_number":37,"context_line":"include ::platform::kubernetes::master"},{"line_number":38,"context_line":"include ::platform::helm"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"087467c8_e42c7cc3","line":35,"in_reply_to":"86c8a7c0_d03c5b9c","updated":"2021-03-31 14:09:35.000000000","message":"Done","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":36,"context_line":"include ::platform::containerd::controller"},{"line_number":37,"context_line":"include ::platform::kubernetes::master"},{"line_number":38,"context_line":"include ::platform::helm"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"include ::platform::patching"},{"line_number":41,"context_line":"include ::platform::patching::api"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e06006cd_514b79c7","line":39,"updated":"2021-03-18 19:42:00.000000000","message":"Looks like you removed ::platform::armada - was that intentional?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"include ::platform::containerd::controller"},{"line_number":37,"context_line":"include ::platform::kubernetes::master"},{"line_number":38,"context_line":"include ::platform::helm"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"include ::platform::patching"},{"line_number":41,"context_line":"include ::platform::patching::api"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e9ae6f79_a4ebe1ac","line":39,"in_reply_to":"e06006cd_514b79c7","updated":"2021-03-31 14:09:35.000000000","message":"Done","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"042b62584c163a5de3f4de67c6bf28af4a936ecb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"include ::platform::containerd::controller"},{"line_number":37,"context_line":"include ::platform::kubernetes::master"},{"line_number":38,"context_line":"include ::platform::helm"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"include ::platform::patching"},{"line_number":41,"context_line":"include ::platform::patching::api"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"85cb44c2_cfa0646c","line":39,"in_reply_to":"e9ae6f79_a4ebe1ac","updated":"2021-04-06 15:58:04.000000000","message":"What did you do?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":92,"context_line":"include ::platform::sm"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"include ::platform::lmon"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"include ::platform::compute"},{"line_number":97,"context_line":"include ::platform::vswitch"},{"line_number":98,"context_line":"include ::platform::devices"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"c31819b3_864edcc4","line":95,"updated":"2021-03-18 19:42:00.000000000","message":"Looks like you removed ::platform::rook and ::platform::deviceimage - was that intentional?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"include ::platform::sm"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"include ::platform::lmon"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"include ::platform::compute"},{"line_number":97,"context_line":"include ::platform::vswitch"},{"line_number":98,"context_line":"include ::platform::devices"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5fe409e0_5c961868","line":95,"in_reply_to":"c31819b3_864edcc4","updated":"2021-03-31 14:09:35.000000000","message":"Done","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"Exec {"},{"line_number":3,"context_line":"  timeout \u003d\u003e 900,"},{"line_number":4,"context_line":"  path \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"d7754c76_a9308a30","line":1,"updated":"2021-04-13 20:48:50.000000000","message":"Missing initial comment block, which the other manifests in this dir have","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"Exec {"},{"line_number":3,"context_line":"  timeout \u003d\u003e 900,"},{"line_number":4,"context_line":"  path \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"784ba9ee_9ecfb468","line":1,"in_reply_to":"d7754c76_a9308a30","updated":"2021-04-14 03:03:04.000000000","message":"Done","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"Exec {"},{"line_number":3,"context_line":"  timeout \u003d\u003e 900,"},{"line_number":4,"context_line":"  path \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin\u0027"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"d125c0aa_5d1028b4","line":3,"updated":"2021-04-13 20:48:50.000000000","message":"maybe a comment about why timeout is 15 minutes on AIO, where controller is just 10","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"3326a4dafa01984d64fa8f5662373dd2cbb92690","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"Exec {"},{"line_number":3,"context_line":"  timeout \u003d\u003e 900,"},{"line_number":4,"context_line":"  path \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin\u0027"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"d35dfdde_05739843","line":3,"in_reply_to":"315bf4b8_ddf9c5f3","updated":"2021-04-15 14:31:35.000000000","message":"That\u0027s not what this timeout is. This timeout is setting the default timeout on individual \"exec\" resources, not the overall timeout for applying the full manifest. The timeout on controller was set to 10 minutes because some of the execs take longer. So you likely can leave this timeout as 600, then.","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"Exec {"},{"line_number":3,"context_line":"  timeout \u003d\u003e 900,"},{"line_number":4,"context_line":"  path \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin\u0027"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"315bf4b8_ddf9c5f3","line":3,"in_reply_to":"d125c0aa_5d1028b4","updated":"2021-04-14 03:03:04.000000000","message":"controller is 10, and worker is 5, so I get total 15.","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"6b0cbfcdd6fdb125d0956726b9058578e2d0a5a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"Exec {"},{"line_number":3,"context_line":"  timeout \u003d\u003e 900,"},{"line_number":4,"context_line":"  path \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin\u0027"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1d87d950_72c3a72d","line":3,"in_reply_to":"d35dfdde_05739843","updated":"2021-04-15 18:05:19.000000000","message":"Done","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"fde7fd3e226b2a8262cd85dc87c1788643b33f8e","unresolved":true,"context_lines":[{"line_number":102,"context_line":"include ::platform::compute"},{"line_number":103,"context_line":"include ::platform::vswitch"},{"line_number":104,"context_line":"include ::platform::devices"},{"line_number":105,"context_line":"include ::platform::interfaces::sriov::config"},{"line_number":106,"context_line":"include ::platform::kubernetes::worker"},{"line_number":107,"context_line":"include ::platform::worker::storage"},{"line_number":108,"context_line":"include ::platform::pciirqaffinity"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7576f43b_98938cca","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":45},"updated":"2021-04-22 14:05:10.000000000","message":"change port from https://review.opendev.org/c/starlingx/stx-puppet/+/784761","commit_id":"e454f932b8da2e29469220b8cec601427c2e12f2"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3d599882c50f7d89e0e910da92ab2fa5261f3dcc","unresolved":true,"context_lines":[{"line_number":102,"context_line":"include ::platform::compute"},{"line_number":103,"context_line":"include ::platform::vswitch"},{"line_number":104,"context_line":"include ::platform::devices"},{"line_number":105,"context_line":"include ::platform::interfaces::sriov::config"},{"line_number":106,"context_line":"include ::platform::kubernetes::worker"},{"line_number":107,"context_line":"include ::platform::worker::storage"},{"line_number":108,"context_line":"include ::platform::pciirqaffinity"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"de14c20e_035982c1","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":45},"in_reply_to":"7576f43b_98938cca","updated":"2021-04-22 14:55:52.000000000","message":"there should probably be a comment in worker.pp that any changes there should be considered also for aio.pp","commit_id":"e454f932b8da2e29469220b8cec601427c2e12f2"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"69ad405671a605b93e4f84882c24209849484df1","unresolved":true,"context_lines":[{"line_number":102,"context_line":"include ::platform::compute"},{"line_number":103,"context_line":"include ::platform::vswitch"},{"line_number":104,"context_line":"include ::platform::devices"},{"line_number":105,"context_line":"include ::platform::interfaces::sriov::config"},{"line_number":106,"context_line":"include ::platform::kubernetes::worker"},{"line_number":107,"context_line":"include ::platform::worker::storage"},{"line_number":108,"context_line":"include ::platform::pciirqaffinity"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"f917c720_80700011","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":45},"in_reply_to":"de14c20e_035982c1","updated":"2021-04-22 19:11:56.000000000","message":"good suggestion... please add a comment in worker.pp","commit_id":"e454f932b8da2e29469220b8cec601427c2e12f2"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"a8174d103d68366f188de888f6395a0e36cf0bf8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"include ::platform::compute"},{"line_number":103,"context_line":"include ::platform::vswitch"},{"line_number":104,"context_line":"include ::platform::devices"},{"line_number":105,"context_line":"include ::platform::interfaces::sriov::config"},{"line_number":106,"context_line":"include ::platform::kubernetes::worker"},{"line_number":107,"context_line":"include ::platform::worker::storage"},{"line_number":108,"context_line":"include ::platform::pciirqaffinity"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9b64b7dc_fdf2b7d1","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":45},"in_reply_to":"f917c720_80700011","updated":"2021-04-22 20:11:17.000000000","message":"Done","commit_id":"e454f932b8da2e29469220b8cec601427c2e12f2"}],"puppet-manifests/src/modules/platform/manifests/config.pp":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"class platform::config::aio::post"},{"line_number":445,"context_line":"{"},{"line_number":446,"context_line":"  file { \u0027/etc/platform/.initial_controller_config_complete\u0027:"},{"line_number":447,"context_line":"    ensure \u003d\u003e present,"},{"line_number":448,"context_line":"  }"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"  file { \u0027/var/run/.controller_config_complete\u0027:"},{"line_number":451,"context_line":"    ensure \u003d\u003e present,"},{"line_number":452,"context_line":"  }"},{"line_number":453,"context_line":"  include ::platform::config::worker::post"},{"line_number":454,"context_line":"}"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7244f42e_a0086005","line":452,"range":{"start_line":446,"start_character":0,"end_line":452,"end_character":3},"updated":"2021-03-18 19:42:00.000000000","message":"The platform::config::controller::post has an upgrade related check. Shouldn\u0027t you just include that class here so you pick that up as well?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":true,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"class platform::config::aio::post"},{"line_number":445,"context_line":"{"},{"line_number":446,"context_line":"  file { \u0027/etc/platform/.initial_controller_config_complete\u0027:"},{"line_number":447,"context_line":"    ensure \u003d\u003e present,"},{"line_number":448,"context_line":"  }"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"  file { \u0027/var/run/.controller_config_complete\u0027:"},{"line_number":451,"context_line":"    ensure \u003d\u003e present,"},{"line_number":452,"context_line":"  }"},{"line_number":453,"context_line":"  include ::platform::config::worker::post"},{"line_number":454,"context_line":"}"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"325b9265_b07c95e0","line":452,"range":{"start_line":446,"start_character":0,"end_line":452,"end_character":3},"in_reply_to":"7244f42e_a0086005","updated":"2021-03-31 14:09:35.000000000","message":"The same file is also created in platform::config::worker::post, with the same condition.","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"}],"puppet-manifests/src/modules/platform/manifests/devices.pp":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class platform::devices::fpga::fec::vf"},{"line_number":116,"context_line":"  inherits ::platform::devices::fpga::fec::params {"},{"line_number":117,"context_line":"  include ::platform::kubernetes::worker::sriovdp"},{"line_number":118,"context_line":"  require ::platform::devices::fpga::fec::pf"},{"line_number":119,"context_line":"  create_resources(\u0027platform::devices::sriov_vf_bind\u0027, $device_config, {})"},{"line_number":120,"context_line":"  Platform::Devices::Sriov_vf_bind \u003c| |\u003e -\u003e Class[\u0027platform::kubernetes::worker::sriovdp\u0027]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"de75d73a_42a17361","side":"PARENT","line":117,"updated":"2021-04-13 20:48:50.000000000","message":"Why are these lines removed?","commit_id":"2a80652598f399995edfc434f1aa0154f1b8299c"}],"puppet-manifests/src/modules/platform/manifests/filesystem.pp":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":316,"context_line":"  include ::platform::filesystem::kubelet"},{"line_number":317,"context_line":"}"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"class platform::filesystem::backup::runtime {"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  include ::platform::filesystem::backup::params"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fd2c8e46_b272ee13","side":"PARENT","line":319,"updated":"2021-03-18 19:42:00.000000000","message":"Please undo this so the file isn\u0027t in your review.","commit_id":"60570ad61b572ec509dc2090df5b30813001a8b9"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"  include ::platform::filesystem::kubelet"},{"line_number":317,"context_line":"}"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"class platform::filesystem::backup::runtime {"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  include ::platform::filesystem::backup::params"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e94fce52_b0a520d0","side":"PARENT","line":319,"in_reply_to":"fd2c8e46_b272ee13","updated":"2021-03-31 14:09:35.000000000","message":"Done","commit_id":"60570ad61b572ec509dc2090df5b30813001a8b9"}],"puppet-manifests/src/modules/platform/manifests/kubernetes.pp":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"93873533e65dd3ee3fc0cd2eebc2f560a6e69406","unresolved":true,"context_lines":[{"line_number":208,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl enable kubelet.service\u0027,"},{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":"  # Start kubelet if it is standard controller."},{"line_number":211,"context_line":"  if !str2bool($::is_worker_subfunction) {"},{"line_number":212,"context_line":"    File[\u0027/etc/kubernetes/manifests\u0027]"},{"line_number":213,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":214,"context_line":"      enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"42f968ae_e30cda3d","line":211,"range":{"start_line":211,"start_character":18,"end_line":211,"end_character":39},"updated":"2021-03-17 21:44:49.000000000","message":"This may also encompass \u0027storage\u0027 personality","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":207,"context_line":"  -\u003e exec { \u0027enable-kubelet\u0027:"},{"line_number":208,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl enable kubelet.service\u0027,"},{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":"  # Start kubelet if it is standard controller."},{"line_number":211,"context_line":"  if !str2bool($::is_worker_subfunction) {"},{"line_number":212,"context_line":"    File[\u0027/etc/kubernetes/manifests\u0027]"},{"line_number":213,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":214,"context_line":"      enable \u003d\u003e true,"},{"line_number":215,"context_line":"    }"},{"line_number":216,"context_line":"  }"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"class platform::kubernetes::master::init"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fcdcfc88_bf086f02","line":216,"range":{"start_line":210,"start_character":0,"end_line":216,"end_character":3},"updated":"2021-03-18 19:42:00.000000000","message":"Why are you changing the order for controllers?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":true,"context_lines":[{"line_number":207,"context_line":"  -\u003e exec { \u0027enable-kubelet\u0027:"},{"line_number":208,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl enable kubelet.service\u0027,"},{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":"  # Start kubelet if it is standard controller."},{"line_number":211,"context_line":"  if !str2bool($::is_worker_subfunction) {"},{"line_number":212,"context_line":"    File[\u0027/etc/kubernetes/manifests\u0027]"},{"line_number":213,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":214,"context_line":"      enable \u003d\u003e true,"},{"line_number":215,"context_line":"    }"},{"line_number":216,"context_line":"  }"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"class platform::kubernetes::master::init"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f2ae18a3_a80c45ae","line":216,"range":{"start_line":210,"start_character":0,"end_line":216,"end_character":3},"in_reply_to":"fcdcfc88_bf086f02","updated":"2021-03-31 14:09:35.000000000","message":"The order for controller is not changed. Here is to skip starting kubblet if it is an AIO controller.","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":450,"context_line":"    -\u003e Class[\u0027::platform::kubernetes::cgroup\u0027]"},{"line_number":451,"context_line":"    -\u003e Class[\u0027::platform::kubernetes::worker::init\u0027]"},{"line_number":452,"context_line":"  } else {"},{"line_number":453,"context_line":"    # Reconfigure cgroups cpusets on AIO"},{"line_number":454,"context_line":"    contain ::platform::kubernetes::cgroup"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    # Add refresh dependency for kubelet for hugepage allocation"},{"line_number":457,"context_line":"    Class[\u0027::platform::compute::allocate\u0027]"},{"line_number":458,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":459,"context_line":"      enable \u003d\u003e true,"},{"line_number":460,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6351c584_86731fd0","line":457,"range":{"start_line":453,"start_character":0,"end_line":457,"end_character":42},"updated":"2021-03-18 19:42:00.000000000","message":"I don\u0027t see the platform::kubernetes::worker class being included for AIO anymore. So how will this be done on AIO?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":true,"context_lines":[{"line_number":450,"context_line":"    -\u003e Class[\u0027::platform::kubernetes::cgroup\u0027]"},{"line_number":451,"context_line":"    -\u003e Class[\u0027::platform::kubernetes::worker::init\u0027]"},{"line_number":452,"context_line":"  } else {"},{"line_number":453,"context_line":"    # Reconfigure cgroups cpusets on AIO"},{"line_number":454,"context_line":"    contain ::platform::kubernetes::cgroup"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    # Add refresh dependency for kubelet for hugepage allocation"},{"line_number":457,"context_line":"    Class[\u0027::platform::compute::allocate\u0027]"},{"line_number":458,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":459,"context_line":"      enable \u003d\u003e true,"},{"line_number":460,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6cd6682f_94e7421c","line":457,"range":{"start_line":453,"start_character":0,"end_line":457,"end_character":42},"in_reply_to":"6351c584_86731fd0","updated":"2021-03-31 14:09:35.000000000","message":"it is mess up in splitting the code from merging starting kubelet. platform::kubernetes::worker is included in aio.pp","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"5f9c36906f2c8adc04a94656dd44826e5b06fadd","unresolved":true,"context_lines":[{"line_number":456,"context_line":"    # Add refresh dependency for kubelet for hugepage allocation"},{"line_number":457,"context_line":"    Class[\u0027::platform::compute::allocate\u0027]"},{"line_number":458,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":459,"context_line":"      enable \u003d\u003e true,"},{"line_number":460,"context_line":"    }"},{"line_number":461,"context_line":"  }"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"410dec8d_87414d18","line":459,"range":{"start_line":459,"start_character":6,"end_line":459,"end_character":21},"updated":"2021-03-18 19:42:00.000000000","message":"Why is this being changed?","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"893d27a8532ac5ea37bb1981c9ea6984e8d00430","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    # Add refresh dependency for kubelet for hugepage allocation"},{"line_number":457,"context_line":"    Class[\u0027::platform::compute::allocate\u0027]"},{"line_number":458,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":459,"context_line":"      enable \u003d\u003e true,"},{"line_number":460,"context_line":"    }"},{"line_number":461,"context_line":"  }"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b108846e_f3630ba6","line":459,"range":{"start_line":459,"start_character":6,"end_line":459,"end_character":21},"in_reply_to":"410dec8d_87414d18","updated":"2021-03-31 17:19:46.000000000","message":"it starts here, don\u0027t need \"refresh\" logic","commit_id":"bbfcdf6176d39148ff2fbaf4236c701a598ed115"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"042b62584c163a5de3f4de67c6bf28af4a936ecb","unresolved":true,"context_lines":[{"line_number":449,"context_line":"    # Reconfigure cgroups cpusets on AIO"},{"line_number":450,"context_line":"    contain ::platform::kubernetes::cgroup"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    # Add refresh dependency for kubelet for hugepage allocation"},{"line_number":453,"context_line":"    Class[\u0027::platform::compute::allocate\u0027]"},{"line_number":454,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":455,"context_line":"      enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"4050dafa_881b79f1","line":452,"range":{"start_line":452,"start_character":4,"end_line":452,"end_character":64},"updated":"2021-04-06 15:58:04.000000000","message":"This comment is no longer correct.","commit_id":"466d2639cfc66a4ceed4790e3ee348445b4c2864"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":428,"context_line":"  include ::platform::kubernetes::worker::pci"},{"line_number":429,"context_line":"}"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class platform::kubernetes::worker::sriovdp {"},{"line_number":432,"context_line":"  include ::platform::kubernetes::params"},{"line_number":433,"context_line":"  include ::platform::params"},{"line_number":434,"context_line":"  $host_labels \u003d $::platform::kubernetes::params::host_labels"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"0e78692a_82b4a4fc","side":"PARENT","line":431,"updated":"2021-04-13 20:48:50.000000000","message":"Why is this removed?","commit_id":"2a80652598f399995edfc434f1aa0154f1b8299c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":true,"context_lines":[{"line_number":428,"context_line":"  include ::platform::kubernetes::worker::pci"},{"line_number":429,"context_line":"}"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class platform::kubernetes::worker::sriovdp {"},{"line_number":432,"context_line":"  include ::platform::kubernetes::params"},{"line_number":433,"context_line":"  include ::platform::params"},{"line_number":434,"context_line":"  $host_labels \u003d $::platform::kubernetes::params::host_labels"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"262dd4ed_2aa7cf0f","side":"PARENT","line":431,"in_reply_to":"0e78692a_82b4a4fc","updated":"2021-04-14 03:03:04.000000000","message":"This is to delete pods that may be in wrong config because of kubernetes start in controller manifest before worker manifest are applied. Now with the change, the kubernetes starts after all necessary worker config are applied, the pods are not supposed run with correct config. We don\u0027t need to delete them anymore.","commit_id":"2a80652598f399995edfc434f1aa0154f1b8299c"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"61498fdadf6bc9b2eb19e70225f96484c38c4862","unresolved":true,"context_lines":[{"line_number":228,"context_line":"    File[\u0027/etc/kubernetes/manifests\u0027]"},{"line_number":229,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":230,"context_line":"      enable \u003d\u003e true,"},{"line_number":231,"context_line":"    }"},{"line_number":232,"context_line":"  }"},{"line_number":233,"context_line":"}"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"4060ee31_b80e1e35","line":231,"updated":"2021-04-13 20:48:50.000000000","message":"Do you also need \"-\u003e Exec[\u0027enable-kubelet\u0027]\" here to match what is currently done?","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":true,"context_lines":[{"line_number":228,"context_line":"    File[\u0027/etc/kubernetes/manifests\u0027]"},{"line_number":229,"context_line":"    -\u003e service { \u0027kubelet\u0027:"},{"line_number":230,"context_line":"      enable \u003d\u003e true,"},{"line_number":231,"context_line":"    }"},{"line_number":232,"context_line":"  }"},{"line_number":233,"context_line":"}"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"840d7cd6_a1489041","line":231,"in_reply_to":"4060ee31_b80e1e35","updated":"2021-04-14 03:03:04.000000000","message":"I think it is important to ensure File[\u0027/etc/kubernetes/manifests\u0027] is ahead of both service[\u0027kubelet\u0027] and Exec[\u0027enable-kubelet\u0027]. The order of service[\u0027kubelet\u0027] and Exec[\u0027enable-kubelet\u0027] shouldn\u0027t matter.","commit_id":"7910ed397417533fcaf0ca971297b9611d18db7c"}],"puppet-manifests/src/modules/platform/manifests/lvm.pp":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"2235f0bc2d0b8d650d7024609d9d8e23f5ae2ad6","unresolved":true,"context_lines":[{"line_number":165,"context_line":"  ::platform::lvm::global_filter { \u0027final filter compute\u0027:"},{"line_number":166,"context_line":"    filter  \u003d\u003e $final_filter,"},{"line_number":167,"context_line":"    require \u003d\u003e Class[\u0027::platform::lvm::compute::vgs\u0027]"},{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  include ::platform::lvm"},{"line_number":171,"context_line":"  include ::platform::lvm::controller::vgs"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"53f4f7be_08e5ada4","line":168,"updated":"2021-03-18 15:06:56.000000000","message":"Can we just do an include of the platform::lvm::controller and platform::lvm::compute classes?","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"451c4c0bab797d22007dd9d2dc1e98e026c97f4c","unresolved":true,"context_lines":[{"line_number":165,"context_line":"  ::platform::lvm::global_filter { \u0027final filter compute\u0027:"},{"line_number":166,"context_line":"    filter  \u003d\u003e $final_filter,"},{"line_number":167,"context_line":"    require \u003d\u003e Class[\u0027::platform::lvm::compute::vgs\u0027]"},{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  include ::platform::lvm"},{"line_number":171,"context_line":"  include ::platform::lvm::controller::vgs"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b844b9cb_03916385","line":168,"in_reply_to":"53f4f7be_08e5ada4","updated":"2021-03-31 14:09:35.000000000","message":"I think I can, after renaming global_filter. will make the change","commit_id":"bb57d0ff276cb4fd37ab87be6d7e58c93880858e"}],"puppet-manifests/src/modules/platform/manifests/network.pp":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"36f14116a45677c5674b374ab398d06a5c57075a","unresolved":true,"context_lines":[{"line_number":266,"context_line":"  } else {"},{"line_number":267,"context_line":"    create_resources(\u0027platform::interfaces::sriov_vf_bind\u0027, $sriov_config, {})"},{"line_number":268,"context_line":"    create_resources(\u0027platform::interfaces::sriov_vf_ratelimit\u0027, $sriov_config, {})"},{"line_number":269,"context_line":"    Platform::Interfaces::Sriov_vf_bind \u003c| |\u003e -\u003e Class[\u0027::platform::kubernetes::worker::sriovdp\u0027]"},{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":"}"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"98fd2d50_417c55d9","line":269,"updated":"2021-04-12 14:19:51.000000000","message":"I suppose this is a key dependency being removed as part of this commit (see commit ca6546f56 \"Enable SR-IOV device plugin restart\")","commit_id":"83f3c69e9b9015554ae9f5b6cdfcba9b4ab9c810"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"7b8cb2516fe0c57405e3077ebd0119563e864262","unresolved":false,"context_lines":[{"line_number":266,"context_line":"  } else {"},{"line_number":267,"context_line":"    create_resources(\u0027platform::interfaces::sriov_vf_bind\u0027, $sriov_config, {})"},{"line_number":268,"context_line":"    create_resources(\u0027platform::interfaces::sriov_vf_ratelimit\u0027, $sriov_config, {})"},{"line_number":269,"context_line":"    Platform::Interfaces::Sriov_vf_bind \u003c| |\u003e -\u003e Class[\u0027::platform::kubernetes::worker::sriovdp\u0027]"},{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":"}"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"667c57c2_4018167f","line":269,"in_reply_to":"98fd2d50_417c55d9","updated":"2021-04-14 03:03:04.000000000","message":"Done","commit_id":"83f3c69e9b9015554ae9f5b6cdfcba9b4ab9c810"}]}