)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e4e16fa66443e8cb1d3952d2054bb60ffa2ae811","unresolved":true,"context_lines":[{"line_number":19,"context_line":"3) Backup and restore starlingx platform on simplex and duplex  --  PASS"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"4) Upgrade starlingx platfrom -- WIP"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ib5ed7976184b61112b545af198cc5c3b4f406aee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"930b7ff9_129fdee8","line":22,"updated":"2021-08-02 11:30:22.000000000","message":"You need a Story/Task or Bug Id\nYou probably should add Depends-On for the reviews that are needed to merge first.\nYou need a Signed-Off-By field","commit_id":"4f671fa92500f9ac02c32e4c91d4b44a8565e63b"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"3) Backup and restore starlingx platform on simplex and duplex  --  PASS"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"4) Upgrade starlingx platfrom -- WIP"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ib5ed7976184b61112b545af198cc5c3b4f406aee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bd6cdccd_0c8f5fff","line":22,"in_reply_to":"930b7ff9_129fdee8","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"4f671fa92500f9ac02c32e4c91d4b44a8565e63b"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"cc332b43cc79923ee716838e3a56ffd69c361f0f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Separate CA for k8s and etcd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sharing cert between kubernetes-ca and etcd-ca will dramatically increase the"},{"line_number":10,"context_line":"complexity of updating etcd-ca cert. Therefore do the spearating CA work"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1) Deployment test on simplex and duplex --  PASS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0664d721_0c035b9d","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":77},"updated":"2021-08-06 17:41:14.000000000","message":"commit message too wide here","commit_id":"f34fc8c8e2f5e0fd2439d4831b98bc6ae4b45033"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Separate CA for k8s and etcd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sharing cert between kubernetes-ca and etcd-ca will dramatically increase the"},{"line_number":10,"context_line":"complexity of updating etcd-ca cert. Therefore do the spearating CA work"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1) Deployment test on simplex and duplex --  PASS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f62fef8_8fa641a0","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":77},"in_reply_to":"0664d721_0c035b9d","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"f34fc8c8e2f5e0fd2439d4831b98bc6ae4b45033"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"cc332b43cc79923ee716838e3a56ffd69c361f0f","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"3) Backup and restore starlingx platform on simplex and duplex  --  PASS"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"4) Upgrade starlingx platfrom on simplex and duplex-- WIP"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Story: 2008833"},{"line_number":24,"context_line":"Task: 42320"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"77ce78ea_577cc35b","line":21,"range":{"start_line":21,"start_character":54,"end_line":21,"end_character":57},"updated":"2021-08-06 17:41:14.000000000","message":"is this testing still in progress?","commit_id":"f34fc8c8e2f5e0fd2439d4831b98bc6ae4b45033"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"3) Backup and restore starlingx platform on simplex and duplex  --  PASS"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"4) Upgrade starlingx platfrom on simplex and duplex-- WIP"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Story: 2008833"},{"line_number":24,"context_line":"Task: 42320"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"040b003f_b39a6744","line":21,"range":{"start_line":21,"start_character":54,"end_line":21,"end_character":57},"in_reply_to":"77ce78ea_577cc35b","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"f34fc8c8e2f5e0fd2439d4831b98bc6ae4b45033"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4ffb92ee_f47f76d7","updated":"2021-10-21 20:57:40.000000000","message":"... exploring new comments outstanding indicates with this version of gerrit.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"5fbe352a5014199517608ec637346b101ee86d56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"560b9bae_9c2ba9f5","updated":"2021-10-21 04:00:59.000000000","message":"wait for depends gerrit review https://review.opendev.org/c/starlingx/ansible-playbooks/+/800412 ","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"}],"puppet-manifests/src/modules/platform/manifests/etcd.pp":[{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"c1ef268414c626aa11aea1fdfa1d6e90efb84318","unresolved":true,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7e2a5432_285a68f0","line":115,"updated":"2021-10-06 16:31:43.000000000","message":"Is the init needed? I assume etcd will pickup the new cert during the sm-restart, and most of the work is pointing the kube-apiserver to the new ca.","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"20a0c1b6d28ffe81c650843c49d51b9e88ffd8b2","unresolved":true,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7cddfd0d_4e9b26bd","line":115,"in_reply_to":"46c613dc_5c4163fc","updated":"2021-10-07 00:21:05.000000000","message":"This is no need anymore, since we already enabled security etcd in STX5\nNo need to update etcd.conf again.","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"fffefd57e206b46412798dc3295206d089fdf7cb","unresolved":true,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"8cdb6fc4_d3a137f9","line":115,"in_reply_to":"7cddfd0d_4e9b26bd","updated":"2021-10-07 18:20:02.000000000","message":"Ok removing ::init.\n\nI am understanding that since \"platform::etcd::upgrade::runtime\" is to be relevant during upgrade, the inclusion of platform::etcd::init no longer makes sense in the current release.\n\nIn separate_etcd_ca playbook, platform::etcd::upgrade::runtime class is output to file and passed to puppet-manifest-apply.sh\n\nSimilarly, during activate_upgrade, _split_etcd_security_config() ... _config_apply_runtime_manifest() applies that platform::etcd::upgrade::runtime manifest.","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"61e6c4c9425b2a317c0ea021a1333b2c0fde0f68","unresolved":true,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"46c613dc_5c4163fc","line":115,"in_reply_to":"7e2a5432_285a68f0","updated":"2021-10-06 16:52:05.000000000","message":"I would need to investigate what sort of defect would be presented including it, or excluding it.\n\nThere is no discussion for it in the review which introduces that class:\nhttps://review.opendev.org/c/starlingx/stx-puppet/+/760510","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"0c92b8ac_b0d489cf","line":115,"in_reply_to":"8cdb6fc4_d3a137f9","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"0ef7df31_1c2bcaa7","line":115,"in_reply_to":"8cdb6fc4_d3a137f9","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"247ab071_d2ebc834","line":115,"in_reply_to":"8cdb6fc4_d3a137f9","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class platform::etcd::upgrade::runtime"},{"line_number":113,"context_line":"  inherits ::platform::etcd::params {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"92e01864_63c79e00","line":115,"in_reply_to":"8cdb6fc4_d3a137f9","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"d5dd095ba211cad670d0811e9dc3096766537d9b","unresolved":true,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"},{"line_number":119,"context_line":"  $etcd_key \u003d \u0027/etc/etcd/etcd-client.key\u0027"},{"line_number":120,"context_line":"  $etcd_ca \u003d \u0027/etc/etcd/ca.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"72e4c176_b5f6b046","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":51},"updated":"2021-10-07 19:59:26.000000000","message":"I\u0027m moving if block for $client_url from platform::etcd::init to platform::etcd::params.","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::platform::etcd::init"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  $server_url \u003d $::platform::etcd::init::client_url"},{"line_number":118,"context_line":"  $etcd_cert \u003d \u0027/etc/etcd/etcd-client.crt\u0027"},{"line_number":119,"context_line":"  $etcd_key \u003d \u0027/etc/etcd/etcd-client.key\u0027"},{"line_number":120,"context_line":"  $etcd_ca \u003d \u0027/etc/etcd/ca.crt\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ae3f97a1_aaa20576","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":51},"in_reply_to":"72e4c176_b5f6b046","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"fdfa9ee7d27645a34e331810f60e3186a12b6f5d"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"31aae329733fad754a0cf42144431d9b3336da53","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  $bind_address_version \u003d 4,"},{"line_number":4,"context_line":"  $port    \u003d 2379,"},{"line_number":5,"context_line":"  $node   \u003d \u0027controller\u0027,"},{"line_number":6,"context_line":"  $security_enabled \u003d undef,"},{"line_number":7,"context_line":")"},{"line_number":8,"context_line":"{"},{"line_number":9,"context_line":"  include ::platform::params"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"575d340a_dc5e504d","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":27},"updated":"2021-10-20 12:11:41.000000000","message":"with this removed, I so no other references to etcd security_enabled","commit_id":"5130cdbf211c5b70f54c9c53fff07d306aa62c44"},{"author":{"_account_id":30728,"name":"YU CHENGDE","display_name":"Chant Yu","email":"chengde.yu@intel.com","username":"yuchengde"},"change_message_id":"599763316983891488370ed4a511178d77869148","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  $bind_address_version \u003d 4,"},{"line_number":4,"context_line":"  $port    \u003d 2379,"},{"line_number":5,"context_line":"  $node   \u003d \u0027controller\u0027,"},{"line_number":6,"context_line":"  $security_enabled \u003d undef,"},{"line_number":7,"context_line":")"},{"line_number":8,"context_line":"{"},{"line_number":9,"context_line":"  include ::platform::params"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"f2dfeb44_34f9400f","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":27},"in_reply_to":"575d340a_dc5e504d","updated":"2021-10-20 14:58:21.000000000","message":"P.S. Refer to patch 28 of https://review.opendev.org/c/starlingx/config/+/800878/\nwe decide to remove it.\n\nThere is one last place will use this parameter\n/config/controllerconfig/controllerconfig/controllerconfig/upgrades/controller.py\nline 728\n\n        if \u0027platform::etcd::params::security_enabled\u0027 in static_config.keys():\n            etcd_security_config[\u0027platform::etcd::params::security_enabled\u0027] \u003d \\\n                static_config[\u0027platform::etcd::params::security_enabled\u0027]\n            etcd_security_config[\u0027platform::etcd::params::bind_address\u0027] \u003d \\\n                static_config[\u0027platform::etcd::params::bind_address\u0027]\n            etcd_security_config[\u0027platform::etcd::params::bind_address_version\u0027] \u003d \\\n                static_config[\u0027platform::etcd::params::bind_address_version\u0027]\n\nAlthough, it is less impact to code.\nShould we go to remove it?","commit_id":"5130cdbf211c5b70f54c9c53fff07d306aa62c44"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $bind_address_version \u003d 4,"},{"line_number":4,"context_line":"  $port    \u003d 2379,"},{"line_number":5,"context_line":"  $node   \u003d \u0027controller\u0027,"},{"line_number":6,"context_line":"  $security_enabled \u003d undef,"},{"line_number":7,"context_line":")"},{"line_number":8,"context_line":"{"},{"line_number":9,"context_line":"  include ::platform::params"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"cf034a4e_00831e1a","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":27},"in_reply_to":"a600c3e3_150d8a3d","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"5130cdbf211c5b70f54c9c53fff07d306aa62c44"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $bind_address_version \u003d 4,"},{"line_number":4,"context_line":"  $port    \u003d 2379,"},{"line_number":5,"context_line":"  $node   \u003d \u0027controller\u0027,"},{"line_number":6,"context_line":"  $security_enabled \u003d undef,"},{"line_number":7,"context_line":")"},{"line_number":8,"context_line":"{"},{"line_number":9,"context_line":"  include ::platform::params"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"eb27c4c7_ac9c490a","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":27},"in_reply_to":"a600c3e3_150d8a3d","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"5130cdbf211c5b70f54c9c53fff07d306aa62c44"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $bind_address_version \u003d 4,"},{"line_number":4,"context_line":"  $port    \u003d 2379,"},{"line_number":5,"context_line":"  $node   \u003d \u0027controller\u0027,"},{"line_number":6,"context_line":"  $security_enabled \u003d undef,"},{"line_number":7,"context_line":")"},{"line_number":8,"context_line":"{"},{"line_number":9,"context_line":"  include ::platform::params"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fdcf9f28_248cd38f","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":27},"in_reply_to":"a600c3e3_150d8a3d","updated":"2021-10-21 20:57:40.000000000","message":"Done","commit_id":"5130cdbf211c5b70f54c9c53fff07d306aa62c44"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"f3984bffafb1044c9af126fee173d0830f8aea90","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  $bind_address_version \u003d 4,"},{"line_number":4,"context_line":"  $port    \u003d 2379,"},{"line_number":5,"context_line":"  $node   \u003d \u0027controller\u0027,"},{"line_number":6,"context_line":"  $security_enabled \u003d undef,"},{"line_number":7,"context_line":")"},{"line_number":8,"context_line":"{"},{"line_number":9,"context_line":"  include ::platform::params"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"a600c3e3_150d8a3d","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":27},"in_reply_to":"f2dfeb44_34f9400f","updated":"2021-10-20 19:09:25.000000000","message":"Hi Chant Yu, it is removed in patch 29: https://review.opendev.org/c/starlingx/config/+/800878/28..29","commit_id":"5130cdbf211c5b70f54c9c53fff07d306aa62c44"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"46b416436e4142c317247c26304f1e724a6a3d53","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    $client_url \u003d \"https://[${bind_address}]:${port},https://[127.0.0.1]:${port}\""},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else {"},{"line_number":18,"context_line":"    $client_url \u003d \"https://${bind_address}:${port},https://[127.0.0.1]:${port}\""},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"900a925d_0a152146","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":70},"updated":"2021-10-20 20:45:27.000000000","message":"I realize you are just moving the code up so my comment here is not aimed at you.\n\nI find it odd that  the ipv4 casehas square brackets and the ipv6 has 127.0.0.1\n\nie I would expect:\nIPv4 127.0.0.1\nIPv6  [::1]","commit_id":"e8721183d7b29da21e61dcf1274ae006ed31ee15"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    $client_url \u003d \"https://[${bind_address}]:${port},https://[127.0.0.1]:${port}\""},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else {"},{"line_number":18,"context_line":"    $client_url \u003d \"https://${bind_address}:${port},https://[127.0.0.1]:${port}\""},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"55ab9342_000f1576","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":70},"in_reply_to":"37ef77e1_2385839c","updated":"2021-10-21 20:57:40.000000000","message":"Ack","commit_id":"e8721183d7b29da21e61dcf1274ae006ed31ee15"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"161e6a02a355f7d084710767067b3538a351653e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    $client_url \u003d \"https://[${bind_address}]:${port},https://[127.0.0.1]:${port}\""},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else {"},{"line_number":18,"context_line":"    $client_url \u003d \"https://${bind_address}:${port},https://[127.0.0.1]:${port}\""},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"fdb02b85_784d4aee","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":70},"in_reply_to":"37ef77e1_2385839c","updated":"2021-10-21 20:57:40.000000000","message":"Ack","commit_id":"e8721183d7b29da21e61dcf1274ae006ed31ee15"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"f086f821a00a76839c0fd89e6442867557e04033","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    $client_url \u003d \"https://[${bind_address}]:${port},https://[127.0.0.1]:${port}\""},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"  else {"},{"line_number":18,"context_line":"    $client_url \u003d \"https://${bind_address}:${port},https://[127.0.0.1]:${port}\""},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"37ef77e1_2385839c","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":70},"in_reply_to":"900a925d_0a152146","updated":"2021-10-20 20:51:25.000000000","message":"I had not noticed that.  At least it\u0027s only the localhost address with weirdness.  That has to be some sort of bug.","commit_id":"e8721183d7b29da21e61dcf1274ae006ed31ee15"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"bee9360e5b3f92c7272251edfd195990e7f4ea4a","unresolved":true,"context_lines":[{"line_number":141,"context_line":"      replace \u003d\u003e true,"},{"line_number":142,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/etcd-client.key\","},{"line_number":143,"context_line":"    }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.crt\u0027:"},{"line_number":146,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":147,"context_line":"      replace \u003d\u003e true,"},{"line_number":148,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.crt\","},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.key\u0027:"},{"line_number":152,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":153,"context_line":"      replace \u003d\u003e true,"},{"line_number":154,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.key\","},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    -\u003e file { \u0027/etc/kubernetes/pki/apiserver-etcd-client.crt\u0027:"},{"line_number":158,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"48ffde70_b5c9c64d","line":155,"range":{"start_line":144,"start_character":0,"end_line":155,"end_character":5},"updated":"2021-10-22 15:44:51.000000000","message":"I assume only these are needed.  Can you confirm?","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"5c23898b313a5f14530af170d9d346b00a4ac469","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      replace \u003d\u003e true,"},{"line_number":142,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/etcd-client.key\","},{"line_number":143,"context_line":"    }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.crt\u0027:"},{"line_number":146,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":147,"context_line":"      replace \u003d\u003e true,"},{"line_number":148,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.crt\","},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.key\u0027:"},{"line_number":152,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":153,"context_line":"      replace \u003d\u003e true,"},{"line_number":154,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.key\","},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    -\u003e file { \u0027/etc/kubernetes/pki/apiserver-etcd-client.crt\u0027:"},{"line_number":158,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"810ec98d_507650e4","line":155,"range":{"start_line":144,"start_character":0,"end_line":155,"end_character":5},"in_reply_to":"48ffde70_b5c9c64d","updated":"2021-10-22 17:11:53.000000000","message":"I\u0027m not very familiar with the upgrades and puppet code.\n\nThis section applies to the not-active controller.\nIt will be called in _split_etcd_security_config() of sysinv/conductor/manager.py, in order to move the certs (and keys) from platform/config to /etc/etcd on the standby controller.\n\nI don\u0027t think we can omit the other certs and keys on the standby controller, no.  But please let me know if you are seeing something else.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2bd5d073fbbc64af51b7d32f09f79e2ac9be2e8a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      replace \u003d\u003e true,"},{"line_number":142,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/etcd-client.key\","},{"line_number":143,"context_line":"    }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.crt\u0027:"},{"line_number":146,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":147,"context_line":"      replace \u003d\u003e true,"},{"line_number":148,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.crt\","},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.key\u0027:"},{"line_number":152,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":153,"context_line":"      replace \u003d\u003e true,"},{"line_number":154,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.key\","},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    -\u003e file { \u0027/etc/kubernetes/pki/apiserver-etcd-client.crt\u0027:"},{"line_number":158,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"95a1a53b_56cfcc39","line":155,"range":{"start_line":144,"start_character":0,"end_line":155,"end_character":5},"in_reply_to":"810ec98d_507650e4","updated":"2021-10-22 18:05:52.000000000","message":"As per note with David, this can be optimized subsequently as upgrades tests have passed.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"a107b88b7267b7b81d5061cad8cc6cc92ac02d04","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      replace \u003d\u003e true,"},{"line_number":142,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/etcd-client.key\","},{"line_number":143,"context_line":"    }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.crt\u0027:"},{"line_number":146,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":147,"context_line":"      replace \u003d\u003e true,"},{"line_number":148,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.crt\","},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    -\u003e file { \u0027/etc/etcd/ca.key\u0027:"},{"line_number":152,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":153,"context_line":"      replace \u003d\u003e true,"},{"line_number":154,"context_line":"      source  \u003d\u003e \"/var/run/platform/config/${sw_version}/etcd/ca.key\","},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    -\u003e file { \u0027/etc/kubernetes/pki/apiserver-etcd-client.crt\u0027:"},{"line_number":158,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5ce8f17c_f520896d","line":155,"range":{"start_line":144,"start_character":0,"end_line":155,"end_character":5},"in_reply_to":"95a1a53b_56cfcc39","updated":"2021-10-25 22:32:18.000000000","message":"Hi. I believe that it is necessary to copy the certs to platform/config at this location because the certs have been recreated.  The program flow is:\n- Recreate all etcd certs and keys\n- Copy certs to platform/config\n- Reconfigure etcd\n- Restart etcd","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"bee9360e5b3f92c7272251edfd195990e7f4ea4a","unresolved":true,"context_lines":[{"line_number":188,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":189,"context_line":"      try_sleep \u003d\u003e 3,"},{"line_number":190,"context_line":"    }"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    -\u003e exec { \u0027create-etcd-root-account\u0027:"},{"line_number":193,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":194,"context_line":"                  user add root:sysadmin\","},{"line_number":195,"context_line":"    }"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    -\u003e exec { \u0027create-etcd-user-account\u0027:"},{"line_number":198,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":199,"context_line":"                  user add apiserver-etcd-client:sysadmin\","},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    -\u003e exec { \u0027enable-etcd-auth\u0027:"},{"line_number":203,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":204,"context_line":"                  auth enable\","},{"line_number":205,"context_line":"      returns \u003d\u003e [0,1]"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1285b325_0fa05395","line":206,"range":{"start_line":191,"start_character":0,"end_line":206,"end_character":5},"updated":"2021-10-22 15:44:51.000000000","message":"nit: I\u0027m pretty sure none of this is needed. Can you confirm? It sounds like this won\u0027t hurt to be run again.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"5c23898b313a5f14530af170d9d346b00a4ac469","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":189,"context_line":"      try_sleep \u003d\u003e 3,"},{"line_number":190,"context_line":"    }"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    -\u003e exec { \u0027create-etcd-root-account\u0027:"},{"line_number":193,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":194,"context_line":"                  user add root:sysadmin\","},{"line_number":195,"context_line":"    }"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    -\u003e exec { \u0027create-etcd-user-account\u0027:"},{"line_number":198,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":199,"context_line":"                  user add apiserver-etcd-client:sysadmin\","},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    -\u003e exec { \u0027enable-etcd-auth\u0027:"},{"line_number":203,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":204,"context_line":"                  auth enable\","},{"line_number":205,"context_line":"      returns \u003d\u003e [0,1]"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"ad315488_feefc4aa","line":206,"range":{"start_line":191,"start_character":0,"end_line":206,"end_character":5},"in_reply_to":"1285b325_0fa05395","updated":"2021-10-22 17:11:53.000000000","message":"Per our discussion, this and the previous question (#155) is something we can continue to work on.  I do not have prompt answers.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"f81ca651ad078e26ec6db9e4af4038c7b242b690","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":189,"context_line":"      try_sleep \u003d\u003e 3,"},{"line_number":190,"context_line":"    }"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    -\u003e exec { \u0027create-etcd-root-account\u0027:"},{"line_number":193,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":194,"context_line":"                  user add root:sysadmin\","},{"line_number":195,"context_line":"    }"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    -\u003e exec { \u0027create-etcd-user-account\u0027:"},{"line_number":198,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":199,"context_line":"                  user add apiserver-etcd-client:sysadmin\","},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    -\u003e exec { \u0027enable-etcd-auth\u0027:"},{"line_number":203,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":204,"context_line":"                  auth enable\","},{"line_number":205,"context_line":"      returns \u003d\u003e [0,1]"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"252d6780_5cd9c7a9","line":206,"range":{"start_line":191,"start_character":0,"end_line":206,"end_character":5},"in_reply_to":"13504664_91e52117","updated":"2021-10-27 20:49:00.000000000","message":"Testing on AIO-SX disagrees with me; with these lines removed then etcd will not have the two users configured and will not have auth enabled after upgrade.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"a107b88b7267b7b81d5061cad8cc6cc92ac02d04","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":189,"context_line":"      try_sleep \u003d\u003e 3,"},{"line_number":190,"context_line":"    }"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    -\u003e exec { \u0027create-etcd-root-account\u0027:"},{"line_number":193,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":194,"context_line":"                  user add root:sysadmin\","},{"line_number":195,"context_line":"    }"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    -\u003e exec { \u0027create-etcd-user-account\u0027:"},{"line_number":198,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":199,"context_line":"                  user add apiserver-etcd-client:sysadmin\","},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    -\u003e exec { \u0027enable-etcd-auth\u0027:"},{"line_number":203,"context_line":"      command \u003d\u003e \"etcdctl --cert-file\u003d${etcd_cert} --key-file\u003d${etcd_key} --ca-file\u003d${etcd_ca} --endpoint\u003d${server_url} \\"},{"line_number":204,"context_line":"                  auth enable\","},{"line_number":205,"context_line":"      returns \u003d\u003e [0,1]"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"13504664_91e52117","line":206,"range":{"start_line":191,"start_character":0,"end_line":206,"end_character":5},"in_reply_to":"ad315488_feefc4aa","updated":"2021-10-25 22:32:18.000000000","message":"I agree that adding the users and enabling security are no longer necessary in this class.  And I agree that it was safe to leave these in - user creation always returns 0, even if the users already exist, while the \"returns \u003d\u003e [0,1]\" statement ignores return value 1 when auth is already enabled.","commit_id":"99eee0012584d4c57582c5509f4d239bbf61ca3a"}]}