)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"4dda910764d5876342bde5284be0dbac5f274edb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e5b6108f_c4b4255d","updated":"2021-10-20 10:43:12.000000000","message":"Build issues.\nRename deb_pkg -\u003e deb_folder.\n\nLintian errors, but I think we can ignore these.\nE: puppet-manifests: dir-in-usr-local usr/local/bin/\nE: puppet-manifests: file-in-usr-local usr/local/bin/apply_network_config.sh\nE: puppet-manifests: file-in-usr-local usr/local/bin/puppet-manifest-apply.sh\nE: puppet-manifests: file-in-usr-local usr/local/bin/puppet-update-default-grub.sh\nW: puppet-manifests: file-in-unusual-dir usr/local/bin/apply_network_config.sh\nW: puppet-manifests: file-in-unusual-dir usr/local/bin/puppet-manifest-apply.sh\nW: puppet-manifests: file-in-unusual-dir usr/local/bin/puppet-update-default-grub.sh\n\n[Note to self: verify files on next iteration]","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d557e781_80327e72","in_reply_to":"e5b6108f_c4b4255d","updated":"2021-10-21 13:22:07.000000000","message":"fixed","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"28471a68c49d1957a1b2c80d84191803cb9fe994","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"264740d8_d874246b","updated":"2021-10-21 10:49:29.000000000","message":"Seems we need to create packaging for another 3rdParty module: https://github.com/rcritten/puppet-nssdb\n\n\nMissing some dependencies in the \u0027Depends:\u0027 field. I didn\u0027t check if a new package is needed or not for those. Will do so in the next iteration.\n\n\n[\nNote to self: track these dependencies for iso build, use puppet-module-cristifalcas-etcd instead of the puppet-module-etcddiscovery:\n\npuppet-manifests : Depends: puppet-module-barbican but it is not installable\nDepends: puppet-module-vswitch but it is not installable\nDepends: puppet-module-etcddiscovery but it is not installable\nDepends: puppet-nssdb but it is not installable\nDepends: puppet-module-voxpupuli-collectd but it is not installable\n]\n","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"}],"puppet-manifests/debian/deb_folder/control":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"28471a68c49d1957a1b2c80d84191803cb9fe994","unresolved":true,"context_lines":[{"line_number":22,"context_line":" puppet-module-barbican,"},{"line_number":23,"context_line":" puppet-module-ceph,"},{"line_number":24,"context_line":" puppet-module-horizon,"},{"line_number":25,"context_line":" puppet-module-puppetlabs-haproxy,"},{"line_number":26,"context_line":" puppet-module-keystone,"},{"line_number":27,"context_line":" puppet-module-openstacklib,"},{"line_number":28,"context_line":" puppet-module-vswitch,"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3ade15d7_3fc5abd5","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":34},"updated":"2021-10-21 10:49:29.000000000","message":"remove this duplicate","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":22,"context_line":" puppet-module-barbican,"},{"line_number":23,"context_line":" puppet-module-ceph,"},{"line_number":24,"context_line":" puppet-module-horizon,"},{"line_number":25,"context_line":" puppet-module-puppetlabs-haproxy,"},{"line_number":26,"context_line":" puppet-module-keystone,"},{"line_number":27,"context_line":" puppet-module-openstacklib,"},{"line_number":28,"context_line":" puppet-module-vswitch,"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"d162c678_41d555c8","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":34},"in_reply_to":"3ade15d7_3fc5abd5","updated":"2021-10-21 13:22:07.000000000","message":"Done","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"28471a68c49d1957a1b2c80d84191803cb9fe994","unresolved":true,"context_lines":[{"line_number":35,"context_line":" puppet-module-puppetlabs-rabbitmq,"},{"line_number":36,"context_line":" puppet-module-puppetlabs-stdlib,"},{"line_number":37,"context_line":" puppet-module-duritong-sysctl,"},{"line_number":38,"context_line":" puppet-module-etcddiscovery,"},{"line_number":39,"context_line":" puppet-drbd,"},{"line_number":40,"context_line":" puppet-module-puppetlabs-firewall,"},{"line_number":41,"context_line":" puppet-module-adrienthebo-filemapper,"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"d71a4983_03c57e21","line":38,"updated":"2021-10-21 10:49:29.000000000","message":"The equivalent of CentOS puppet-etcd module is puppet-module-cristifalcas-etcd, not puppet-module-etcddiscovery.","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":35,"context_line":" puppet-module-puppetlabs-rabbitmq,"},{"line_number":36,"context_line":" puppet-module-puppetlabs-stdlib,"},{"line_number":37,"context_line":" puppet-module-duritong-sysctl,"},{"line_number":38,"context_line":" puppet-module-etcddiscovery,"},{"line_number":39,"context_line":" puppet-drbd,"},{"line_number":40,"context_line":" puppet-module-puppetlabs-firewall,"},{"line_number":41,"context_line":" puppet-module-adrienthebo-filemapper,"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"05b8da86_57b7286f","line":38,"in_reply_to":"d71a4983_03c57e21","updated":"2021-10-21 13:22:07.000000000","message":"Done","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"28471a68c49d1957a1b2c80d84191803cb9fe994","unresolved":true,"context_lines":[{"line_number":44,"context_line":" puppet-network,"},{"line_number":45,"context_line":" puppet-nslcd,"},{"line_number":46,"context_line":" puppet-module-voxpupuli-collectd,"},{"line_number":47,"context_line":" python3-ruamel.yaml"},{"line_number":48,"context_line":"Description: Puppet configuration and manifests"},{"line_number":49,"context_line":" Puppet lets you centrally manage every important aspect of your system using a"},{"line_number":50,"context_line":" cross-platform specification language that manages all the separate elements"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"bdb3ebd6_b4413d01","line":47,"updated":"2021-10-21 10:49:29.000000000","message":"These are present in CentOS, but missing here:\nRequires: puppet-boolean\nRequires: puppet-certmonger\nRequires: puppet-dnsmasq\nRequires: puppet-nssdb\nRequires: puppet-puppi\nRequires: puppet-vlan\n\n[Other than nssdb, I didn\u0027t dig to see if a new package is needed]","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"116b8e54a84b1b22249bc2d00ac0b3f8422db999","unresolved":false,"context_lines":[{"line_number":44,"context_line":" puppet-network,"},{"line_number":45,"context_line":" puppet-nslcd,"},{"line_number":46,"context_line":" puppet-module-voxpupuli-collectd,"},{"line_number":47,"context_line":" python3-ruamel.yaml"},{"line_number":48,"context_line":"Description: Puppet configuration and manifests"},{"line_number":49,"context_line":" Puppet lets you centrally manage every important aspect of your system using a"},{"line_number":50,"context_line":" cross-platform specification language that manages all the separate elements"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"e8812973_39a1bfaa","line":47,"in_reply_to":"2bf78be0_f82744b9","updated":"2021-10-28 16:43:53.000000000","message":"Ack","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":true,"context_lines":[{"line_number":44,"context_line":" puppet-network,"},{"line_number":45,"context_line":" puppet-nslcd,"},{"line_number":46,"context_line":" puppet-module-voxpupuli-collectd,"},{"line_number":47,"context_line":" python3-ruamel.yaml"},{"line_number":48,"context_line":"Description: Puppet configuration and manifests"},{"line_number":49,"context_line":" Puppet lets you centrally manage every important aspect of your system using a"},{"line_number":50,"context_line":" cross-platform specification language that manages all the separate elements"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"2bf78be0_f82744b9","line":47,"in_reply_to":"bdb3ebd6_b4413d01","updated":"2021-10-21 13:22:07.000000000","message":"I looked through the source code\n\n\u003e These are present in CentOS, but missing here:\n\u003e Requires: puppet-boolean\n\ndone\n\u003e Requires: puppet-certmonger\n\ndropped no longer used\n\n\u003e Requires: puppet-dnsmasq\n\ndropped no longer used\n\n\u003e Requires: puppet-nssdb\n\ndropped no longer used\n\n\u003e Requires: puppet-puppi\n\ndone\n\n\u003e Requires: puppet-vlan\n\nDropped no longer needed\n \n\u003e [Other than nssdb, I didn\u0027t dig to see if a new package is needed]","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"}],"puppet-manifests/debian/deb_folder/puppet-manifests.lintian-overrides":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"28471a68c49d1957a1b2c80d84191803cb9fe994","unresolved":true,"context_lines":[{"line_number":1,"context_line":"dir-in-usr-local "},{"line_number":2,"context_line":"file-in-usr-local usr"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"2d682c45_5ed06d2d","line":1,"updated":"2021-10-21 10:49:29.000000000","message":"extra whitespace","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dir-in-usr-local "},{"line_number":2,"context_line":"file-in-usr-local usr"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"22503d62_0d2072bb","line":1,"in_reply_to":"2d682c45_5ed06d2d","updated":"2021-10-21 13:22:07.000000000","message":"Done","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"}],"puppet-manifests/debian/deb_folder/puppet-manifests.postinst":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"28471a68c49d1957a1b2c80d84191803cb9fe994","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"set -e"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"case \"$1\" in"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"97ca6591_3fda63d1","line":1,"updated":"2021-10-21 10:49:29.000000000","message":"Please fix indentation in the whole file. I know 2 spaces are allowed by shell coding style, but Zuul...","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"set -e"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"case \"$1\" in"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ffaa9e79_d0b08951","line":1,"in_reply_to":"97ca6591_3fda63d1","updated":"2021-10-21 13:22:07.000000000","message":"Done","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":2,"context_line":"set -e"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"case \"$1\" in"},{"line_number":5,"context_line":"  configure)"},{"line_number":6,"context_line":"    # Replace the default hiera.yaml with our copy"},{"line_number":7,"context_line":"    if [ -e /etc/puppet/hiera.yaml ]; then"},{"line_number":8,"context_line":"        mv -f /etc/puppet/hiera.yaml /etc/puppet/hiera.yaml.dpkg-new"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9b5585a5_ae6eb162","line":5,"in_reply_to":"8061245b_be842e26","updated":"2021-10-21 13:22:07.000000000","message":"\u003e linters: E003 Indent not multiple of 4\n\nPlease fix.","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        mv -f /etc/puppet/hiera.yaml /etc/puppet/hiera.yaml.dpkg-new"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":"    ;;"},{"line_number":11,"context_line":"   *)"},{"line_number":12,"context_line":"    echo \"postinst called with an unknown argument \\`$1\u0027\" \u003e\u00262"},{"line_number":13,"context_line":"    exit 1"},{"line_number":14,"context_line":"    ;;"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"899967b3_4b0fa882","line":11,"in_reply_to":"b7e95350_216012d6","updated":"2021-10-21 13:22:07.000000000","message":"\u003e linters: E003 Indent not multiple of 4\n\nPlease fix.","commit_id":"33541a74009becdfb33e55a0aa608c160f5db782"}],"puppet-manifests/debian/deb_folder/rules":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2b045ad1396f9779806553a42f46657a506f1e5b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules"},{"line_number":17,"context_line":"\t# Prevent puppet installation errors, since puppet ships "},{"line_number":18,"context_line":"\t# its own hiera.yaml"},{"line_number":19,"context_line":"\tmkdir -p $(CURDIR)/debian/tmp/usr/share/puppet-manifests/config"},{"line_number":20,"context_line":"\tmv $(CURDIR)/debian/tmp/etc/puppet/hiera.yaml \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"c6f91a40_7537af25","line":17,"updated":"2021-10-22 18:14:42.000000000","message":"nit: remove whitespace at the end of the line\n\nWhy are we doing this? The CentOS package installs this in /etc/puppet as well. Trying to understand why we are deviating.","commit_id":"14d28a05e0ed96847f187abeef4df80d331d8b65"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"2fa4d865fb4b2bb66f5de60cfd06742d3b934d79","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules"},{"line_number":17,"context_line":"\t# Prevent puppet installation errors, since puppet ships "},{"line_number":18,"context_line":"\t# its own hiera.yaml"},{"line_number":19,"context_line":"\tmkdir -p $(CURDIR)/debian/tmp/usr/share/puppet-manifests/config"},{"line_number":20,"context_line":"\tmv $(CURDIR)/debian/tmp/etc/puppet/hiera.yaml \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"ef8f9758_2cefe80c","line":17,"in_reply_to":"78fdcaa5_757a711d","updated":"2021-10-26 12:06:30.000000000","message":"Looking a bit deeper, debian ships only a conffile, its puppet itself shipping a default hiera.yaml. We will need puppet to stop doing this:\n\nhttps://github.com/puppetlabs/puppet/commit/7178bf1850c1addc40b5cc31a29aa4add09f34a9","commit_id":"14d28a05e0ed96847f187abeef4df80d331d8b65"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"59fe9ffb093b9f31b41eb49d1b3b5735b71e7303","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules"},{"line_number":17,"context_line":"\t# Prevent puppet installation errors, since puppet ships "},{"line_number":18,"context_line":"\t# its own hiera.yaml"},{"line_number":19,"context_line":"\tmkdir -p $(CURDIR)/debian/tmp/usr/share/puppet-manifests/config"},{"line_number":20,"context_line":"\tmv $(CURDIR)/debian/tmp/etc/puppet/hiera.yaml \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"78fdcaa5_757a711d","line":17,"in_reply_to":"997a6d7a_e9af5dfb","updated":"2021-10-26 05:29:53.000000000","message":"Looks like the CentOS puppet package did not install a default hiera.yaml file, so we didn\u0027t have a conflict there.\n\nI think we need to patch the puppet-5.5.22 package to drop debian/conffiles/hiera.yaml so that this package can install to /etc/puppet. This version contains the hierarchy and datadir that aligns with our implementation and puppet-manifest-apply.sh","commit_id":"14d28a05e0ed96847f187abeef4df80d331d8b65"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"1241a3fb3910eb93856e32930792985653d4ad05","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules"},{"line_number":17,"context_line":"\t# Prevent puppet installation errors, since puppet ships "},{"line_number":18,"context_line":"\t# its own hiera.yaml"},{"line_number":19,"context_line":"\tmkdir -p $(CURDIR)/debian/tmp/usr/share/puppet-manifests/config"},{"line_number":20,"context_line":"\tmv $(CURDIR)/debian/tmp/etc/puppet/hiera.yaml \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"997a6d7a_e9af5dfb","line":17,"in_reply_to":"c6f91a40_7537af25","updated":"2021-10-23 12:59:52.000000000","message":"The puppet package in Debian ships its own /etc/puppet/hiera.yaml by default so when puppet is installed first and then puppet-manifest the install will fail because dpkg will prevent the package to install because /etc/puppet/hiera.yaml already exists. And its a conffile.","commit_id":"14d28a05e0ed96847f187abeef4df80d331d8b65"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"e4a1c37372eda2d8bd21958479e6a62b584e74e0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules"},{"line_number":17,"context_line":"\t# Prevent puppet installation errors, since puppet ships "},{"line_number":18,"context_line":"\t# its own hiera.yaml"},{"line_number":19,"context_line":"\tmkdir -p $(CURDIR)/debian/tmp/usr/share/puppet-manifests/config"},{"line_number":20,"context_line":"\tmv $(CURDIR)/debian/tmp/etc/puppet/hiera.yaml \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"6d3aa2dc_eb9f8d6e","line":17,"in_reply_to":"ef8f9758_2cefe80c","updated":"2021-10-26 15:27:04.000000000","message":"Done","commit_id":"14d28a05e0ed96847f187abeef4df80d331d8b65"}],"puppet-manifests/debian/deb_pkg/control":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"4dda910764d5876342bde5284be0dbac5f274edb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Source: puppet-manifests"},{"line_number":2,"context_line":"Section: admin"},{"line_number":3,"context_line":"Priority: optional"},{"line_number":4,"context_line":"Maintainer: Starlingx Developers \u003cstarlingx-discuss@lists.starlingx.io\u003e"},{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13)"},{"line_number":6,"context_line":"Standards-Version: 4.4.1"},{"line_number":7,"context_line":"Homepage: https://www.starlingx.io"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"63cced70_c53d257e","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":21},"updated":"2021-10-20 10:43:12.000000000","message":"X","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Source: puppet-manifests"},{"line_number":2,"context_line":"Section: admin"},{"line_number":3,"context_line":"Priority: optional"},{"line_number":4,"context_line":"Maintainer: Starlingx Developers \u003cstarlingx-discuss@lists.starlingx.io\u003e"},{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13)"},{"line_number":6,"context_line":"Standards-Version: 4.4.1"},{"line_number":7,"context_line":"Homepage: https://www.starlingx.io"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"2e3fb3a2_9629df7c","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":21},"in_reply_to":"63cced70_c53d257e","updated":"2021-10-21 13:22:07.000000000","message":"Done","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"4dda910764d5876342bde5284be0dbac5f274edb","unresolved":true,"context_lines":[{"line_number":52,"context_line":" normally aggregated in different files, like users, cron jobs, and hosts,"},{"line_number":53,"context_line":" along with obviously discrete elements like packages, services, and files."},{"line_number":54,"context_line":" ."},{"line_number":55,"context_line":" Puppet configuraton and manifests."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"37132ea2_f7cb68ee","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":20},"updated":"2021-10-20 10:43:12.000000000","message":"configuration","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"116b8e54a84b1b22249bc2d00ac0b3f8422db999","unresolved":false,"context_lines":[{"line_number":52,"context_line":" normally aggregated in different files, like users, cron jobs, and hosts,"},{"line_number":53,"context_line":" along with obviously discrete elements like packages, services, and files."},{"line_number":54,"context_line":" ."},{"line_number":55,"context_line":" Puppet configuraton and manifests."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"984510aa_aaf85a75","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":20},"in_reply_to":"37132ea2_f7cb68ee","updated":"2021-10-28 16:43:53.000000000","message":"Ack","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"}],"puppet-manifests/debian/deb_pkg/rules":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"4dda910764d5876342bde5284be0dbac5f274edb","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\t$(MAKE) install \\"},{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules "},{"line_number":17,"context_line":"\tdh_install"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"16aab6ef_e8ea6314","line":16,"range":{"start_line":16,"start_character":57,"end_line":16,"end_character":58},"updated":"2021-10-20 10:43:12.000000000","message":"extra whitespace","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"116b8e54a84b1b22249bc2d00ac0b3f8422db999","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\t$(MAKE) install \\"},{"line_number":14,"context_line":"\t\tBINDIR\u003d$(CURDIR)/debian/tmp/usr/local/bin \\"},{"line_number":15,"context_line":"\t\tCONFIGDIR\u003d$(CURDIR)/debian/tmp/etc/puppet \\"},{"line_number":16,"context_line":"\t\tMODULEDIR\u003d$(CURDIR)/debian/tmp/usr/share/puppet/modules "},{"line_number":17,"context_line":"\tdh_install"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ecec06ce_87cebe67","line":16,"range":{"start_line":16,"start_character":57,"end_line":16,"end_character":58},"in_reply_to":"16aab6ef_e8ea6314","updated":"2021-10-28 16:43:53.000000000","message":"Done","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"}],"puppet-manifests/debian/meta_data.yaml":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"4dda910764d5876342bde5284be0dbac5f274edb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: puppet-manifests"},{"line_number":3,"context_line":"debver: 1.0"},{"line_number":4,"context_line":"src_path: src"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"    dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"285681ec_2673f294","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":11},"updated":"2021-10-20 10:43:12.000000000","message":"Build issue: this needs to have an extra .0.\n\nAlso, the built package will be 1.0.0-1, use the same 1.0.0-1 here to create less confusion.","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8b2061d924c996c8bd988b366f7bc1b72e1ce519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: puppet-manifests"},{"line_number":3,"context_line":"debver: 1.0"},{"line_number":4,"context_line":"src_path: src"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"    dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2c1cb704_04fb7c14","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":11},"in_reply_to":"285681ec_2673f294","updated":"2021-10-21 13:22:07.000000000","message":"Done","commit_id":"5b074cf7a27320f2c8d08ee6c856221f757c80ec"}]}