)]}'
{"puppet-manifests/src/modules/platform/manifests/ceph.pp":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e18881841310b0b98ce6c2fc8f17cc876b667746","unresolved":true,"context_lines":[{"line_number":933,"context_line":"        # 1 node configuration, a single monitor is available"},{"line_number":934,"context_line":"        $mon_host \u003d $mon_0_addr"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        # Cleanup stx.5.0 ceph.conf from rerstored file from upgrade backup"},{"line_number":937,"context_line":"        ceph_config {"},{"line_number":938,"context_line":"          \u0027mon/mon warn on insecure global id reclaim\u0027:         value \u003d\u003e false;"},{"line_number":939,"context_line":"          \u0027mon/mon warn on insecure global id reclaim allowed\u0027: value \u003d\u003e false;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"41007f77_0bdfe301","line":936,"range":{"start_line":936,"start_character":41,"end_line":936,"end_character":50},"updated":"2021-11-15 01:06:04.000000000","message":"restored","commit_id":"ee68923085762dd0631bc0f122f990ea932229fc"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"8cc053a68066b6e7c1c97d714c3cbe7d55fef527","unresolved":false,"context_lines":[{"line_number":933,"context_line":"        # 1 node configuration, a single monitor is available"},{"line_number":934,"context_line":"        $mon_host \u003d $mon_0_addr"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        # Cleanup stx.5.0 ceph.conf from rerstored file from upgrade backup"},{"line_number":937,"context_line":"        ceph_config {"},{"line_number":938,"context_line":"          \u0027mon/mon warn on insecure global id reclaim\u0027:         value \u003d\u003e false;"},{"line_number":939,"context_line":"          \u0027mon/mon warn on insecure global id reclaim allowed\u0027: value \u003d\u003e false;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"36c9275e_57e31a91","line":936,"range":{"start_line":936,"start_character":41,"end_line":936,"end_character":50},"in_reply_to":"41007f77_0bdfe301","updated":"2021-11-15 01:12:51.000000000","message":"Done","commit_id":"ee68923085762dd0631bc0f122f990ea932229fc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e18881841310b0b98ce6c2fc8f17cc876b667746","unresolved":true,"context_lines":[{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        # Cleanup stx.5.0 ceph.conf from rerstored file from upgrade backup"},{"line_number":937,"context_line":"        ceph_config {"},{"line_number":938,"context_line":"          \u0027mon/mon warn on insecure global id reclaim\u0027:         value \u003d\u003e false;"},{"line_number":939,"context_line":"          \u0027mon/mon warn on insecure global id reclaim allowed\u0027: value \u003d\u003e false;"},{"line_number":940,"context_line":"          \u0027mon/auth allow insecure global id reclaim\u0027:          value \u003d\u003e true;"},{"line_number":941,"context_line":"          \u0027mon.controller-0/mon_addr\u0027:                          ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"07cb92f1_fce28978","line":938,"updated":"2021-11-15 01:06:04.000000000","message":"I dont think these are correct.   All the other ceph_config entries use underscores and do not have spaces in their entries.","commit_id":"ee68923085762dd0631bc0f122f990ea932229fc"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"8cc053a68066b6e7c1c97d714c3cbe7d55fef527","unresolved":true,"context_lines":[{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        # Cleanup stx.5.0 ceph.conf from rerstored file from upgrade backup"},{"line_number":937,"context_line":"        ceph_config {"},{"line_number":938,"context_line":"          \u0027mon/mon warn on insecure global id reclaim\u0027:         value \u003d\u003e false;"},{"line_number":939,"context_line":"          \u0027mon/mon warn on insecure global id reclaim allowed\u0027: value \u003d\u003e false;"},{"line_number":940,"context_line":"          \u0027mon/auth allow insecure global id reclaim\u0027:          value \u003d\u003e true;"},{"line_number":941,"context_line":"          \u0027mon.controller-0/mon_addr\u0027:                          ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"67b3b4f3_102696c2","line":938,"in_reply_to":"07cb92f1_fce28978","updated":"2021-11-15 01:12:51.000000000","message":"There are other configs that do not use underscore.\n\nPlease check mon section in https://opendev.org/starlingx/integ/src/branch/master/ceph/ceph/files/ceph.conf#L54\n\nAlso, this has been tested in AIO-SX and it solved warnings that were previously appearing,","commit_id":"ee68923085762dd0631bc0f122f990ea932229fc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"771a9f8585a019e832f5a03c9c7b0db6aa0deb57","unresolved":false,"context_lines":[{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        # Cleanup stx.5.0 ceph.conf from rerstored file from upgrade backup"},{"line_number":937,"context_line":"        ceph_config {"},{"line_number":938,"context_line":"          \u0027mon/mon warn on insecure global id reclaim\u0027:         value \u003d\u003e false;"},{"line_number":939,"context_line":"          \u0027mon/mon warn on insecure global id reclaim allowed\u0027: value \u003d\u003e false;"},{"line_number":940,"context_line":"          \u0027mon/auth allow insecure global id reclaim\u0027:          value \u003d\u003e true;"},{"line_number":941,"context_line":"          \u0027mon.controller-0/mon_addr\u0027:                          ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"99089fe5_9df5c5b1","line":938,"in_reply_to":"67b3b4f3_102696c2","updated":"2021-11-15 01:43:49.000000000","message":"Yes. This should be good. The config supports both styles with or without underscores.","commit_id":"ee68923085762dd0631bc0f122f990ea932229fc"}]}