)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"797f091609336eeea9a30ef8c805ff173b4d9cd6","unresolved":true,"context_lines":[{"line_number":16,"context_line":"AIO-DX config. Just keep running \"/etc/init.d/ceph restart mon\" until"},{"line_number":17,"context_line":"the following message appears:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icc55ab64a4d2a697e08935b120410a05dad16676"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"--------------------------------------------------"},{"line_number":22,"context_line":"controller-0:~$ sudo /etc/init.d/ceph restart mon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"220f57bb_3f9407c8","line":19,"updated":"2021-11-25 20:51:32.000000000","message":"Usually Change-Id is be located  with the story/task/bug/signed-off-by  near the end of the commit message","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"5793e1e27fca1a31e28856833417ec519708b0c3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"AIO-DX config. Just keep running \"/etc/init.d/ceph restart mon\" until"},{"line_number":17,"context_line":"the following message appears:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icc55ab64a4d2a697e08935b120410a05dad16676"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"--------------------------------------------------"},{"line_number":22,"context_line":"controller-0:~$ sudo /etc/init.d/ceph restart mon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a491045f_a3359182","line":19,"in_reply_to":"1ba7fa6b_9d1ace73","updated":"2021-11-25 20:59:21.000000000","message":"Ack","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e5e5d644a614f13a8b3df0dfe1abecae6d2493de","unresolved":true,"context_lines":[{"line_number":16,"context_line":"AIO-DX config. Just keep running \"/etc/init.d/ceph restart mon\" until"},{"line_number":17,"context_line":"the following message appears:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icc55ab64a4d2a697e08935b120410a05dad16676"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"--------------------------------------------------"},{"line_number":22,"context_line":"controller-0:~$ sudo /etc/init.d/ceph restart mon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ba7fa6b_9d1ace73","line":19,"in_reply_to":"220f57bb_3f9407c8","updated":"2021-11-25 20:56:37.000000000","message":"I think the \"----------\" might have confused the script and added the change-id there.","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"797f091609336eeea9a30ef8c805ff173b4d9cd6","unresolved":true,"context_lines":[{"line_number":26,"context_line":"Stopping Ceph mon.controller on controller-0...kill  99034...done"},{"line_number":27,"context_line":"\u003d\u003d\u003d mon.controller \u003d\u003d\u003d"},{"line_number":28,"context_line":"Starting Ceph mon.controller on controller-0..."},{"line_number":29,"context_line":"Failed to start transient scope unit: Unit ceph-mon.scope already exists."},{"line_number":30,"context_line":"failed: \u0027ulimit -n 32768; TCMALLOC_MAX_TOTAL_THREAD_CACHE_BYTES\u003d134217728  systemd-run --scope --unit\u003dceph-mon --slice\u003dsystem-ceph /usr/bin/ceph-mon -i controller --pid-file /var/run/ceph/mon.controller.pid -c /etc/ceph/ceph.conf --cluster ceph \u0027"},{"line_number":31,"context_line":"--------------------------------------------------"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4b130a35_7c7640d9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":73},"updated":"2021-11-25 20:51:32.000000000","message":"You could probably just include this one line as part of your: \u0027following message appears\u0027 comment above.\n\nHowever, since this is submitted for a task rather than a bug, I am fine with keeping this as well.","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"5793e1e27fca1a31e28856833417ec519708b0c3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Stopping Ceph mon.controller on controller-0...kill  99034...done"},{"line_number":27,"context_line":"\u003d\u003d\u003d mon.controller \u003d\u003d\u003d"},{"line_number":28,"context_line":"Starting Ceph mon.controller on controller-0..."},{"line_number":29,"context_line":"Failed to start transient scope unit: Unit ceph-mon.scope already exists."},{"line_number":30,"context_line":"failed: \u0027ulimit -n 32768; TCMALLOC_MAX_TOTAL_THREAD_CACHE_BYTES\u003d134217728  systemd-run --scope --unit\u003dceph-mon --slice\u003dsystem-ceph /usr/bin/ceph-mon -i controller --pid-file /var/run/ceph/mon.controller.pid -c /etc/ceph/ceph.conf --cluster ceph \u0027"},{"line_number":31,"context_line":"--------------------------------------------------"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"01a63fa3_c0bc6875","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":73},"in_reply_to":"4b130a35_7c7640d9","updated":"2021-11-25 20:59:21.000000000","message":"Ack","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"626b38d0a6c8914e0b4b58ca3e3fd08f2ffdd0e2","unresolved":true,"context_lines":[{"line_number":16,"context_line":"AIO-DX config. Just keep running \"/etc/init.d/ceph restart mon\" until"},{"line_number":17,"context_line":"the following message appears:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icc55ab64a4d2a697e08935b120410a05dad16676"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"--------------------------------------------------"},{"line_number":22,"context_line":"controller-0:~$ sudo /etc/init.d/ceph restart mon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"72e9484c_95108ae5","line":19,"updated":"2021-11-26 21:24:08.000000000","message":"There appears to be two different Change-Id in this commit message","commit_id":"42a9abe13d4a3e5b9615fb8dddaac8beabd576ad"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e69e197f498df7b98fa26314b6e04a8193258fc6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"AIO-DX config. Just keep running \"/etc/init.d/ceph restart mon\" until"},{"line_number":17,"context_line":"the following message appears:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icc55ab64a4d2a697e08935b120410a05dad16676"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"--------------------------------------------------"},{"line_number":22,"context_line":"controller-0:~$ sudo /etc/init.d/ceph restart mon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ec3fde8_fe3505c9","line":19,"in_reply_to":"3853d555_da040c68","updated":"2021-11-26 21:30:15.000000000","message":"Done","commit_id":"42a9abe13d4a3e5b9615fb8dddaac8beabd576ad"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"4170eb29ce42eac9a147a899daec7d85c93065bf","unresolved":true,"context_lines":[{"line_number":16,"context_line":"AIO-DX config. Just keep running \"/etc/init.d/ceph restart mon\" until"},{"line_number":17,"context_line":"the following message appears:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icc55ab64a4d2a697e08935b120410a05dad16676"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"--------------------------------------------------"},{"line_number":22,"context_line":"controller-0:~$ sudo /etc/init.d/ceph restart mon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3853d555_da040c68","line":19,"in_reply_to":"72e9484c_95108ae5","updated":"2021-11-26 21:28:09.000000000","message":"I\u0027m not sure why this did appear. I will remove it.","commit_id":"42a9abe13d4a3e5b9615fb8dddaac8beabd576ad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"797f091609336eeea9a30ef8c805ff173b4d9cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"971ea685_63a11bfa","updated":"2021-11-25 20:51:32.000000000","message":"changes seem fine to me.  I have only minor nits related to the commit message","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":34295,"name":"Flavio Luis Peres","email":"flavioluis.peres@windriver.com"},"change_message_id":"df0c98d9baf24b8a20424b2f0d29fc49c4a6fe36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed1e9360_8f9f0ed4","updated":"2021-11-26 19:03:37.000000000","message":"up","commit_id":"2103d859de3f86a31f0a4f084a132bf34e937c1b"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"cb74d59167c0361c422f69f83386df97eb6e8869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f6cb78cb_4cf50526","updated":"2021-11-26 21:31:32.000000000","message":"I\u0027m good with the changes.  We\u0027ll try to bottom out why \"sm-restart service ceph-mon\" and \"/etc/init.d/ceph restart mon\" aren\u0027t working as expected as separate issues.","commit_id":"b382a852cb368368c31d985a64c0bb3a5702cd06"}],"puppet-manifests/src/modules/platform/manifests/ceph.pp":[{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"eb21bc61f0ad3bb567ed93a84043f65a1c74a36f","unresolved":true,"context_lines":[{"line_number":958,"context_line":"    } -\u003e Exec[\u0027Restart Ceph Monitor\u0027]"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"    exec { \u0027Restart Ceph Monitor\u0027 :"},{"line_number":961,"context_line":"      command \u003d\u003e \u0027/etc/init.d/ceph restart mon\u0027,"},{"line_number":962,"context_line":"    }"},{"line_number":963,"context_line":"  }"},{"line_number":964,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3bd196e5_fc93220e","side":"PARENT","line":961,"updated":"2021-11-25 21:57:12.000000000","message":"I think the root cause is that we\u0027re restarting the process outside of SM. Why not just use sm-safe-restart? eg platform::sm::restart {\u0027ceph-mon\u0027:}","commit_id":"e223b96ac4ce4518d93636005bb28429b2aea165"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"9b842e033f5ecd23f84379e7c681879af41d6f40","unresolved":true,"context_lines":[{"line_number":958,"context_line":"    } -\u003e Exec[\u0027Restart Ceph Monitor\u0027]"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"    exec { \u0027Restart Ceph Monitor\u0027 :"},{"line_number":961,"context_line":"      command \u003d\u003e \u0027/etc/init.d/ceph restart mon\u0027,"},{"line_number":962,"context_line":"    }"},{"line_number":963,"context_line":"  }"},{"line_number":964,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa01db61_0283d9e7","side":"PARENT","line":961,"in_reply_to":"3bd196e5_fc93220e","updated":"2021-11-26 17:29:48.000000000","message":"I tried command \"sm-restart service ceph-mon\". In AIO-DX it didn\u0027t have any negative impact. For AIO-SX it didn\u0027t restart the monitor. \n\nThe restart operation is not required when adding \"mon_host\" in the config file. It was only required for the monitor in AIO-SX which is now being handled by running ceph commands directly.","commit_id":"e223b96ac4ce4518d93636005bb28429b2aea165"}]}
