)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"83bb8c408626efed2043d964b33172e10f5fe2bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0231aaf7_7cb70737","updated":"2021-12-21 21:38:50.000000000","message":"WIP, pending testing","commit_id":"3372db7b86d35c2b96d55cf04660a581da693155"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"d9351c8967181e28831b9d7a25170e27818b6160","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4cabc60_01366a47","updated":"2022-01-06 19:58:07.000000000","message":"Pending https://review.opendev.org/c/starlingx/config/+/823731","commit_id":"1677db4980e046e9e3a7b64487972c7ea8fe75c8"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"9a9c7123b059862433cb7585ec601b24cfaa477f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ecbd2610_d6824f01","updated":"2022-02-01 15:10:52.000000000","message":"updating CR pending response to comment on exec order","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"a33997b5abf26bcfc8667433595834b31f5f115e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7335db5b_d50b3ae9","updated":"2022-02-03 14:21:07.000000000","message":"I think the Task and Story #s are reversed","commit_id":"6777c9f28b8ffaf01635324f16b6ba6a39023e0f"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"6254d6506d6d1ba6b9b822f229f56d289357f9fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2e8436c5_ab8e50a9","in_reply_to":"7335db5b_d50b3ae9","updated":"2022-02-03 15:26:12.000000000","message":"Fixed, thanks.","commit_id":"6777c9f28b8ffaf01635324f16b6ba6a39023e0f"}],"puppet-manifests/src/modules/platform/manifests/ptpinstance.pp":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"33ec353f83c2e7c398c30a0afe7e61b4f479d5c8","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    exec { \"${ifname}_${parm}\":"},{"line_number":72,"context_line":"      command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*); echo ${wpc_commands[$parm][$value]}\","},{"line_number":73,"context_line":"      provider \u003d\u003e shell,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"07acfc5d_753198db","line":74,"updated":"2022-02-01 14:23:59.000000000","message":"Are these parameters specific to a particular NIC, and always exist?  For example, is it possible that companyB comes out with a NIC that does not have a u.fl2?  In that case it might be good to add an \u0027onlyif\u0027 the file path actually exists.  Not so easy to do it in this format -- did you explore doing all of this in a template .erb?","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"51ce72b5db8fdc04394f1e5b1cb53a3d77340a44","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    exec { \"${ifname}_${parm}\":"},{"line_number":72,"context_line":"      command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*); echo ${wpc_commands[$parm][$value]}\","},{"line_number":73,"context_line":"      provider \u003d\u003e shell,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"a863fee6_de66ff4b","line":74,"in_reply_to":"07acfc5d_753198db","updated":"2022-02-02 20:46:51.000000000","message":"After our discussion, I added onlyif conditions that check the class of NIC, this ensures that the given paths will be present and will not run on invalid NICs. This is the recommended NIC identifier to use as per the NIC documentation.","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"7a7983a1dc9401188bdf0c3130f63fa1e1bba011","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":88,"context_line":"      echo 0 1 \u003e /sys/class/net/${base_port}/device/ptp/\\$PTP/pins/U.FL1\","},{"line_number":89,"context_line":"    provider \u003d\u003e shell,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"  exec { \"${ifname}_clear_UFL2\":"},{"line_number":92,"context_line":"    command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":93,"context_line":"      echo 0 2 \u003e /sys/class/net/${base_port}/device/ptp/\\$PTP/pins/U.FL2\","},{"line_number":94,"context_line":"    provider \u003d\u003e shell,"},{"line_number":95,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bb0551bc_53861588","line":92,"range":{"start_line":90,"start_character":1,"end_line":92,"end_character":9},"updated":"2022-02-01 13:30:07.000000000","message":"if these commands need to be run sequentially, there should be \u0027-\u003e\u0027 dependency added.","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"51ce72b5db8fdc04394f1e5b1cb53a3d77340a44","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":88,"context_line":"      echo 0 1 \u003e /sys/class/net/${base_port}/device/ptp/\\$PTP/pins/U.FL1\","},{"line_number":89,"context_line":"    provider \u003d\u003e shell,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"  exec { \"${ifname}_clear_UFL2\":"},{"line_number":92,"context_line":"    command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":93,"context_line":"      echo 0 2 \u003e /sys/class/net/${base_port}/device/ptp/\\$PTP/pins/U.FL2\","},{"line_number":94,"context_line":"    provider \u003d\u003e shell,"},{"line_number":95,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"53ef2f9e_68bc0ea7","line":92,"range":{"start_line":90,"start_character":1,"end_line":92,"end_character":9},"in_reply_to":"bb0551bc_53861588","updated":"2022-02-02 20:46:51.000000000","message":"Thanks John, there is no requirement to run these sequentially.","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"33ec353f83c2e7c398c30a0afe7e61b4f479d5c8","unresolved":true,"context_lines":[{"line_number":115,"context_line":"class platform::ptpinstance::nic_clock ("},{"line_number":116,"context_line":"  $nic_clock_config \u003d {},"},{"line_number":117,"context_line":"  $nic_clock_enabled \u003d false,"},{"line_number":118,"context_line":"  $runtime \u003d false,"},{"line_number":119,"context_line":") {"},{"line_number":120,"context_line":"  if $nic_clock_enabled {"},{"line_number":121,"context_line":"    create_resources(\u0027nic_clock_reset\u0027, $nic_clock_config)"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"b39ae7bd_55a03109","line":118,"updated":"2022-02-01 14:23:59.000000000","message":"Is runtime needed / used?","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"51ce72b5db8fdc04394f1e5b1cb53a3d77340a44","unresolved":false,"context_lines":[{"line_number":115,"context_line":"class platform::ptpinstance::nic_clock ("},{"line_number":116,"context_line":"  $nic_clock_config \u003d {},"},{"line_number":117,"context_line":"  $nic_clock_enabled \u003d false,"},{"line_number":118,"context_line":"  $runtime \u003d false,"},{"line_number":119,"context_line":") {"},{"line_number":120,"context_line":"  if $nic_clock_enabled {"},{"line_number":121,"context_line":"    create_resources(\u0027nic_clock_reset\u0027, $nic_clock_config)"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"e7db1f35_73f6343e","line":118,"in_reply_to":"b39ae7bd_55a03109","updated":"2022-02-02 20:46:51.000000000","message":"Removed","commit_id":"ae994c333e0b2209bc25d4e00d1104663530b25d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"662b69ff3e1d64b465b3e1ce671434fb7bc2262c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":73,"context_line":"        echo ${wpc_commands[$parm][$value]}\","},{"line_number":74,"context_line":"      provider \u003d\u003e shell,"},{"line_number":75,"context_line":"      onlyif   \u003d\u003e \"grep 000e /sys/class/net/${base_port}/device/subsystem_device\""},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"e10ec2d0_e72492ff","line":75,"updated":"2022-02-02 22:35:06.000000000","message":"It appears this path  ../device/... does not exist on Debian systems?","commit_id":"6777c9f28b8ffaf01635324f16b6ba6a39023e0f"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"4d602500515819486ca40bca8234fc7a4397055c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":73,"context_line":"        echo ${wpc_commands[$parm][$value]}\","},{"line_number":74,"context_line":"      provider \u003d\u003e shell,"},{"line_number":75,"context_line":"      onlyif   \u003d\u003e \"grep 000e /sys/class/net/${base_port}/device/subsystem_device\""},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"99667a4c_f17020ee","line":75,"in_reply_to":"e10ec2d0_e72492ff","updated":"2022-02-03 16:32:14.000000000","message":"I just checked on Dan\u0027s debian system and the path is present.","commit_id":"6777c9f28b8ffaf01635324f16b6ba6a39023e0f"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"4cf914bd705082c22033889011cb472ef1e11901","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":73,"context_line":"        echo ${wpc_commands[$parm][$value]}\","},{"line_number":74,"context_line":"      provider \u003d\u003e shell,"},{"line_number":75,"context_line":"      onlyif   \u003d\u003e \"grep 000e /sys/class/net/${base_port}/device/subsystem_device\""},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"e3801215_c7201d7c","line":75,"updated":"2022-02-03 19:17:27.000000000","message":"In the case that we weren\u0027t able to calculate a base_port (not likely, but for whatever reason), this will catch the situation as well and not try to execute the configure.","commit_id":"b6b68a3cdeabd6fc65fcb3c7365500e13d67a35e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"3b30e2ceb7d05198182987f467064f6dd2125994","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      command  \u003d\u003e \"PTP\u003d$(basename /sys/class/net/${base_port}/device/ptp/ptp*);\\"},{"line_number":73,"context_line":"        echo ${wpc_commands[$parm][$value]}\","},{"line_number":74,"context_line":"      provider \u003d\u003e shell,"},{"line_number":75,"context_line":"      onlyif   \u003d\u003e \"grep 000e /sys/class/net/${base_port}/device/subsystem_device\""},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"2e6b4508_775954bd","line":75,"in_reply_to":"e3801215_c7201d7c","updated":"2022-02-03 19:24:26.000000000","message":"Ack","commit_id":"b6b68a3cdeabd6fc65fcb3c7365500e13d67a35e"}]}