)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"2e1ec453558343d5d9754ece6d2184777b99c438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb6fcd47_33413d9b","updated":"2022-01-14 21:16:16.000000000","message":"Testing","commit_id":"d963a64764cc1374b2b9215c4139ce2ddd4bc76e"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"c472571baa08d9fd046b56955df9639d95d334d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"073a31f6_866a44f8","updated":"2022-01-20 19:31:46.000000000","message":"LGTM, thanks Cole","commit_id":"a73a4c00cc3124e407d45618676cef31d4543c11"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"84b1f0193130f53a23636b839949a073bb331240","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5903399_e525db63","updated":"2022-01-20 16:28:44.000000000","message":"Re-tested on Standard and Simplex","commit_id":"a73a4c00cc3124e407d45618676cef31d4543c11"}],"puppet-manifests/src/modules/platform/manifests/ptpinstance.pp":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"e35ae6ae4ab2cb51605bf4784079a7495d7032e9","unresolved":true,"context_lines":[{"line_number":35,"context_line":"      command \u003d\u003e \"/usr/bin/systemctl enable \\"},{"line_number":36,"context_line":"      ${service}@${_name}\","},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  } else {"},{"line_number":39,"context_line":"    exec { \"disable-${_name}\":"},{"line_number":40,"context_line":"      command \u003d\u003e \"/usr/bin/systemctl disable \\"},{"line_number":41,"context_line":"                 ${service}@${_name}\","}],"source_content_type":"text/x-puppet","patch_set":4,"id":"149f65c9_8d3e5aa4","line":38,"updated":"2022-01-19 21:50:15.000000000","message":"can probably remove this condition as it\u0027s handled L104-124.","commit_id":"3e83c2f7e40b397cbd112c76455e5f0439f4567e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"84b1f0193130f53a23636b839949a073bb331240","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      command \u003d\u003e \"/usr/bin/systemctl enable \\"},{"line_number":36,"context_line":"      ${service}@${_name}\","},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  } else {"},{"line_number":39,"context_line":"    exec { \"disable-${_name}\":"},{"line_number":40,"context_line":"      command \u003d\u003e \"/usr/bin/systemctl disable \\"},{"line_number":41,"context_line":"                 ${service}@${_name}\","}],"source_content_type":"text/x-puppet","patch_set":4,"id":"005517ad_001058c1","line":38,"in_reply_to":"149f65c9_8d3e5aa4","updated":"2022-01-20 16:28:44.000000000","message":"Done. The enable condition is also checked at L56, so no need for that either.","commit_id":"3e83c2f7e40b397cbd112c76455e5f0439f4567e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"cfb207169c7a32d6c2a870add7757d9e077044d6","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    exec { \u0027disable-ptp4l-instance\u0027:"},{"line_number":105,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl disable ptp4l@*\u0027,"},{"line_number":106,"context_line":"      onlyif  \u003d\u003e \u0027test -f /etc/systemd/system/ptp4l@.service\u0027,"},{"line_number":107,"context_line":"      require \u003d\u003e Exec[\u0027systemctl-daemon-reload\u0027],"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    -\u003e exec { \u0027disable-phc2sys-instance\u0027:"},{"line_number":110,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl disable phc2sys@*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"59b77b01_c58bbf46","line":107,"updated":"2022-01-19 20:29:22.000000000","message":"Change this to ptpinstance-systemctl-daemon-reload as defined on line 97","commit_id":"3e83c2f7e40b397cbd112c76455e5f0439f4567e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"434cdd56c189f80f44cd2ca65f2625cc287346b5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    exec { \u0027disable-ptp4l-instance\u0027:"},{"line_number":105,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl disable ptp4l@*\u0027,"},{"line_number":106,"context_line":"      onlyif  \u003d\u003e \u0027test -f /etc/systemd/system/ptp4l@.service\u0027,"},{"line_number":107,"context_line":"      require \u003d\u003e Exec[\u0027systemctl-daemon-reload\u0027],"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    -\u003e exec { \u0027disable-phc2sys-instance\u0027:"},{"line_number":110,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl disable phc2sys@*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"6b1ea618_4ebf19f5","line":107,"in_reply_to":"2f1cf77b_956e1b8f","updated":"2022-01-20 20:32:53.000000000","message":"Shoot, I forgot to pull that change from my working branch. Corrected it, thanks!","commit_id":"3e83c2f7e40b397cbd112c76455e5f0439f4567e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"5c8c8b37ff70ebc3603ee87df6976d5e646105d3","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    exec { \u0027disable-ptp4l-instance\u0027:"},{"line_number":105,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl disable ptp4l@*\u0027,"},{"line_number":106,"context_line":"      onlyif  \u003d\u003e \u0027test -f /etc/systemd/system/ptp4l@.service\u0027,"},{"line_number":107,"context_line":"      require \u003d\u003e Exec[\u0027systemctl-daemon-reload\u0027],"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    -\u003e exec { \u0027disable-phc2sys-instance\u0027:"},{"line_number":110,"context_line":"      command \u003d\u003e \u0027/usr/bin/systemctl disable phc2sys@*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"2f1cf77b_956e1b8f","line":107,"in_reply_to":"59b77b01_c58bbf46","updated":"2022-01-20 20:23:08.000000000","message":"is this review comment still valid?","commit_id":"3e83c2f7e40b397cbd112c76455e5f0439f4567e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"5c8c8b37ff70ebc3603ee87df6976d5e646105d3","unresolved":true,"context_lines":[{"line_number":10,"context_line":") {"},{"line_number":11,"context_line":"  file { $_name:"},{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    notify  \u003d\u003e Service[\"instance-${_name}\"],"},{"line_number":14,"context_line":"    path    \u003d\u003e \"/etc/ptpinstance/${service}-${_name}.conf\","},{"line_number":15,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\u0027platform/ptpinstance.conf.erb\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"73b7c845_f1724edc","line":13,"updated":"2022-01-20 20:23:08.000000000","message":"does it matter that the notify is done here ahead of the \u0027file { \"${_name}-sysconfig\" \u0027 ?","commit_id":"a73a4c00cc3124e407d45618676cef31d4543c11"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"434cdd56c189f80f44cd2ca65f2625cc287346b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":") {"},{"line_number":11,"context_line":"  file { $_name:"},{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    notify  \u003d\u003e Service[\"instance-${_name}\"],"},{"line_number":14,"context_line":"    path    \u003d\u003e \"/etc/ptpinstance/${service}-${_name}.conf\","},{"line_number":15,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\u0027platform/ptpinstance.conf.erb\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5b36a021_6dd11491","line":13,"in_reply_to":"73b7c845_f1724edc","updated":"2022-01-20 20:32:53.000000000","message":"Nope, puppet handles this intelligently and the service is restarted as expected. I specifically validated this :)","commit_id":"a73a4c00cc3124e407d45618676cef31d4543c11"}]}