)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a1292afff70e894adc3ff8a4f905df7ea1d3c555","unresolved":true,"context_lines":[{"line_number":14,"context_line":"For Debian the implementation is completely new and for CentOS the"},{"line_number":15,"context_line":"specific code was isolated on its respective file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change still does support Debian static route creation, this will"},{"line_number":18,"context_line":"be handled on another task. The test focus was done on physical and"},{"line_number":19,"context_line":"VLAN interfaces as they are the ones supported on Debian at this"},{"line_number":20,"context_line":"moment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"52d3c553_bd237039","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":22},"updated":"2022-03-02 15:01:32.000000000","message":"still does? or still does \u0027not\u0027 ?","commit_id":"3c13fed072eb93266136b2bed7e77370dcb22832"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a2efdf42beff001559685c6967e27b451f66a846","unresolved":false,"context_lines":[{"line_number":14,"context_line":"For Debian the implementation is completely new and for CentOS the"},{"line_number":15,"context_line":"specific code was isolated on its respective file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change still does support Debian static route creation, this will"},{"line_number":18,"context_line":"be handled on another task. The test focus was done on physical and"},{"line_number":19,"context_line":"VLAN interfaces as they are the ones supported on Debian at this"},{"line_number":20,"context_line":"moment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"78b47d58_b9321eba","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":22},"in_reply_to":"52d3c553_bd237039","updated":"2022-03-02 16:09:12.000000000","message":"Done","commit_id":"3c13fed072eb93266136b2bed7e77370dcb22832"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"2030ffb1b22e1abecbe0239db3339eb7252ee69d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecf9f9cb_03e35daf","updated":"2022-02-23 22:21:42.000000000","message":"I think the structure/separation is good","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"17e020008144a6778dc6ba6cf3a20e3adeac9c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0557574e_e8646947","updated":"2022-02-23 18:27:45.000000000","message":"under development","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"979d28029f75caaca1fd32ccc8ab8b023808e5f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08b9bc99_c6b3732e","updated":"2022-03-01 17:46:56.000000000","message":"still developing","commit_id":"2f00064c7d7797b3972a44ede884e394d240146b"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"18dc242d_01631638","updated":"2022-03-02 20:14:16.000000000","message":"Were you able to ensure the update_routes is still working on CentOS?","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a12c8d6a_5fb94561","in_reply_to":"18dc242d_01631638","updated":"2022-03-04 12:33:28.000000000","message":"Yes I have, addition and removal, I will update the commit message","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"1dad2381e19a2614a5b05a5b43dce1334bf94dc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d7599635_71dd3217","updated":"2022-03-04 20:43:43.000000000","message":"Thanks Andre.  I think if there were more common functions, I might think about a \u0027common\u0027 network operation script/helper that could be sourced.  At this point, it\u0027s probably not worth it as it\u0027s only is_eq_sriov_numvfs, verify_all_vlans_created that seem to be duplicated (and could probably make the is_ethernet the same as well).","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"a2f2286de4d40cbb32ab4b6b789796a60258030a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"75bf3ef4_d4c9c28a","updated":"2022-03-07 15:10:39.000000000","message":"Thanks Andre","commit_id":"dd350d61c774aef5215ee702eb18358aea2c1f94"}],"puppet-manifests/src/Makefile":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"11dca57127d1ac739368e9e893d57153f8cc1515","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (C) 2019 Intel Corporation"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BINDIR ?\u003d /usr/local/bin"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d522e9d1_3c5c84ce","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":20},"updated":"2022-02-25 05:38:08.000000000","message":"2019-2022","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a2efdf42beff001559685c6967e27b451f66a846","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (C) 2019 Intel Corporation"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BINDIR ?\u003d /usr/local/bin"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5280bb21_d0cb4c4b","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":20},"in_reply_to":"d522e9d1_3c5c84ce","updated":"2022-03-02 16:09:12.000000000","message":"Done","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"}],"puppet-manifests/src/bin/apply_network_config.sh":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"11dca57127d1ac739368e9e893d57153f8cc1515","unresolved":true,"context_lines":[{"line_number":156,"context_line":"            log_it \"No /var/run/network-scripts.puppet/ifcfg-lo found! Aborting...\""},{"line_number":157,"context_line":"            exit 1"},{"line_number":158,"context_line":"        fi"},{"line_number":159,"context_line":"        source /usr/local/bin/network_sysconfig.sh"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    elif [ -d /etc/network/interfaces.d/ ] ; then"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"71216498_2cf37659","line":159,"updated":"2022-02-25 05:38:08.000000000","message":"I think you can add the following to pass Zuul for lines 159 and 163\n\n# shellcheck disable\u003dSC1091","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a2efdf42beff001559685c6967e27b451f66a846","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            log_it \"No /var/run/network-scripts.puppet/ifcfg-lo found! Aborting...\""},{"line_number":157,"context_line":"            exit 1"},{"line_number":158,"context_line":"        fi"},{"line_number":159,"context_line":"        source /usr/local/bin/network_sysconfig.sh"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    elif [ -d /etc/network/interfaces.d/ ] ; then"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"037d7d87_28d6d93e","line":159,"in_reply_to":"71216498_2cf37659","updated":"2022-03-02 16:09:12.000000000","message":"Done","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":true,"context_lines":[{"line_number":141,"context_line":"    # the network service."},{"line_number":142,"context_line":"    verify_all_vlans_created"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    for cfg_path in $(find $PUPPET_DIR -name \"${IFNAME_INCLUDE}\"); do"},{"line_number":145,"context_line":"        cfg\u003d$(basename $cfg_path)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if is_vlan $ETC_DIR/$cfg; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"92970292_cc4d1658","line":144,"updated":"2022-03-02 20:14:16.000000000","message":"Please use ${PUPPET_DIR} .. same for rest of variable expansion in this file","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    # the network service."},{"line_number":142,"context_line":"    verify_all_vlans_created"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    for cfg_path in $(find $PUPPET_DIR -name \"${IFNAME_INCLUDE}\"); do"},{"line_number":145,"context_line":"        cfg\u003d$(basename $cfg_path)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if is_vlan $ETC_DIR/$cfg; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ce2bd2ce_b4647657","line":144,"in_reply_to":"92970292_cc4d1658","updated":"2022-03-04 12:33:28.000000000","message":"Done","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        exit 1"},{"line_number":298,"context_line":"    fi"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    if [ ! -f /var/run/network-scripts.puppet/ifcfg-lo ] ; then"},{"line_number":301,"context_line":"        # Something has gone horribly wrong"},{"line_number":302,"context_line":"        log_it \"No /var/run/network-scripts.puppet/ifcfg-lo found! Aborting...\""},{"line_number":303,"context_line":"        exit 1"}],"source_content_type":"text/x-sh","patch_set":9,"id":"aa54f276_81eac455","line":300,"updated":"2022-03-02 20:14:16.000000000","message":"Is this file going to be there for Debian?","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        exit 1"},{"line_number":298,"context_line":"    fi"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    if [ ! -f /var/run/network-scripts.puppet/ifcfg-lo ] ; then"},{"line_number":301,"context_line":"        # Something has gone horribly wrong"},{"line_number":302,"context_line":"        log_it \"No /var/run/network-scripts.puppet/ifcfg-lo found! Aborting...\""},{"line_number":303,"context_line":"        exit 1"}],"source_content_type":"text/x-sh","patch_set":9,"id":"575d08c2_9bcf3705","line":300,"in_reply_to":"aa54f276_81eac455","updated":"2022-03-04 12:33:28.000000000","message":"After parse_interface_stanzas() is executed it must be there also","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"}],"puppet-manifests/src/bin/network_ifupdown.sh":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"11dca57127d1ac739368e9e893d57153f8cc1515","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47a6dfdb_3e6ebdc9","updated":"2022-02-25 05:38:08.000000000","message":"Add: \n\n################################################################################\n# Copyright (c) 2022 Wind River Systems, Inc.\n#\n# SPDX-License-Identifier: Apache-2.0\n#\n################################################################################","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a2efdf42beff001559685c6967e27b451f66a846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7177162e_2127a3a6","in_reply_to":"47a6dfdb_3e6ebdc9","updated":"2022-03-02 16:09:12.000000000","message":"Done","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":true,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# Parse /var/run/network-scripts.puppet/interfaces "},{"line_number":64,"context_line":"# into /var/run/network-scripts.puppet/ifcfg-[interface mane] files"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"function parse_interface_stanzas {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"0806a23f_8e720229","line":63,"updated":"2022-03-02 20:14:16.000000000","message":"nit: whitespace","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# Parse /var/run/network-scripts.puppet/interfaces "},{"line_number":64,"context_line":"# into /var/run/network-scripts.puppet/ifcfg-[interface mane] files"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"function parse_interface_stanzas {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"5486b5aa_dd8946b2","line":63,"in_reply_to":"0806a23f_8e720229","updated":"2022-03-04 12:33:28.000000000","message":"Done","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            if [ $? -ne 0 ] ; then"},{"line_number":131,"context_line":"                log_it \"$cfg - not present on the kernel, bring up before proceeding\""},{"line_number":132,"context_line":"                do_if_up $cfg_path"},{"line_number":133,"context_line":"                is_vlan_device_present_on_kernel $ETC_DIR/$cfg"},{"line_number":134,"context_line":"                if [ $? -ne 0 ] ; then"},{"line_number":135,"context_line":"                    log_it \"$cfg - failed to add VLAN interface on kernel\""},{"line_number":136,"context_line":"                fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9381c27b_79c17fb8","line":133,"updated":"2022-03-02 20:14:16.000000000","message":"Is there a reason you are doing the check again here and not in the sysconfig version?","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if [ $? -ne 0 ] ; then"},{"line_number":131,"context_line":"                log_it \"$cfg - not present on the kernel, bring up before proceeding\""},{"line_number":132,"context_line":"                do_if_up $cfg_path"},{"line_number":133,"context_line":"                is_vlan_device_present_on_kernel $ETC_DIR/$cfg"},{"line_number":134,"context_line":"                if [ $? -ne 0 ] ; then"},{"line_number":135,"context_line":"                    log_it \"$cfg - failed to add VLAN interface on kernel\""},{"line_number":136,"context_line":"                fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"e367f6ee_0423caed","line":133,"in_reply_to":"9381c27b_79c17fb8","updated":"2022-03-04 12:33:28.000000000","message":"Actually I used for debugging and forgot to remove it, I can remove from the ifupdown or add it on sysconfig\nI will add it on sysconfig to help the debug there","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":true,"context_lines":[{"line_number":180,"context_line":"#                 part of a bond"},{"line_number":181,"context_line":"#"},{"line_number":182,"context_line":"function is_ethernet {"},{"line_number":183,"context_line":"    local cfg\u003d$1"},{"line_number":184,"context_line":"    if [ -f $cfg ]; then"},{"line_number":185,"context_line":"        if ! is_vlan $cfg; then"},{"line_number":186,"context_line":"            if ! is_slave $cfg; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"4405d2b7_eb62ff53","line":183,"updated":"2022-03-02 20:14:16.000000000","message":"Ok, we are checking the existence of the cfg file here, but not in the sysconfig version.  This is because in the sysconfig version it\u0027s done underneath at cfg_has_property_with_value function.","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[{"line_number":180,"context_line":"#                 part of a bond"},{"line_number":181,"context_line":"#"},{"line_number":182,"context_line":"function is_ethernet {"},{"line_number":183,"context_line":"    local cfg\u003d$1"},{"line_number":184,"context_line":"    if [ -f $cfg ]; then"},{"line_number":185,"context_line":"        if ! is_vlan $cfg; then"},{"line_number":186,"context_line":"            if ! is_slave $cfg; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"23b62869_fcffddbe","line":183,"in_reply_to":"4405d2b7_eb62ff53","updated":"2022-03-04 12:33:28.000000000","message":"Ack","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"1dad2381e19a2614a5b05a5b43dce1334bf94dc0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"################################################################################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"export IFNAME_INCLUDE\u003d\"ifcfg-*\""},{"line_number":9,"context_line":"export PUPPET_FILE\u003d\"/var/run/network-scripts.puppet/interfaces\""},{"line_number":10,"context_line":"export ETC_DIR\u003d\"/etc/network/interfaces.d/\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"264ff104_19a2d332","line":7,"updated":"2022-03-04 20:43:43.000000000","message":"Can you add a description at the top - something about how this file contains Debian helper functions used by the apply_network_config.sh script?","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"49984516f95d35bce6c69d7d258c1f7e76648961","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"################################################################################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"export IFNAME_INCLUDE\u003d\"ifcfg-*\""},{"line_number":9,"context_line":"export PUPPET_FILE\u003d\"/var/run/network-scripts.puppet/interfaces\""},{"line_number":10,"context_line":"export ETC_DIR\u003d\"/etc/network/interfaces.d/\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"97e0e65b_50fb57ce","line":7,"in_reply_to":"264ff104_19a2d332","updated":"2022-03-07 13:19:38.000000000","message":"Done","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"}],"puppet-manifests/src/bin/network_sysconfig.sh":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"11dca57127d1ac739368e9e893d57153f8cc1515","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8eed9ca6_7b97a8c8","updated":"2022-02-25 05:38:08.000000000","message":"Add: \n\n################################################################################\n# Copyright (c) 2022 Wind River Systems, Inc.\n#\n# SPDX-License-Identifier: Apache-2.0\n#\n################################################################################","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a2efdf42beff001559685c6967e27b451f66a846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b1ff2c3_a61d3029","in_reply_to":"8eed9ca6_7b97a8c8","updated":"2022-03-02 16:09:12.000000000","message":"Done","commit_id":"ba219cf99d295c33b824ffc0fe9e703a4ce81296"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8604354a9f8760d01845c42d09dc2af3da697c7b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    local cfg\u003d$1"},{"line_number":43,"context_line":"    local attr_name\u003d$2"},{"line_number":44,"context_line":"    local attr_value"},{"line_number":45,"context_line":"    attr_value\u003d$(cat $cfg | grep $attr_name\u003d | awk -F \"\u003d\" {\u0027print $2\u0027})"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    #"}],"source_content_type":"text/x-sh","patch_set":9,"id":"635632bf_07573e37","line":45,"updated":"2022-03-02 20:14:16.000000000","message":"Could you wrap all variable expansion in ${} ?  There\u0027s kind of a mix in this file of doing it or not.","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"1fbc07f5a8b7d5737440a39575a74c2948fcfd73","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    local cfg\u003d$1"},{"line_number":43,"context_line":"    local attr_name\u003d$2"},{"line_number":44,"context_line":"    local attr_value"},{"line_number":45,"context_line":"    attr_value\u003d$(cat $cfg | grep $attr_name\u003d | awk -F \"\u003d\" {\u0027print $2\u0027})"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    #"}],"source_content_type":"text/x-sh","patch_set":9,"id":"79af38f8_a77e6982","line":45,"in_reply_to":"635632bf_07573e37","updated":"2022-03-04 12:33:28.000000000","message":"Done","commit_id":"b483fd32ac94447b6a3a7c4041cceebfc2411e31"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"1dad2381e19a2614a5b05a5b43dce1334bf94dc0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"################################################################################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"export IFNAME_INCLUDE\u003d\"ifcfg-*\""},{"line_number":9,"context_line":"export RTNAME_INCLUDE\u003d\"route-*\""},{"line_number":10,"context_line":"export ETC_DIR\u003d\"/etc/sysconfig/network-scripts/\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"daafbcd9_f1a42092","line":7,"updated":"2022-03-04 20:43:43.000000000","message":"Can you add a description at the top - something about how this file contains CentOS helper functions used by the apply_network_config.sh script?","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"49984516f95d35bce6c69d7d258c1f7e76648961","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"################################################################################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"export IFNAME_INCLUDE\u003d\"ifcfg-*\""},{"line_number":9,"context_line":"export RTNAME_INCLUDE\u003d\"route-*\""},{"line_number":10,"context_line":"export ETC_DIR\u003d\"/etc/sysconfig/network-scripts/\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"270e3056_1b145e96","line":7,"in_reply_to":"daafbcd9_f1a42092","updated":"2022-03-07 13:19:38.000000000","message":"Done","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"1dad2381e19a2614a5b05a5b43dce1334bf94dc0","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"function do_if_up {"},{"line_number":13,"context_line":"    local iface\u003d$1"},{"line_number":14,"context_line":"    log_it \"Bringing ${iface} up\""},{"line_number":15,"context_line":"    /sbin/ifup ${iface}"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"cdc92065_25f262d1","line":14,"updated":"2022-03-04 20:43:43.000000000","message":"I know this works as the file is being sourced, but looking at this file in isolation I would say \"where\u0027s the log_it function\" .  I am thinking for debugging purposes, I wonder if it\u0027s better to have a separate log function that would indicate the log is coming from apply_network_config.sh -\u003e network_sysconfig.sh via the ${BASH_SOURCE[]} array.  Right now I think the log will print out \"apply_network_config.sh message\", so I might go looking for that message in apply_network_config.sh and not find it.","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"49984516f95d35bce6c69d7d258c1f7e76648961","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"function do_if_up {"},{"line_number":13,"context_line":"    local iface\u003d$1"},{"line_number":14,"context_line":"    log_it \"Bringing ${iface} up\""},{"line_number":15,"context_line":"    /sbin/ifup ${iface}"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"89bf7985_2be6c6c6","line":14,"in_reply_to":"cdc92065_25f262d1","updated":"2022-03-07 13:19:38.000000000","message":"Done","commit_id":"68946e217bb985eaf3a3992e0ab8845e7d9d25b4"}]}