)]}'
{"puppet-manifests/src/modules/openstack/manifests/barbican.pp":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"991d266a93e8e975ed8ed7b7d973f718ff947bff","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    tag   \u003d\u003e \u0027modify-workers\u0027,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  # On Debian barbican is set to run by UWSGI by default so"},{"line_number":46,"context_line":"  # it doesn\u0027t update gunicorn-config.py. Update it in order"},{"line_number":47,"context_line":"  # to run by gunicorn."},{"line_number":48,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":49,"context_line":"    include ::platform::network::mgmt::params"},{"line_number":50,"context_line":"    $api_host \u003d $::platform::network::mgmt::params::subnet_version ? {"},{"line_number":51,"context_line":"      6       \u003d\u003e \"[${::platform::network::mgmt::params::controller_address}]\","},{"line_number":52,"context_line":"      default \u003d\u003e $::platform::network::mgmt::params::controller_address,"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"    file_line { \u0027Modify bind_port in gunicorn-config.py\u0027:"},{"line_number":55,"context_line":"      path  \u003d\u003e \u0027/etc/barbican/gunicorn-config.py\u0027,"},{"line_number":56,"context_line":"      line  \u003d\u003e \"bind \u003d \u0027${api_host}:${api_port}\u0027\","},{"line_number":57,"context_line":"      match \u003d\u003e \u0027.*bind \u003d .*\u0027,"},{"line_number":58,"context_line":"      tag   \u003d\u003e \u0027modify-bind-port\u0027,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  file { \u0027/etc/logrotate.d/barbican-api\u0027:"},{"line_number":63,"context_line":"    ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"373d6fb0_a3b9f283","line":60,"range":{"start_line":45,"start_character":0,"end_line":60,"end_character":3},"updated":"2022-03-10 10:12:06.000000000","message":"Would it make more sense to keep this contained in puppet module for barbican?\n\nWhen class barbican::api is called, we can update the gunicorn-config.\n~ lines 490 in barbican api.pp remove the check:\n    # Debian is using UWSGI, not gunicorn\n    if $::os_package_type !\u003d \u0027debian\u0027 {\n      file_line { \u0027Modify bind_port in gunicorn-config.py\u0027:\n        path  \u003d\u003e \u0027/etc/barbican/gunicorn-config.py\u0027,\n        line  \u003d\u003e \"bind \u003d \u0027${bind_host}:${bind_port}\u0027\",\n        match \u003d\u003e \u0027.*bind \u003d .*\u0027,\n        tag   \u003d\u003e \u0027modify-bind-port\u0027,\n      }\n    }","commit_id":"e4536355900ed1306d4fada1fa3f31b5a3a4acd2"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"bf537f4bf63db855aa02df47bf4780c8a0126c54","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    tag   \u003d\u003e \u0027modify-workers\u0027,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  # On Debian barbican is set to run by UWSGI by default so"},{"line_number":46,"context_line":"  # it doesn\u0027t update gunicorn-config.py. Update it in order"},{"line_number":47,"context_line":"  # to run by gunicorn."},{"line_number":48,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":49,"context_line":"    include ::platform::network::mgmt::params"},{"line_number":50,"context_line":"    $api_host \u003d $::platform::network::mgmt::params::subnet_version ? {"},{"line_number":51,"context_line":"      6       \u003d\u003e \"[${::platform::network::mgmt::params::controller_address}]\","},{"line_number":52,"context_line":"      default \u003d\u003e $::platform::network::mgmt::params::controller_address,"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"    file_line { \u0027Modify bind_port in gunicorn-config.py\u0027:"},{"line_number":55,"context_line":"      path  \u003d\u003e \u0027/etc/barbican/gunicorn-config.py\u0027,"},{"line_number":56,"context_line":"      line  \u003d\u003e \"bind \u003d \u0027${api_host}:${api_port}\u0027\","},{"line_number":57,"context_line":"      match \u003d\u003e \u0027.*bind \u003d .*\u0027,"},{"line_number":58,"context_line":"      tag   \u003d\u003e \u0027modify-bind-port\u0027,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  file { \u0027/etc/logrotate.d/barbican-api\u0027:"},{"line_number":63,"context_line":"    ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"018dfd94_e5dbc775","line":60,"range":{"start_line":45,"start_character":0,"end_line":60,"end_character":3},"in_reply_to":"373d6fb0_a3b9f283","updated":"2022-03-10 14:17:49.000000000","message":"The problem with this is that puppet-module-barbican is a binary package we include in the iso. I think it\u0027s better to do this in stx openstack barbican.pp so to avoid building puppet-module-barbican from source and patching it.","commit_id":"e4536355900ed1306d4fada1fa3f31b5a3a4acd2"}]}