)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"1338c1847fe5034cef0497f55eda8cc20f3a27c9","unresolved":true,"context_lines":[{"line_number":28,"context_line":"PASS: On AIO-SX, after controller unlock, login by \"admin\" user on"},{"line_number":29,"context_line":"      console, and su to \"admin\" on ssh session."},{"line_number":30,"context_line":"PASS: On AIO-DX, after both controllers unlock, login to both"},{"line_number":31,"context_line":"      controlles by \"admin\" user on console, and su to \"admin\" on"},{"line_number":32,"context_line":"      ssh session on both controllers."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Story: 2009101"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8374dcc7_d6c45e6f","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":16},"updated":"2022-03-31 22:04:09.000000000","message":"nit: controllers","commit_id":"33d05344efe59b146fc4303d8290c0f7929a37ee"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"69aa71ee9ca12d63606044a75f9ce7d6ca7bdce6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"PASS: On AIO-SX, after controller unlock, login by \"admin\" user on"},{"line_number":29,"context_line":"      console, and su to \"admin\" on ssh session."},{"line_number":30,"context_line":"PASS: On AIO-DX, after both controllers unlock, login to both"},{"line_number":31,"context_line":"      controlles by \"admin\" user on console, and su to \"admin\" on"},{"line_number":32,"context_line":"      ssh session on both controllers."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Story: 2009101"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f86544b6_2977022f","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":16},"in_reply_to":"8374dcc7_d6c45e6f","updated":"2022-04-01 13:27:17.000000000","message":"Ack","commit_id":"33d05344efe59b146fc4303d8290c0f7929a37ee"}],"puppet-manifests/src/manifests/aio.pp":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"191e79cfaca1791ce90c7291c710346c7ffde65f","unresolved":true,"context_lines":[{"line_number":23,"context_line":"include ::platform::drbd"},{"line_number":24,"context_line":"include ::platform::exports"},{"line_number":25,"context_line":"include ::platform::dns"},{"line_number":26,"context_line":"include ::platform::password"},{"line_number":27,"context_line":"include ::platform::ldap::server"},{"line_number":28,"context_line":"include ::platform::ldap::client"},{"line_number":29,"context_line":"include ::platform::ntp::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1dd3bb99_d8f839e5","line":26,"updated":"2022-03-28 13:12:12.000000000","message":"is this order (::platform::password before ::platform::ldap::server, ::platform::ldap::client) also required in controller.pp ?","commit_id":"cec9ee81a090ee8cb8f2b2f291c3e57bf93317bb"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"2640bcb524fd7d0d0f3f1ce4b7cc710b9a6b91ca","unresolved":true,"context_lines":[{"line_number":23,"context_line":"include ::platform::drbd"},{"line_number":24,"context_line":"include ::platform::exports"},{"line_number":25,"context_line":"include ::platform::dns"},{"line_number":26,"context_line":"include ::platform::password"},{"line_number":27,"context_line":"include ::platform::ldap::server"},{"line_number":28,"context_line":"include ::platform::ldap::client"},{"line_number":29,"context_line":"include ::platform::ntp::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"516c1db7_d40c714b","line":26,"in_reply_to":"1dd3bb99_d8f839e5","updated":"2022-03-28 13:23:49.000000000","message":"It may be required as well. But since there is no way to test for Debian, I\u0027ll defer that update until we can test it on Debian DX.","commit_id":"cec9ee81a090ee8cb8f2b2f291c3e57bf93317bb"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"283da2b38376e9cd74713add4f8104133f82cbb3","unresolved":true,"context_lines":[{"line_number":23,"context_line":"include ::platform::drbd"},{"line_number":24,"context_line":"include ::platform::exports"},{"line_number":25,"context_line":"include ::platform::dns"},{"line_number":26,"context_line":"include ::platform::password"},{"line_number":27,"context_line":"include ::platform::ldap::server"},{"line_number":28,"context_line":"include ::platform::ldap::client"},{"line_number":29,"context_line":"include ::platform::ntp::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"69296c6e_6265146f","line":26,"in_reply_to":"516c1db7_d40c714b","updated":"2022-03-28 15:58:47.000000000","message":"Thanks Andy, I\u0027d recommend a task to be added to the Story to track that verification.","commit_id":"cec9ee81a090ee8cb8f2b2f291c3e57bf93317bb"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"806baea55ea1bdef3d0ebf234f63a67dcc97e27b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"include ::platform::drbd"},{"line_number":24,"context_line":"include ::platform::exports"},{"line_number":25,"context_line":"include ::platform::dns"},{"line_number":26,"context_line":"include ::platform::password"},{"line_number":27,"context_line":"include ::platform::ldap::server"},{"line_number":28,"context_line":"include ::platform::ldap::client"},{"line_number":29,"context_line":"include ::platform::ntp::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dc4d6cb7_40fba7ed","line":26,"in_reply_to":"69296c6e_6265146f","updated":"2022-03-28 16:26:39.000000000","message":"\"Task 44869: Fix ldap user not found for DX on Debian\" has been added to the story.","commit_id":"cec9ee81a090ee8cb8f2b2f291c3e57bf93317bb"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"d5038310ef485960285a1b6ecf494e9844ac708e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"include ::platform::drbd"},{"line_number":24,"context_line":"include ::platform::exports"},{"line_number":25,"context_line":"include ::platform::dns"},{"line_number":26,"context_line":"include ::platform::password"},{"line_number":27,"context_line":"include ::platform::ldap::server"},{"line_number":28,"context_line":"include ::platform::ldap::client"},{"line_number":29,"context_line":"include ::platform::ntp::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4a5565cc_999408d7","line":26,"in_reply_to":"6c3e19bb_5957b4e3","updated":"2022-03-29 14:39:45.000000000","message":"Ack","commit_id":"cec9ee81a090ee8cb8f2b2f291c3e57bf93317bb"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ca708d7499ae3ed745727034fdcb1d8e3a220dfb","unresolved":true,"context_lines":[{"line_number":23,"context_line":"include ::platform::drbd"},{"line_number":24,"context_line":"include ::platform::exports"},{"line_number":25,"context_line":"include ::platform::dns"},{"line_number":26,"context_line":"include ::platform::password"},{"line_number":27,"context_line":"include ::platform::ldap::server"},{"line_number":28,"context_line":"include ::platform::ldap::client"},{"line_number":29,"context_line":"include ::platform::ntp::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6c3e19bb_5957b4e3","line":26,"in_reply_to":"dc4d6cb7_40fba7ed","updated":"2022-03-28 22:36:04.000000000","message":"In addition, consider adding:\n\n  Class[\u0027platform::password\u0027] -\u003e Class[$name]\n\nto the platform::ldap::server class to guarantee this dependency in case for some reason the include ordering isn\u0027t enough to guarantee the proper order.","commit_id":"cec9ee81a090ee8cb8f2b2f291c3e57bf93317bb"}],"puppet-manifests/src/modules/platform/manifests/ldap.pp":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"314210aa39c647e0c424bc351a874a9eae6ea139","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class platform::ldap::server"},{"line_number":26,"context_line":"  inherits ::platform::ldap::params {"},{"line_number":27,"context_line":"  Class[\u0027platform::password\u0027] -\u003e Class[$name]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! $ldapserver_remote {"},{"line_number":30,"context_line":"    include ::platform::ldap::server::local"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ea2a751_352a1aae","line":27,"updated":"2022-03-29 14:56:31.000000000","message":"this should be verified on controller (non-AIO) as that has a different include order","commit_id":"a591191e6d86dd3b0b55a0f74f42bb941a3f4aef"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"7887826b4323c048f1cacb51d37ad155f4e53f29","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class platform::ldap::server"},{"line_number":26,"context_line":"  inherits ::platform::ldap::params {"},{"line_number":27,"context_line":"  Class[\u0027platform::password\u0027] -\u003e Class[$name]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! $ldapserver_remote {"},{"line_number":30,"context_line":"    include ::platform::ldap::server::local"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f1aa4a46_db6a3d13","line":27,"in_reply_to":"9ea2a751_352a1aae","updated":"2022-03-29 15:40:58.000000000","message":"Yes, that\u0027s right. I\u0027ll update controller.pp with the new order as well and verify on CentOS. (The Debian verification on DX will be covered by the new task I created)","commit_id":"a591191e6d86dd3b0b55a0f74f42bb941a3f4aef"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"86c4612ecb27a4bd81533cac9eda0b6d0290f483","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class platform::ldap::server"},{"line_number":26,"context_line":"  inherits ::platform::ldap::params {"},{"line_number":27,"context_line":"  Class[\u0027platform::password\u0027] -\u003e Class[$name]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! $ldapserver_remote {"},{"line_number":30,"context_line":"    include ::platform::ldap::server::local"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2928b402_e1dcc478","line":27,"in_reply_to":"f1aa4a46_db6a3d13","updated":"2022-03-31 21:47:29.000000000","message":"Ack","commit_id":"a591191e6d86dd3b0b55a0f74f42bb941a3f4aef"}]}