)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ecdc0624bc80e201f9ab73fcadd54c077344ab70","unresolved":true,"context_lines":[{"line_number":46,"context_line":"PASS: /etc/haproxy/haproxy.cfg configured properly by puppet"},{"line_number":47,"context_line":"PASS: /etc/haproxy/haproxy.cfg checked on CentOS"},{"line_number":48,"context_line":"PASS: On both CentOS/Debian no error on AIO apply manifest"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Story: 2009965"},{"line_number":51,"context_line":"Task: 45149"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"04cffb4b_5d4d80ed","line":49,"updated":"2022-04-27 18:33:32.000000000","message":"Will this affect the proxy utils, such as at distributedcloud/dcorch/api/proxy/common/utils.py::set_request_forward_environ() ?  If further dcorch Debian investigation required, recommend a separate task to track.","commit_id":"79cb51d0b4ece53b88de83efbf5a3b1eb21d46a2"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"94209fcdd56afe1ff6c12ce92215316530f0d41a","unresolved":true,"context_lines":[{"line_number":46,"context_line":"PASS: /etc/haproxy/haproxy.cfg configured properly by puppet"},{"line_number":47,"context_line":"PASS: /etc/haproxy/haproxy.cfg checked on CentOS"},{"line_number":48,"context_line":"PASS: On both CentOS/Debian no error on AIO apply manifest"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Story: 2009965"},{"line_number":51,"context_line":"Task: 45149"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"86220979_b07df9fe","line":49,"in_reply_to":"04cffb4b_5d4d80ed","updated":"2022-04-27 20:09:46.000000000","message":"From what I saw the processing of this \"X-Forwarded-Proto\" optional header is done on NVF VIM api and ceph, those on ::set_request_forward_environ() seem to be others. Basically, on VIM, if it is there it changes to http/https (vice-versa), it changes the protocol on the url.","commit_id":"79cb51d0b4ece53b88de83efbf5a3b1eb21d46a2"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"99bf0e1cfdf187d49c628674701a03d8ae3187b0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"PASS: /etc/haproxy/haproxy.cfg configured properly by puppet"},{"line_number":47,"context_line":"PASS: /etc/haproxy/haproxy.cfg checked on CentOS"},{"line_number":48,"context_line":"PASS: On both CentOS/Debian no error on AIO apply manifest"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Story: 2009965"},{"line_number":51,"context_line":"Task: 45149"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a72d76eb_afedf04e","line":49,"in_reply_to":"86220979_b07df9fe","updated":"2022-04-28 19:45:24.000000000","message":"Ack","commit_id":"79cb51d0b4ece53b88de83efbf5a3b1eb21d46a2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"c062b74298154d72172651aea4469ed7f572fc8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad6a2fe8_485e110f","updated":"2022-04-22 18:22:00.000000000","message":"To be tested on CentOS","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"}],"puppet-manifests/src/modules/platform/manifests/haproxy.pp":[{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"f070869a721bd74fad9cfad8dbb0466b6e72d2ee","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    $real_client_timeout \u003d undef"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":89,"context_line":"    if $proto !\u003d undef {"},{"line_number":90,"context_line":"      $header \u003d regsubst($proto, /:\\\\/, \u0027\u0027)"},{"line_number":91,"context_line":"      $proto_header \u003d \"add-header ${header}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d9b40749_bd838117","line":88,"updated":"2022-04-22 18:23:59.000000000","message":"Maybe instead of checking Debian, check the haproxy version? However, by doing that, other parts of the code shall be screened too, so it seems to be a wider work. Not sure we we should leave a comment or something.","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"99bf0e1cfdf187d49c628674701a03d8ae3187b0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    $real_client_timeout \u003d undef"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":89,"context_line":"    if $proto !\u003d undef {"},{"line_number":90,"context_line":"      $header \u003d regsubst($proto, /:\\\\/, \u0027\u0027)"},{"line_number":91,"context_line":"      $proto_header \u003d \"add-header ${header}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c13d9c84_4a66d89c","line":88,"in_reply_to":"d9b40749_bd838117","updated":"2022-04-28 19:45:24.000000000","message":"Ack","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"0a02dc4daf8d52aa088dc777856e7ba0d8cf8c38","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if $hsts_option !\u003d undef {"},{"line_number":97,"context_line":"      $htst_header \u003d regsubst($hsts_option, /:\\\\/, \u0027\u0027)"},{"line_number":98,"context_line":"      $hsts_option_header \u003d \"add-header ${htst_header}\""},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      $hsts_option_header \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d4e0179a_12040dba","line":97,"range":{"start_line":97,"start_character":44,"end_line":97,"end_character":49},"updated":"2022-04-26 15:06:47.000000000","message":"This worked on Debian but got an error on CentOS, most probably because CentOS puppet is older, 4.8.2.","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"ee5554805f6e5804874cd49b0dfdc60ff467fce8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if $hsts_option !\u003d undef {"},{"line_number":97,"context_line":"      $htst_header \u003d regsubst($hsts_option, /:\\\\/, \u0027\u0027)"},{"line_number":98,"context_line":"      $hsts_option_header \u003d \"add-header ${htst_header}\""},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      $hsts_option_header \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c58df27d_4616ce04","line":97,"range":{"start_line":97,"start_character":44,"end_line":97,"end_character":49},"in_reply_to":"5d19a0fc_8e07958f","updated":"2022-04-27 00:02:57.000000000","message":"Using:\n\nregsubst($hsts_option, \u0027:\\\\\\ \u0027, \u0027 \u0027)\n\nit worked on both as if it needed a escape on the space that comes after the \"\\\", then add space back.","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"323774e0b4d3aa76b47b08a4cb7eed64f2497aa7","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if $hsts_option !\u003d undef {"},{"line_number":97,"context_line":"      $htst_header \u003d regsubst($hsts_option, /:\\\\/, \u0027\u0027)"},{"line_number":98,"context_line":"      $hsts_option_header \u003d \"add-header ${htst_header}\""},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      $hsts_option_header \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5d19a0fc_8e07958f","line":97,"range":{"start_line":97,"start_character":44,"end_line":97,"end_character":49},"in_reply_to":"838a1900_e6b98345","updated":"2022-04-26 21:16:33.000000000","message":"Just for reference the error on CentOS with \"/:\\\\/\" was:\n2022-04-25T22:04:38.870 ^[[1;31mError: 2022-04-25 22:04:38 +0000 Evaluation Erroo\nr: Error while evaluating a Function Call, unmatched close parenthesis: /:\\\\/, \u0027\u0027\u0027\n)","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"ba5fa0c3009886decf669ed0721ca401bd7fd2af","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if $hsts_option !\u003d undef {"},{"line_number":97,"context_line":"      $htst_header \u003d regsubst($hsts_option, /:\\\\/, \u0027\u0027)"},{"line_number":98,"context_line":"      $hsts_option_header \u003d \"add-header ${htst_header}\""},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      $hsts_option_header \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"838a1900_e6b98345","line":97,"range":{"start_line":97,"start_character":44,"end_line":97,"end_character":49},"in_reply_to":"d4e0179a_12040dba","updated":"2022-04-26 21:14:15.000000000","message":"Tried storing the expression in a variable and doing different pattern for Debian and CentOS, but the sintaxe end up failing for CentOS puppet.\nUsing \u0027:\\\\\u0027 fails on Debian with the error \"Error while evaluating a Function Call, too short escape sequence\".\nConsidering just having the Debian header info in a separate variable.","commit_id":"fa1afb7e2ee2acfa939a95945cea84ff2bf1dbab"}]}