)]}'
{"puppet-manifests/src/modules/platform/manifests/ldap.pp":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"bea895f3ccaa69f7c3ec81e3333d2463f557db3c","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class platform::ldap::server"},{"line_number":26,"context_line":"  inherits ::platform::ldap::params {"},{"line_number":27,"context_line":"  Class[\u0027platform::password\u0027] -\u003e Class[$name]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! $ldapserver_remote {"},{"line_number":30,"context_line":"    include ::platform::ldap::server::local"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"658bbc62_cff8ee01","side":"PARENT","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":5},"updated":"2022-04-25 18:22:51.000000000","message":"Why is this removed? (this is to ensure platform::password is applied before platform::ldap::server)","commit_id":"5d6738f65b06b1c9ac328df9de9d3473ca41f541"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"3c70ae7181fe68d78b25b24454db18fd924b32b3","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class platform::ldap::server"},{"line_number":26,"context_line":"  inherits ::platform::ldap::params {"},{"line_number":27,"context_line":"  Class[\u0027platform::password\u0027] -\u003e Class[$name]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! $ldapserver_remote {"},{"line_number":30,"context_line":"    include ::platform::ldap::server::local"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fb9ede3f_fb932e1a","side":"PARENT","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":5},"in_reply_to":"658bbc62_cff8ee01","updated":"2022-04-25 21:07:49.000000000","message":"This removal is odd. I did not intend to have this line removed. I will add it back.","commit_id":"5d6738f65b06b1c9ac328df9de9d3473ca41f541"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"ba98a78cbfce1fdf668fed146396d6303df50524","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class platform::ldap::server"},{"line_number":26,"context_line":"  inherits ::platform::ldap::params {"},{"line_number":27,"context_line":"  Class[\u0027platform::password\u0027] -\u003e Class[$name]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! $ldapserver_remote {"},{"line_number":30,"context_line":"    include ::platform::ldap::server::local"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7ed8b3c3_3fcbca2e","side":"PARENT","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":5},"in_reply_to":"fb9ede3f_fb932e1a","updated":"2022-04-25 21:30:29.000000000","message":"You added that line just before I committed my code and I did not have it. We overlapped while in review.","commit_id":"5d6738f65b06b1c9ac328df9de9d3473ca41f541"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"a0a587ef4f10025451b4d87fa39ebccdadb0a72c","unresolved":true,"context_lines":[{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":"    -\u003e exec { \u0027add ldaps to slapd configuration\u0027:"},{"line_number":209,"context_line":"    command \u003d\u003e"},{"line_number":210,"context_line":"      \"/bin/sed -i \u0027s,\\\"ldap:///\\\",\\\"ldap:/// ldaps:///\\\",\u0027 /etc/rc.d/init.d/openldap\""},{"line_number":211,"context_line":"  }"},{"line_number":212,"context_line":"    -\u003e exec { \u0027restart-openldap\u0027:"},{"line_number":213,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"18abde6c_e8d111e6","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":2},"updated":"2022-04-25 18:27:55.000000000","message":"I think everytime this runtime class applies, the line will be added one more \" ldaps:///\".","commit_id":"a0032d5450a7b6327c31e8b16b7ffc8fa9be2dfc"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"3c70ae7181fe68d78b25b24454db18fd924b32b3","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":"    -\u003e exec { \u0027add ldaps to slapd configuration\u0027:"},{"line_number":209,"context_line":"    command \u003d\u003e"},{"line_number":210,"context_line":"      \"/bin/sed -i \u0027s,\\\"ldap:///\\\",\\\"ldap:/// ldaps:///\\\",\u0027 /etc/rc.d/init.d/openldap\""},{"line_number":211,"context_line":"  }"},{"line_number":212,"context_line":"    -\u003e exec { \u0027restart-openldap\u0027:"},{"line_number":213,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d4201f33_9e95a129","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":2},"in_reply_to":"18abde6c_e8d111e6","updated":"2022-04-25 21:07:49.000000000","message":"My testing showed that it will not be added. The change would only be done once. Subsequent certificate installs that will call runtime manifest will not keep adding \"ldaps///\" to slapd command. It is the same for all the other configuration changes applied by runtime manifest.","commit_id":"a0032d5450a7b6327c31e8b16b7ffc8fa9be2dfc"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"8a520044f01dcee448268ca818e0bf4f5fba2a6a","unresolved":true,"context_lines":[{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":"    -\u003e exec { \u0027add ldaps to slapd configuration\u0027:"},{"line_number":211,"context_line":"    command \u003d\u003e"},{"line_number":212,"context_line":"      \"/bin/sed -i \u0027s,\\\"ldap:///\\\",\\\"ldap:/// ldaps:///\\\",\u0027 /etc/rc.d/init.d/openldap\""},{"line_number":213,"context_line":"  }"},{"line_number":214,"context_line":"    -\u003e exec { \u0027restart-openldap\u0027:"},{"line_number":215,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b0900aef_e92130e0","line":212,"updated":"2022-04-26 14:20:02.000000000","message":"is this expected to work on Debian target as well ?","commit_id":"dffea1d06dd9810469ce167916ba90166e498aa5"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"959bf0cf78baed2cd93fdcb9bdd74be6fd304a0b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":"    -\u003e exec { \u0027add ldaps to slapd configuration\u0027:"},{"line_number":211,"context_line":"    command \u003d\u003e"},{"line_number":212,"context_line":"      \"/bin/sed -i \u0027s,\\\"ldap:///\\\",\\\"ldap:/// ldaps:///\\\",\u0027 /etc/rc.d/init.d/openldap\""},{"line_number":213,"context_line":"  }"},{"line_number":214,"context_line":"    -\u003e exec { \u0027restart-openldap\u0027:"},{"line_number":215,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"436bafdb_1b848a12","line":212,"in_reply_to":"4cbbccc5_70241643","updated":"2022-04-26 14:46:23.000000000","message":"Ack","commit_id":"dffea1d06dd9810469ce167916ba90166e498aa5"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"3dc893ef11f6ea85c6c748fad4b4c84c5e90ffa5","unresolved":true,"context_lines":[{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":"    -\u003e exec { \u0027add ldaps to slapd configuration\u0027:"},{"line_number":211,"context_line":"    command \u003d\u003e"},{"line_number":212,"context_line":"      \"/bin/sed -i \u0027s,\\\"ldap:///\\\",\\\"ldap:/// ldaps:///\\\",\u0027 /etc/rc.d/init.d/openldap\""},{"line_number":213,"context_line":"  }"},{"line_number":214,"context_line":"    -\u003e exec { \u0027restart-openldap\u0027:"},{"line_number":215,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4cbbccc5_70241643","line":212,"in_reply_to":"b0900aef_e92130e0","updated":"2022-04-26 14:46:11.000000000","message":"There is a dedicated task for Debian changes. So anything Debian related is not included in this work.","commit_id":"dffea1d06dd9810469ce167916ba90166e498aa5"}]}