)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b6093247565067ae7515f40c6ccf3d313bc80014","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  state_workers\u003d4"},{"line_number":18,"context_line":"  audit_workers\u003d1"},{"line_number":19,"context_line":"  audit_worker_workers\u003d4"},{"line_number":20,"context_line":"  playbook_timeout\u003d2700"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Note: These values override the settings in"},{"line_number":23,"context_line":"the config values in code from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"aaf9fed8_119a8638","line":20,"updated":"2022-05-06 20:49:56.000000000","message":"playbook_timeout in code differs","commit_id":"8f15d25fee3027f360c0de1eac0e4a0b779ce8c1"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"d2c699b9123a84185be2b71d0c6f4b7f86fd9f86","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  state_workers\u003d4"},{"line_number":18,"context_line":"  audit_workers\u003d1"},{"line_number":19,"context_line":"  audit_worker_workers\u003d4"},{"line_number":20,"context_line":"  playbook_timeout\u003d2700"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Note: These values override the settings in"},{"line_number":23,"context_line":"the config values in code from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"05c5c44f_45bf82a3","line":20,"in_reply_to":"aaf9fed8_119a8638","updated":"2022-05-06 20:58:32.000000000","message":"Thanks. Updated.","commit_id":"8f15d25fee3027f360c0de1eac0e4a0b779ce8c1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"be7cab5b943d1fb08efce72e7ed420e27f107012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"444c9a6f_9e59fe96","updated":"2022-05-03 13:37:25.000000000","message":"Are we planning to remove: https://github.com/starlingx/distcloud/blob/b6020fcda575546bc681d67948df48c2b26adff8/distributedcloud/dcmanager/common/config.py#L149 after this commit?","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"88e7dc992346b43015aff89dbea650aa11b5f600","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4eb0315_7688b376","updated":"2022-05-03 14:16:29.000000000","message":"Setting to W-1 pending discussion about delivery scope","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"caa3ebf32580568bcc59b67d1e9ab20ba431cc77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"16d1d72e_1365ad4f","updated":"2022-05-09 13:05:01.000000000","message":"ok,sounds like playbook_timeout doesnt affect the user from setting the rvmc playbook in the customer supplied yaml file to a larger value","commit_id":"2d5e6d8a492e7ea0023b6492e62fea12b95fee05"}],"modules/puppet-dcmanager/src/dcmanager/manifests/init.pp":[{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"be7cab5b943d1fb08efce72e7ed420e27f107012","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Files in this package are licensed under Apache; see LICENSE file."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (c) 2013-2020 Wind River Systems, Inc."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a2abd09b_40657736","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":25},"updated":"2022-05-03 13:37:25.000000000","message":"2022","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"acd8b3cbf69a5cedd78788f7c63a5cbca73238dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Files in this package are licensed under Apache; see LICENSE file."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (c) 2013-2020 Wind River Systems, Inc."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"f3c3cd82_94d20e83","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":25},"in_reply_to":"a2abd09b_40657736","updated":"2022-05-06 17:37:43.000000000","message":"Done","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"11ab063c5972c4403cbd13d601cbf19c03abee71","unresolved":true,"context_lines":[{"line_number":43,"context_line":"  $dcmanager_mtc_inv_label     \u003d \u0027/v1/\u0027,"},{"line_number":44,"context_line":"  $region_name                 \u003d \u0027RegionOne\u0027,"},{"line_number":45,"context_line":"  $log_levels                  \u003d \u0027keystoneauth\u003dERROR,eventlet.wsgi.server\u003dWARN\u0027,"},{"line_number":46,"context_line":"  $workers                     \u003d 1,"},{"line_number":47,"context_line":"  $orch_workers                \u003d 1,"},{"line_number":48,"context_line":"  $state_workers               \u003d 4,"},{"line_number":49,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":50,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":51,"context_line":"  $prestage_packages_timeout   \u003d 2700,"},{"line_number":52,"context_line":"  $prestage_images_timeout     \u003d 3600"},{"line_number":53,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3bb48e6b_f3d13691","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":35},"updated":"2022-05-06 13:14:37.000000000","message":"I don\u0027t see a dc repo commit to make use of these configuration parameters. Will this be done in a future commit?","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"acd8b3cbf69a5cedd78788f7c63a5cbca73238dd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $dcmanager_mtc_inv_label     \u003d \u0027/v1/\u0027,"},{"line_number":44,"context_line":"  $region_name                 \u003d \u0027RegionOne\u0027,"},{"line_number":45,"context_line":"  $log_levels                  \u003d \u0027keystoneauth\u003dERROR,eventlet.wsgi.server\u003dWARN\u0027,"},{"line_number":46,"context_line":"  $workers                     \u003d 1,"},{"line_number":47,"context_line":"  $orch_workers                \u003d 1,"},{"line_number":48,"context_line":"  $state_workers               \u003d 4,"},{"line_number":49,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":50,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":51,"context_line":"  $prestage_packages_timeout   \u003d 2700,"},{"line_number":52,"context_line":"  $prestage_images_timeout     \u003d 3600"},{"line_number":53,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d4663911_5be33b1b","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":35},"in_reply_to":"3bb48e6b_f3d13691","updated":"2022-05-06 17:37:43.000000000","message":"These parameters directly override the parameters at https://github.com/starlingx/distcloud/blob/fc2e6898c816b60ac09f31f3f37d2c6021e22b4e/distributedcloud/dcmanager/common/config.py#L149\n\nThe TODO I have at that code block is removed as part of another commit (https://review.opendev.org/c/starlingx/distcloud/+/839948)","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"047263d2fb9f2f81de107a44b67f7df21db0dd81","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":50,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":51,"context_line":"  $prestage_packages_timeout   \u003d 2700,"},{"line_number":52,"context_line":"  $prestage_images_timeout     \u003d 3600"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include dcmanager::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"416b82e6_53a4d12d","line":52,"updated":"2022-05-03 18:58:49.000000000","message":"In the future, should be also able to persist and modify parameters e.g. via \u0027system service-parameter \u0027","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"acd8b3cbf69a5cedd78788f7c63a5cbca73238dd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":50,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":51,"context_line":"  $prestage_packages_timeout   \u003d 2700,"},{"line_number":52,"context_line":"  $prestage_images_timeout     \u003d 3600"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include dcmanager::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6cef7f23_1855d3f1","line":52,"in_reply_to":"416b82e6_53a4d12d","updated":"2022-05-06 17:37:43.000000000","message":"I added this as a TODO","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"11ab063c5972c4403cbd13d601cbf19c03abee71","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  $state_workers               \u003d 4,"},{"line_number":49,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":50,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":51,"context_line":"  $prestage_packages_timeout   \u003d 2700,"},{"line_number":52,"context_line":"  $prestage_images_timeout     \u003d 3600"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include dcmanager::params"},{"line_number":56,"context_line":"  include dcmanager::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"122bd65f_65517d3f","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":0},"updated":"2022-05-06 13:14:37.000000000","message":"Don\u0027t match with change done in https://review.opendev.org/c/starlingx/distcloud/+/839948","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"acd8b3cbf69a5cedd78788f7c63a5cbca73238dd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $state_workers               \u003d 4,"},{"line_number":49,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":50,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":51,"context_line":"  $prestage_packages_timeout   \u003d 2700,"},{"line_number":52,"context_line":"  $prestage_images_timeout     \u003d 3600"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include dcmanager::params"},{"line_number":56,"context_line":"  include dcmanager::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"539df230_a1bc9ebf","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":0},"in_reply_to":"122bd65f_65517d3f","updated":"2022-05-06 17:37:43.000000000","message":"Done","commit_id":"469717f2bd4ec7dd3469c1e0b3521f8c8005b07e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"69df08cfb7d544f7e11f8e15b1581d73b6192b2d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  $state_workers               \u003d 4,"},{"line_number":51,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":52,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":53,"context_line":"  $playbook_timeout            \u003d 3600"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  include dcmanager::params"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"b4ad809c_e8e92373","line":53,"range":{"start_line":53,"start_character":33,"end_line":53,"end_character":37},"updated":"2022-05-06 20:49:17.000000000","message":"note that the rvmc playbook timeout is configurable by customer yaml file:\n\"playbookconfig/src/playbooks/install.yml\"\n\n(i.e. wait_for_timeout has been set higher than 5400).  So, wondering if this could still override this or related.","commit_id":"8f15d25fee3027f360c0de1eac0e4a0b779ce8c1"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"d2c699b9123a84185be2b71d0c6f4b7f86fd9f86","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  $state_workers               \u003d 4,"},{"line_number":51,"context_line":"  $audit_workers               \u003d 1,"},{"line_number":52,"context_line":"  $audit_worker_workers        \u003d 4,"},{"line_number":53,"context_line":"  $playbook_timeout            \u003d 3600"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  include dcmanager::params"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"23a0eaf4_50f4633a","line":53,"range":{"start_line":53,"start_character":33,"end_line":53,"end_character":37},"in_reply_to":"b4ad809c_e8e92373","updated":"2022-05-06 20:58:32.000000000","message":"Our plan is to introduce this for prestaging. The 3600s default timeout can then be used as a baseline value. The thinking is that for something like the playbook you\u0027ve referenced we\u0027d want to use at least 2x the default.\n\nHowever, it remains to be seen if we\u0027ll even get there, since with Debian we\u0027ll be able to use the ANSIBLE_TASK_TIMEOUT which will require some changes in this area.","commit_id":"8f15d25fee3027f360c0de1eac0e4a0b779ce8c1"}]}