)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"ecb4ab353d15c73b799db99b77141aee7fcd5ba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f8822c5_978e33fd","updated":"2022-05-17 15:09:03.000000000","message":"recheck","commit_id":"32054779440d9bb51b184dbefa04ffce7d5cf74f"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"d6a9f6e8d908163b802d93bc2e2bb9cac960b2db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48fbea23_55fd36f2","updated":"2022-05-17 15:43:57.000000000","message":"LGTM","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"4fb61bd2632d37b9bfd3df2cba00dd34ecd560d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1437826_127cb49f","updated":"2022-05-18 18:39:51.000000000","message":"LGTM","commit_id":"8252fc3a03e0ff3a6bca38e841fe68deffe99e0a"}],"puppet-manifests/src/modules/platform/manifests/ptpinstance.pp":[{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"de53d69db9ea37a04241dc646a478c11ec55e6a4","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  $pmc_gm_settings"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"  if ($service \u003d\u003d \u0027ptp4l\u0027) and ($pmc_gm_settings !\u003d \u0027\u0027) {"},{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_paramters\":"},{"line_number":56,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":57,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP ${pmc_gm_settings}\u0027\","},{"line_number":58,"context_line":"      require \u003d\u003e Service[\"instance-${_name}\"]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"a675183c_cfb739da","line":55,"range":{"start_line":55,"start_character":37,"end_line":55,"end_character":46},"updated":"2022-05-17 15:37:35.000000000","message":"nit: parameters","commit_id":"16d946b665311911b0eb09ca98d3c86b68b30158"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"f064c991faf8cca9a211e67b9590114e10c0256e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $pmc_gm_settings"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"  if ($service \u003d\u003d \u0027ptp4l\u0027) and ($pmc_gm_settings !\u003d \u0027\u0027) {"},{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_paramters\":"},{"line_number":56,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":57,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP ${pmc_gm_settings}\u0027\","},{"line_number":58,"context_line":"      require \u003d\u003e Service[\"instance-${_name}\"]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"2ee4d8f4_ddbb7f35","line":55,"range":{"start_line":55,"start_character":37,"end_line":55,"end_character":46},"in_reply_to":"a675183c_cfb739da","updated":"2022-05-17 15:43:08.000000000","message":"Done","commit_id":"16d946b665311911b0eb09ca98d3c86b68b30158"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"143be71c3a733e98f2069568ee823499bbf7adad","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  if ($service \u003d\u003d \u0027ptp4l\u0027) and ($pmc_gm_settings !\u003d \u0027\u0027) {"},{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_parameters\":"},{"line_number":56,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":57,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP ${pmc_gm_settings}\u0027\","},{"line_number":58,"context_line":"      require \u003d\u003e Service[\"instance-${_name}\"]"},{"line_number":59,"context_line":"      # This command always returns 0 even if it fails, but it is always running the same"},{"line_number":60,"context_line":"      # valid command so failure is not expected."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0e0ff57b_f14760c2","line":57,"updated":"2022-05-17 18:52:48.000000000","message":"Does this need to be done as an explicit command with \u0027set GRANDMASTER_SETTINGS_NP \u003cparam string\u003e\u0027 , or could all of these parameters be embedded in the global parameters?  I see (for example) you are removing currentUtcOffsetValid from the conf file in https://review.opendev.org/c/starlingx/config/+/842003/3/sysinv/sysinv/sysinv/sysinv/puppet/networking.py#252 if we are in this case.","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"b2b2d92b5d38c40c6211a8185609532472f74496","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  if ($service \u003d\u003d \u0027ptp4l\u0027) and ($pmc_gm_settings !\u003d \u0027\u0027) {"},{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_parameters\":"},{"line_number":56,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":57,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP ${pmc_gm_settings}\u0027\","},{"line_number":58,"context_line":"      require \u003d\u003e Service[\"instance-${_name}\"]"},{"line_number":59,"context_line":"      # This command always returns 0 even if it fails, but it is always running the same"},{"line_number":60,"context_line":"      # valid command so failure is not expected."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"88429bdd_e0225e2a","line":57,"in_reply_to":"0e0ff57b_f14760c2","updated":"2022-05-18 16:00:30.000000000","message":"Reworked to set the values as individual params rather than a single string. This will lead to better extensibility in the future if required.","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"143be71c3a733e98f2069568ee823499bbf7adad","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_parameters\":"},{"line_number":56,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":57,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP ${pmc_gm_settings}\u0027\","},{"line_number":58,"context_line":"      require \u003d\u003e Service[\"instance-${_name}\"]"},{"line_number":59,"context_line":"      # This command always returns 0 even if it fails, but it is always running the same"},{"line_number":60,"context_line":"      # valid command so failure is not expected."},{"line_number":61,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"088baa4b_f4fc7df7","line":58,"updated":"2022-05-17 18:52:48.000000000","message":"Ok, so this should ensure the /etc/ptpinstance/${service}-${_name}.conf is created first","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"b2b2d92b5d38c40c6211a8185609532472f74496","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_parameters\":"},{"line_number":56,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":57,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP ${pmc_gm_settings}\u0027\","},{"line_number":58,"context_line":"      require \u003d\u003e Service[\"instance-${_name}\"]"},{"line_number":59,"context_line":"      # This command always returns 0 even if it fails, but it is always running the same"},{"line_number":60,"context_line":"      # valid command so failure is not expected."},{"line_number":61,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"2f029c2b_339e0f0c","line":58,"in_reply_to":"088baa4b_f4fc7df7","updated":"2022-05-18 16:00:30.000000000","message":"Correct, the this ensures the service exists and is started first before trying to modify the pmc.","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"143be71c3a733e98f2069568ee823499bbf7adad","unresolved":true,"context_lines":[{"line_number":287,"context_line":"    create_resources(\u0027ptp_config_files\u0027, $config, $ptp_state)"},{"line_number":288,"context_line":"  }"},{"line_number":289,"context_line":"  if $enabled {"},{"line_number":290,"context_line":"    create_resources(\u0027set_ptp4l_pmc_parameters\u0027, $config, $ptp_state)"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  exec { \u0027set-ice-gnss-thread-niceness\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dd4b824d_2bf23cb2","line":290,"updated":"2022-05-17 18:52:48.000000000","message":"Any reason not to combine this with L286-288 block?","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"b2b2d92b5d38c40c6211a8185609532472f74496","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    create_resources(\u0027ptp_config_files\u0027, $config, $ptp_state)"},{"line_number":288,"context_line":"  }"},{"line_number":289,"context_line":"  if $enabled {"},{"line_number":290,"context_line":"    create_resources(\u0027set_ptp4l_pmc_parameters\u0027, $config, $ptp_state)"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  exec { \u0027set-ice-gnss-thread-niceness\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"096ab535_ac11d391","line":290,"in_reply_to":"dd4b824d_2bf23cb2","updated":"2022-05-18 16:00:30.000000000","message":"Done","commit_id":"694275eccdb1f00547702319c3c6b14e6efbff4e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"04502169e65d5ed98af5ae4a4e536f7bdfeacae3","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_paramters\":"},{"line_number":56,"context_line":"      # This command always returns 0 even if it fails, but it is always running the same"},{"line_number":57,"context_line":"      # valid command so failure is not expected."},{"line_number":58,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":59,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP \\"},{"line_number":60,"context_line":"                  clockClass ${pmc_gm_settings[\u0027clockClass\u0027]} \\"},{"line_number":61,"context_line":"                  clockAccuracy ${pmc_gm_settings[\u0027clockAccuracy\u0027]} \\"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"30d6205f_73ebdf50","line":58,"updated":"2022-05-18 18:45:04.000000000","message":"this code is fragile, if those dictionary settings change in the future","commit_id":"8252fc3a03e0ff3a6bca38e841fe68deffe99e0a"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"b4ceb2d401457f753d77a1f4c245ade20abe7f6b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    exec { \"${_name}_set_initial_pmc_paramters\":"},{"line_number":56,"context_line":"      # This command always returns 0 even if it fails, but it is always running the same"},{"line_number":57,"context_line":"      # valid command so failure is not expected."},{"line_number":58,"context_line":"      command \u003d\u003e \"/sbin/pmc -u -b 0 -f /etc/ptpinstance/${service}-${_name}.conf \\"},{"line_number":59,"context_line":"                  \u0027set GRANDMASTER_SETTINGS_NP \\"},{"line_number":60,"context_line":"                  clockClass ${pmc_gm_settings[\u0027clockClass\u0027]} \\"},{"line_number":61,"context_line":"                  clockAccuracy ${pmc_gm_settings[\u0027clockAccuracy\u0027]} \\"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1df76af4_7c9d6876","line":58,"in_reply_to":"30d6205f_73ebdf50","updated":"2022-05-18 18:50:15.000000000","message":"Agreed. If we need to support a more varied set of pmc parameters then this will have to be improved, likely by implementing some sort of dedicated manifest for pmc configuration.","commit_id":"8252fc3a03e0ff3a6bca38e841fe68deffe99e0a"}]}