)]}'
{"puppet-manifests/src/modules/platform/manifests/kubernetes.pp":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"d590af4ddbe9d433307cf785061c5ee753c5561f","unresolved":true,"context_lines":[{"line_number":1408,"context_line":"  exec { \u0027update kubelet config parameters\u0027:"},{"line_number":1409,"context_line":"    environment \u003d\u003e [ \u0027KUBECONFIG\u003d/etc/kubernetes/admin.conf\u0027 ],"},{"line_number":1410,"context_line":"    provider    \u003d\u003e shell,"},{"line_number":1411,"context_line":"    command     \u003d\u003e template(\u0027platform/kube-config-kubelet.erb\u0027),"},{"line_number":1412,"context_line":"    timeout     \u003d\u003e 60,"},{"line_number":1413,"context_line":"    logoutput   \u003d\u003e true,"},{"line_number":1414,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"74dc64f0_9aa59011","line":1411,"updated":"2022-06-06 17:01:59.000000000","message":"for future configurability, it would be useful to be able to drive the changed params to puppet from the hieara params.  In this manner, an incycle update can be more readily provided.","commit_id":"61b736756de3595d1cdfe378e988f0fc1cc969e1"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"6014a1ecf953624ede0410fa712c2ff04e0dc620","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"  exec { \u0027update kubelet config parameters\u0027:"},{"line_number":1409,"context_line":"    environment \u003d\u003e [ \u0027KUBECONFIG\u003d/etc/kubernetes/admin.conf\u0027 ],"},{"line_number":1410,"context_line":"    provider    \u003d\u003e shell,"},{"line_number":1411,"context_line":"    command     \u003d\u003e template(\u0027platform/kube-config-kubelet.erb\u0027),"},{"line_number":1412,"context_line":"    timeout     \u003d\u003e 60,"},{"line_number":1413,"context_line":"    logoutput   \u003d\u003e true,"},{"line_number":1414,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"0f13cd7b_72f62b2a","line":1411,"in_reply_to":"115e7ac7_c32f7d99","updated":"2022-06-07 19:16:41.000000000","message":"Done","commit_id":"61b736756de3595d1cdfe378e988f0fc1cc969e1"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"6014a1ecf953624ede0410fa712c2ff04e0dc620","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"  exec { \u0027update kubelet config parameters\u0027:"},{"line_number":1409,"context_line":"    environment \u003d\u003e [ \u0027KUBECONFIG\u003d/etc/kubernetes/admin.conf\u0027 ],"},{"line_number":1410,"context_line":"    provider    \u003d\u003e shell,"},{"line_number":1411,"context_line":"    command     \u003d\u003e template(\u0027platform/kube-config-kubelet.erb\u0027),"},{"line_number":1412,"context_line":"    timeout     \u003d\u003e 60,"},{"line_number":1413,"context_line":"    logoutput   \u003d\u003e true,"},{"line_number":1414,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"af77a8b3_c6b75cf7","line":1411,"in_reply_to":"115e7ac7_c32f7d99","updated":"2022-06-07 19:16:41.000000000","message":"Done","commit_id":"61b736756de3595d1cdfe378e988f0fc1cc969e1"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"0cbf491289a4f58c3998d6dff9aab8cc48720316","unresolved":true,"context_lines":[{"line_number":1408,"context_line":"  exec { \u0027update kubelet config parameters\u0027:"},{"line_number":1409,"context_line":"    environment \u003d\u003e [ \u0027KUBECONFIG\u003d/etc/kubernetes/admin.conf\u0027 ],"},{"line_number":1410,"context_line":"    provider    \u003d\u003e shell,"},{"line_number":1411,"context_line":"    command     \u003d\u003e template(\u0027platform/kube-config-kubelet.erb\u0027),"},{"line_number":1412,"context_line":"    timeout     \u003d\u003e 60,"},{"line_number":1413,"context_line":"    logoutput   \u003d\u003e true,"},{"line_number":1414,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"115e7ac7_c32f7d99","line":1411,"in_reply_to":"74dc64f0_9aa59011","updated":"2022-06-06 17:59:18.000000000","message":"i.e. specify in ::platform::kubernetes::params ; even if not driven by sysinv yet.","commit_id":"61b736756de3595d1cdfe378e988f0fc1cc969e1"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"18694e56f05a41cde0ca6afe8851742b6f968b6f","unresolved":true,"context_lines":[{"line_number":1411,"context_line":"  $kubelet_image_gc_high_threshold_percent \u003d $::platform::kubernetes::params::kubelet_image_gc_high_threshold_percent"},{"line_number":1412,"context_line":"  $kubelet_eviction_hard_imagefs_available \u003d $::platform::kubernetes::params::kubelet_eviction_hard_imagefs_available"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"  notice(\"kubelet_image_gc_low_threshold_percent is ${kubelet_image_gc_low_threshold_percent}\")"},{"line_number":1415,"context_line":"  notice(\"kubelet_image_gc_high_threshold_percent is ${kubelet_image_gc_high_threshold_percent}\")"},{"line_number":1416,"context_line":"  notice(\"kubelet_eviction_hard_imagefs_available is ${kubelet_eviction_hard_imagefs_available}\")"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"  # Update kubelet parameters in kubelet-config Configmap."},{"line_number":1419,"context_line":"  exec { \u0027update kubelet config parameters\u0027:"},{"line_number":1420,"context_line":"    environment \u003d\u003e [ \u0027KUBECONFIG\u003d/etc/kubernetes/admin.conf\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7e766f3b_8a2dbd9a","line":1417,"range":{"start_line":1414,"start_character":0,"end_line":1417,"end_character":0},"updated":"2022-06-08 13:49:27.000000000","message":"these debug statements could be removed","commit_id":"61829fab9d20cdbd954e8bf325360ff3d64ba88d"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"74b513931993e55785feb96b402a884c7da723d5","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"  $kubelet_image_gc_high_threshold_percent \u003d $::platform::kubernetes::params::kubelet_image_gc_high_threshold_percent"},{"line_number":1412,"context_line":"  $kubelet_eviction_hard_imagefs_available \u003d $::platform::kubernetes::params::kubelet_eviction_hard_imagefs_available"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"  notice(\"kubelet_image_gc_low_threshold_percent is ${kubelet_image_gc_low_threshold_percent}\")"},{"line_number":1415,"context_line":"  notice(\"kubelet_image_gc_high_threshold_percent is ${kubelet_image_gc_high_threshold_percent}\")"},{"line_number":1416,"context_line":"  notice(\"kubelet_eviction_hard_imagefs_available is ${kubelet_eviction_hard_imagefs_available}\")"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"  # Update kubelet parameters in kubelet-config Configmap."},{"line_number":1419,"context_line":"  exec { \u0027update kubelet config parameters\u0027:"},{"line_number":1420,"context_line":"    environment \u003d\u003e [ \u0027KUBECONFIG\u003d/etc/kubernetes/admin.conf\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"e4e97fa8_212de40e","line":1417,"range":{"start_line":1414,"start_character":0,"end_line":1417,"end_character":0},"in_reply_to":"7e766f3b_8a2dbd9a","updated":"2022-06-08 17:54:53.000000000","message":"Done","commit_id":"61829fab9d20cdbd954e8bf325360ff3d64ba88d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6fba2aec7f5c7b8e4845abb0af98fdc0e212c119","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  $rootca_keyfile_new \u003d \u0027/etc/kubernetes/pki/ca_new.key\u0027,"},{"line_number":53,"context_line":"  $kubelet_image_gc_low_threshold_percent \u003d 75,"},{"line_number":54,"context_line":"  $kubelet_image_gc_high_threshold_percent \u003d 79,"},{"line_number":55,"context_line":"  $kubelet_eviction_hard_imagefs_available \u003d \u00271Gi\u0027,"},{"line_number":56,"context_line":") { }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class platform::kubernetes::configuration {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"e4df5939_d632612a","line":55,"range":{"start_line":55,"start_character":45,"end_line":55,"end_character":50},"updated":"2022-06-10 17:38:22.000000000","message":"The default in the script appears to be \u00272Gi\u0027. Please confirm which should be default?","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"c6b2d6326c675ba51947a684bdd77a1ea6c3d066","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $rootca_keyfile_new \u003d \u0027/etc/kubernetes/pki/ca_new.key\u0027,"},{"line_number":53,"context_line":"  $kubelet_image_gc_low_threshold_percent \u003d 75,"},{"line_number":54,"context_line":"  $kubelet_image_gc_high_threshold_percent \u003d 79,"},{"line_number":55,"context_line":"  $kubelet_eviction_hard_imagefs_available \u003d \u00271Gi\u0027,"},{"line_number":56,"context_line":") { }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class platform::kubernetes::configuration {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"0deb7538_655a3bf2","line":55,"range":{"start_line":55,"start_character":45,"end_line":55,"end_character":50},"in_reply_to":"9c0186d3_83b753e3","updated":"2022-06-10 18:21:54.000000000","message":"Done","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"55d815ea72a1c8a1ee43dfedb4ddac2a924f5798","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  $rootca_keyfile_new \u003d \u0027/etc/kubernetes/pki/ca_new.key\u0027,"},{"line_number":53,"context_line":"  $kubelet_image_gc_low_threshold_percent \u003d 75,"},{"line_number":54,"context_line":"  $kubelet_image_gc_high_threshold_percent \u003d 79,"},{"line_number":55,"context_line":"  $kubelet_eviction_hard_imagefs_available \u003d \u00271Gi\u0027,"},{"line_number":56,"context_line":") { }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class platform::kubernetes::configuration {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9c0186d3_83b753e3","line":55,"range":{"start_line":55,"start_character":45,"end_line":55,"end_character":50},"in_reply_to":"e4df5939_d632612a","updated":"2022-06-10 18:13:43.000000000","message":"it was supposed to be 2Gi, will change","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"}],"puppet-manifests/src/modules/platform/templates/kube-config-kubelet.erb":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"88246552298a9acc4b4e900bb0cbe0bc9717c56c","unresolved":true,"context_lines":[{"line_number":57,"context_line":"fi"},{"line_number":58,"context_line":"\u003c% end -%\u003e"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Success path exit and cleanup"},{"line_number":61,"context_line":"s_exit"}],"source_content_type":"application/x-erb","patch_set":5,"id":"e522c37e_37b246b7","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":31},"updated":"2022-06-08 18:37:14.000000000","message":"Any cleanup to do? Like remove the tempfile?","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"b542cfe603fd58764eedb3fcf2db0636efe33324","unresolved":true,"context_lines":[{"line_number":57,"context_line":"fi"},{"line_number":58,"context_line":"\u003c% end -%\u003e"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Success path exit and cleanup"},{"line_number":61,"context_line":"s_exit"}],"source_content_type":"application/x-erb","patch_set":5,"id":"aab0a646_e70ebcf0","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":31},"in_reply_to":"6e6c32a2_bc4f940f","updated":"2022-06-09 13:50:10.000000000","message":"It is removed by the s_exit() function above; this routine is the same as kube-apiserver-update-certSANs.erb .\n\ns_exit() {\n    rm -v -f ${cm_kubelet_tempfile}\n    exit \"${1:-0}\"\n}\nThis","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"82525fb37a70ce6234d312413e32495a78851967","unresolved":true,"context_lines":[{"line_number":57,"context_line":"fi"},{"line_number":58,"context_line":"\u003c% end -%\u003e"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Success path exit and cleanup"},{"line_number":61,"context_line":"s_exit"}],"source_content_type":"application/x-erb","patch_set":5,"id":"6e6c32a2_bc4f940f","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":31},"in_reply_to":"903a615e_79d3357c","updated":"2022-06-08 19:07:50.000000000","message":"But I don\u0027t see where the tempfile is remove ...","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"f4ce8a6f936e772b757715fb8231773c0ff2324c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"fi"},{"line_number":58,"context_line":"\u003c% end -%\u003e"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Success path exit and cleanup"},{"line_number":61,"context_line":"s_exit"}],"source_content_type":"application/x-erb","patch_set":5,"id":"2f5b685c_799d94a7","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":31},"in_reply_to":"aab0a646_e70ebcf0","updated":"2022-06-10 13:56:16.000000000","message":"Done","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"498c93af5ccb9de4fab9264dc319f8ba325b3722","unresolved":true,"context_lines":[{"line_number":57,"context_line":"fi"},{"line_number":58,"context_line":"\u003c% end -%\u003e"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Success path exit and cleanup"},{"line_number":61,"context_line":"s_exit"}],"source_content_type":"application/x-erb","patch_set":5,"id":"903a615e_79d3357c","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":31},"in_reply_to":"e522c37e_37b246b7","updated":"2022-06-08 19:05:33.000000000","message":"in this case it means just remove the tempfile","commit_id":"cb01852d6b5f49754b47ba89a5357760fc5456ca"}]}