)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"da884412e98caaf140e4e83fdb96f87ae104a2c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43fc45b4_950addb4","updated":"2022-07-13 15:36:17.000000000","message":"Seems fine to me. Will bump my vote when Steve confirms this is good to go.","commit_id":"638e2292b52256943306d448f654baad15dd4b15"}],"puppet-manifests/src/modules/platform/manifests/kubernetes.pp":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"cc68b23f0e351aa879d2b6da13b0ae5b2d63fd2b","unresolved":true,"context_lines":[{"line_number":618,"context_line":"# add 5000 as the default port for private registry"},{"line_number":619,"context_line":"# Ports are not being included in the iptables rules created."},{"line_number":620,"context_line":"class platform::kubernetes::firewall::params ("},{"line_number":621,"context_line":"  $transport \u003d \u0027all\u0027,"},{"line_number":622,"context_line":"  $table \u003d \u0027nat\u0027,"},{"line_number":623,"context_line":"  $dports \u003d [80, 443, 9001, 5000],"},{"line_number":624,"context_line":"  $chain \u003d \u0027POSTROUTING\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d4e337b8_62b880c7","line":621,"updated":"2022-07-13 13:42:52.000000000","message":"How does the rule look in iptables?  (iptables -t nat -L)?  Are the dports still in effect?","commit_id":"638e2292b52256943306d448f654baad15dd4b15"},{"author":{"_account_id":33755,"name":"Jorge Saffe","email":"jorge.saffe@windriver.com","username":"jsaffe"},"change_message_id":"cc4887944c2c774c59c7feac6391b1248188c99e","unresolved":true,"context_lines":[{"line_number":618,"context_line":"# add 5000 as the default port for private registry"},{"line_number":619,"context_line":"# Ports are not being included in the iptables rules created."},{"line_number":620,"context_line":"class platform::kubernetes::firewall::params ("},{"line_number":621,"context_line":"  $transport \u003d \u0027all\u0027,"},{"line_number":622,"context_line":"  $table \u003d \u0027nat\u0027,"},{"line_number":623,"context_line":"  $dports \u003d [80, 443, 9001, 5000],"},{"line_number":624,"context_line":"  $chain \u003d \u0027POSTROUTING\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6f63f339_e0ee42df","line":621,"in_reply_to":"4933f095_f5388b47","updated":"2022-07-13 21:17:45.000000000","message":"perfect, can you merge it?","commit_id":"638e2292b52256943306d448f654baad15dd4b15"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"6d73193c07ae2f8c3f68943483dd52bf851c3ad6","unresolved":true,"context_lines":[{"line_number":618,"context_line":"# add 5000 as the default port for private registry"},{"line_number":619,"context_line":"# Ports are not being included in the iptables rules created."},{"line_number":620,"context_line":"class platform::kubernetes::firewall::params ("},{"line_number":621,"context_line":"  $transport \u003d \u0027all\u0027,"},{"line_number":622,"context_line":"  $table \u003d \u0027nat\u0027,"},{"line_number":623,"context_line":"  $dports \u003d [80, 443, 9001, 5000],"},{"line_number":624,"context_line":"  $chain \u003d \u0027POSTROUTING\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4933f095_f5388b47","line":621,"in_reply_to":"99b92335_217b247b","updated":"2022-07-13 16:14:41.000000000","message":"Ok, that kind of confirms that the dports are not taken into effect.","commit_id":"638e2292b52256943306d448f654baad15dd4b15"},{"author":{"_account_id":33755,"name":"Jorge Saffe","email":"jorge.saffe@windriver.com","username":"jsaffe"},"change_message_id":"e8c09721b099d643b66db2a6a20d943d01ebfaa6","unresolved":true,"context_lines":[{"line_number":618,"context_line":"# add 5000 as the default port for private registry"},{"line_number":619,"context_line":"# Ports are not being included in the iptables rules created."},{"line_number":620,"context_line":"class platform::kubernetes::firewall::params ("},{"line_number":621,"context_line":"  $transport \u003d \u0027all\u0027,"},{"line_number":622,"context_line":"  $table \u003d \u0027nat\u0027,"},{"line_number":623,"context_line":"  $dports \u003d [80, 443, 9001, 5000],"},{"line_number":624,"context_line":"  $chain \u003d \u0027POSTROUTING\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"99b92335_217b247b","line":621,"in_reply_to":"d4e337b8_62b880c7","updated":"2022-07-13 14:41:45.000000000","message":"After changes:\nSNAT       all  --  *      enp0s3  192.168.204.0/24    !192.168.204.0/24     /* 500 kubernetes forwarding kubernetes-nat */ to:10.20.6.3\n\nBefore changes:\nSNAT       tcp  --  *      enp0s3  192.168.204.0/24    !192.168.204.0/24     /* 500 kubernetes forwarding kubernetes-nat */ to:10.20.6.3","commit_id":"638e2292b52256943306d448f654baad15dd4b15"}]}