)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"a0d41e63fe517ff8d9f0bef90bd11f95f3bd67f5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"PASS: AIO-SX: build a new Debian ISO. Install, boostrap and"},{"line_number":15,"context_line":"perform a host-unlock verifying expected number of threads"},{"line_number":16,"context_line":"created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2010087"},{"line_number":19,"context_line":"Task: 45710"},{"line_number":20,"context_line":"Change-Id: I959f6426419e8fb5ed1398fb7e88a3d5219e80ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"893254ba_bee9355a","line":17,"updated":"2022-11-16 16:40:26.000000000","message":"given that the thread count depends on whether it\u0027s an AIO or not, I think this needs testing on a standard lab as well.","commit_id":"31b245cac7f2fa1be1e7f547b6a3285696d3fc62"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"8e1866afaaae6de9c4520533bccfe49b509fffbc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"PASS: AIO-SX: build a new Debian ISO. Install, boostrap and"},{"line_number":15,"context_line":"perform a host-unlock verifying expected number of threads"},{"line_number":16,"context_line":"created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2010087"},{"line_number":19,"context_line":"Task: 45710"},{"line_number":20,"context_line":"Change-Id: I959f6426419e8fb5ed1398fb7e88a3d5219e80ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"59fb9a3e_90d44376","line":17,"in_reply_to":"893254ba_bee9355a","updated":"2022-11-16 20:46:01.000000000","message":"Done","commit_id":"31b245cac7f2fa1be1e7f547b6a3285696d3fc62"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"34974a1e4ea61cc92ec8d35fcc66e86a3947f666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59885ae3_26cf45c4","updated":"2022-07-25 22:04:33.000000000","message":"recheck","commit_id":"d05152b61b92a97f9432d529f4d9697ece7f4b88"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"ba57a863891262e56245c6c58b3372085db94e7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4245755a_423cbf20","updated":"2022-10-07 19:03:45.000000000","message":"Please check my comments","commit_id":"36907b67fcb98f68440c62497ed4b31a71f05375"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"512fac517a1072e8de02edef43429430633ed376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9cee0b5c_ee9dd148","updated":"2022-11-16 16:45:14.000000000","message":"Removing the vote until Chris\u0027 questions are answered","commit_id":"31b245cac7f2fa1be1e7f547b6a3285696d3fc62"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a028a9ff29d80918c45ac9c34d412d580045e87f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"80e8fec9_22cf7e3f","updated":"2022-11-18 19:38:28.000000000","message":"Looks like the section mentioned by Chris is already root/root 755 so we dont need that section in puppet","commit_id":"a20aaaf1ae1769ec95311d578d6fcf67130d572e"}],"puppet-manifests/src/modules/platform/manifests/containerd.pp":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"36876c56e7c5a8d338eed349b8c40c85e655f310","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"    -\u003e file_line { \u0027optimize GOMAXPROCS for AIO\u0027:"},{"line_number":85,"context_line":"      append_on_no_match \u003d\u003e true,"},{"line_number":86,"context_line":"      line               \u003d\u003e \"Environment\u003d\\\"GOMAXPROCS\u003d${eng_workers}\\\"\","},{"line_number":87,"context_line":"      match              \u003d\u003e \u0027^Environment\u003d.*\u0027,"},{"line_number":88,"context_line":"      path               \u003d\u003e \u0027/etc/systemd/system/containerd.service.d/containerd-stx-override.conf\u0027,"},{"line_number":89,"context_line":"      replace            \u003d\u003e true"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"765fac98_21b6bbf0","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":23},"updated":"2022-07-26 17:19:13.000000000","message":"This does not follow the same \u0027template\u0027 system you are using in the other reviews.\nIs this because this file is pre-packaged?","commit_id":"9912709cb5db2422dc6e03663f8970b3a26e6345"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"2e08135a327cd0e7af406cf4571d7cb204554492","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"    -\u003e file_line { \u0027optimize GOMAXPROCS for AIO\u0027:"},{"line_number":85,"context_line":"      append_on_no_match \u003d\u003e true,"},{"line_number":86,"context_line":"      line               \u003d\u003e \"Environment\u003d\\\"GOMAXPROCS\u003d${eng_workers}\\\"\","},{"line_number":87,"context_line":"      match              \u003d\u003e \u0027^Environment\u003d.*\u0027,"},{"line_number":88,"context_line":"      path               \u003d\u003e \u0027/etc/systemd/system/containerd.service.d/containerd-stx-override.conf\u0027,"},{"line_number":89,"context_line":"      replace            \u003d\u003e true"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"b6a17abc_77e22c98","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":23},"in_reply_to":"765fac98_21b6bbf0","updated":"2022-07-28 11:38:18.000000000","message":"We change to another approach using an erb template","commit_id":"9912709cb5db2422dc6e03663f8970b3a26e6345"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"c1462a1473784f2d7a365c72579d40ec845406c8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"    -\u003e file_line { \u0027optimize GOMAXPROCS for AIO\u0027:"},{"line_number":85,"context_line":"      append_on_no_match \u003d\u003e true,"},{"line_number":86,"context_line":"      line               \u003d\u003e \"Environment\u003d\\\"GOMAXPROCS\u003d${eng_workers}\\\"\","},{"line_number":87,"context_line":"      match              \u003d\u003e \u0027^Environment\u003d.*\u0027,"},{"line_number":88,"context_line":"      path               \u003d\u003e \u0027/etc/systemd/system/containerd.service.d/containerd-stx-override.conf\u0027,"},{"line_number":89,"context_line":"      replace            \u003d\u003e true"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"88558dce_07a94959","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":23},"in_reply_to":"b6a17abc_77e22c98","updated":"2022-09-08 17:53:38.000000000","message":"Done","commit_id":"9912709cb5db2422dc6e03663f8970b3a26e6345"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"3254098e21c8894fb7c2ea169df72dcb34f5c257","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  include ::platform::params"},{"line_number":68,"context_line":"  include ::platform::mtce::params"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::platform::params::system_type \u003d\u003d \u0027All-in-one\u0027 and"},{"line_number":71,"context_line":"      $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":72,"context_line":"    $containerd_max_proc \u003d $::platform::params::eng_workers"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9ac25319_09fc83db","line":70,"range":{"start_line":70,"start_character":5,"end_line":70,"end_character":53},"updated":"2022-09-07 16:51:52.000000000","message":"Do we also want this for \u0027Standard\u0027  or is this reduced load only for AIO","commit_id":"ff847b31e8b4e6204ecb585833342cb19479f919"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"9c3ec87e85de1375f602d9d6fec7bdfdb2711722","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  include ::platform::params"},{"line_number":68,"context_line":"  include ::platform::mtce::params"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::platform::params::system_type \u003d\u003d \u0027All-in-one\u0027 and"},{"line_number":71,"context_line":"      $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":72,"context_line":"    $containerd_max_proc \u003d $::platform::params::eng_workers"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"c175bda1_e982a247","line":70,"range":{"start_line":70,"start_character":5,"end_line":70,"end_character":53},"in_reply_to":"9ac25319_09fc83db","updated":"2022-09-08 17:52:04.000000000","message":"All scale downs are applicable only for AIO non DC controller systems","commit_id":"ff847b31e8b4e6204ecb585833342cb19479f919"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"c1462a1473784f2d7a365c72579d40ec845406c8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  include ::platform::params"},{"line_number":68,"context_line":"  include ::platform::mtce::params"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::platform::params::system_type \u003d\u003d \u0027All-in-one\u0027 and"},{"line_number":71,"context_line":"      $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":72,"context_line":"    $containerd_max_proc \u003d $::platform::params::eng_workers"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"2c549489_97696785","line":70,"range":{"start_line":70,"start_character":5,"end_line":70,"end_character":53},"in_reply_to":"c175bda1_e982a247","updated":"2022-09-08 17:53:38.000000000","message":"Done","commit_id":"ff847b31e8b4e6204ecb585833342cb19479f919"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"ba57a863891262e56245c6c58b3372085db94e7d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"      $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":72,"context_line":"    $containerd_max_proc \u003d $::platform::params::eng_workers"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d\u0027:"},{"line_number":75,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":76,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"},{"line_number":77,"context_line":"      group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"d6e902b3_871efe08","line":74,"updated":"2022-10-07 19:03:45.000000000","message":"This will conflict with the declaration at line 29. Please review it","commit_id":"36907b67fcb98f68440c62497ed4b31a71f05375"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"f2d7003220b69e0a049ad0707482eb53b4cfc41f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"      $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":72,"context_line":"    $containerd_max_proc \u003d $::platform::params::eng_workers"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d\u0027:"},{"line_number":75,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":76,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"},{"line_number":77,"context_line":"      group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"c8f9bd9d_9636f4e7","line":74,"in_reply_to":"d6e902b3_871efe08","updated":"2022-10-12 16:54:03.000000000","message":"This conflict was resolved moving the file insurance to a new class and including when necessary","commit_id":"36907b67fcb98f68440c62497ed4b31a71f05375"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"961ce5bdffd6a41999a6e27e94a02cd22735f3b4","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $http_proxy or $https_proxy {"},{"line_number":38,"context_line":"    include ::platform::containerd::systemd"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027:"},{"line_number":41,"context_line":"      ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"16ef6117_7b0ce034","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":12},"updated":"2022-11-16 16:31:50.000000000","message":"Given that we want /etc/systemd/system/containerd.service.d/ to exist before we try to create /etc/systemd/system/containerd.service.d/http-proxy.conf I think this should either be \"require\", or else there should be an explicit \"require\" metaparameter added to the file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027 definition.","commit_id":"31b245cac7f2fa1be1e7f547b6a3285696d3fc62"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5256e0c44ed9fefb58274f1876c27a03938965fb","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $http_proxy or $https_proxy {"},{"line_number":38,"context_line":"    include ::platform::containerd::systemd"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027:"},{"line_number":41,"context_line":"      ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5bd3b5e7_59a6ade1","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":12},"in_reply_to":"16ef6117_7b0ce034","updated":"2022-11-16 16:37:13.000000000","message":"Actually, it looks like  /etc/systemd/system/containerd.service.d is already part of the containerd-config Debian package.   Not sure why we need to ensure it exists since it\u0027s not dynamically created.","commit_id":"31b245cac7f2fa1be1e7f547b6a3285696d3fc62"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"8e1866afaaae6de9c4520533bccfe49b509fffbc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $http_proxy or $https_proxy {"},{"line_number":38,"context_line":"    include ::platform::containerd::systemd"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027:"},{"line_number":41,"context_line":"      ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"886ef2f7_353c09c8","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":12},"in_reply_to":"5bd3b5e7_59a6ade1","updated":"2022-11-16 20:46:01.000000000","message":"Dear Mr. Chris Friesen,\nYou\u0027re right!\nI removed the unnecessary check and fix the approach.","commit_id":"31b245cac7f2fa1be1e7f547b6a3285696d3fc62"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"60f516f9008d3f3eb0416c54ff9bacf329a5473f","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if $http_proxy or $https_proxy {"},{"line_number":29,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d\u0027:"},{"line_number":30,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":31,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"},{"line_number":32,"context_line":"      group  \u003d\u003e \u0027root\u0027,"},{"line_number":33,"context_line":"      mode   \u003d\u003e \u00270755\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    -\u003e file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027:"},{"line_number":36,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":37,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"601ce35d_e9c35587","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":5},"updated":"2022-11-18 19:27:40.000000000","message":"Not sure we need this, since the containerd-config Debian package already creates this directory with this mode and ownership.  Adding it here shouldn\u0027t hurt anything but it adds unnecessary clutter.","commit_id":"a20aaaf1ae1769ec95311d578d6fcf67130d572e"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"0a7352586518cdccec6e4bcd4c8f24ef00288042","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if $http_proxy or $https_proxy {"},{"line_number":29,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d\u0027:"},{"line_number":30,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":31,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"},{"line_number":32,"context_line":"      group  \u003d\u003e \u0027root\u0027,"},{"line_number":33,"context_line":"      mode   \u003d\u003e \u00270755\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    -\u003e file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027:"},{"line_number":36,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":37,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"72b58a5c_bddd7dca","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":5},"in_reply_to":"601ce35d_e9c35587","updated":"2022-11-18 20:06:40.000000000","message":"Dear Chris, this is legacy code not part of the changes we are proposing. Is it possible to let existing change to be merged and we can work on this cleanup as follow-up activity?","commit_id":"a20aaaf1ae1769ec95311d578d6fcf67130d572e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0c703739ff17f5abc78dd46fd71e470ed871b050","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if $http_proxy or $https_proxy {"},{"line_number":29,"context_line":"    file { \u0027/etc/systemd/system/containerd.service.d\u0027:"},{"line_number":30,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":31,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"},{"line_number":32,"context_line":"      group  \u003d\u003e \u0027root\u0027,"},{"line_number":33,"context_line":"      mode   \u003d\u003e \u00270755\u0027,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    -\u003e file { \u0027/etc/systemd/system/containerd.service.d/http-proxy.conf\u0027:"},{"line_number":36,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":37,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"94dceace_a928dc71","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":5},"in_reply_to":"72b58a5c_bddd7dca","updated":"2022-11-22 20:42:52.000000000","message":"yeah, that would be fine.","commit_id":"a20aaaf1ae1769ec95311d578d6fcf67130d572e"}]}