)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"5dd7967d91ba99a0e53bb551b1d6a929f36e1e04","unresolved":true,"context_lines":[{"line_number":15,"context_line":"PASS: Check if modifications were applied"},{"line_number":16,"context_line":"PASS: Build ISO, install, bootstrap and host-unlock"},{"line_number":17,"context_line":"PASS: Check parameter through command line using ps command"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2010087"},{"line_number":20,"context_line":"Task: 45766"},{"line_number":21,"context_line":"Change-Id: Id667f21d1778251233314000b2763fa2dad877d1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6a45da32_c0c82878","line":18,"updated":"2022-11-15 18:20:16.000000000","message":"The changes impact AIO-DX as well and should be added to TestPlan","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"51eea8bc050b6c961fe3cf15125771dc02104bb0","unresolved":true,"context_lines":[{"line_number":14,"context_line":"PASS: build a new Debian ISO."},{"line_number":15,"context_line":"PASS: AIO: SX|DX|DX+: Reboot system."},{"line_number":16,"context_line":"PASS: AIO: SX|DX|DX+: Check if modifications were applied."},{"line_number":17,"context_line":"PASS: AIO: SX|DX|DX+: Install, bootstrap and perform a host-unlock."},{"line_number":18,"context_line":"PASS: AIO: SX|DX|DX+: Check parameter through command line using ps"},{"line_number":19,"context_line":"command."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df871d49_a46dc57b","line":17,"updated":"2022-11-16 14:49:17.000000000","message":"for the DX case, was a host-swact performed to ensure controller swacted properly, memcached an no unexpected alarms?","commit_id":"a17b8ea28ce32d02103592e2840369af5c1f0aad"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"49ce3dbe9cf757bbb561e0cd47d26fea5ec23db6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"PASS: build a new Debian ISO."},{"line_number":15,"context_line":"PASS: AIO: SX|DX|DX+: Reboot system."},{"line_number":16,"context_line":"PASS: AIO: SX|DX|DX+: Check if modifications were applied."},{"line_number":17,"context_line":"PASS: AIO: SX|DX|DX+: Install, bootstrap and perform a host-unlock."},{"line_number":18,"context_line":"PASS: AIO: SX|DX|DX+: Check parameter through command line using ps"},{"line_number":19,"context_line":"command."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"39e59095_5f9aebb4","line":17,"in_reply_to":"cd0d007b_6e04e131","updated":"2022-11-16 16:03:51.000000000","message":"Thanks for confirming.","commit_id":"a17b8ea28ce32d02103592e2840369af5c1f0aad"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"b34a772981e4e3a6e3e9e3994cbc60af543c9e79","unresolved":true,"context_lines":[{"line_number":14,"context_line":"PASS: build a new Debian ISO."},{"line_number":15,"context_line":"PASS: AIO: SX|DX|DX+: Reboot system."},{"line_number":16,"context_line":"PASS: AIO: SX|DX|DX+: Check if modifications were applied."},{"line_number":17,"context_line":"PASS: AIO: SX|DX|DX+: Install, bootstrap and perform a host-unlock."},{"line_number":18,"context_line":"PASS: AIO: SX|DX|DX+: Check parameter through command line using ps"},{"line_number":19,"context_line":"command."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cd0d007b_6e04e131","line":17,"in_reply_to":"df871d49_a46dc57b","updated":"2022-11-16 15:44:01.000000000","message":"Yes, swact was verified on AIO-DX including compute nodes and no alarm nor log error was observed.","commit_id":"a17b8ea28ce32d02103592e2840369af5c1f0aad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"366110ce4ec20813878bc81e7247d9347996dd1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83234639_728624b6","updated":"2022-09-07 18:00:58.000000000","message":"I think you need to verify the \u0027else\u0027 block as well  for your testing.\nI am fairly certain that since that hiera variable does not exist, it would have broken in that situation.","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"}],"puppet-manifests/src/modules/platform/manifests/memcached.pp":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"366110ce4ec20813878bc81e7247d9347996dd1f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":19,"context_line":"    $processorcount \u003d $::platform::params::eng_workers"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $processorcount \u003d $::processorcount"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $system_mode \u003d\u003d \u0027simplex\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7672870c_961b0cb0","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":39},"updated":"2022-09-07 18:00:58.000000000","message":"this variable does not exist.","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c6e754fe5385931be769d4e4ac3b8926ecc90a19","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":19,"context_line":"    $processorcount \u003d $::platform::params::eng_workers"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $processorcount \u003d $::processorcount"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $system_mode \u003d\u003d \u0027simplex\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0aa5edaa_fb71b36f","line":21,"updated":"2022-11-08 15:19:12.000000000","message":"why would we want to use processorcount instead of eng_workers for AIO or worker nodes? wouldnt processor count be \u003e\u003d eng_workers?","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"},{"author":{"_account_id":34908,"name":"Romão Martines","email":"romaomatheus.martinesdejesus@windriver.com","username":"rmartine"},"change_message_id":"7da8339dd258b73619e33d8bdb33ee68b029fcad","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":19,"context_line":"    $processorcount \u003d $::platform::params::eng_workers"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $processorcount \u003d $::processorcount"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $system_mode \u003d\u003d \u0027simplex\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a0815eb4_2ef80899","line":21,"in_reply_to":"0aa5edaa_fb71b36f","updated":"2022-11-08 18:08:49.000000000","message":"since we want to perform scale down only in cases we have AIO and not system-controller role, for the exceptions of that we want to keep the current behavior (i.e., use the $processorcount variable).","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dbe6a1bca3cc71affa578ca4aa8f4edc030e9177","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":19,"context_line":"    $processorcount \u003d $::platform::params::eng_workers"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $processorcount \u003d $::processorcount"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $system_mode \u003d\u003d \u0027simplex\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b44cf94e_30cd479b","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":39},"in_reply_to":"7672870c_961b0cb0","updated":"2022-09-22 18:05:02.000000000","message":"Removing my comment.\nThis is a system wide fact\nhttps://puppet.com/docs/puppet/7/core_facts.html#processorcount","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"},{"author":{"_account_id":34908,"name":"Romão Martines","email":"romaomatheus.martinesdejesus@windriver.com","username":"rmartine"},"change_message_id":"59ba8e9773df846da589ef6268734f324af022bc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    $::platform::params::distributed_cloud_role !\u003d \u0027systemcontroller\u0027 {"},{"line_number":19,"context_line":"    $processorcount \u003d $::platform::params::eng_workers"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $processorcount \u003d $::processorcount"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $system_mode \u003d\u003d \u0027simplex\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d9cf970e_4c357679","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":39},"in_reply_to":"b44cf94e_30cd479b","updated":"2022-09-22 18:29:13.000000000","message":"Done","commit_id":"876861dd160ed0b25486c984f55a86f61b743a0d"}]}