)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"005a9315b5475b14a621e5d46caad20244e166a4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"      ldapsearch -xH ldaps://controller -b \"ou\u003dPeople,dc\u003dcgcs,dc\u003dlocal\""},{"line_number":20,"context_line":"PASS: After deployment, verify openldap users by"},{"line_number":21,"context_line":"      ldapfinger"},{"line_number":22,"context_line":"PASS: After deployemt, verify openldap users can login on console and"},{"line_number":23,"context_line":"      by ssh"},{"line_number":24,"context_line":"PASS: After deployment, delete secret system-openldap-local-certificate,"},{"line_number":25,"context_line":"      trigger cert-mon to renew openldap cert/key, verify the cert/key"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a40eaa26_83ee1182","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":21},"updated":"2022-10-14 01:51:21.000000000","message":"nit: deployment","commit_id":"2ad754387e85ee2e8010cde79308ae1b824ab4d7"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"98c549850d29aa2b221a517cd6d7dec12b3f1a18","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      ldapsearch -xH ldaps://controller -b \"ou\u003dPeople,dc\u003dcgcs,dc\u003dlocal\""},{"line_number":20,"context_line":"PASS: After deployment, verify openldap users by"},{"line_number":21,"context_line":"      ldapfinger"},{"line_number":22,"context_line":"PASS: After deployemt, verify openldap users can login on console and"},{"line_number":23,"context_line":"      by ssh"},{"line_number":24,"context_line":"PASS: After deployment, delete secret system-openldap-local-certificate,"},{"line_number":25,"context_line":"      trigger cert-mon to renew openldap cert/key, verify the cert/key"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"01fe2a0b_15fec6ce","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":21},"in_reply_to":"a40eaa26_83ee1182","updated":"2022-10-14 01:55:15.000000000","message":"Ack","commit_id":"2ad754387e85ee2e8010cde79308ae1b824ab4d7"}],"puppet-manifests/src/modules/platform/manifests/ldap.pp":[{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"c0549b797231ae62ad6b544e6f2d2a22dc9a0162","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"0fb6b262_a59e6db6","line":72,"updated":"2022-10-14 14:55:55.000000000","message":"Is this the right way to restart slapd if slapd is managed by sm?","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"34264e6756a184ef4170e338e55f7224eec8f7ea","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4b21839d_1d1c988e","line":72,"in_reply_to":"0fb6b262_a59e6db6","updated":"2022-10-14 15:00:02.000000000","message":"I think so, because sm will take over and manage services at the very end of unlock. (at this moment sm is not managing this service).","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"0906cc464ddc7475f20e968489c081f25a3ffc02","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"507b1a7a_ff2c3833","line":72,"in_reply_to":"4b21839d_1d1c988e","updated":"2022-10-14 15:50:45.000000000","message":"Since this is a second unlock, so to speak, second to the one done at install, the slapd was under sm control, here it is just restarted. When I do manual restart of slapd, I first do a \"sm-unmanage service open-ldap\".","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"6e0647dea75d6d8791117664c126d69457966507","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b2d8ca70_eb5607a4","line":72,"in_reply_to":"507b1a7a_ff2c3833","updated":"2022-10-14 16:20:48.000000000","message":"The restart has a onlyif condition. The second unlock after the initial one, the slapd.conf has already moved to slapd.conf.backup. The restart won\u0027t be even executed.(since it\u0027s not neccessary, the exec before it \"-\u003e Exec[\u0027slapd-convert-config\u0027]\" is skipped for the same reason, so nothing change to require a restart)","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"8eb721e2356ce2355012ee0ad1d5210244d1b12e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8ea0d950_f30c8f28","line":72,"in_reply_to":"b2d8ca70_eb5607a4","updated":"2022-10-14 17:43:56.000000000","message":"Ack","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"348b75ada0579b9d620e7629b2238cb79d9452ba","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  exec { \u0027stop-openldap\u0027:"},{"line_number":68,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl stop slapd.service\u0027,"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  exec { \u0027configure-ldaps\u0027:"},{"line_number":77,"context_line":"    command \u003d\u003e \"ldapmodify -D cn\u003dconfig -w \\\"${admin_pw}\\\" -xH ldap:/// -f ${slapd_etc_path}/certs.ldif\","},{"line_number":78,"context_line":"    onlyif  \u003d\u003e [\"test -e ${slapd_etc_path}/certs/openldap-cert.crt\", \"test -e ${slapd_etc_path}/certs/openldap-cert.key\"]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"88c50565_1e56828d","line":75,"range":{"start_line":67,"start_character":1,"end_line":75,"end_character":0},"updated":"2022-10-14 13:52:38.000000000","message":"Should the stop be chained (-\u003e)  to the restart?","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"d18dcd738132a9528935f689dec23cdfd9d2ed4d","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  exec { \u0027stop-openldap\u0027:"},{"line_number":68,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl stop slapd.service\u0027,"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  exec { \u0027configure-ldaps\u0027:"},{"line_number":77,"context_line":"    command \u003d\u003e \"ldapmodify -D cn\u003dconfig -w \\\"${admin_pw}\\\" -xH ldap:/// -f ${slapd_etc_path}/certs.ldif\","},{"line_number":78,"context_line":"    onlyif  \u003d\u003e [\"test -e ${slapd_etc_path}/certs/openldap-cert.crt\", \"test -e ${slapd_etc_path}/certs/openldap-cert.key\"]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e015ac2f_9114f594","line":75,"range":{"start_line":67,"start_character":1,"end_line":75,"end_character":0},"in_reply_to":"88c50565_1e56828d","updated":"2022-10-14 13:58:48.000000000","message":"Yes, they are chained on line 127 and 131.","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"8eb721e2356ce2355012ee0ad1d5210244d1b12e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  exec { \u0027stop-openldap\u0027:"},{"line_number":68,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl stop slapd.service\u0027,"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  exec { \u0027restart-openldap\u0027:"},{"line_number":72,"context_line":"    command \u003d\u003e \u0027/usr/bin/systemctl restart slapd.service\u0027,"},{"line_number":73,"context_line":"    onlyif  \u003d\u003e \"/usr/bin/test -e ${slapd_etc_path}/slapd.conf\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  exec { \u0027configure-ldaps\u0027:"},{"line_number":77,"context_line":"    command \u003d\u003e \"ldapmodify -D cn\u003dconfig -w \\\"${admin_pw}\\\" -xH ldap:/// -f ${slapd_etc_path}/certs.ldif\","},{"line_number":78,"context_line":"    onlyif  \u003d\u003e [\"test -e ${slapd_etc_path}/certs/openldap-cert.crt\", \"test -e ${slapd_etc_path}/certs/openldap-cert.key\"]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"815c978d_1a0a774e","line":75,"range":{"start_line":67,"start_character":1,"end_line":75,"end_character":0},"in_reply_to":"e015ac2f_9114f594","updated":"2022-10-14 17:43:56.000000000","message":"Ack","commit_id":"51a830e85688091d091b3d2b0c14956c18c18eca"}]}