)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"593feca10d0937ea0a61548a7c85b7f41df908f3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"upgrade_k8s_config.sh has been deprecated and"},{"line_number":10,"context_line":"removed due to lack of support \"flow\" style in"},{"line_number":11,"context_line":"the YAML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updating calls the kubeadm the use an explicit"},{"line_number":14,"context_line":"version."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bd20bd77_b23140b8","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":9},"updated":"2023-04-25 22:04:01.000000000","message":"Should also mention that what it used to do is now being handled better in a YAML-aware way within sysinv.","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"f73f98dad70a0a5a5c563adbda4f18708e73754a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"upgrade_k8s_config.sh has been deprecated and"},{"line_number":10,"context_line":"removed due to lack of support \"flow\" style in"},{"line_number":11,"context_line":"the YAML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updating calls the kubeadm the use an explicit"},{"line_number":14,"context_line":"version."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e69b51b3_1d3c5695","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":9},"in_reply_to":"bd20bd77_b23140b8","updated":"2023-04-26 03:03:42.000000000","message":"Done","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"6850db8d7b0b481b03af7ecf5967b1c6ad2aa286","unresolved":true,"context_lines":[{"line_number":10,"context_line":"removed due to lack of support \"flow\" style in"},{"line_number":11,"context_line":"the YAML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updating calls the kubeadm the use an explicit"},{"line_number":14,"context_line":"version."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Test Plan:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"89d0920a_12e5b320","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":8},"updated":"2023-04-25 21:36:25.000000000","message":"grammar? :)","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"f73f98dad70a0a5a5c563adbda4f18708e73754a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"removed due to lack of support \"flow\" style in"},{"line_number":11,"context_line":"the YAML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updating calls the kubeadm the use an explicit"},{"line_number":14,"context_line":"version."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Test Plan:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"599e9ebc_abf8f310","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":8},"in_reply_to":"3451ac84_9baadb2a","updated":"2023-04-26 03:03:42.000000000","message":"Done","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bc81fe4fdd511e3ce6e767b46e38b85ceb79018b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"removed due to lack of support \"flow\" style in"},{"line_number":11,"context_line":"the YAML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updating calls the kubeadm the use an explicit"},{"line_number":14,"context_line":"version."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Test Plan:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3451ac84_9baadb2a","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":8},"in_reply_to":"89d0920a_12e5b320","updated":"2023-04-25 21:58:09.000000000","message":"Also should mention that we\u0027re doing this so that we use the version of kubeadm that we\u0027re upgrading to, so that we can handle kubeadm configmap being updated to a format that the old kubeadm no longer understands.","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"075f973a596ce2fd24fd185cdc8c08e520cd5808","unresolved":true,"context_lines":[{"line_number":15,"context_line":"version of kubeadm when calling it.  The version called"},{"line_number":16,"context_line":"will now match the version we are upgrading to in order to handle"},{"line_number":17,"context_line":"the format unsupported by previous versions of kubeadm."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/integ/+/880390"},{"line_number":20,"context_line":"Closes-Bug: 2017696"},{"line_number":21,"context_line":"Change-Id: I840eb566057be495fe0da3cae7604bf8055c0d4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9dce16c0_1fd5efe3","line":18,"updated":"2023-04-26 13:49:42.000000000","message":"Need a Test Plan section.","commit_id":"c49b5e77f867edd7fdadb07c71f7b23139c6e2ac"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"e2362e2e999dce701ef1a3ded609c61c038afe20","unresolved":false,"context_lines":[{"line_number":15,"context_line":"version of kubeadm when calling it.  The version called"},{"line_number":16,"context_line":"will now match the version we are upgrading to in order to handle"},{"line_number":17,"context_line":"the format unsupported by previous versions of kubeadm."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/integ/+/880390"},{"line_number":20,"context_line":"Closes-Bug: 2017696"},{"line_number":21,"context_line":"Change-Id: I840eb566057be495fe0da3cae7604bf8055c0d4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ed280824_d4510054","line":18,"in_reply_to":"9dce16c0_1fd5efe3","updated":"2023-04-26 15:01:58.000000000","message":"Done","commit_id":"c49b5e77f867edd7fdadb07c71f7b23139c6e2ac"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"53d4478f743b6e7c89e39c3f3f9444a3205e71d2","unresolved":true,"context_lines":[{"line_number":27,"context_line":"to verify the code."},{"line_number":28,"context_line":"Patch was not tested."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/integ/+/880390"},{"line_number":31,"context_line":"Closes-Bug: 2017696"},{"line_number":32,"context_line":"Change-Id: I840eb566057be495fe0da3cae7604bf8055c0d4f"},{"line_number":33,"context_line":"Signed-off-by: Gleb Aronsky \u003cgleb.aronsky@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"84edcc38_a958226d","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":65},"updated":"2023-04-26 21:50:19.000000000","message":"this is backwards.  We can remove the calling location in this commit while the script still exists in the load.","commit_id":"959c1cf4e963cbb9d71d29e1222bb46971db8745"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"50eac2330f1393977c77cfb77c82c9486bd261a8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"to verify the code."},{"line_number":28,"context_line":"Patch was not tested."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/integ/+/880390"},{"line_number":31,"context_line":"Closes-Bug: 2017696"},{"line_number":32,"context_line":"Change-Id: I840eb566057be495fe0da3cae7604bf8055c0d4f"},{"line_number":33,"context_line":"Signed-off-by: Gleb Aronsky \u003cgleb.aronsky@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"a431ee9c_12307ca3","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":65},"in_reply_to":"84edcc38_a958226d","updated":"2023-04-26 23:30:52.000000000","message":"Done","commit_id":"959c1cf4e963cbb9d71d29e1222bb46971db8745"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dcc26861a7c1d46c4b0a81f9bd3a81a169e8458f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a3335d71_65a08c8b","updated":"2023-05-01 16:57:22.000000000","message":"Adding a reference to the fix from Chris when that target was removed\nhttps://review.opendev.org/c/starlingx/stx-puppet/+/881917","commit_id":"77e0c7c14fb489194960bd7bf5f9f5f0e9495020"}],"puppet-manifests/src/modules/platform/manifests/kubernetes.pp":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d87e8bb751b51141e1089afb4238a391d9aa7ca8","unresolved":true,"context_lines":[{"line_number":912,"context_line":""},{"line_number":913,"context_line":"  # workers use kubelet.conf rather than admin.conf"},{"line_number":914,"context_line":"  $kubelet_version \u003d $::platform::kubernetes::params::kubelet_version"},{"line_number":915,"context_line":"  # Pull the pause image tag from kubeadm required images list for this version"},{"line_number":916,"context_line":"  $kubeadm_version \u003d $::platform::kubernetes::params::kubeadm_version # lint:ignore:140chars"},{"line_number":917,"context_line":"  $local_registry_auth \u003d \"${::platform::dockerdistribution::params::registry_username}:${::platform::dockerdistribution::params::registry_password}\" # lint:ignore:140chars"},{"line_number":918,"context_line":"  $creds_command \u003d \u0027$(cat /tmp/puppet/registry_credentials)\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"df72769e_b26f84a5","line":915,"range":{"start_line":915,"start_character":4,"end_line":915,"end_character":79},"updated":"2023-04-25 22:01:50.000000000","message":"this doesn\u0027t really match the line below.  Here we\u0027re really just getting the kubeadm version that we\u0027re upgrading to.","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"f73f98dad70a0a5a5c563adbda4f18708e73754a","unresolved":false,"context_lines":[{"line_number":912,"context_line":""},{"line_number":913,"context_line":"  # workers use kubelet.conf rather than admin.conf"},{"line_number":914,"context_line":"  $kubelet_version \u003d $::platform::kubernetes::params::kubelet_version"},{"line_number":915,"context_line":"  # Pull the pause image tag from kubeadm required images list for this version"},{"line_number":916,"context_line":"  $kubeadm_version \u003d $::platform::kubernetes::params::kubeadm_version # lint:ignore:140chars"},{"line_number":917,"context_line":"  $local_registry_auth \u003d \"${::platform::dockerdistribution::params::registry_username}:${::platform::dockerdistribution::params::registry_password}\" # lint:ignore:140chars"},{"line_number":918,"context_line":"  $creds_command \u003d \u0027$(cat /tmp/puppet/registry_credentials)\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3fdbb4a2_df793c91","line":915,"range":{"start_line":915,"start_character":4,"end_line":915,"end_character":79},"in_reply_to":"df72769e_b26f84a5","updated":"2023-04-26 03:03:42.000000000","message":"Done","commit_id":"8ed5d5b4afabadd336d86feb8c52b4b68106344b"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d8b96bb02621db0d5c7b3c008273bc8aafa4a922","unresolved":true,"context_lines":[{"line_number":917,"context_line":""},{"line_number":918,"context_line":"  # workers use kubelet.conf rather than admin.conf"},{"line_number":919,"context_line":"  $kubelet_version \u003d $::platform::kubernetes::params::kubelet_version"},{"line_number":920,"context_line":"  $kubeadm_version \u003d $::platform::kubernetes::params::kubeadm_version # lint:ignore:140chars"},{"line_number":921,"context_line":"  $local_registry_auth \u003d \"${::platform::dockerdistribution::params::registry_username}:${::platform::dockerdistribution::params::registry_password}\" # lint:ignore:140chars"},{"line_number":922,"context_line":"  $creds_command \u003d \u0027$(cat /tmp/puppet/registry_credentials)\u0027"},{"line_number":923,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":18,"id":"c54ebf9b_365fd36a","line":920,"updated":"2023-04-26 23:39:52.000000000","message":"nit : you dont need this ignore here.\nline 926 below needed it but this one is ok","commit_id":"77e0c7c14fb489194960bd7bf5f9f5f0e9495020"}]}