)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"e42a33f79ee053a8210b4a505e0fe5b651613cf1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update kubelet system overrides on unlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We want to ensure that kube-stx-override is regenerated"},{"line_number":10,"context_line":"when the host in unlocked.  This is neccessary when patching"},{"line_number":11,"context_line":"hosts and we need to update the kubelet system configuration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4da49567_7db78809","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":61},"updated":"2023-09-05 03:40:20.000000000","message":"Might be clearer as:\n\nMove generation of kubelet\u0027s systemd override file, kube-stx-override.conf, from platform::kubernetes::master::init to platform::kubernetes::configuration so that the file will be generated on every host unlock. This facilitates delivery of systemd service changes via patches to existing installs.","commit_id":"f38da2ea828d6da7eb1ee397fdccde25132171b4"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"2ceea324d6bd30be7709932706ea695b49047062","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update kubelet system overrides on unlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We want to ensure that kube-stx-override is regenerated"},{"line_number":10,"context_line":"when the host in unlocked.  This is neccessary when patching"},{"line_number":11,"context_line":"hosts and we need to update the kubelet system configuration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f7b904f_cb1bf847","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":61},"in_reply_to":"4da49567_7db78809","updated":"2023-09-05 12:44:59.000000000","message":"Done","commit_id":"f38da2ea828d6da7eb1ee397fdccde25132171b4"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"f01312baf41058b1110f2b2d129b8297486a51bf","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Pass:  - Update the kube-stx-override.conf.erb file"},{"line_number":18,"context_line":"       - Lock the host"},{"line_number":19,"context_line":"       - Unlock the host"},{"line_number":20,"context_line":"       - Verify that kube-stx-override.conf has been updated"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial-Bug: 2027810"},{"line_number":23,"context_line":"Change-Id: I3b496abc807bf75716d28079c62ef4700dcd3244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a6939e0a_794162ff","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":60},"updated":"2023-09-05 18:54:49.000000000","message":"Need to also verify that the systemd service itself was reloaded. Need to make sure it actually takes the new settings from kube-stx-override.conf.\n\nBasically somewhere after the unlock, is there a step that does equivalent of: \"systemctl daemon-reload\"?","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"1eb13422801308622055d00bcde04517fa3de9d9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Pass:  - Update the kube-stx-override.conf.erb file"},{"line_number":18,"context_line":"       - Lock the host"},{"line_number":19,"context_line":"       - Unlock the host"},{"line_number":20,"context_line":"       - Verify that kube-stx-override.conf has been updated"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial-Bug: 2027810"},{"line_number":23,"context_line":"Change-Id: I3b496abc807bf75716d28079c62ef4700dcd3244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e59bc4fa_045d7156","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":60},"in_reply_to":"a6939e0a_794162ff","updated":"2023-09-06 21:05:12.000000000","message":"Verified that the running kubelet service has the updated values after unlocking.","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"f01312baf41058b1110f2b2d129b8297486a51bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70133e84_6f8d0858","updated":"2023-09-05 18:54:49.000000000","message":"Code looks correct to me, but I would like to know the answer to whether the systemd services are actually reloaded.","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"80d20d7196e3e8c5f2195ba0e144135b9b102f6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4198eaec_b432e5f1","updated":"2023-09-05 20:16:57.000000000","message":"I no longer have concerns for the reboot reloading the service config; this was manually tested and confirmed as working.","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c8f03d71b352e5aa295d8ad14fb01bebd6c6ed68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d6bfc0ca_9ab55eb7","updated":"2023-09-05 20:12:41.000000000","message":"It looks okay as an initial step, but ideally we want to be able to reconfigure kubelet without needing an unlock.","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d4f5db922af62f377ac1d8c62c1b7699f7f96017","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6da0854_85ea64b3","updated":"2023-09-05 20:16:58.000000000","message":"Looking at the code, both platform::kubernetes::worker::init and platform::kubernetes::configuration","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"59c66827580c6de2343936d89ada5bf1703eccc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a7770a51_98aefc4d","in_reply_to":"15c73b43_1bfa1320","updated":"2023-09-07 21:52:07.000000000","message":"I\u0027m an idiot...mixed up which review I was looking at, confused this with the one to move per-node custom config to the kubelet config file.","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"e111fe3bd5b24b60c724b97be4742fa4961874d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15c73b43_1bfa1320","in_reply_to":"6684b8f3_aed00fe9","updated":"2023-09-06 15:05:08.000000000","message":"The new code is now outside of the \" if str2bool($::is_initial_k8s_config) {\"","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"7b06abd62f8deb2de0d455ca2b7792ae14befee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6684b8f3_aed00fe9","in_reply_to":"b6da0854_85ea64b3","updated":"2023-09-05 20:23:13.000000000","message":"Whoops, posted by accident.   Looking at the code, platform::kubernetes::master::init and platform::kubernetes::configuration are both contained within platform::kubernetes::master, so how does this code change things?\n\nAnd platform::kubernetes::worker::init and platform::kubernetes::configuration are both contained within platform::kubernetes::worker.\n\nplatform::kubernetes::master is included in puppet-manifests/src/manifests/controller.pp and platform::kubernetes::worker is included in puppet-manifests/src/manifests/worker.pp so it *seems* like we would already regenerate the kubelet service override as part of a host-unlock sequence, no?","commit_id":"2190522bf1decdd55feef58763cb5f98b61bdc19"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"9bca79d9d5b05b7a29b5710cabd516f41151920c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2fc142c_04ad1336","updated":"2023-09-07 22:04:48.000000000","message":"So I\u0027m okay with the idea in principle.  It does mean that the \"Restart\u003dno\" won\u0027t take effect until the first host-unlock operation, so if kubelet dies before the first host-unlock both systemd and pmon will try to restart it.\n\nIdeally I\u0027d like to see a runtime mechanism where we could make changes to the systemd service file via a no-reboot-required patch rather than needing a reboot for the changes to take effect. If other changes make the patch reboot-required though this is a bit of a moot point.","commit_id":"7d870177c6c01f5b47a33ef1cd7ce92c3c58694f"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"711cdcae6f7ee819967b87fd96f1fa665207ad6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b1e31635_039013f7","updated":"2023-09-06 22:35:57.000000000","message":"lgtm","commit_id":"7d870177c6c01f5b47a33ef1cd7ce92c3c58694f"}],"puppet-manifests/src/modules/platform/manifests/kubernetes.pp":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c8f03d71b352e5aa295d8ad14fb01bebd6c6ed68","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    # set kubelet monitored by pmond"},{"line_number":435,"context_line":"    -\u003e file { \u0027/etc/pmon.d/kubelet.conf\u0027:"},{"line_number":436,"context_line":"      ensure  \u003d\u003e file,"},{"line_number":437,"context_line":"      content \u003d\u003e template(\u0027platform/kubelet-pmond-conf.erb\u0027),"},{"line_number":438,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"},{"line_number":439,"context_line":"      group   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ce87dbda_f51b1616","side":"PARENT","line":436,"updated":"2023-09-05 20:12:41.000000000","message":"I\u0027m slightly tempted to also leave the original code here so that the service override takes effect on initial installation, but given the current contents of the override it would be okay for it to only take effect on the next host-unlock.","commit_id":"c0d150941e7dedd9e51ab438305c526a437c2ef5"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"1eb13422801308622055d00bcde04517fa3de9d9","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    # set kubelet monitored by pmond"},{"line_number":435,"context_line":"    -\u003e file { \u0027/etc/pmon.d/kubelet.conf\u0027:"},{"line_number":436,"context_line":"      ensure  \u003d\u003e file,"},{"line_number":437,"context_line":"      content \u003d\u003e template(\u0027platform/kubelet-pmond-conf.erb\u0027),"},{"line_number":438,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"},{"line_number":439,"context_line":"      group   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"a4cbbae0_3300c2df","side":"PARENT","line":436,"in_reply_to":"ce87dbda_f51b1616","updated":"2023-09-06 21:05:12.000000000","message":"Ack","commit_id":"c0d150941e7dedd9e51ab438305c526a437c2ef5"}]}