)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"dc399e1840b2832c9311e2550e8437f2df515bfe","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update etcd-override.conf.erb for new etcd version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Etcd config file path on Debian has been /etc/default/etcd. It is corrected in the etcd service overrides template. Also, starting etcd 3.4, etcd fatally fails if both command line flags and environment variables are used. Flags are removed in this change."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":"ON AIO-SX and AIO-DX:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7936a7fd_3212f798","line":9,"range":{"start_line":9,"start_character":223,"end_line":9,"end_character":255},"updated":"2023-10-30 17:11:32.000000000","message":".. since they are sufficiently specified in /etc/default/etcd.\n\nPlease confirm my interpretation.","commit_id":"7d38c75d228db56d2df64c10629f243b1b0565c7"},{"author":{"_account_id":33814,"name":"Kaustubh Dhokte","display_name":"Kaustubh Dhokte","email":"kaustubh.dhokte@windriver.com","username":"kdhokte"},"change_message_id":"542904c26e1274187ce042de1fdef3e59100300c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update etcd-override.conf.erb for new etcd version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Etcd config file path on Debian has been /etc/default/etcd. It is corrected in the etcd service overrides template. Also, starting etcd 3.4, etcd fatally fails if both command line flags and environment variables are used. Flags are removed in this change."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":"ON AIO-SX and AIO-DX:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"edacd8c5_bc75377f","line":9,"range":{"start_line":9,"start_character":223,"end_line":9,"end_character":255},"in_reply_to":"7936a7fd_3212f798","updated":"2023-12-06 21:58:44.000000000","message":"Done","commit_id":"7d38c75d228db56d2df64c10629f243b1b0565c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"dc399e1840b2832c9311e2550e8437f2df515bfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa3a5ac7_c52b5ec9","updated":"2023-10-30 17:11:32.000000000","message":"some clarification questions","commit_id":"7d38c75d228db56d2df64c10629f243b1b0565c7"}],"puppet-manifests/src/modules/platform/templates/etcd-override.conf.erb":[{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"dc399e1840b2832c9311e2550e8437f2df515bfe","unresolved":true,"context_lines":[{"line_number":11,"context_line":"ExecStart\u003d"},{"line_number":12,"context_line":"ExecStart\u003d-/bin/bash -c \"GOMAXPROCS\u003d\u003c%\u003d @etcd_max_procs %\u003e /usr/bin/etcd\""},{"line_number":13,"context_line":"ExecStartPost\u003d/bin/bash -c \u0027echo $MAINPID \u003e/var/run/etcd.pid\u0027"},{"line_number":14,"context_line":"ExecStop\u003d"},{"line_number":15,"context_line":"ExecStopPost\u003d/bin/bash -c \u0027rm -f /var/run/etcd.pid\u0027"},{"line_number":16,"context_line":"Nice\u003d-19"},{"line_number":17,"context_line":"IOSchedulingClass\u003dbest-effort"}],"source_content_type":"application/x-erb","patch_set":4,"id":"4c8d330c_2860ab72","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2023-10-30 17:11:32.000000000","message":"this wipes out the default EcexStop from its systemd conf file. What actually stops the etcd process now?","commit_id":"7d38c75d228db56d2df64c10629f243b1b0565c7"},{"author":{"_account_id":33814,"name":"Kaustubh Dhokte","display_name":"Kaustubh Dhokte","email":"kaustubh.dhokte@windriver.com","username":"kdhokte"},"change_message_id":"542904c26e1274187ce042de1fdef3e59100300c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ExecStart\u003d"},{"line_number":12,"context_line":"ExecStart\u003d-/bin/bash -c \"GOMAXPROCS\u003d\u003c%\u003d @etcd_max_procs %\u003e /usr/bin/etcd\""},{"line_number":13,"context_line":"ExecStartPost\u003d/bin/bash -c \u0027echo $MAINPID \u003e/var/run/etcd.pid\u0027"},{"line_number":14,"context_line":"ExecStop\u003d"},{"line_number":15,"context_line":"ExecStopPost\u003d/bin/bash -c \u0027rm -f /var/run/etcd.pid\u0027"},{"line_number":16,"context_line":"Nice\u003d-19"},{"line_number":17,"context_line":"IOSchedulingClass\u003dbest-effort"}],"source_content_type":"application/x-erb","patch_set":4,"id":"4cdf9886_104e6612","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"in_reply_to":"4c8d330c_2860ab72","updated":"2023-12-06 21:58:44.000000000","message":"It is now stopped by SIGKILL.\n\nExisting version 3.3.25 is installed by using upstream etcd debian package. So it installs files at /lib/systemd/system/etcd.service. As Stx anyways overrides it by generating config (using puppet) at /etc/systemd/systemd/etcd.service.d/etcd.service, it is not added to this change. With that, if we run \"sudo systemctl status etcd\", for 3.3.25, \"Loaded\" unit shows \u0027/lib/systemd/system/etcd.service\u0027 whereas for 3.4.27 it is \"/etc/init.d/etcd\". \nSeems like with no /lib/systemd/system/etcd.service and without \"ExecStop\u003d\", etcd is stopped using \u0027/etc/init.d/etcd stop\u0027 when we run \u0027sudo systemctl stop etcd\u0027. \u0027/etcd/init.d/etcd stop\u0027 internally runs \"systemctl stop etcd\". This goes into recursive infinite loop and etcd stop/restart commands execution get stuck and go to completion only by the timeout.\nWith \u0027ExecStop\u003d\"\"\u0027, service is stopped by SIGKILL and commands don\u0027t go into infinite loop.","commit_id":"7d38c75d228db56d2df64c10629f243b1b0565c7"}]}