)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"a5bb0da2928ba4b015ea6961f1a2e1cc9ce1285b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"scenario, the system is able to pull the required"},{"line_number":18,"context_line":"images."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Test Plan:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PASS - BUILD ISO and test install on AIO-DX using"},{"line_number":23,"context_line":"       Virtual Box. After upgrade controller-1 unlocks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"2761e758_ad4cadb2","line":20,"updated":"2023-11-16 19:58:39.000000000","message":"I think we have one more test is needed. Change a docker proxy service parameter (maybe point to upstream registry) and apply it, pull and image from that registry, then can change it back, apply it, pull an image from the proxy registry. That should fire a runtime manifest impacting this code.","commit_id":"8cb3f7f38ad6cc28ea9cd20f5835bd74aaa60dbd"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"077fa517b28844702ff72a8bf2b618e21c3601bb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"scenario, the system is able to pull the required"},{"line_number":18,"context_line":"images."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Test Plan:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PASS - BUILD ISO and test install on AIO-DX using"},{"line_number":23,"context_line":"       Virtual Box. After upgrade controller-1 unlocks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"8f43de59_42b8659f","line":20,"in_reply_to":"2761e758_ad4cadb2","updated":"2023-11-17 08:54:14.000000000","message":"Added a test for the runtime docker manifest.","commit_id":"8cb3f7f38ad6cc28ea9cd20f5835bd74aaa60dbd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28439,"name":"Matt Peters","email":"matt.peters@windriver.com","username":"mpeters-wrs"},"change_message_id":"3f3f93cc537c36b9119de1f493efec16b54a10b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3e2937d_88140b3c","updated":"2023-11-14 17:28:39.000000000","message":"Giving +1 for the runtime configuration as the docker.service is started before the mount would be available (i.e. before puppet configures the host).  A future update should address the docker.service dependency issues by deferring startup.","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":35757,"name":"Bruce Jones","email":"bruce.jones@windriver.com","username":"bejones"},"change_message_id":"687c847f844b80232d0adedd3f40cbda03171b9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fa41da3_5cc99a78","updated":"2023-11-15 20:24:02.000000000","message":"Well done, and thanks to the entire team who worked on this.","commit_id":"3533a05d2f62814e65b3a5776e78795751e56e48"},{"author":{"_account_id":35757,"name":"Bruce Jones","email":"bruce.jones@windriver.com","username":"bejones"},"change_message_id":"52a48fccbdf272ab36a3fb1461df2cdc03ea9fb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dfe68c43_bb4ac4c3","updated":"2023-11-16 16:23:29.000000000","message":"Need to fix the Zuul issues...","commit_id":"85cd478f4ab87bb366ce60c52bb2e8af1adb2dae"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"d0dbab7856b19b9d8cb11c9091254dc19b24a613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"176ae36d_3bfcb2af","updated":"2023-11-17 16:53:18.000000000","message":"lgtm","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"}],"puppet-manifests/src/modules/platform/manifests/docker.pp":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"927f75c0805917c1849745ea8a3bd48c73ad8f96","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    enable  \u003d\u003e true,"},{"line_number":66,"context_line":"    require \u003d\u003e ["},{"line_number":67,"context_line":"      Package[\u0027docker\u0027],"},{"line_number":68,"context_line":"      Mount[\u0027docker-lv\u0027],"},{"line_number":69,"context_line":"    ],"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1c728062_c71a436c","line":68,"updated":"2023-11-16 16:12:08.000000000","message":"This may not be the correct dependency here. I\u0027m still evaluating this, although this appears to be working.","commit_id":"85cd478f4ab87bb366ce60c52bb2e8af1adb2dae"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"077fa517b28844702ff72a8bf2b618e21c3601bb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    enable  \u003d\u003e true,"},{"line_number":66,"context_line":"    require \u003d\u003e ["},{"line_number":67,"context_line":"      Package[\u0027docker\u0027],"},{"line_number":68,"context_line":"      Mount[\u0027docker-lv\u0027],"},{"line_number":69,"context_line":"    ],"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"47b7ff25_b01d2c94","line":68,"in_reply_to":"1c728062_c71a436c","updated":"2023-11-17 08:54:14.000000000","message":"This is correct. Need to now include \u0027platform::filesystem::docker\u0027 along with \u0027platform::docker::runtime\u0027 with the runtime manifest execution.","commit_id":"85cd478f4ab87bb366ce60c52bb2e8af1adb2dae"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"927f75c0805917c1849745ea8a3bd48c73ad8f96","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    enable  \u003d\u003e true,"},{"line_number":134,"context_line":"    require \u003d\u003e ["},{"line_number":135,"context_line":"      Package[\u0027docker\u0027],"},{"line_number":136,"context_line":"      Mount[\u0027docker-lv\u0027],"},{"line_number":137,"context_line":"    ],"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":"  -\u003e exec { \u0027enable-docker\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"809ca17e_f3cd6635","line":136,"updated":"2023-11-16 16:12:08.000000000","message":"This may not be the correct dependency here. I\u0027m still evaluating this, although this appears to be working.","commit_id":"85cd478f4ab87bb366ce60c52bb2e8af1adb2dae"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"077fa517b28844702ff72a8bf2b618e21c3601bb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    enable  \u003d\u003e true,"},{"line_number":134,"context_line":"    require \u003d\u003e ["},{"line_number":135,"context_line":"      Package[\u0027docker\u0027],"},{"line_number":136,"context_line":"      Mount[\u0027docker-lv\u0027],"},{"line_number":137,"context_line":"    ],"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":"  -\u003e exec { \u0027enable-docker\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"f12c0a29_a3ad8b53","line":136,"in_reply_to":"809ca17e_f3cd6635","updated":"2023-11-17 08:54:14.000000000","message":"This is correct. Need to now include \u0027platform::filesystem::docker\u0027 along with \u0027platform::docker::runtime\u0027 with the runtime manifest execution.","commit_id":"85cd478f4ab87bb366ce60c52bb2e8af1adb2dae"}],"puppet-manifests/src/modules/platform/manifests/filesystem.pp":[{"author":{"_account_id":28439,"name":"Matt Peters","email":"matt.peters@windriver.com","username":"mpeters-wrs"},"change_message_id":"abcf816aebe2e954c914a930acfec7bdf2982609","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    mode       \u003d\u003e \u00270711\u0027,"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  $docker_overrides \u003d \u0027/etc/systemd/system/docker.service.d/docker-stx-override.conf\u0027"},{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"914cda8e_0f114f02","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":85},"updated":"2023-11-14 13:05:19.000000000","message":"Does this need to be done at runtime or could this be added to the docker-config package directly which provides this file?  If it can\u0027t, this should be a separate service override to avoid updating the packaged file.","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"5d2ac56adb14cf7f90dd7997bc3d4e6c33ecd926","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    mode       \u003d\u003e \u00270711\u0027,"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  $docker_overrides \u003d \u0027/etc/systemd/system/docker.service.d/docker-stx-override.conf\u0027"},{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"eded1e6b_6836ca14","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":85},"in_reply_to":"914cda8e_0f114f02","updated":"2023-11-14 17:06:02.000000000","message":"I defer to Bob Church on the question.","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"927f75c0805917c1849745ea8a3bd48c73ad8f96","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    mode       \u003d\u003e \u00270711\u0027,"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  $docker_overrides \u003d \u0027/etc/systemd/system/docker.service.d/docker-stx-override.conf\u0027"},{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f3ab786f_27d13dba","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":85},"in_reply_to":"c460caaf_2735b29b","updated":"2023-11-16 16:12:08.000000000","message":"I did check on this, the service are disable. So if we can get all the puppet dependencies correct (i.e. don\u0027t enable/start docker until its filesystem is present, we could deliver the overrides in the docker-config package)","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9175294757688c40c74c09a58aea33820b2c48ae","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    mode       \u003d\u003e \u00270711\u0027,"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  $docker_overrides \u003d \u0027/etc/systemd/system/docker.service.d/docker-stx-override.conf\u0027"},{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c460caaf_2735b29b","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":85},"in_reply_to":"eded1e6b_6836ca14","updated":"2023-11-14 17:23:32.000000000","message":"Can\u0027t be done in the docker-config package as docker-lv is not present on a fresh install. docker-lv is created during bootstrap on controller-0 or node unlock on controller-1. It was observed during testing, docker was started on controller-1 after install and would be in a failed state, due to some other dependencies (guessing containerd/docker proxy related).\n\nWe could revisit, but to me it only makes sense to include the dependency in docker-config if the kickstarts created docker-lv OR if we are guaranteed to only start docker after docker-lv is created (i.e. docker is disabled on install)\n\nIt\u0027s possible that the node service setting are not correct. Will check.","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"7d53d7445eeb773046ac4624b4ebc5792ad3334e","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    mode       \u003d\u003e \u00270711\u0027,"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  $docker_overrides \u003d \u0027/etc/systemd/system/docker.service.d/docker-stx-override.conf\u0027"},{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"151db81a_b14e55ee","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":85},"in_reply_to":"eded1e6b_6836ca14","updated":"2023-11-14 17:15:05.000000000","message":"Matt - What I do know is that we need finer controller over exactly when the file is modified for  timing purposes, and doing so with puppet will ensure that the changes are added when the file system is created, since docker is dependent on it.","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"51ee19c0988bc34492a6601bb1f6256bf1e77dc5","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    mode       \u003d\u003e \u00270711\u0027,"},{"line_number":332,"context_line":"  }"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"  $docker_overrides \u003d \u0027/etc/systemd/system/docker.service.d/docker-stx-override.conf\u0027"},{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"314ef9c3_c47d29dd","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":85},"in_reply_to":"f3ab786f_27d13dba","updated":"2023-11-17 17:21:12.000000000","message":"\u003e I did check on this, the service are disable. So if we can get all the puppet dependencies correct (i.e. don\u0027t enable/start docker until its filesystem is present, we could deliver the overrides in the docker-config package)","commit_id":"2e14f8017bda36ea7c6783babcf740f712e3c11f"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"dc57bacd8aa26b34a54afcd206c7c90a0157f6bc","unresolved":true,"context_lines":[{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"},{"line_number":338,"context_line":"  }"},{"line_number":339,"context_line":"  -\u003e file_line { \"${docker_overrides}: add mount After dependency\":"},{"line_number":340,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":341,"context_line":"    line \u003d\u003e \u0027After\u003dvar-lib-docker.mount\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"4783dff0_6702034d","line":338,"updated":"2023-11-17 15:25:23.000000000","message":"does this ensure these line are added only if it doesn\u0027t already exist ?\nmatch -\u003e \u0027^[Unit]\u0027\n\ncould verify this by performing another host-lock/unlock to ensure no duplicate in docker-stx-override.conf","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"eef450800fa1cffcc69eca747681251b10b02a0c","unresolved":false,"context_lines":[{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"},{"line_number":338,"context_line":"  }"},{"line_number":339,"context_line":"  -\u003e file_line { \"${docker_overrides}: add mount After dependency\":"},{"line_number":340,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":341,"context_line":"    line \u003d\u003e \u0027After\u003dvar-lib-docker.mount\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"451434d6_d089a498","line":338,"in_reply_to":"322028bd_61e132d4","updated":"2023-11-17 15:58:55.000000000","message":"Acknowledged","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"e8120999a3b6f113b733a460afbe0672d3540af6","unresolved":true,"context_lines":[{"line_number":335,"context_line":"  file_line { \"${docker_overrides}: add unit section\":"},{"line_number":336,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":337,"context_line":"    line \u003d\u003e \u0027[Unit]\u0027,"},{"line_number":338,"context_line":"  }"},{"line_number":339,"context_line":"  -\u003e file_line { \"${docker_overrides}: add mount After dependency\":"},{"line_number":340,"context_line":"    path \u003d\u003e $docker_overrides,"},{"line_number":341,"context_line":"    line \u003d\u003e \u0027After\u003dvar-lib-docker.mount\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"322028bd_61e132d4","line":338,"in_reply_to":"4783dff0_6702034d","updated":"2023-11-17 15:57:13.000000000","message":"Hi John. Yes it does.\n\nI double checked and this out on a DX system where \n\n1. system host-lock controller-1\n2. wait for it to lock, and then system host-unlock controller-1\n3. After reboot. I did \"cat /etc/systemd/system/docker.service.d/docker-stx-override.conf\"  \n\nAll is well. After step 3 I could only see the one unit section and no duplicates.","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"80880eaeeac8dc1472b668ea8410fd07ab7db114","unresolved":true,"context_lines":[{"line_number":349,"context_line":"    logoutput \u003d\u003e true,"},{"line_number":350,"context_line":"  }"},{"line_number":351,"context_line":"}"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"class platform::filesystem::storage {"},{"line_number":354,"context_line":"  include ::platform::filesystem::kubelet"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dc1ab643_70d2d220","line":352,"updated":"2023-11-17 17:17:33.000000000","message":"I\u0027m wondering why we update docker service unit file this way ...\nWhy not just update the file in stx/config-files/docker-config/source-debian/docker-stx-override.conf?","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"742c2b262c836a226a209a842dc4a036e210a40a","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    logoutput \u003d\u003e true,"},{"line_number":350,"context_line":"  }"},{"line_number":351,"context_line":"}"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"class platform::filesystem::storage {"},{"line_number":354,"context_line":"  include ::platform::filesystem::kubelet"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ad04e01d_a857f54f","line":352,"in_reply_to":"9c36ebe0_32b3dcc8","updated":"2023-11-27 16:14:37.000000000","message":"Resolving this since Andy got the answer he was looking for.","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"5289a880c468fe6c1c09bda0053448c366da9002","unresolved":true,"context_lines":[{"line_number":349,"context_line":"    logoutput \u003d\u003e true,"},{"line_number":350,"context_line":"  }"},{"line_number":351,"context_line":"}"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"class platform::filesystem::storage {"},{"line_number":354,"context_line":"  include ::platform::filesystem::kubelet"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"b5b58f06_a37b4177","line":352,"in_reply_to":"dc1ab643_70d2d220","updated":"2023-11-17 17:19:59.000000000","message":"Hi Andy. This was asked in a previous review comment and has already been addressed.","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"51ee19c0988bc34492a6601bb1f6256bf1e77dc5","unresolved":true,"context_lines":[{"line_number":349,"context_line":"    logoutput \u003d\u003e true,"},{"line_number":350,"context_line":"  }"},{"line_number":351,"context_line":"}"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"class platform::filesystem::storage {"},{"line_number":354,"context_line":"  include ::platform::filesystem::kubelet"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9c36ebe0_32b3dcc8","line":352,"in_reply_to":"dc1ab643_70d2d220","updated":"2023-11-17 17:21:12.000000000","message":"See: https://review.opendev.org/c/starlingx/stx-puppet/+/900806/2..7/puppet-manifests/src/modules/platform/manifests/filesystem.pp#b334","commit_id":"5bf7f76b9c3bd2cae6564222eee9da2cea4613cd"}]}