)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"f4b0df16787c3bb6fef2fc02acea2faab3376019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1be6b9b1_369bc19f","updated":"2021-11-17 15:26:52.000000000","message":"A few minor comments. But please go with what Scott says in his review of these changes. The updates strings definitely improve the readability of the code.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"}],"stx/lib/stx/stx_build.py":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"93b56dd9f5956ee9a8f77a0bad1fa6917a6e65de","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    def buildImageCMD(self, args, prefixcmd):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        if args.kerneltype:"},{"line_number":35,"context_line":"            if args.kerneltype not in [\u0027rt\u0027, \u0027std\u0027]:"},{"line_number":36,"context_line":"                self.logger.error(\u0027Option -t for generaing image only \u0027 +"},{"line_number":37,"context_line":"                                  \u0027should be [ rt|std ]\u0027)"},{"line_number":38,"context_line":"                self.logger.error(\u0027Please use \"stx build -h\" to show the help\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9423f460_317efc49","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":52},"updated":"2021-11-17 15:51:27.000000000","message":"I would prefer to call this a built_type, not a kerneltype.  There are non-kernel packages that relevant to a \u0027rt\u0027 build.\n\nRather than hard coding the set of supported build_types in multiple places, I would like to see the set of supported build_types captured in a global variable and merely referenced here.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def buildImageCMD(self, args, prefixcmd):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        if args.kerneltype:"},{"line_number":35,"context_line":"            if args.kerneltype not in [\u0027rt\u0027, \u0027std\u0027]:"},{"line_number":36,"context_line":"                self.logger.error(\u0027Option -t for generaing image only \u0027 +"},{"line_number":37,"context_line":"                                  \u0027should be [ rt|std ]\u0027)"},{"line_number":38,"context_line":"                self.logger.error(\u0027Please use \"stx build -h\" to show the help\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9939d88_d68c5685","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":52},"in_reply_to":"9423f460_317efc49","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"93b56dd9f5956ee9a8f77a0bad1fa6917a6e65de","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                self.logger.error(\u0027Please use \"stx build -h\" to show the help\u0027)"},{"line_number":39,"context_line":"                sys.exit(1)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"            cmd \u003d prefixcmd + \u0027\"build-image -t \u0027 + args.kerneltype + \u0027\"\\\u0027\u0027"},{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            cmd \u003d prefixcmd + \u0027\"build-image\"\\\u0027\u0027"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bb5a45aa_732c485c","line":41,"range":{"start_line":41,"start_character":44,"end_line":41,"end_character":46},"updated":"2021-11-17 15:51:27.000000000","message":"Prefer to see the long form arguments in all these internally generated commands.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                self.logger.error(\u0027Please use \"stx build -h\" to show the help\u0027)"},{"line_number":39,"context_line":"                sys.exit(1)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"            cmd \u003d prefixcmd + \u0027\"build-image -t \u0027 + args.kerneltype + \u0027\"\\\u0027\u0027"},{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            cmd \u003d prefixcmd + \u0027\"build-image\"\\\u0027\u0027"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7cfa3ae7_712cfd0f","line":41,"range":{"start_line":41,"start_character":44,"end_line":41,"end_character":46},"in_reply_to":"bb5a45aa_732c485c","updated":"2021-11-22 06:36:55.000000000","message":"For build-image in root repo, there is only the short form arguments now.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"93b56dd9f5956ee9a8f77a0bad1fa6917a6e65de","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        cmd \u003d prefixcmd + \u0027\"build-pkgs \u0027"},{"line_number":50,"context_line":"        if not args.layers:"},{"line_number":51,"context_line":"            self.logger.error(\u0027Must use \"-l\" option for layer building.\u0027)"},{"line_number":52,"context_line":"            self.logger.error(\u0027Now support [ flock|distro ] layers:\u0027)"},{"line_number":53,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock\u0027)"},{"line_number":54,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l distro\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e091fd7_e1bf8932","line":51,"range":{"start_line":51,"start_character":41,"end_line":51,"end_character":43},"updated":"2021-11-17 15:51:27.000000000","message":"Prefer to see the long form arguments in all these logs, or reference both long and short options.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        cmd \u003d prefixcmd + \u0027\"build-pkgs \u0027"},{"line_number":50,"context_line":"        if not args.layers:"},{"line_number":51,"context_line":"            self.logger.error(\u0027Must use \"-l\" option for layer building.\u0027)"},{"line_number":52,"context_line":"            self.logger.error(\u0027Now support [ flock|distro ] layers:\u0027)"},{"line_number":53,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock\u0027)"},{"line_number":54,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l distro\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b69f3ad4_b75c0582","line":51,"range":{"start_line":51,"start_character":41,"end_line":51,"end_character":43},"in_reply_to":"4e091fd7_e1bf8932","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"f4b0df16787c3bb6fef2fc02acea2faab3376019","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        cmd \u003d prefixcmd + \u0027\"build-pkgs \u0027"},{"line_number":50,"context_line":"        if not args.layers:"},{"line_number":51,"context_line":"            self.logger.error(\u0027Must use \"-l\" option for layer building.\u0027)"},{"line_number":52,"context_line":"            self.logger.error(\u0027Now support [ flock|distro ] layers:\u0027)"},{"line_number":53,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock\u0027)"},{"line_number":54,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l distro\u0027)"},{"line_number":55,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock,distro\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a663b7c_d4f982ca","line":52,"updated":"2021-11-17 15:26:52.000000000","message":"I would suggest this line gets dropped. I will defer to Scott though.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"93b56dd9f5956ee9a8f77a0bad1fa6917a6e65de","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        cmd \u003d prefixcmd + \u0027\"build-pkgs \u0027"},{"line_number":50,"context_line":"        if not args.layers:"},{"line_number":51,"context_line":"            self.logger.error(\u0027Must use \"-l\" option for layer building.\u0027)"},{"line_number":52,"context_line":"            self.logger.error(\u0027Now support [ flock|distro ] layers:\u0027)"},{"line_number":53,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock\u0027)"},{"line_number":54,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l distro\u0027)"},{"line_number":55,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock,distro\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4576eaea_c60144eb","line":52,"range":{"start_line":52,"start_character":43,"end_line":52,"end_character":59},"updated":"2021-11-17 15:51:27.000000000","message":"Rather than hard coding the set of supported layers in multiple places, I would like to see the set of supported layers captured in a global variable and merely referenced here.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cmd \u003d prefixcmd + \u0027\"build-pkgs \u0027"},{"line_number":50,"context_line":"        if not args.layers:"},{"line_number":51,"context_line":"            self.logger.error(\u0027Must use \"-l\" option for layer building.\u0027)"},{"line_number":52,"context_line":"            self.logger.error(\u0027Now support [ flock|distro ] layers:\u0027)"},{"line_number":53,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock\u0027)"},{"line_number":54,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l distro\u0027)"},{"line_number":55,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock,distro\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f0f5e24_5daec280","line":52,"in_reply_to":"3a663b7c_d4f982ca","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cmd \u003d prefixcmd + \u0027\"build-pkgs \u0027"},{"line_number":50,"context_line":"        if not args.layers:"},{"line_number":51,"context_line":"            self.logger.error(\u0027Must use \"-l\" option for layer building.\u0027)"},{"line_number":52,"context_line":"            self.logger.error(\u0027Now support [ flock|distro ] layers:\u0027)"},{"line_number":53,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock\u0027)"},{"line_number":54,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l distro\u0027)"},{"line_number":55,"context_line":"            self.logger.error(\u0027  eg: stx build layer -l flock,distro\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"87e6c532_7bd9a05e","line":52,"range":{"start_line":52,"start_character":43,"end_line":52,"end_character":59},"in_reply_to":"4576eaea_c60144eb","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"93b56dd9f5956ee9a8f77a0bad1fa6917a6e65de","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        elif args.build_task \u003d\u003d \u0027world\u0027:"},{"line_number":159,"context_line":"            cmd \u003d self.buildPackageCMD(args, prefix_cmd, True)"},{"line_number":160,"context_line":"            self.logger.debug(\u0027Execute the debdownloader command: [%s].\u0027, cmd)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            cmd \u003d self.buildPackageCMD(args, prefix_cmd, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb514435_400cffc8","line":160,"range":{"start_line":160,"start_character":31,"end_line":160,"end_character":64},"updated":"2021-11-17 15:51:27.000000000","message":"wrong message in this log","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        elif args.build_task \u003d\u003d \u0027world\u0027:"},{"line_number":159,"context_line":"            cmd \u003d self.buildPackageCMD(args, prefix_cmd, True)"},{"line_number":160,"context_line":"            self.logger.debug(\u0027Execute the debdownloader command: [%s].\u0027, cmd)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            cmd \u003d self.buildPackageCMD(args, prefix_cmd, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0138228a_e5f5a788","line":160,"range":{"start_line":160,"start_character":31,"end_line":160,"end_character":64},"in_reply_to":"bb514435_400cffc8","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d99cc4fb367ad16440485b6af51c1251e8afc1cd","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if args.buildtype:"},{"line_number":38,"context_line":"            if args.buildtype not in STX_BUILD_TYPES:"},{"line_number":39,"context_line":"                self.logger.error(\u0027Option \"-b|--buildtype\" for generaing \u0027 +"},{"line_number":40,"context_line":"                                  \u0027only should be %s.\u0027, STX_BUILD_TYPES)"},{"line_number":41,"context_line":"                self.logger.error(\u0027Please use \"stx build -h\" to show the help\u0027)"},{"line_number":42,"context_line":"                sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"08ac142d_0f7c4417","line":39,"range":{"start_line":39,"start_character":63,"end_line":39,"end_character":73},"updated":"2021-11-24 03:27:42.000000000","message":"generating","commit_id":"f0af3284b6c20affde267607032a6b1f483b485e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"da53a2e0bb1fecfd3a1e31baf1132fe85eae2b74","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if args.buildtype:"},{"line_number":38,"context_line":"            if args.buildtype not in STX_BUILD_TYPES:"},{"line_number":39,"context_line":"                self.logger.error(\u0027Option \"-b|--buildtype\" for generaing \u0027 +"},{"line_number":40,"context_line":"                                  \u0027only should be %s.\u0027, STX_BUILD_TYPES)"},{"line_number":41,"context_line":"                self.logger.error(\u0027Please use \"stx build -h\" to show the help\u0027)"},{"line_number":42,"context_line":"                sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7eb0446f_2c33f569","line":39,"range":{"start_line":39,"start_character":63,"end_line":39,"end_character":73},"in_reply_to":"08ac142d_0f7c4417","updated":"2021-11-24 05:45:45.000000000","message":"Done","commit_id":"f0af3284b6c20affde267607032a6b1f483b485e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d99cc4fb367ad16440485b6af51c1251e8afc1cd","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if args.build_task !\u003d \u0027prepare\u0027 and args.build_task !\u003d \u0027cleanup\u0027:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            bashcmd \u003d \"\\\u0027find /home/${MYUNAME}/prepare-build.done \""},{"line_number":126,"context_line":"            bashcmd +\u003d \"\u0026\u003e/dev/null\\\u0027\""},{"line_number":127,"context_line":"            cmd \u003d command.generatePrefixCommand(podname, bashcmd, 0)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"07ac154b_d9f8b289","line":125,"range":{"start_line":125,"start_character":30,"end_line":125,"end_character":36},"updated":"2021-11-24 03:27:42.000000000","message":"un-related to your change, but can the home directory exist somewhere else (like /folk).","commit_id":"f0af3284b6c20affde267607032a6b1f483b485e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"da53a2e0bb1fecfd3a1e31baf1132fe85eae2b74","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if args.build_task !\u003d \u0027prepare\u0027 and args.build_task !\u003d \u0027cleanup\u0027:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            bashcmd \u003d \"\\\u0027find /home/${MYUNAME}/prepare-build.done \""},{"line_number":126,"context_line":"            bashcmd +\u003d \"\u0026\u003e/dev/null\\\u0027\""},{"line_number":127,"context_line":"            cmd \u003d command.generatePrefixCommand(podname, bashcmd, 0)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4a8d6a47_2a796135","line":125,"range":{"start_line":125,"start_character":30,"end_line":125,"end_character":36},"in_reply_to":"07ac154b_d9f8b289","updated":"2021-11-24 05:45:45.000000000","message":"The directory /home/${MYUNAME} for stx-builder container for this bash command will be created in the finishsetup.sh script which is added into bashrc file during the `minikube kubectl -- exec -l ....` command.","commit_id":"f0af3284b6c20affde267607032a6b1f483b485e"}],"stx/lib/stx/stx_main.py":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"f4b0df16787c3bb6fef2fc02acea2faab3376019","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                                     help\u003d\u0027Enable the automatical test for \\"},{"line_number":114,"context_line":"                                     the package building.\u0027,"},{"line_number":115,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"},{"line_number":116,"context_line":"        build_subparser.add_argument(\u0027-kt\u0027, \u0027--kerneltype\u0027,"},{"line_number":117,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the kernel type.\\"},{"line_number":118,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":119,"context_line":"        build_subparser.set_defaults(handle\u003dself.handlebuild.handleBuild)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d13fe573_c1f64863","line":116,"updated":"2021-11-17 15:26:52.000000000","message":"I would prefer all one char shortforms, so -k for kernel type and -t for test. Again, I will defer to Scott on this one.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"93b56dd9f5956ee9a8f77a0bad1fa6917a6e65de","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                                     help\u003d\u0027Enable the automatical test for \\"},{"line_number":114,"context_line":"                                     the package building.\u0027,"},{"line_number":115,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"},{"line_number":116,"context_line":"        build_subparser.add_argument(\u0027-kt\u0027, \u0027--kerneltype\u0027,"},{"line_number":117,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the kernel type.\\"},{"line_number":118,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":119,"context_line":"        build_subparser.set_defaults(handle\u003dself.handlebuild.handleBuild)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4eca0a04_fe091f88","line":116,"range":{"start_line":116,"start_character":37,"end_line":116,"end_character":58},"updated":"2021-11-17 15:51:27.000000000","message":"build-type, not kerneltype.  rt is more than just the kernel.  Also givers ud the option to define new types if we aren\u0027t too specific.","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                     help\u003d\u0027Enable the automatical test for \\"},{"line_number":114,"context_line":"                                     the package building.\u0027,"},{"line_number":115,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"},{"line_number":116,"context_line":"        build_subparser.add_argument(\u0027-kt\u0027, \u0027--kerneltype\u0027,"},{"line_number":117,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the kernel type.\\"},{"line_number":118,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":119,"context_line":"        build_subparser.set_defaults(handle\u003dself.handlebuild.handleBuild)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d439dc8a_7158e4cf","line":116,"range":{"start_line":116,"start_character":37,"end_line":116,"end_character":58},"in_reply_to":"4eca0a04_fe091f88","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"b749087c68f9dacb24a4a2a8742d82d0f5b7b270","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                     help\u003d\u0027Enable the automatical test for \\"},{"line_number":114,"context_line":"                                     the package building.\u0027,"},{"line_number":115,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"},{"line_number":116,"context_line":"        build_subparser.add_argument(\u0027-kt\u0027, \u0027--kerneltype\u0027,"},{"line_number":117,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the kernel type.\\"},{"line_number":118,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":119,"context_line":"        build_subparser.set_defaults(handle\u003dself.handlebuild.handleBuild)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b5ef7dff_0924882f","line":116,"in_reply_to":"d13fe573_c1f64863","updated":"2021-11-22 06:36:55.000000000","message":"Done","commit_id":"5696d46f3fcfd218a516449e167d373393ac7d48"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"7e6c5b28a66df8fef6e02b85551debef2cc0f7cd","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                     build packages, distro layer or image.\\"},{"line_number":102,"context_line":"                                     \\n\\n\u0027)"},{"line_number":103,"context_line":"        build_subparser.add_argument(\u0027-b\u0027, \u0027--buildtype\u0027,"},{"line_number":104,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the build type.\\"},{"line_number":105,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":106,"context_line":"        build_subparser.add_argument(\u0027-e\u0027, \u0027--exit_on_fail\u0027,"},{"line_number":107,"context_line":"                                     help\u003d\"Exit for any fail.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"69ee7fa5_2f89d71d","line":104,"updated":"2021-11-24 14:54:19.000000000","message":"I suggest this option is named the same way in all scripts. Right now its \"-b\" here and \"-t\" elsewhere.","commit_id":"efbbec0a586fb64be89036018efc1279db38b2fd"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"f64192a97a07fa2fd537d8b9476ff50e24249139","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                     build packages, distro layer or image.\\"},{"line_number":102,"context_line":"                                     \\n\\n\u0027)"},{"line_number":103,"context_line":"        build_subparser.add_argument(\u0027-b\u0027, \u0027--buildtype\u0027,"},{"line_number":104,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the build type.\\"},{"line_number":105,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":106,"context_line":"        build_subparser.add_argument(\u0027-e\u0027, \u0027--exit_on_fail\u0027,"},{"line_number":107,"context_line":"                                     help\u003d\"Exit for any fail.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"25141b07_b5c1bece","line":104,"in_reply_to":"69ee7fa5_2f89d71d","updated":"2021-11-25 13:01:44.000000000","message":"Done","commit_id":"efbbec0a586fb64be89036018efc1279db38b2fd"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"7e6c5b28a66df8fef6e02b85551debef2cc0f7cd","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        build_subparser.add_argument(\u0027-b\u0027, \u0027--buildtype\u0027,"},{"line_number":104,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the build type.\\"},{"line_number":105,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":106,"context_line":"        build_subparser.add_argument(\u0027-e\u0027, \u0027--exit_on_fail\u0027,"},{"line_number":107,"context_line":"                                     help\u003d\"Exit for any fail.\","},{"line_number":108,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"},{"line_number":109,"context_line":"        build_subparser.add_argument(\u0027-f\u0027, \u0027--force\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"87a3a922_7412ed62","line":106,"updated":"2021-11-24 14:54:19.000000000","message":"Please use dashes in option names, not underscores: --exit-on-fail. I think this affects other scripts too.","commit_id":"efbbec0a586fb64be89036018efc1279db38b2fd"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"f64192a97a07fa2fd537d8b9476ff50e24249139","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        build_subparser.add_argument(\u0027-b\u0027, \u0027--buildtype\u0027,"},{"line_number":104,"context_line":"                                     help\u003d\u0027[ rt|std ]: Select the build type.\\"},{"line_number":105,"context_line":"                                     \u0027, required\u003dFalse)"},{"line_number":106,"context_line":"        build_subparser.add_argument(\u0027-e\u0027, \u0027--exit_on_fail\u0027,"},{"line_number":107,"context_line":"                                     help\u003d\"Exit for any fail.\","},{"line_number":108,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"},{"line_number":109,"context_line":"        build_subparser.add_argument(\u0027-f\u0027, \u0027--force\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a23007a6_5ddbb40b","line":106,"in_reply_to":"87a3a922_7412ed62","updated":"2021-11-25 13:01:44.000000000","message":"Done","commit_id":"efbbec0a586fb64be89036018efc1279db38b2fd"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"7e6c5b28a66df8fef6e02b85551debef2cc0f7cd","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        build_subparser.add_argument(\u0027-l\u0027, \u0027--layers\u0027,"},{"line_number":113,"context_line":"                                     help\u003d\u0027[ flock|distro ]: Compile the \\"},{"line_number":114,"context_line":"                                     packages for the layer.\u0027, required\u003dFalse)"},{"line_number":115,"context_line":"        build_subparser.add_argument(\u0027-t\u0027, \u0027--enable_test\u0027,"},{"line_number":116,"context_line":"                                     help\u003d\u0027Enable the automatical test for \\"},{"line_number":117,"context_line":"                                     the package building.\u0027,"},{"line_number":118,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4b07de60_4691c031","line":115,"updated":"2021-11-24 14:54:19.000000000","message":"Please use dashes in option names, not underscores: --enable-test","commit_id":"efbbec0a586fb64be89036018efc1279db38b2fd"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"f64192a97a07fa2fd537d8b9476ff50e24249139","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        build_subparser.add_argument(\u0027-l\u0027, \u0027--layers\u0027,"},{"line_number":113,"context_line":"                                     help\u003d\u0027[ flock|distro ]: Compile the \\"},{"line_number":114,"context_line":"                                     packages for the layer.\u0027, required\u003dFalse)"},{"line_number":115,"context_line":"        build_subparser.add_argument(\u0027-t\u0027, \u0027--enable_test\u0027,"},{"line_number":116,"context_line":"                                     help\u003d\u0027Enable the automatical test for \\"},{"line_number":117,"context_line":"                                     the package building.\u0027,"},{"line_number":118,"context_line":"                                     action\u003d\u0027store_true\u0027, required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"526feb0e_3f907684","line":115,"in_reply_to":"4b07de60_4691c031","updated":"2021-11-25 13:01:44.000000000","message":"Done","commit_id":"efbbec0a586fb64be89036018efc1279db38b2fd"}]}