)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"3c21ff4c908b35a5f5dfc23a50ba6ffcc19e3c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"379a259e_4cad68b8","updated":"2022-03-14 14:09:15.000000000","message":"I usually don\u0027t agree to the \"can we just get this in I will follow up with other fixes to address the problems\". Just been burnt too many times by this, usually the right answer is do the fixes first then accept this new change in its final form.\n\nThat being said, these 6 or so additions are a drop in the bucket in this case and will allow you to continue with build system changes that are timely. So I agree let\u0027s get this merged.\n\nPlease follow through on the story to sort out the various lst files *and* include cleanup (assigned to the right person, does not have to be you). For instance the base-bullseye.lst contains entries like \u0027tasksel\u0027 which is of questionable use in STX images, and I suspect there are more.\n\n","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"90778e9663af569ea9932a330edd67cae07b087e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28466984_aeb7754f","updated":"2022-03-09 01:49:46.000000000","message":"These are to support building docker images within the build system. Shouldn\u0027t these be added as Dockerfile pkgs installs to the builder? This change will include these in the StarlingX ISO, which we don\u0027t want. Am I missing something?","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"38fb805d3b583a676e49624a8608b08961ae13d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a64ab9d9_f36f5760","in_reply_to":"28466984_aeb7754f","updated":"2022-03-09 21:18:09.000000000","message":"\u003e This change will include these in the StarlingX ISO\nWill it? I thought we only include packages from stx-std.lst file.","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"89f1205c846164222fa3f10ccf68c77b6e09a840","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b92427b_21855aa4","in_reply_to":"2e91c2f3_a805a1df","updated":"2022-03-11 17:39:44.000000000","message":"Thanks for the explanation.\n\n\u003e\u003e All the packages in the default standard ISO image \u003d base-bullseye.lst + distro/os-std.lst + distro/stx-std.lst\n\nMy question is: is every package listed in base-bullseye.lst installed in the ISO? Or just the ones pulled in as dependencies via os-std.lst \u0026 stx-std.lst ??","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"6346da3d3971becceec29830fa399148829eeae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"451c6762_05c42d2e","in_reply_to":"44dd9fe8_99165d2d","updated":"2022-03-13 16:44:05.000000000","message":"OK thanks.\n\nI think we will need to improve this. This file already contain packages that don\u0027t belong in the ISO (most -dev packages, gcc).\n\n@Bob Church, @Mark Asselstine: I propose we create a separate story to separate download lists from ISO lists.\n\nIn the meanwhile I\u0027d like to merge this patch anyway. I do need these extra packages to build container apps.","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":32562,"name":"hqbai","display_name":"Haiqing Bai","email":"haiqing.bai@windriver.com","username":"hbai"},"change_message_id":"617245e849945fe4652e024ab571c3d95778be88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"46e324a1_363b827a","in_reply_to":"451c6762_05c42d2e","updated":"2022-03-14 10:30:47.000000000","message":"Though not clear about the \u0027container apps\u0027 you want to create, is that ok for you to add the packages into \"tools/debian-mirror-tools/config/debian/containers/os-std.lst\"?  then all the required packages to be installed into the \u0027container app\u0027 are from the original base-bullseye.lst + containers/os-std.lst?  Would you need a new LAT yaml file for this \u0027container app\u0027 to define some attributes, e.g. image name.","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"7b144482193b220dc4e6029cd22a1e7e365fa43b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f2ea0fc_6e85df5f","in_reply_to":"46e324a1_363b827a","updated":"2022-03-14 14:07:23.000000000","message":"No, I don\u0027t think this would work.\n\nBob\u0027s objection is for adding _any_ packages to _any_ lists files, that are not needed in the ISO, because the lists files are used to populate the ISO. With that in mind, there\u0027s no place to specify a package that is (effectively) needed at build time, but not at runtime. I think this needs to be improved.\n\nWe don\u0027t need LAT yaml files for container apps -- they are just docker images, they just need access to apt/deb repositories (deb-local-binary, deb-local-build).","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":32562,"name":"hqbai","display_name":"Haiqing Bai","email":"haiqing.bai@windriver.com","username":"hbai"},"change_message_id":"a361d626e7f68168e6c955c9519e21f6ed88b8a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"44dd9fe8_99165d2d","in_reply_to":"7b92427b_21855aa4","updated":"2022-03-12 03:27:31.000000000","message":"Every package listed in base-bullseye.lst will be installed in the ISO. You can check the \u0027packages\u0027 field in \u0027/localdisk/deploy/lat.yaml\u0027 in builder, every package listed in base-bullseye.lst will be added into this field and installed by LAT.","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":32562,"name":"hqbai","display_name":"Haiqing Bai","email":"haiqing.bai@windriver.com","username":"hbai"},"change_message_id":"077b843cf00660c12a736d2b89bc88a3f3ce8e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e91c2f3_a805a1df","in_reply_to":"a64ab9d9_f36f5760","updated":"2022-03-11 05:50:08.000000000","message":"According with the original design, there are three types of package lists in \"tools/debian-mirror-tools//config/debian/\" directory:\n\ncommon/base-bullseye.lst: The minimal binary packages list to build the basic bullseye OS without any starlingX packages.\n\nSince we are not clear about the criteria to distinguishing these Debian packages into the STX\u0027s layers like \u0027distro\u0027,\u0027flock\u0027, it assumes the default building layer is \"distro\"(), and we just added below lists and hope them to be filled during the developing: \ndistro/os-std.lst:  All the extra binary packages which the STX packages depends on in distro layer\ndistro/stx-std.lst: All the STX packages\n\nAll the packages in the above three lists will be put into the starlingX ISO image(They will be added into the /localdisk/deploy/lat.yaml first then handled by LAT during \u0027build-image\u0027)\nIn other words,\nAll the packages in the default standard ISO image \u003d base-bullseye.lst + distro/os-std.lst + distro/stx-std.lst\n\nIn addition, any package that needs to be installed into one of the docker containers(builder, pkgbuilder, repomgr, lat) should edit the dockerfile directly, e.g.:\ntools/stx/dockerfiles/{stx-aptly.Dockerfile, stx-builder.Dockerfile , stx-lat-tool.Dockerfile, stx-pkgbuilder.Dockerfile}.\n\nBut it seems the packages you want are not belong to the above cases?  Maybe need new package lists or some modifications?  Anyhow the current \u0027base-bullseye.lst\u0027 has deviated from the original design and become bigger and bigger, I think it should be splited.","commit_id":"36ce5089b27444a89d07714ae63199b91d79e91e"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"e9d21cdc3fabdc793393bff4a8d25a9856279ddf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63d4da30_e5177e1d","updated":"2022-03-14 14:45:23.000000000","message":"I created a task for list file separation + cleanup:\n\nStory: 2008846\nTask: 44770","commit_id":"888fccc7fad040da2f0477c7ad780958cb6aab89"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"63590951a4226c506cd9c0393364fda870495a63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc802b5d_40b192e9","in_reply_to":"63d4da30_e5177e1d","updated":"2022-03-14 14:56:59.000000000","message":"Thanks Davlet. I\u0027m good with merging this for now and cleaning up later.","commit_id":"888fccc7fad040da2f0477c7ad780958cb6aab89"}]}
