)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"6f97d5bc6a7d8add380fd8ac8087a99f944d7c0b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-11-05 11:10:46 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"modified machine and removed seclabels, tested successfully on Fedora 33"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4bdf18dcf2a71fb56262b40d3440f14578b4ae03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c84df013_e12c5fae","line":8,"updated":"2022-11-09 20:05:37.000000000","message":"A commit log should preempt any questions the reviewer might have while also documenting other reasons for the change.\n\nMy main question is why you selected \u0027pc-i440fx-2.1\u0027 in some instances and \u0027pc-q35-6.2\u0027 in others. Unless you have a good reason the q35 provides some slight benefits, such as PCIe and reportedly less host CPU utilization under normal loads, so should be used for all the \u0027machine\u0027 changes here.\n\nOtherwise the change looks fine once the other comments are addressed. Thanks.","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"dd017e602392cd351abd27aeb8f71546f750ae5e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-11-05 11:10:46 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"modified machine and removed seclabels, tested successfully on Fedora 33"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4bdf18dcf2a71fb56262b40d3440f14578b4ae03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0e88357f_5414edae","line":8,"updated":"2022-11-09 16:02:25.000000000","message":"Hi, please describe why each of the two changes is needed.","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":35344,"name":"Scott Kamp","display_name":"Scott Kamp","email":"scott.kamp@optimcloud.com","username":"OutBackDingo"},"change_message_id":"09263ff8aa6a4e5c408279775b5152f9456714e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-11-05 11:10:46 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"modified machine and removed seclabels, tested successfully on Fedora 33"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4bdf18dcf2a71fb56262b40d3440f14578b4ae03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5d708aab_8453d9e6","line":8,"in_reply_to":"0e88357f_5414edae","updated":"2023-01-15 13:59:06.000000000","message":"seclabels didnt in fact work on Fedora, the pc-q35-6.2 does in fact work","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":35344,"name":"Scott Kamp","display_name":"Scott Kamp","email":"scott.kamp@optimcloud.com","username":"OutBackDingo"},"change_message_id":"09263ff8aa6a4e5c408279775b5152f9456714e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-11-05 11:10:46 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"modified machine and removed seclabels, tested successfully on Fedora 33"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4bdf18dcf2a71fb56262b40d3440f14578b4ae03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"882296ae_f7af0242","line":8,"in_reply_to":"c84df013_e12c5fae","updated":"2023-01-15 13:59:06.000000000","message":"dumpxml where we changed to pc-q35-6.2 does also in fact work","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"cbc6136d6fbef01bddc2f9e3cbe080f39ac7aabc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95d3d5bb_b7705ab8","line":10,"updated":"2022-11-09 16:06:46.000000000","message":"Remember to add your Signed-off-by line","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"2670f6bf7dbe2c6012478490026ddc5079be16df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4e5d9d4_8e7889fa","line":10,"in_reply_to":"95d3d5bb_b7705ab8","updated":"2022-11-09 18:28:34.000000000","message":"When I run \u0027virsh dumpxml  simplex-controller-0\u0027 and compare that with the template controller_allinone.xml I can see that virsh is ignoring those entries anyway.\n\nIf the template values are causing issues on fedora I would prefer to remove them from the template:\n\n  --- a/deployment/libvirt/controller_allinone.xml\n  +++ b/deployment/libvirt/controller_allinone.xml\n  @@ -7,7 +7,7 @@\n       \u003cpartition\u003e/machine\u003c/partition\u003e\n     \u003c/resource\u003e\n     \u003cos\u003e\n  -    \u003ctype arch\u003d\u0027x86_64\u0027 machine\u003d\u0027pc-q35-xenial\u0027\u003ehvm\u003c/type\u003e\n  +    \u003ctype\u003ehvm\u003c/type\u003e\n     \u003c/os\u003e\n     \u003cfeatures\u003e\n       \u003cacpi/\u003e\n  @@ -101,9 +101,5 @@\n         \u003calias name\u003d\u0027balloon0\u0027/\u003e\n       \u003c/memballoon\u003e\n     \u003c/devices\u003e\n  -  \u003cseclabel type\u003d\u0027dynamic\u0027 model\u003d\u0027apparmor\u0027 relabel\u003d\u0027yes\u0027\u003e\n  -    \u003clabel\u003elibvirt-6afab2ba-0ed0-45cb-b1bd-985e211a48de\u003c/label\u003e\n  -    \u003cimagelabel\u003elibvirt-6afab2ba-0ed0-45cb-b1bd-985e211a48de\u003c/imagelabel\u003e\n  -  \u003c/seclabel\u003e\n   \u003c/domain\u003e\n\n\nIf you apply that removal and send me the dumpxml result for your controller I\u0027ll compare to see what other interesting things get configured for fedora.\n\nSend to michel.thebeau@windriver.com","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"0dc08859caaf663bfb33f4ebca343983caeafe09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70f6cea0_a94b35c0","line":10,"in_reply_to":"b5d82469_7e9a57b6","updated":"2023-01-17 15:33:40.000000000","message":"Ack, I\u0027ll take a look this week.","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":35344,"name":"Scott Kamp","display_name":"Scott Kamp","email":"scott.kamp@optimcloud.com","username":"OutBackDingo"},"change_message_id":"09263ff8aa6a4e5c408279775b5152f9456714e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5d82469_7e9a57b6","line":10,"in_reply_to":"d4e5d9d4_8e7889fa","updated":"2023-01-15 13:59:06.000000000","message":"\u003cdomain type\u003d\u0027kvm\u0027 id\u003d\u00272\u0027\u003e\n  \u003cname\u003eduplex-madcloud-0\u003c/name\u003e\n  \u003cuuid\u003e9757cd6e-2082-4591-9af5-bcf6fb1d4891\u003c/uuid\u003e\n  \u003cmemory unit\u003d\u0027KiB\u0027\u003e18874368\u003c/memory\u003e\n  \u003ccurrentMemory unit\u003d\u0027KiB\u0027\u003e18874368\u003c/currentMemory\u003e\n  \u003cvcpu placement\u003d\u0027static\u0027\u003e6\u003c/vcpu\u003e\n  \u003cresource\u003e\n    \u003cpartition\u003e/machine\u003c/partition\u003e\n  \u003c/resource\u003e\n  \u003cos\u003e\n    \u003ctype arch\u003d\u0027x86_64\u0027 machine\u003d\u0027pc-q35-6.2\u0027\u003ehvm\u003c/type\u003e\n  \u003c/os\u003e\n  \u003cfeatures\u003e\n    \u003cacpi/\u003e\n    \u003capic/\u003e\n    \u003cpae/\u003e\n  \u003c/features\u003e\n  \u003ccpu mode\u003d\u0027custom\u0027 match\u003d\u0027exact\u0027 check\u003d\u0027full\u0027\u003e\n    \u003cmodel fallback\u003d\u0027forbid\u0027\u003eNehalem\u003c/model\u003e\n    \u003ctopology sockets\u003d\u00271\u0027 dies\u003d\u00271\u0027 cores\u003d\u00276\u0027 threads\u003d\u00271\u0027/\u003e\n    \u003cfeature policy\u003d\u0027require\u0027 name\u003d\u0027vmx\u0027/\u003e\n    \u003cfeature policy\u003d\u0027disable\u0027 name\u003d\u0027svm\u0027/\u003e\n    \u003cfeature policy\u003d\u0027require\u0027 name\u003d\u0027vme\u0027/\u003e\n    \u003cfeature policy\u003d\u0027require\u0027 name\u003d\u0027x2apic\u0027/\u003e\n    \u003cfeature policy\u003d\u0027require\u0027 name\u003d\u0027hypervisor\u0027/\u003e\n  \u003c/cpu\u003e\n  \u003cclock offset\u003d\u0027utc\u0027/\u003e\n  \u003con_poweroff\u003edestroy\u003c/on_poweroff\u003e\n  \u003con_reboot\u003erestart\u003c/on_reboot\u003e\n  \u003con_crash\u003edestroy\u003c/on_crash\u003e\n  \u003cdevices\u003e\n    \u003cemulator\u003e/usr/bin/qemu-system-x86_64\u003c/emulator\u003e\n    \u003cdisk type\u003d\u0027file\u0027 device\u003d\u0027disk\u0027\u003e\n      \u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027qcow2\u0027/\u003e\n      \u003csource file\u003d\u0027/var/lib/libvirt/images/duplex-madcloud-0-0.img\u0027 index\u003d\u00274\u0027/\u003e\n      \u003cbackingStore/\u003e\n      \u003ctarget dev\u003d\u0027sda\u0027 bus\u003d\u0027sata\u0027/\u003e\n      \u003cboot order\u003d\u00271\u0027/\u003e\n      \u003calias name\u003d\u0027sata0-0-0\u0027/\u003e\n      \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e\n    \u003c/disk\u003e\n    \u003cdisk type\u003d\u0027file\u0027 device\u003d\u0027disk\u0027\u003e\n      \u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027qcow2\u0027/\u003e\n      \u003csource file\u003d\u0027/var/lib/libvirt/images/duplex-madcloud-0-1.img\u0027 index\u003d\u00273\u0027/\u003e\n      \u003cbackingStore/\u003e\n      \u003ctarget dev\u003d\u0027sdb\u0027 bus\u003d\u0027sata\u0027/\u003e\n      \u003calias name\u003d\u0027sata0-0-1\u0027/\u003e\n      \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00271\u0027/\u003e\n    \u003c/disk\u003e\n    \u003cdisk type\u003d\u0027file\u0027 device\u003d\u0027disk\u0027\u003e\n      \u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027qcow2\u0027/\u003e\n      \u003csource file\u003d\u0027/var/lib/libvirt/images/duplex-madcloud-0-2.img\u0027 index\u003d\u00272\u0027/\u003e\n      \u003cbackingStore/\u003e\n      \u003ctarget dev\u003d\u0027sdc\u0027 bus\u003d\u0027sata\u0027/\u003e\n      \u003calias name\u003d\u0027sata0-0-2\u0027/\u003e\n      \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00272\u0027/\u003e\n    \u003c/disk\u003e\n    \u003cdisk type\u003d\u0027file\u0027 device\u003d\u0027cdrom\u0027\u003e\n      \u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027raw\u0027/\u003e\n      \u003csource file\u003d\u0027/home/dingo/Downloads/starlingx-intel-x86-64-cd.iso\u0027 index\u003d\u00271\u0027/\u003e\n      \u003cbackingStore/\u003e\n      \u003ctarget dev\u003d\u0027sdd\u0027 bus\u003d\u0027sata\u0027 tray\u003d\u0027open\u0027/\u003e\n      \u003creadonly/\u003e\n      \u003cboot order\u003d\u00272\u0027/\u003e\n      \u003calias name\u003d\u0027sata0-0-3\u0027/\u003e\n      \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00273\u0027/\u003e\n    \u003c/disk\u003e\n    \u003ccontroller type\u003d\u0027usb\u0027 index\u003d\u00270\u0027 model\u003d\u0027qemu-xhci\u0027\u003e\n      \u003calias name\u003d\u0027usb\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x05\u0027 slot\u003d\u00270x00\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027sata\u0027 index\u003d\u00270\u0027\u003e\n      \u003calias name\u003d\u0027ide\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x1f\u0027 function\u003d\u00270x2\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00270\u0027 model\u003d\u0027pcie-root\u0027\u003e\n      \u003calias name\u003d\u0027pcie.0\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00271\u0027 model\u003d\u0027pcie-root-port\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-root-port\u0027/\u003e\n      \u003ctarget chassis\u003d\u00271\u0027 port\u003d\u00270x10\u0027/\u003e\n      \u003calias name\u003d\u0027pci.1\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x0\u0027 multifunction\u003d\u0027on\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00272\u0027 model\u003d\u0027pcie-to-pci-bridge\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-pci-bridge\u0027/\u003e\n      \u003calias name\u003d\u0027pci.2\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x01\u0027 slot\u003d\u00270x00\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00273\u0027 model\u003d\u0027pcie-root-port\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-root-port\u0027/\u003e\n      \u003ctarget chassis\u003d\u00273\u0027 port\u003d\u00270x11\u0027/\u003e\n      \u003calias name\u003d\u0027pci.3\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x1\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00274\u0027 model\u003d\u0027pcie-root-port\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-root-port\u0027/\u003e\n      \u003ctarget chassis\u003d\u00274\u0027 port\u003d\u00270x12\u0027/\u003e\n      \u003calias name\u003d\u0027pci.4\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x2\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00275\u0027 model\u003d\u0027pcie-root-port\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-root-port\u0027/\u003e\n      \u003ctarget chassis\u003d\u00275\u0027 port\u003d\u00270x13\u0027/\u003e\n      \u003calias name\u003d\u0027pci.5\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x3\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00276\u0027 model\u003d\u0027pcie-root-port\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-root-port\u0027/\u003e\n      \u003ctarget chassis\u003d\u00276\u0027 port\u003d\u00270x14\u0027/\u003e\n      \u003calias name\u003d\u0027pci.6\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x4\u0027/\u003e\n    \u003c/controller\u003e\n    \u003ccontroller type\u003d\u0027pci\u0027 index\u003d\u00277\u0027 model\u003d\u0027pcie-root-port\u0027\u003e\n      \u003cmodel name\u003d\u0027pcie-root-port\u0027/\u003e\n      \u003ctarget chassis\u003d\u00277\u0027 port\u003d\u00270x15\u0027/\u003e\n      \u003calias name\u003d\u0027pci.7\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x5\u0027/\u003e\n    \u003c/controller\u003e\n    \u003cinterface type\u003d\u0027network\u0027\u003e\n      \u003cmac address\u003d\u002752:54:00:ec:b7:0f\u0027/\u003e\n      \u003csource network\u003d\u0027madbr1\u0027 portid\u003d\u00278343a5a3-7278-4e2c-87f4-14fad76e86a2\u0027 bridge\u003d\u0027virbr1\u0027/\u003e\n      \u003ctarget dev\u003d\u0027vnet1\u0027/\u003e\n      \u003cmodel type\u003d\u0027e1000\u0027/\u003e\n      \u003calias name\u003d\u0027net0\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x02\u0027 slot\u003d\u00270x01\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/interface\u003e\n    \u003cinterface type\u003d\u0027network\u0027\u003e\n      \u003cmac address\u003d\u002752:54:00:f1:0f:db\u0027/\u003e\n      \u003csource network\u003d\u0027madbr2\u0027 portid\u003d\u002737566695-bd6c-484d-9f36-75bca83bf556\u0027 bridge\u003d\u0027virbr2\u0027/\u003e\n      \u003ctarget dev\u003d\u0027vnet2\u0027/\u003e\n      \u003cmodel type\u003d\u0027e1000\u0027/\u003e\n      \u003cboot order\u003d\u00273\u0027/\u003e\n      \u003calias name\u003d\u0027net1\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x02\u0027 slot\u003d\u00270x02\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/interface\u003e\n    \u003cinterface type\u003d\u0027network\u0027\u003e\n      \u003cmac address\u003d\u002752:54:00:ff:ed:37\u0027/\u003e\n      \u003csource network\u003d\u0027madbr3\u0027 portid\u003d\u002728f50cb3-cdff-4c26-9cf6-74d226f3d742\u0027 bridge\u003d\u0027virbr3\u0027/\u003e\n      \u003ctarget dev\u003d\u0027vnet3\u0027/\u003e\n      \u003cmodel type\u003d\u0027virtio\u0027/\u003e\n      \u003calias name\u003d\u0027net2\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x03\u0027 slot\u003d\u00270x00\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/interface\u003e\n    \u003cinterface type\u003d\u0027network\u0027\u003e\n      \u003cmac address\u003d\u002752:54:00:36:d6:3a\u0027/\u003e\n      \u003csource network\u003d\u0027madbr4\u0027 portid\u003d\u0027daa54662-f0a3-47c2-a3f6-b0dc0bd64c97\u0027 bridge\u003d\u0027virbr4\u0027/\u003e\n      \u003ctarget dev\u003d\u0027vnet4\u0027/\u003e\n      \u003cmodel type\u003d\u0027virtio\u0027/\u003e\n      \u003calias name\u003d\u0027net3\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x04\u0027 slot\u003d\u00270x00\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/interface\u003e\n    \u003cserial type\u003d\u0027pty\u0027\u003e\n      \u003csource path\u003d\u0027/dev/pts/5\u0027/\u003e\n      \u003ctarget type\u003d\u0027isa-serial\u0027 port\u003d\u00270\u0027\u003e\n        \u003cmodel name\u003d\u0027isa-serial\u0027/\u003e\n      \u003c/target\u003e\n      \u003calias name\u003d\u0027serial0\u0027/\u003e\n    \u003c/serial\u003e\n    \u003cconsole type\u003d\u0027pty\u0027 tty\u003d\u0027/dev/pts/5\u0027\u003e\n      \u003csource path\u003d\u0027/dev/pts/5\u0027/\u003e\n      \u003ctarget type\u003d\u0027serial\u0027 port\u003d\u00270\u0027/\u003e\n      \u003calias name\u003d\u0027serial0\u0027/\u003e\n    \u003c/console\u003e\n    \u003cinput type\u003d\u0027mouse\u0027 bus\u003d\u0027ps2\u0027\u003e\n      \u003calias name\u003d\u0027input0\u0027/\u003e\n    \u003c/input\u003e\n    \u003cinput type\u003d\u0027keyboard\u0027 bus\u003d\u0027ps2\u0027\u003e\n      \u003calias name\u003d\u0027input1\u0027/\u003e\n    \u003c/input\u003e\n    \u003cgraphics type\u003d\u0027vnc\u0027 port\u003d\u00275901\u0027 autoport\u003d\u0027yes\u0027 listen\u003d\u0027127.0.0.1\u0027 keymap\u003d\u0027en-us\u0027\u003e\n      \u003clisten type\u003d\u0027address\u0027 address\u003d\u0027127.0.0.1\u0027/\u003e\n    \u003c/graphics\u003e\n    \u003caudio id\u003d\u00271\u0027 type\u003d\u0027none\u0027/\u003e\n    \u003cvideo\u003e\n      \u003cmodel type\u003d\u0027cirrus\u0027 vram\u003d\u002716384\u0027 heads\u003d\u00271\u0027 primary\u003d\u0027yes\u0027/\u003e\n      \u003calias name\u003d\u0027video0\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x01\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/video\u003e\n    \u003cmemballoon model\u003d\u0027virtio\u0027\u003e\n      \u003calias name\u003d\u0027balloon0\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x06\u0027 slot\u003d\u00270x00\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/memballoon\u003e\n  \u003c/devices\u003e\n  \u003cseclabel type\u003d\u0027dynamic\u0027 model\u003d\u0027dac\u0027 relabel\u003d\u0027yes\u0027\u003e\n    \u003clabel\u003e+107:+107\u003c/label\u003e\n    \u003cimagelabel\u003e+107:+107\u003c/imagelabel\u003e\n  \u003c/seclabel\u003e\n\u003c/domain\u003e","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"ff620d7604e4060b046b383107b24d2d9086a329","unresolved":true,"context_lines":[{"line_number":7,"context_line":"libvirt deployment: remove machine and seclabel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The template is generated from a running virtual machine on Ubuntu.  The"},{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"76b606b4_6d27d3ce","line":10,"updated":"2023-05-31 15:25:42.000000000","message":"RE the \u0027machine\u0027 attribute. This should actually be a clue to this change not being as innocuous as is made out to be here. From the libvirt documentation \"If not specified libvirt attempts to pick a suitable default.\" (https://wiki.libvirt.org/QEMUSwitchToLibvirt.html). By including the machine attribute you are ensuring that the VM will behave the same across difference host OSes and hardware, as the default can vary from one system to another.\n\nA better approach would be to leave the \u0027machine\u0027 attribute in place and find a value which will work on all expected systems. Ideally documenting how to handle a case that does fail.\n\nIf you want to go the approach you describe here you need to include links to the documentation and describe clearly that a default will be selected which might result in different behavior of the VM in order for this commit log to be complete.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"c5e8f1697f85bc1b6a24d59de29aee8d53828b4a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"libvirt deployment: remove machine and seclabel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The template is generated from a running virtual machine on Ubuntu.  The"},{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa8857a6_2385c012","line":10,"in_reply_to":"76b606b4_6d27d3ce","updated":"2023-06-07 15:05:10.000000000","message":"Hi Mark, Thank-you for reminding that we want a configuration that presents a consistent hardware platform for starlingx to run on.\n\nI anticipate that I will have an opportunity to revisit this question within a week or two.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"77e71f9ddd18a82f8e264069ae46f831c4b0fa0a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"libvirt deployment: remove machine and seclabel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The template is generated from a running virtual machine on Ubuntu.  The"},{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d0eed51e_46f818cc","line":10,"in_reply_to":"fa8857a6_2385c012","updated":"2023-06-07 21:37:17.000000000","message":"I can use \u0027pc-q35-4.2\u0027 today. I might consider q35 which is an alias to whatever the latest is (Scott mentions pc-q35-6.2 which I do not ahve). There was no change in xml dump for pc-q35-xenial to pc-q35-4.2 (uuid and mac addresses only).  I reviewed the subject of i440fx and I do recall that q35 was selected for the newer architecture (PCI-e for example).  So I do not want to return to i440fx.  There are device twiddles for the xml dump when i440fx is used:\n\n    drops pcie\n    omits cpu feature vme\n    usb controller (qemu-xhci -\u003e piix3-uhci)","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"ff620d7604e4060b046b383107b24d2d9086a329","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The template is generated from a running virtual machine on Ubuntu.  The"},{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS: standard cluster with dedicated storage 2+2+1 on Ubuntu host"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"32cc7dd9_dee4420b","line":12,"updated":"2023-05-31 15:25:42.000000000","message":"I have evidence to the contrary, a VM with\n\nmachine\u003d\u0027pc-q35-4.2\u0027\n\nand in the resulting QEMU command line\n\n-machine pc-q35-4.2\n\nHow are you able to show that Ubuntu ignores this?","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"c5e8f1697f85bc1b6a24d59de29aee8d53828b4a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The template is generated from a running virtual machine on Ubuntu.  The"},{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS: standard cluster with dedicated storage 2+2+1 on Ubuntu host"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"59a54738_b4e4b989","line":12,"in_reply_to":"32cc7dd9_dee4420b","updated":"2023-06-07 15:05:10.000000000","message":"I can double check.  I had observed the running vm\u0027s xml dump versus the template.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"77e71f9ddd18a82f8e264069ae46f831c4b0fa0a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The template is generated from a running virtual machine on Ubuntu.  The"},{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS: standard cluster with dedicated storage 2+2+1 on Ubuntu host"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4b91e507_d056332e","line":12,"in_reply_to":"59a54738_b4e4b989","updated":"2023-06-07 21:37:17.000000000","message":"ack.  Not sure.  I can use pc-i440fx-2.1 today for example.  I\u0027ll omit that from log.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"ff620d7604e4060b046b383107b24d2d9086a329","unresolved":true,"context_lines":[{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS: standard cluster with dedicated storage 2+2+1 on Ubuntu host"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a4b7934e_40d9574a","line":13,"updated":"2023-05-31 15:25:42.000000000","message":"Regarding \u0027seclabel\u0027 providing a link to the related documentation would assist any readers of this commit log understand what it does and the implication of removing it\n\nhttps://libvirt.org/formatdomain.html#security-label\n\nWhat is the difference between dropping this vs. setting it to \u0027none\u0027? If you load a libvirt XML without seclabel and then do a \u0027virsh dumpxml\u0027 does it still insert a seclabel section? Similar to the \u0027machine\u0027 attribute we have to be careful with libvirt assigning a default in the absence of a value, in this case it might be better to include seclabel and set it to \u0027none\u0027 to force consistency and avoid a surprise default.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"77e71f9ddd18a82f8e264069ae46f831c4b0fa0a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS: standard cluster with dedicated storage 2+2+1 on Ubuntu host"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"85b88bfa_c091a373","line":13,"in_reply_to":"94c38299_95177847","updated":"2023-06-07 21:37:17.000000000","message":"none is kept for seclabel model apparmor.  This did not affect the Starlingx procedure for simplex on ubuntu running apparmor.  We could consider doing the same for seclabel model selinux - but I\u0027m not prepared to test that, so I would omit it.\n\nI think should let libvirt do what it wants with model dac, since it is specifying file permissions.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"c5e8f1697f85bc1b6a24d59de29aee8d53828b4a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"machine and seclabel values do not work on Fedora for example."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It is observed they are ignored anyway on Ubuntu.  Remove the values."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS: standard cluster with dedicated storage 2+2+1 on Ubuntu host"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"94c38299_95177847","line":13,"in_reply_to":"a4b7934e_40d9574a","updated":"2023-06-07 15:05:10.000000000","message":"Setting it to none is an interesting observation. I\u0027ll consider then when I get to look at this again.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"61127ea2c0db0fef22ca04f2850c6bae0ceddaff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e00ad83b_a62bff6f","updated":"2022-12-01 16:56:47.000000000","message":"Scott Kamp: could you address reviewers\u0027 comments?","commit_id":"01359e8e3936bbad970a58c5dac977086b4b9489"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"f4bfb01db386837aa87a9c2e6407ba825dac9554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"879dacd8_35635145","updated":"2023-01-18 19:31:51.000000000","message":"Hi Scott.  Please consider this change instead, and if it works for you on Fedora, add your signed-off-by for the benefit of Fedora users.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"e76102242d2658e872d746b592737dfd70d7baac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e88f6364_f758378a","updated":"2023-06-29 14:06:26.000000000","message":"Please abandon or move this review to starlingx/virtual-deployement:\nhttps://review.opendev.org/admin/repos/starlingx/virtual-deployment","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"97cc379127402bc32aa5fc58faf4fe4afdc893d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c80f6886_5c37bc29","in_reply_to":"e88f6364_f758378a","updated":"2023-06-30 13:50:38.000000000","message":"Oh, I have permission to abandon this now.","commit_id":"2b7754de016be98af25b6dd7193f74b9da2e0aa4"}]}