)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"0a555e18635205c5e56dde5efb2ed714d3eb499a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84af5ac3_c9db4f88","updated":"2023-02-09 13:18:56.000000000","message":"Hi, Bailey, Scott and Davlet\nPlease help to review+2.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"bd81711f210e8efb593cf22545109128bf799996","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07ceae31_562783ff","updated":"2023-02-07 13:59:19.000000000","message":"Is there a use-case which requires the drivers to be updated in the initramfs? Recall we are trying to limit the occasions we are updating the initramfs since it is a significant cost to storage. This should only be done if the drivers are required to boot the system, otherwise the drivers should only be updated in the rootfs.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"0a40bc9c1507108c337f9fd694c33048652191c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1bcb477f_ebca979d","updated":"2023-02-09 02:45:37.000000000","message":"Thank Vefa to explain.  yes it is correct because ostree rootfs is read-only, we can not use depmod to switch drivers.  So we must switch it in initramfs.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"b322d884141e7247c8c911fc4bccc70d995737e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d10da4a9_c621e1b1","updated":"2023-02-08 19:59:59.000000000","message":"Thanks to Vefa for answering the question.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"731cb19e9744c9c91e93bf7a1e571d206289f6bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4573623_7671ff7c","in_reply_to":"07bae90e_8e802fe6","updated":"2023-02-08 01:11:17.000000000","message":"Sorry, that caused the confuse. That means repo ostree/initramfs-ostree will not need further modification for new/different driver package releases that are integrated into StarlingX in the future.\ndrivers must be added to initramfs to support multi-drivers.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"1770469b5100a1d8d735a793396f2080de0e2351","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a892bed1_ea05ebdd","in_reply_to":"07ceae31_562783ff","updated":"2023-02-07 18:18:54.000000000","message":"I have the same question, why do nic drivers have to be in initramfs at all?  I can understand having the initramfs hosting disk drivers so that the root disk can get mounted, but shouldn\u0027t the nic drivers then be subsequently loaded from the root disk?  Am I missing something?","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"6a2b36654d89e416cf914083ce06425473d8bb6e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9bf1926_483e9938","in_reply_to":"246956f4_4e2138b1","updated":"2023-02-08 15:45:03.000000000","message":"Hi Mark and Jim,\n\nIf my recollection is correct, there is some history behind the decision to have the NIC driver version switch logic in the initramfs for Debian-based StarlingX.\n\nJiping, correct me if I am wrong, but I think it had to do with the inability to modify the root file system (due to ostree) to persistently add a /etc/depmod.d/... file to be able to change the precedence/priority of different ice/iavf/i40e bundle versions, so that the desired version would be used with every reboot.\n\n(I can attempt to find an internal bug report reference to support this. Let me try that; I may or may not be right.)\n\nIn CentOS-based StarlingX, the depmod.d approach was at least initially taken with small/minimal impact on the initramfs, whereas with Debian-based StarlingX, the initramfs-based approach *had* to be taken.\n\nNow, this is what I remember, but I wish Jiping had explained this in detail.\n\nThank you,\n\nVefa","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"8983cb137ee6035b6e3a5e7f5e40edd3610708b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07bae90e_8e802fe6","in_reply_to":"465346f3_9a12131b","updated":"2023-02-08 01:05:49.000000000","message":"From the commit log in the review \"This way, the initramfs will not need further modifications for new/different driver package releases that are integrated into StarlingX in the future.\"\n\nSo am I missing something? The initramfs should *only* be updated if it needs modifications to gain access to the rootfs. This will not mean that it never gets updated, but it will be rare.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"b1fc71e0e0dfc29ad62ef35ee7cc821ea8c1d120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"112bef56_a1f6c9a6","in_reply_to":"a19097ef_8610badc","updated":"2023-02-08 16:24:25.000000000","message":"OK. Based on the additional information provided by Vefa pointing at the limitations of driver selection given a read-only rootfs due to Ostree we can mark this line of comments as resolved. Obviously there are competing requirements which force our hand, the biggest and original problem in my mind being the need to support multiple driver versions. The size impact is only somewhat in our control and if size becomes a bigger priority than driver versions, then we can revisit this, but until then it is what it is.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"1e773bb558b2cfd704490fe9c0430b1662599d4d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"465346f3_9a12131b","in_reply_to":"a892bed1_ea05ebdd","updated":"2023-02-08 00:36:48.000000000","message":"We switch the different drivers in initramfs.  so we need put them to initramfs.\nPlease refer https://review.opendev.org/c/starlingx/integ/+/863204","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"b32a5d6c7b17ac58818d6bb50b22a0ccec9f5254","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a19097ef_8610badc","in_reply_to":"b9bf1926_483e9938","updated":"2023-02-08 15:47:47.000000000","message":"Okay, I was close. The limitation was as follows:\n\nAfter creating a file in /etc/depmod.d/... to be able to select a specific version of ice/iavf/i40e, one has to run \"depmod\", which naturally needs to write to /lib/modules/\u003ckver\u003e/... This is not possible with ostree, as the root file system is read-only. This is why the initramfs approach was taken.\n\nI will send the internal bug report to the participants of this code review.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"206a324d2f311a6e2b32a68af99e649642f3b3c4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"246956f4_4e2138b1","in_reply_to":"f4573623_7671ff7c","updated":"2023-02-08 02:09:31.000000000","message":"I don\u0027t know what to say, that text is completely misleading. This will need to be corrected as we need the initramfs to rarely be updated as it has a large size cost for the ostree commit. The only drivers that should be in the initramfs are those required to load and pivot to the rootfs, this did require some network drivers to enable network install via redfish but the multidriver should be relegated to after the pivot to the init on the rootfs and thus reside in the rootfs, not the initramfs.","commit_id":"29c24db3fb8bfe4d79a6aeaa11303a43c356f36b"}]}