)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"84ab8d3850354c845b97b8ddc39c7049bb0e6666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cfab8048_43361258","updated":"2023-05-02 17:02:06.000000000","message":"I suggested a small change and another that might not be as small but also shouldn\u0027t be too big.","commit_id":"7492de073c4f3732572d4be412c40321f1f1943c"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"cd1c8279af9fc3a7c0fd234ae224222fbeb68ed0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fda1e513_f56a4335","updated":"2023-05-09 01:07:36.000000000","message":"I think we can add core reviewers here. I noticed that there\u0027s a group called `starlingx-tools-core`. I think you can add the group and it should take care of adding the relevant people here.","commit_id":"8cd94bc362c83950a4332c7c3bbfa3edd04d8206"},{"author":{"_account_id":35920,"name":"dcaires","display_name":"Daniel Caires","email":"daniel.caires@encora.com","username":"Daniel.Caires"},"change_message_id":"4ae7420388b9e6f511ecea26cd8b21d00864709d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a3b93133_bd5e7755","in_reply_to":"fda1e513_f56a4335","updated":"2023-05-10 11:56:08.000000000","message":"Done","commit_id":"8cd94bc362c83950a4332c7c3bbfa3edd04d8206"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"b2ba3b26535c68084145c3e5f67439b33437b2b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa3b2cb2_1f2f7d49","updated":"2023-05-23 13:42:17.000000000","message":"Missing Test Plan","commit_id":"166ee1cc4c5ee929746ba8012945cfbd13ffa471"}],"deployment/virtualbox/pybox/Parser.py":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"84ab8d3850354c845b97b8ddc39c7049bb0e6666","unresolved":true,"context_lines":[{"line_number":399,"context_line":"                        \"\"\""},{"line_number":400,"context_line":"                        Type of start of the VMs, either headless or gui."},{"line_number":401,"context_line":"                        gui is default"},{"line_number":402,"context_line":"                        \"\"\","},{"line_number":403,"context_line":"                        choices\u003d[\u0027headless\u0027, \u0027gui\u0027],"},{"line_number":404,"context_line":"                        type\u003dstr,"},{"line_number":405,"context_line":"                        default\u003d\u0027gui\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"76767d6c_a900d64a","line":402,"updated":"2023-05-02 17:02:06.000000000","message":"Maybe instead of setting the parameter plus the desired value it would be easier if the parameter was called `--headless`. \n\nPassing `--headless` (without the need to pass either `gui` or `headless` as the value for the parameter) would then instruct the script to set the `vboxmanage` to use `--type headless`. Not passing anything would use `--type gui` when invoking `vboxmanage` commands.\n\nThen the help text of `--headless` could be something like: \"Instructs VirtualBox to start virtual machines without a graphical user interface (GUI). Especially useful in non-GUI systems\". Avoid abbreviations in these help messages, it helps users to quickly understand the problems they might be having.","commit_id":"7492de073c4f3732572d4be412c40321f1f1943c"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"110be8d19bd5a86a227567d28bea582f6bbc0b10","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                        \"\"\""},{"line_number":400,"context_line":"                        Type of start of the VMs, either headless or gui."},{"line_number":401,"context_line":"                        gui is default"},{"line_number":402,"context_line":"                        \"\"\","},{"line_number":403,"context_line":"                        choices\u003d[\u0027headless\u0027, \u0027gui\u0027],"},{"line_number":404,"context_line":"                        type\u003dstr,"},{"line_number":405,"context_line":"                        default\u003d\u0027gui\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ae7342b_11b8d064","line":402,"in_reply_to":"76767d6c_a900d64a","updated":"2023-05-02 18:03:07.000000000","message":"Done","commit_id":"7492de073c4f3732572d4be412c40321f1f1943c"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"9286a5116c8ccf26cfbb5f2b992e0105d8b47275","unresolved":true,"context_lines":[{"line_number":398,"context_line":"    parser.add_argument(\"--headless\", help\u003d"},{"line_number":399,"context_line":"                        \"\"\""},{"line_number":400,"context_line":"                        Instructs VirtualBox to start virtual machines "},{"line_number":401,"context_line":"                        without a graphical user interface (GUI). "},{"line_number":402,"context_line":"                        Especially useful in non-GUI systems"},{"line_number":403,"context_line":"                        \"\"\","},{"line_number":404,"context_line":"                        action\u003d\u0027store_true\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"39cf6dfc_950a0393","line":401,"range":{"start_line":401,"start_character":65,"end_line":401,"end_character":66},"updated":"2023-05-31 12:56:13.000000000","message":"nit: EOLs","commit_id":"166ee1cc4c5ee929746ba8012945cfbd13ffa471"},{"author":{"_account_id":35920,"name":"dcaires","display_name":"Daniel Caires","email":"daniel.caires@encora.com","username":"Daniel.Caires"},"change_message_id":"1564ef89a82b04048ac9e0fa2c20a4889a253d35","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    parser.add_argument(\"--headless\", help\u003d"},{"line_number":399,"context_line":"                        \"\"\""},{"line_number":400,"context_line":"                        Instructs VirtualBox to start virtual machines "},{"line_number":401,"context_line":"                        without a graphical user interface (GUI). "},{"line_number":402,"context_line":"                        Especially useful in non-GUI systems"},{"line_number":403,"context_line":"                        \"\"\","},{"line_number":404,"context_line":"                        action\u003d\u0027store_true\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0198956c_00c30b1e","line":401,"range":{"start_line":401,"start_character":65,"end_line":401,"end_character":66},"in_reply_to":"39cf6dfc_950a0393","updated":"2023-06-06 16:40:58.000000000","message":"Ack","commit_id":"166ee1cc4c5ee929746ba8012945cfbd13ffa471"}],"deployment/virtualbox/pybox/helper/vboxmanage.py":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"12ca4b48509cd9010033bd2a6603ed54d9ae6387","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    time.sleep(5)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def vboxmanage_startvm(hostname\u003dNone, type_bool\u003dFalse, force\u003dFalse):"},{"line_number":416,"context_line":"    \"\"\""},{"line_number":417,"context_line":"    This allows you to power on a VM."},{"line_number":418,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"e00401b8_5d897932","line":415,"updated":"2023-05-03 19:25:25.000000000","message":"I would prefer not to include the type in the name of the variable.","commit_id":"8cd94bc362c83950a4332c7c3bbfa3edd04d8206"},{"author":{"_account_id":35920,"name":"dcaires","display_name":"Daniel Caires","email":"daniel.caires@encora.com","username":"Daniel.Caires"},"change_message_id":"1aeefdac6cb92a0037b55fccf91e89804e83e7fe","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    time.sleep(5)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def vboxmanage_startvm(hostname\u003dNone, type_bool\u003dFalse, force\u003dFalse):"},{"line_number":416,"context_line":"    \"\"\""},{"line_number":417,"context_line":"    This allows you to power on a VM."},{"line_number":418,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"28e04b1a_8669e296","line":415,"in_reply_to":"2a230f94_74aab8dd","updated":"2023-05-17 16:47:52.000000000","message":"Done","commit_id":"8cd94bc362c83950a4332c7c3bbfa3edd04d8206"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"ef8b86445e4a5d9bed9e1b1710469c6d2ee62f46","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    time.sleep(5)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def vboxmanage_startvm(hostname\u003dNone, type_bool\u003dFalse, force\u003dFalse):"},{"line_number":416,"context_line":"    \"\"\""},{"line_number":417,"context_line":"    This allows you to power on a VM."},{"line_number":418,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"2a230f94_74aab8dd","line":415,"in_reply_to":"e00401b8_5d897932","updated":"2023-05-17 15:44:32.000000000","message":"I agree, \"type_bool\" is an unfortunate name for this. Perhaps call this parameter \"headless\" ?","commit_id":"8cd94bc362c83950a4332c7c3bbfa3edd04d8206"}],"deployment/virtualbox/pybox/install_vbox.py":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"84ab8d3850354c845b97b8ddc39c7049bb0e6666","unresolved":true,"context_lines":[{"line_number":959,"context_line":"def stage_install_nodes(ssh_client):"},{"line_number":960,"context_line":"    # Create and transfer host_bulk_add.xml to ctrl-0"},{"line_number":961,"context_line":"    host_xml \u003d create_host_bulk_add()"},{"line_number":962,"context_line":"    startvm_type \u003d vboxoptions.startvm_type"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"    LOG.info(\"host_bulk_add.xml content:\\n%s\", host_xml)"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"53c96c9f_46cc640c","line":962,"updated":"2023-05-02 17:02:06.000000000","message":"Can we put the creation of this variable closer to its usage in line 1000?","commit_id":"7492de073c4f3732572d4be412c40321f1f1943c"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"110be8d19bd5a86a227567d28bea582f6bbc0b10","unresolved":false,"context_lines":[{"line_number":959,"context_line":"def stage_install_nodes(ssh_client):"},{"line_number":960,"context_line":"    # Create and transfer host_bulk_add.xml to ctrl-0"},{"line_number":961,"context_line":"    host_xml \u003d create_host_bulk_add()"},{"line_number":962,"context_line":"    startvm_type \u003d vboxoptions.startvm_type"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"    LOG.info(\"host_bulk_add.xml content:\\n%s\", host_xml)"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fd04882_72204689","line":962,"in_reply_to":"53c96c9f_46cc640c","updated":"2023-05-02 18:03:07.000000000","message":"Done","commit_id":"7492de073c4f3732572d4be412c40321f1f1943c"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"110be8d19bd5a86a227567d28bea582f6bbc0b10","unresolved":true,"context_lines":[{"line_number":996,"context_line":"    if vboxoptions.headless:"},{"line_number":997,"context_line":"        startvm_type \u003d \u0027headless\u0027"},{"line_number":998,"context_line":"    else:"},{"line_number":999,"context_line":"        startvm_type \u003d \u0027gui\u0027"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    # Start hosts one by one, wait 10s between each start"},{"line_number":1002,"context_line":"    vms \u003d vboxmanage.get_all_vms(vboxoptions.labname, option\u003d\"vms\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"08bbcfcd_c4c0709a","line":999,"updated":"2023-05-02 18:03:07.000000000","message":"Now maybe we can deduplicate this `if/else` statement ho happen only once, inside the `vboxmanage_startvm` function.","commit_id":"9f3d68a549ee990688c72003bf685774d8e5f560"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"12ca4b48509cd9010033bd2a6603ed54d9ae6387","unresolved":false,"context_lines":[{"line_number":996,"context_line":"    if vboxoptions.headless:"},{"line_number":997,"context_line":"        startvm_type \u003d \u0027headless\u0027"},{"line_number":998,"context_line":"    else:"},{"line_number":999,"context_line":"        startvm_type \u003d \u0027gui\u0027"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    # Start hosts one by one, wait 10s between each start"},{"line_number":1002,"context_line":"    vms \u003d vboxmanage.get_all_vms(vboxoptions.labname, option\u003d\"vms\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"296c1654_b6c98cdf","line":999,"in_reply_to":"08bbcfcd_c4c0709a","updated":"2023-05-03 19:25:25.000000000","message":"Done","commit_id":"9f3d68a549ee990688c72003bf685774d8e5f560"}]}