)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35944,"name":"Tomás Nascimento Pimentel Barros","display_name":"Tomás Barros","email":"tomas.barros@encora.com","username":"tomas_barros_encora"},"change_message_id":"144ed30037c6eecb1ef02c5b48e684e276a0a405","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"50da4183_653795a2","line":12,"updated":"2023-05-16 16:28:46.000000000","message":"Missing sign-off line","commit_id":"f17cb5109626af782716aa467990766caef77685"},{"author":{"_account_id":35967,"name":"Lindley Werner Soares Vieira","display_name":"Lindley Werner","email":"lindley.vieira@encora.com","username":"lindleywerner"},"change_message_id":"57ddf7a9699a96a963cc3b3f625098fc003964b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"692927a2_4151def1","line":12,"in_reply_to":"50da4183_653795a2","updated":"2023-05-16 19:08:27.000000000","message":"Done","commit_id":"f17cb5109626af782716aa467990766caef77685"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"01df4567adc8684c58b4f1586834d6fcca66ca96","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lindley Werner \u003clindley.vieira@encora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-17 09:15:43 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding pylint to /deployment/virtualbox/pybox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2005051"},{"line_number":10,"context_line":"Task: 47900"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"0d446d64_1127075b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"updated":"2023-05-23 13:24:52.000000000","message":"Be wary that commits should include a Test Plan: https://docs.starlingx.io/developer_resources/code-submission-guide.html#id1\n\nAnd it would help reviewers if you include a short description to explain the context of your commit as well.\n\nIn this case, I assume you should have run tox and it passed successfully. You don\u0027t need to change it now since it will reset the votes on your commit, but keep in mind for future commits","commit_id":"a458c301a0c03fd09760fe43e9de61a1acba097c"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"25ef427a10484d614334b930c0ede6da9f8294b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lindley Werner \u003clindley.vieira@encora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-17 09:15:43 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding pylint to /deployment/virtualbox/pybox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2005051"},{"line_number":10,"context_line":"Task: 47900"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa72595_21b32332","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"in_reply_to":"0d446d64_1127075b","updated":"2023-05-23 14:03:59.000000000","message":"Also, by adding `deployment/virtualbox/pybox` to `tox.ini` in this commit, Zuul is already picking this up validating the files changed in this commit.","commit_id":"a458c301a0c03fd09760fe43e9de61a1acba097c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"29879b8a60801ddd51830fc71539b188ff9ed104","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72a2730c_de0e041f","updated":"2023-05-09 20:48:28.000000000","message":"(bringing my comments to this Review)\n\nWould you mind adding very high-level info about each folder below in the README file?\n\n```\n \u003e\u003e tree -L 2 -d\n.\n├── configs\n│   └── aio-sx\n├── consts\n├── helper\n└── utils\n```\n\nOr, rather, do you think it\u0027s a good idea? Or would it be redundant with the docstring that you already added?","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"},{"author":{"_account_id":35967,"name":"Lindley Werner Soares Vieira","display_name":"Lindley Werner","email":"lindley.vieira@encora.com","username":"lindleywerner"},"change_message_id":"02644aaa04600ad684b8367867fcaa098b7375cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00b1593f_6dee8b96","in_reply_to":"72a2730c_de0e041f","updated":"2023-05-11 13:06:45.000000000","message":"I can add, no problems","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"}],"deployment/virtualbox/pybox/consts/env.py":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"29879b8a60801ddd51830fc71539b188ff9ed104","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        \"controller-0_ip\": \"10.10.10.8\","},{"line_number":33,"context_line":"        \"controller-1_ip\": \"10.10.10.9\","},{"line_number":34,"context_line":"        \"username\": \"sysadmin\","},{"line_number":35,"context_line":"        \"password\": \"Li69nux*\","},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7b26c27_80b3fd5a","line":35,"updated":"2023-05-09 20:48:28.000000000","message":"I don\u0027t like passwords here. I created task 47960 in story 2005051 to deal with this later.","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"},{"author":{"_account_id":35967,"name":"Lindley Werner Soares Vieira","display_name":"Lindley Werner","email":"lindley.vieira@encora.com","username":"lindleywerner"},"change_message_id":"02644aaa04600ad684b8367867fcaa098b7375cb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"controller-0_ip\": \"10.10.10.8\","},{"line_number":33,"context_line":"        \"controller-1_ip\": \"10.10.10.9\","},{"line_number":34,"context_line":"        \"username\": \"sysadmin\","},{"line_number":35,"context_line":"        \"password\": \"Li69nux*\","},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1a39a26_f492c16d","line":35,"in_reply_to":"b7b26c27_80b3fd5a","updated":"2023-05-11 13:06:45.000000000","message":"Ack","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"}],"deployment/virtualbox/pybox/consts/networking.py":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"29879b8a60801ddd51830fc71539b188ff9ed104","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Classes:"},{"line_number":13,"context_line":"- `Subnets`: A class containing dictionaries for IPv4 and IPv6 subnets."},{"line_number":14,"context_line":"- `NICs`: A class containing dictionaries for NIC configurations of different types of"},{"line_number":15,"context_line":"nodes in the virtual environment, such as `CONTROLLER`, `COMPUTE`, and `STORAGE`."},{"line_number":16,"context_line":"- `OAM`: A class containing an IP address and netmask for the out-of-band management (OAM) network."},{"line_number":17,"context_line":"- `Serial`: A class containing configurations for the serial ports."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"81785926_e0457987","line":15,"updated":"2023-05-09 20:48:28.000000000","message":"I wonder if `COMPUTE` and `WORKER` refer to the same thing. That\u0027s the first time I see `COMPUTE` but it looks like it\u0027s trying to reference a worker node. Is it?","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"51e228d3aeabac21dd5807cbb4a5913cd2715f26","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Classes:"},{"line_number":13,"context_line":"- `Subnets`: A class containing dictionaries for IPv4 and IPv6 subnets."},{"line_number":14,"context_line":"- `NICs`: A class containing dictionaries for NIC configurations of different types of"},{"line_number":15,"context_line":"nodes in the virtual environment, such as `CONTROLLER`, `COMPUTE`, and `STORAGE`."},{"line_number":16,"context_line":"- `OAM`: A class containing an IP address and netmask for the out-of-band management (OAM) network."},{"line_number":17,"context_line":"- `Serial`: A class containing configurations for the serial ports."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"00769e12_88f89647","line":15,"in_reply_to":"2071c644_e117686a","updated":"2023-05-11 14:03:24.000000000","message":"Ack","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"},{"author":{"_account_id":35967,"name":"Lindley Werner Soares Vieira","display_name":"Lindley Werner","email":"lindley.vieira@encora.com","username":"lindleywerner"},"change_message_id":"02644aaa04600ad684b8367867fcaa098b7375cb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Classes:"},{"line_number":13,"context_line":"- `Subnets`: A class containing dictionaries for IPv4 and IPv6 subnets."},{"line_number":14,"context_line":"- `NICs`: A class containing dictionaries for NIC configurations of different types of"},{"line_number":15,"context_line":"nodes in the virtual environment, such as `CONTROLLER`, `COMPUTE`, and `STORAGE`."},{"line_number":16,"context_line":"- `OAM`: A class containing an IP address and netmask for the out-of-band management (OAM) network."},{"line_number":17,"context_line":"- `Serial`: A class containing configurations for the serial ports."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2071c644_e117686a","line":15,"in_reply_to":"81785926_e0457987","updated":"2023-05-11 13:06:45.000000000","message":"I put COMPUTE because this is the variable name inside the class","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"29879b8a60801ddd51830fc71539b188ff9ed104","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- `NICs`: A class containing dictionaries for NIC configurations of different types of"},{"line_number":15,"context_line":"nodes in the virtual environment, such as `CONTROLLER`, `COMPUTE`, and `STORAGE`."},{"line_number":16,"context_line":"- `OAM`: A class containing an IP address and netmask for the out-of-band management (OAM) network."},{"line_number":17,"context_line":"- `Serial`: A class containing configurations for the serial ports."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d83126a7_fa6b125b","line":17,"updated":"2023-05-09 20:48:28.000000000","message":"nitpick: \"A class containing configuration for the serial ports.\"","commit_id":"277fc0a16fa3c32bf7e22f4115724818a5b873da"}],"deployment/virtualbox/pybox/utils/kpi.py":[{"author":{"_account_id":35944,"name":"Tomás Nascimento Pimentel Barros","display_name":"Tomás Barros","email":"tomas.barros@encora.com","username":"tomas_barros_encora"},"change_message_id":"c78281491188fcee2084487ae97cdbcb81b2bcfa","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        return f\"{minutes:.0f}m {seconds:.2f}s\""},{"line_number":42,"context_line":"    if seconds:"},{"line_number":43,"context_line":"        return f\"{seconds:.2f}s\""},{"line_number":44,"context_line":"    return None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def set_kpi_metric(metric, duration):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a106c065_558dafb6","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":15},"updated":"2023-05-16 20:39:52.000000000","message":"Is it necessary to have any kind of checking when calling this function to not cause an exception and stop the program?","commit_id":"a3b0af1636c6120a1ad0661a7cda0d656497d8ed"},{"author":{"_account_id":35967,"name":"Lindley Werner Soares Vieira","display_name":"Lindley Werner","email":"lindley.vieira@encora.com","username":"lindleywerner"},"change_message_id":"69d702c98aee99f4ed6a125c3d8a2fe6053c7508","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return f\"{minutes:.0f}m {seconds:.2f}s\""},{"line_number":42,"context_line":"    if seconds:"},{"line_number":43,"context_line":"        return f\"{seconds:.2f}s\""},{"line_number":44,"context_line":"    return None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def set_kpi_metric(metric, duration):"}],"source_content_type":"text/x-python","patch_set":6,"id":"27abc347_8c786f11","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":15},"in_reply_to":"a106c065_558dafb6","updated":"2023-05-17 11:51:35.000000000","message":"You have a good point here, actually, the function should return seconds instead of None","commit_id":"a3b0af1636c6120a1ad0661a7cda0d656497d8ed"}]}