)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"a9172fd10a2a48f1eca3605f405f3f0f5f5cf5ef","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Raise 900.003 alarm when an unavailable release is present"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":"PASS: Deploy software release with no unwanted alarms"},{"line_number":19,"context_line":"PASS: Force a failed deploy host and verify alarm"},{"line_number":20,"context_line":"PASS: Deploy a major release and verify 900.003 alarm"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"220ecf0f_c7b62b1c","line":18,"updated":"2024-10-07 17:29:59.000000000","message":"recommend to verify with sw-manager to ensure the new alarms do not affect it (they should be ignored as per https://opendev.org/starlingx/nfv/src/commit/cde7c6494af526d23857c848e02e5ea3a9f1f033/nfv/nfv-vim/nfv_vim/strategy/_strategy.py#L1447","commit_id":"6f853b61435310cadf4601bf6f5435a04c325204"},{"author":{"_account_id":33797,"name":"Matheus Machado Guilhermino","email":"Matheus.MachadoGuilhermino@windriver.com","username":"mmachado"},"change_message_id":"fa033b2b080123cfbed654a77ce1f42805fe588c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Raise 900.003 alarm when an unavailable release is present"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":"PASS: Deploy software release with no unwanted alarms"},{"line_number":19,"context_line":"PASS: Force a failed deploy host and verify alarm"},{"line_number":20,"context_line":"PASS: Deploy a major release and verify 900.003 alarm"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"eb7a7e92_dff4c8be","line":18,"in_reply_to":"220ecf0f_c7b62b1c","updated":"2024-10-08 02:49:46.000000000","message":"sw-manager sw-deploy-strategy apply failed because of 900.001 alarm during software upgrade, it could be added to this list as well:\nhttps://opendev.org/starlingx/nfv/src/commit/cde7c6494af526d23857c848e02e5ea3a9f1f033/nfv/nfv-vim/nfv_vim/strategy/_strategy.py#L1802\n\nOr we could avoid raising this alarm for upgrade and only raise it for patching.","commit_id":"6f853b61435310cadf4601bf6f5435a04c325204"},{"author":{"_account_id":33797,"name":"Matheus Machado Guilhermino","email":"Matheus.MachadoGuilhermino@windriver.com","username":"mmachado"},"change_message_id":"76b1877b56b981eeb58b84f15b55975250c9b99a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Raise 900.003 alarm when an unavailable release is present"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":"PASS: Deploy software release with no unwanted alarms"},{"line_number":19,"context_line":"PASS: Force a failed deploy host and verify alarm"},{"line_number":20,"context_line":"PASS: Deploy a major release and verify 900.003 alarm"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a2908e79_150b953e","line":18,"in_reply_to":"eb7a7e92_dff4c8be","updated":"2024-10-10 12:07:42.000000000","message":"Added new alarm to strategy ignore list: https://review.opendev.org/c/starlingx/nfv/+/931964","commit_id":"6f853b61435310cadf4601bf6f5435a04c325204"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"0ccac8e0bc30083f2083518fefed4cb52be3e04e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"PASS: Force a failed deploy host and verify alarm"},{"line_number":23,"context_line":"PASS: Deploy a major release and verify 900.024 alarm"},{"line_number":24,"context_line":"PASS: Use sw-manager to deploy major \u0026 minor releases"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Story: 2010676"},{"line_number":27,"context_line":"Task: 51120"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"264d3e7f_3d4bf70c","line":25,"updated":"2024-10-10 18:59:22.000000000","message":"should verify on bootstrap and initial host-unlock that there are no unexpected new alarms","commit_id":"8733c9b74bcd8320c9452c0f73a956d6ac4f67b4"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"f1cb335ce0241e6703fb0c51755d5993b6e1032a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PASS: Force a failed deploy host and verify alarm"},{"line_number":23,"context_line":"PASS: Deploy a major release and verify 900.024 alarm"},{"line_number":24,"context_line":"PASS: Use sw-manager to deploy major \u0026 minor releases"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Story: 2010676"},{"line_number":27,"context_line":"Task: 51120"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7b94004f_95d83646","line":25,"in_reply_to":"264d3e7f_3d4bf70c","updated":"2024-10-16 17:26:16.000000000","message":"Done","commit_id":"8733c9b74bcd8320c9452c0f73a956d6ac4f67b4"},{"author":{"_account_id":33797,"name":"Matheus Machado Guilhermino","email":"Matheus.MachadoGuilhermino@windriver.com","username":"mmachado"},"change_message_id":"8aee6748c4b8bcc9476a8d9c6af9d5a47012d004","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PASS: Force a failed deploy host and verify alarm"},{"line_number":23,"context_line":"PASS: Deploy a major release and verify 900.024 alarm"},{"line_number":24,"context_line":"PASS: Use sw-manager to deploy major \u0026 minor releases"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Story: 2010676"},{"line_number":27,"context_line":"Task: 51120"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bcf460df_87fec1ae","line":25,"in_reply_to":"264d3e7f_3d4bf70c","updated":"2024-10-16 17:24:36.000000000","message":"Tests were done with dev iso so bootstrap and initial host-unlock are included","commit_id":"8733c9b74bcd8320c9452c0f73a956d6ac4f67b4"}],"patch-alarm/patch-alarm/patch_alarm/patch_alarm_manager.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"380dd2b3ec5539d978efb8a2725e9985a53c60e6","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        cert_alarm \u003d self.fm_api.get_fault(fm_constants.FM_ALARM_ID_NONSTANDARD_CERT_PATCH,"},{"line_number":167,"context_line":"                                           entity_instance_id)"},{"line_number":168,"context_line":"        if raise_cert_alarm and cert_alarm is None:"},{"line_number":169,"context_line":"            logging.info(\"Raising developer-certificate-enabled alarm\")"},{"line_number":170,"context_line":"            fault \u003d fm_api.Fault(alarm_id\u003dfm_constants.FM_ALARM_ID_NONSTANDARD_CERT_PATCH,"},{"line_number":171,"context_line":"                                 alarm_type\u003dfm_constants.FM_ALARM_TYPE_9,"},{"line_number":172,"context_line":"                                 alarm_state\u003dfm_constants.FM_ALARM_STATE_SET,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a975559c_cc973b32","side":"PARENT","line":169,"updated":"2024-10-11 14:16:04.000000000","message":"this developer certificate alarm could be still relevant ?","commit_id":"4ac20a6c44957eee07e3569f854b2ebb00b1f63f"},{"author":{"_account_id":33797,"name":"Matheus Machado Guilhermino","email":"Matheus.MachadoGuilhermino@windriver.com","username":"mmachado"},"change_message_id":"6503b056081d7c8f8dcd83556681b38b70ef7996","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        cert_alarm \u003d self.fm_api.get_fault(fm_constants.FM_ALARM_ID_NONSTANDARD_CERT_PATCH,"},{"line_number":167,"context_line":"                                           entity_instance_id)"},{"line_number":168,"context_line":"        if raise_cert_alarm and cert_alarm is None:"},{"line_number":169,"context_line":"            logging.info(\"Raising developer-certificate-enabled alarm\")"},{"line_number":170,"context_line":"            fault \u003d fm_api.Fault(alarm_id\u003dfm_constants.FM_ALARM_ID_NONSTANDARD_CERT_PATCH,"},{"line_number":171,"context_line":"                                 alarm_type\u003dfm_constants.FM_ALARM_TYPE_9,"},{"line_number":172,"context_line":"                                 alarm_state\u003dfm_constants.FM_ALARM_STATE_SET,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a7df789c_e62328ec","side":"PARENT","line":169,"in_reply_to":"a975559c_cc973b32","updated":"2024-10-16 13:03:29.000000000","message":"included mechanism for raising this alarm in the future","commit_id":"4ac20a6c44957eee07e3569f854b2ebb00b1f63f"}]}