)]}'
{"openstack/openstack-aodh/centos/meta_patches/0001-Modify-service-files-and-create-expirer-cron-script.patch":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c8cc2feab080b31287a218eef67ecf8a6810d408","unresolved":false,"context_lines":[{"line_number":172,"context_line":" Source13:         %{name}-expirer.service"},{"line_number":173,"context_line":" Source14:         %{name}-listener.service"},{"line_number":174,"context_line":" "},{"line_number":175,"context_line":"+#WRS"},{"line_number":176,"context_line":"+Source20:         aodh-expirer-active"},{"line_number":177,"context_line":"+"},{"line_number":178,"context_line":" BuildArch:        noarch"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_0684060a","line":175,"updated":"2018-09-06 13:26:49.000000000","message":"minor detail.  I think we are removing references to WRS from the patches.\nHowever that would require all the patches to be updated.","commit_id":"7647d75beef0589910f630a73cc80a877e15015d"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c8cc2feab080b31287a218eef67ecf8a6810d408","unresolved":false,"context_lines":[{"line_number":191,"context_line":" # Find language files"},{"line_number":192,"context_line":" %find_lang %{pypi_name} --all-name"},{"line_number":193,"context_line":" "},{"line_number":194,"context_line":"+# WRS"},{"line_number":195,"context_line":"+install -p -D -m 750 %{SOURCE20} %{buildroot}%{_bindir}/aodh-expirer-active"},{"line_number":196,"context_line":"+"},{"line_number":197,"context_line":" # Remove unused files"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_c6792e2f","line":194,"updated":"2018-09-06 13:26:49.000000000","message":"WRS comment again","commit_id":"7647d75beef0589910f630a73cc80a877e15015d"}],"openstack/openstack-aodh/centos/meta_patches/0001-meta-modify-aodh-api.patch":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c8cc2feab080b31287a218eef67ecf8a6810d408","unresolved":false,"context_lines":[{"line_number":28,"context_line":"--- a/SPECS/openstack-aodh.spec"},{"line_number":29,"context_line":"+++ b/SPECS/openstack-aodh.spec"},{"line_number":30,"context_line":"@@ -20,6 +20,9 @@ Source14:         %{name}-listener.service"},{"line_number":31,"context_line":" #WRS"},{"line_number":32,"context_line":" Source20:         aodh-expirer-active"},{"line_number":33,"context_line":" "},{"line_number":34,"context_line":"+#WRS: Include patches here:"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_46e19ecf","line":31,"updated":"2018-09-06 13:26:49.000000000","message":"WRS comment","commit_id":"7647d75beef0589910f630a73cc80a877e15015d"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c8cc2feab080b31287a218eef67ecf8a6810d408","unresolved":false,"context_lines":[{"line_number":31,"context_line":" #WRS"},{"line_number":32,"context_line":" Source20:         aodh-expirer-active"},{"line_number":33,"context_line":" "},{"line_number":34,"context_line":"+#WRS: Include patches here:"},{"line_number":35,"context_line":"+Patch1:           0001-modify-aodh-api.patch"},{"line_number":36,"context_line":"+"},{"line_number":37,"context_line":" BuildArch:        noarch"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_06e726e5","line":34,"updated":"2018-09-06 13:26:49.000000000","message":"WRS","commit_id":"7647d75beef0589910f630a73cc80a877e15015d"}],"openstack/openstack-aodh/centos/meta_patches/PATCH_ORDER":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"381c6e6f4d2a2edddaed99134e6ae726be5b2d2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f79a3b5_896fc65e","line":7,"updated":"2018-09-06 16:37:45.000000000","message":"if we\u0027re mucking around in here anyways, do we maybe want to remove the numeric prefixes on these patches to avoid confusion?  (Could maybe do this in a followup patch to keep this patch as clear as possible.)","commit_id":"c076b035d9d54d3feda646b3172e5b2bdf6f4d58"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"cf5c981fdb655c90f67294524cb99c8e33258504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f79a3b5_846fa490","line":7,"in_reply_to":"3f79a3b5_896fc65e","updated":"2018-09-07 00:12:24.000000000","message":"Yes. I also don\u0027t like it. Just keep it in order to mislead gerrit thought it is a different file, and cannot show the diff. I think we could do a refine later.","commit_id":"c076b035d9d54d3feda646b3172e5b2bdf6f4d58"}],"openstack/openstack-aodh/centos/patches/0002-Add-drivername-support-for-postgresql-connection-set.patch":[{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"2f579925816c411c48faafa5fbe818e6f10a6842","unresolved":false,"context_lines":[{"line_number":29,"context_line":"@@ -94,7 +94,7 @@ def _validate_conn_options(args):"},{"line_number":30,"context_line":"                               ), nosql_scheme)"},{"line_number":31,"context_line":"         sys.exit(1)"},{"line_number":32,"context_line":"     if sql_scheme not in (\u0027mysql\u0027, \u0027mysql+pymysql\u0027, \u0027postgresql\u0027,"},{"line_number":33,"context_line":"-                          \u0027sqlite\u0027):"},{"line_number":34,"context_line":"+                          \u0027postgresql+psycopg2\u0027, \u0027sqlite\u0027):"},{"line_number":35,"context_line":"         root_logger.error(_LE(\u0027Invalid destination DB type %s, the destination\u0027"},{"line_number":36,"context_line":"                               \u0027 database connection should be one of: \u0027"},{"line_number":37,"context_line":"                               \u0027[mysql, postgresql, sqlite]\u0027), sql_scheme)"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_8b2d8847","side":"PARENT","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":60},"updated":"2018-09-06 06:54:14.000000000","message":"This patch is not applied due to new src rpm doesn\u0027t have similar code.","commit_id":"57ae67d02232e9799f4d398f5019f5b3eb3fd202"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c8cc2feab080b31287a218eef67ecf8a6810d408","unresolved":false,"context_lines":[{"line_number":29,"context_line":"@@ -94,7 +94,7 @@ def _validate_conn_options(args):"},{"line_number":30,"context_line":"                               ), nosql_scheme)"},{"line_number":31,"context_line":"         sys.exit(1)"},{"line_number":32,"context_line":"     if sql_scheme not in (\u0027mysql\u0027, \u0027mysql+pymysql\u0027, \u0027postgresql\u0027,"},{"line_number":33,"context_line":"-                          \u0027sqlite\u0027):"},{"line_number":34,"context_line":"+                          \u0027postgresql+psycopg2\u0027, \u0027sqlite\u0027):"},{"line_number":35,"context_line":"         root_logger.error(_LE(\u0027Invalid destination DB type %s, the destination\u0027"},{"line_number":36,"context_line":"                               \u0027 database connection should be one of: \u0027"},{"line_number":37,"context_line":"                               \u0027[mysql, postgresql, sqlite]\u0027), sql_scheme)"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_26a262af","side":"PARENT","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":60},"in_reply_to":"3f79a3b5_8b2d8847","updated":"2018-09-06 13:26:49.000000000","message":"Your change is correct.  Those warning logs were added prior to AODH 4.0 and removed with 4.0 to provide people with time to move away from unsupported nosql connnection schemes like hbase.","commit_id":"57ae67d02232e9799f4d398f5019f5b3eb3fd202"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"2f579925816c411c48faafa5fbe818e6f10a6842","unresolved":false,"context_lines":[{"line_number":42,"context_line":"@@ -59,7 +59,7 @@ def get_connection_from_config(conf):"},{"line_number":43,"context_line":"     url \u003d conf.database.connection"},{"line_number":44,"context_line":"     connection_scheme \u003d urlparse.urlparse(url).scheme"},{"line_number":45,"context_line":"     if connection_scheme not in (\u0027mysql\u0027, \u0027mysql+pymysql\u0027, \u0027postgresql\u0027,"},{"line_number":46,"context_line":"-                                 \u0027sqlite\u0027):"},{"line_number":47,"context_line":"+                                 \u0027postgresql+psycopg2\u0027, \u0027sqlite\u0027):"},{"line_number":48,"context_line":"         msg \u003d (\u0027Storage backend %s is deprecated, and all the NoSQL backends \u0027"},{"line_number":49,"context_line":"                \u0027will be removed in Aodh 4.0, please use SQL backend.\u0027 %"},{"line_number":50,"context_line":"                connection_scheme)"}],"source_content_type":"text/x-diff","patch_set":3,"id":"3f79a3b5_2b1eb40b","side":"PARENT","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":67},"updated":"2018-09-06 06:54:14.000000000","message":"This code is not applied also.","commit_id":"57ae67d02232e9799f4d398f5019f5b3eb3fd202"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"381c6e6f4d2a2edddaed99134e6ae726be5b2d2d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"         sys.exit(1)"},{"line_number":32,"context_line":"     if sql_scheme not in (\u0027mysql\u0027, \u0027mysql+pymysql\u0027, \u0027postgresql\u0027,"},{"line_number":33,"context_line":"-                          \u0027sqlite\u0027):"},{"line_number":34,"context_line":"+                          \u0027postgresql+psycopg2\u0027, \u0027sqlite\u0027):"},{"line_number":35,"context_line":"         root_logger.error(_LE(\u0027Invalid destination DB type %s, the destination\u0027"},{"line_number":36,"context_line":"                               \u0027 database connection should be one of: \u0027"},{"line_number":37,"context_line":"                               \u0027[mysql, postgresql, sqlite]\u0027), sql_scheme)"}],"source_content_type":"text/x-diff","patch_set":6,"id":"3f79a3b5_691eeabb","side":"PARENT","line":34,"range":{"start_line":34,"start_character":28,"end_line":34,"end_character":47},"updated":"2018-09-06 16:37:45.000000000","message":"no longer need this with the new version?","commit_id":"57ae67d02232e9799f4d398f5019f5b3eb3fd202"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"cf5c981fdb655c90f67294524cb99c8e33258504","unresolved":false,"context_lines":[{"line_number":31,"context_line":"         sys.exit(1)"},{"line_number":32,"context_line":"     if sql_scheme not in (\u0027mysql\u0027, \u0027mysql+pymysql\u0027, \u0027postgresql\u0027,"},{"line_number":33,"context_line":"-                          \u0027sqlite\u0027):"},{"line_number":34,"context_line":"+                          \u0027postgresql+psycopg2\u0027, \u0027sqlite\u0027):"},{"line_number":35,"context_line":"         root_logger.error(_LE(\u0027Invalid destination DB type %s, the destination\u0027"},{"line_number":36,"context_line":"                               \u0027 database connection should be one of: \u0027"},{"line_number":37,"context_line":"                               \u0027[mysql, postgresql, sqlite]\u0027), sql_scheme)"}],"source_content_type":"text/x-diff","patch_set":6,"id":"3f79a3b5_8446c420","side":"PARENT","line":34,"range":{"start_line":34,"start_character":28,"end_line":34,"end_character":47},"in_reply_to":"3f79a3b5_691eeabb","updated":"2018-09-07 00:12:24.000000000","message":"Yes. The original author AI confirmed it is no longer needed.","commit_id":"57ae67d02232e9799f4d398f5019f5b3eb3fd202"}],"openstack/openstack-aodh/centos/patches/0003-support-new-gnocchiclient-interface.patch":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"48fcbcce0093cb8dc7bc237ef6750ac10167e391","unresolved":false,"context_lines":[{"line_number":23,"context_line":"-"},{"line_number":24,"context_line":"+            adapter_options\u003d{"},{"line_number":25,"context_line":"+                \u0027interface\u0027: conf.service_credentials.interface,"},{"line_number":26,"context_line":"+                \u0027region_name\u0027: conf.service_credentials.region_name})"},{"line_number":27,"context_line":"         try:"},{"line_number":28,"context_line":"             return gnocchi_client.capabilities.list().get("},{"line_number":29,"context_line":"                 \u0027aggregation_methods\u0027, [])"}],"source_content_type":"text/x-diff","patch_set":5,"id":"3f79a3b5_d33c8bc0","line":26,"updated":"2018-09-06 14:33:30.000000000","message":"Are you sure you need this?\nWhen I look upstream aodh 5.1.0 I already see those lines, unless the src rpm from centos is not exactly the same.\nhttps://github.com/openstack/aodh/blob/5.1.0/aodh/api/controllers/v2/alarm_rules/gnocchi.py#L81","commit_id":"76156fce2e977ec37992b98aaab269a14e3f4d1d"}]}
