)]}'
{"openstack/openstack-helm/files/0011-Add-Placement-Chart.patch":[{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":247,"context_line":"+{{- $mounts_placement_init :\u003d .Values.pod.mounts.placement.init_container }}"},{"line_number":248,"context_line":"+"},{"line_number":249,"context_line":"+{{- $serviceAccountName :\u003d \"placement-api\" }}"},{"line_number":250,"context_line":"+{{ tuple $envAll \"api\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":251,"context_line":"+---"},{"line_number":252,"context_line":"+apiVersion: apps/v1"},{"line_number":253,"context_line":"+kind: Deployment"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_e3ef1685","line":250,"range":{"start_line":250,"start_character":19,"end_line":250,"end_character":22},"updated":"2019-06-03 22:09:09.000000000","message":"The passed component is called \"api\". The following that uses the helm-toolkit functions require to pass the component should be identical. Although you don\u0027t have any dependency for placement-api, if there has, it will mess up.\n\nYou can update the \"api\" to \"placement\" here, that works too but use \"api\" is more make sense to me because the \"placement\" has been used for the label \"application\".","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":256,"context_line":"+  annotations:"},{"line_number":257,"context_line":"+    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":258,"context_line":"+  labels:"},{"line_number":259,"context_line":"+{{ tuple $envAll \"placement\" \"placement\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":260,"context_line":"+spec:"},{"line_number":261,"context_line":"+  replicas: {{ .Values.pod.replicas.placement }}"},{"line_number":262,"context_line":"+  selector:"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_23fd2e3a","line":259,"range":{"start_line":259,"start_character":31,"end_line":259,"end_character":40},"updated":"2019-06-03 22:09:09.000000000","message":"api","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":266,"context_line":"+  template:"},{"line_number":267,"context_line":"+    metadata:"},{"line_number":268,"context_line":"+      labels:"},{"line_number":269,"context_line":"+{{ tuple $envAll \"placement\" \"placement\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":270,"context_line":"+      annotations:"},{"line_number":271,"context_line":"+{{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" | indent 8 }}"},{"line_number":272,"context_line":"+        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_43faa242","line":269,"range":{"start_line":269,"start_character":31,"end_line":269,"end_character":40},"updated":"2019-06-03 22:09:09.000000000","message":"api","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":274,"context_line":"+    spec:"},{"line_number":275,"context_line":"+      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":276,"context_line":"+      affinity:"},{"line_number":277,"context_line":"+{{ tuple $envAll \"placement\" \"placement\" | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":278,"context_line":"+      nodeSelector:"},{"line_number":279,"context_line":"+        {{ .Values.labels.placement.node_selector_key }}: {{ .Values.labels.placement.node_selector_value }}"},{"line_number":280,"context_line":"+      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.placement.timeout | default \"30\" }}"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_a39efe04","line":277,"range":{"start_line":277,"start_character":31,"end_line":277,"end_character":40},"updated":"2019-06-03 22:09:09.000000000","message":"api","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":543,"context_line":"+  minAvailable: {{ .Values.pod.lifecycle.disruption_budget.placement.min_available }}"},{"line_number":544,"context_line":"+  selector:"},{"line_number":545,"context_line":"+    matchLabels:"},{"line_number":546,"context_line":"+{{ tuple $envAll \"placement\" \"placement\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":547,"context_line":"+{{- end }}"},{"line_number":548,"context_line":"diff --git a/placement/templates/secret-db.yaml b/placement/templates/secret-db.yaml"},{"line_number":549,"context_line":"new file mode 100644"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_c3bc526b","line":546,"range":{"start_line":546,"start_character":31,"end_line":546,"end_character":40},"updated":"2019-06-03 22:09:09.000000000","message":"api","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":663,"context_line":"+    nodePort: {{ .Values.network.placement.node_port.port }}"},{"line_number":664,"context_line":"+    {{ end }}"},{"line_number":665,"context_line":"+  selector:"},{"line_number":666,"context_line":"+{{ tuple $envAll \"placement\" \"placement\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":667,"context_line":"+  {{ if .Values.network.placement.node_port.enabled }}"},{"line_number":668,"context_line":"+  type: NodePort"},{"line_number":669,"context_line":"+  {{ end }}"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_2359ae59","line":666,"range":{"start_line":666,"start_character":31,"end_line":666,"end_character":40},"updated":"2019-06-03 22:09:09.000000000","message":"api","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"+        services:"},{"line_number":1009,"context_line":"+          - endpoint: node"},{"line_number":1010,"context_line":"+            service: local_image_registry"},{"line_number":1011,"context_line":"+  static:"},{"line_number":1012,"context_line":"+    ks_endpoints:"},{"line_number":1013,"context_line":"+      jobs:"},{"line_number":1014,"context_line":"+        - placement-ks-user"}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_a3b11ee4","line":1011,"range":{"start_line":1011,"start_character":3,"end_line":1011,"end_character":10},"updated":"2019-06-03 22:09:09.000000000","message":"should add dependencies for ks_service and ks_user too.","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"6c23bc4cafbd7196ec66ccef2ab1c3a22f4e0400","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"+  job_ks_endpoints: true"},{"line_number":1051,"context_line":"+  secret_keystone: true"},{"line_number":1052,"context_line":"+  service_ingress: true"},{"line_number":1053,"context_line":"+  service: true"},{"line_number":1054,"context_line":"-- "},{"line_number":1055,"context_line":"1.8.3.1"},{"line_number":1056,"context_line":""}],"source_content_type":"text/x-diff","patch_set":2,"id":"9fb8cfa7_06a038f4","line":1053,"range":{"start_line":1053,"start_character":3,"end_line":1053,"end_character":10},"updated":"2019-06-03 22:09:09.000000000","message":"nit: would be clearer if use service_api, ingress_api, pdb_api","commit_id":"978065864c3214d576128cce8c029fc1282d79c3"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"a1057f63c365af73a2b1cd79d3b8f6a7e387ed0c","unresolved":false,"context_lines":[{"line_number":808,"context_line":"+      incomplete_consumer_user_id: 00000000-0000-0000-0000-000000000000"},{"line_number":809,"context_line":"+      policy_file: policy.yaml"},{"line_number":810,"context_line":"+    placement_database:"},{"line_number":811,"context_line":"+      connection: mysql+pymysql://placement:PASSWORD@***/placement"},{"line_number":812,"context_line":"+    api:"},{"line_number":813,"context_line":"+      auth_strategy: keystone"},{"line_number":814,"context_line":"+    keystone_authtoken:"}],"source_content_type":"text/x-diff","patch_set":3,"id":"9fb8cfa7_e3eb77ad","line":811,"range":{"start_line":811,"start_character":0,"end_line":811,"end_character":67},"updated":"2019-06-05 07:46:40.000000000","message":"connection should be set to null for helm-toolkit override. the override takes place in configmap-etc.yaml","commit_id":"95024ed5203f1b4cacecf8f6e92d9783b3fd9ade"}],"openstack/openstack-helm/files/0012-Add-Placement-Chart.patch":[{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"f7e5853d4d51ba8e1554d7f66ef11171fae15d9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 724d96177b181975cab9bb1bdb3df139376320f1 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: zhipengl \u003czhipengs.liu@intel.com\u003e"},{"line_number":3,"context_line":"Date: Fri, 31 May 2019 06:49:51 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] WIP: add placement chart"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"This commit adds a helm chart to deploy placement."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-diff","patch_set":8,"id":"9fb8cfa7_80b34798","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":41},"updated":"2019-06-10 03:07:54.000000000","message":"nit: Remove the WIP since your original patch to openstack-helm was updated.","commit_id":"076047a9f9957d172d2eae8cf7ffdadff9a4a56d"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":108,"context_line":"+"},{"line_number":109,"context_line":"+set -ex"},{"line_number":110,"context_line":"+"},{"line_number":111,"context_line":"+su -s /bin/sh -c \"placement-manage db sync\" placement"},{"line_number":112,"context_line":"diff --git a/placement/templates/bin/_placement-api.sh.tpl b/placement/templates/bin/_placement-api.sh.tpl"},{"line_number":113,"context_line":"new file mode 100644"},{"line_number":114,"context_line":"index 0000000..4f82970"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_c6238555","line":111,"updated":"2019-06-11 01:52:51.000000000","message":"do we need placement client in our builds?","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":108,"context_line":"+"},{"line_number":109,"context_line":"+set -ex"},{"line_number":110,"context_line":"+"},{"line_number":111,"context_line":"+su -s /bin/sh -c \"placement-manage db sync\" placement"},{"line_number":112,"context_line":"diff --git a/placement/templates/bin/_placement-api.sh.tpl b/placement/templates/bin/_placement-api.sh.tpl"},{"line_number":113,"context_line":"new file mode 100644"},{"line_number":114,"context_line":"index 0000000..4f82970"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_01266769","line":111,"in_reply_to":"9fb8cfa7_c6238555","updated":"2019-06-11 02:19:46.000000000","message":"I\u0027m not sure about this, could you help clarify it for me, thanks!","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"64e1d0fbf84ecbc15767552f4325e18cc482adc4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"+"},{"line_number":109,"context_line":"+set -ex"},{"line_number":110,"context_line":"+"},{"line_number":111,"context_line":"+su -s /bin/sh -c \"placement-manage db sync\" placement"},{"line_number":112,"context_line":"diff --git a/placement/templates/bin/_placement-api.sh.tpl b/placement/templates/bin/_placement-api.sh.tpl"},{"line_number":113,"context_line":"new file mode 100644"},{"line_number":114,"context_line":"index 0000000..4f82970"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_41169faa","line":111,"in_reply_to":"9fb8cfa7_c6238555","updated":"2019-06-11 02:37:59.000000000","message":"We may not need it, but this patch will come from upstream\nin the future, so that\u0027s keep it","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":742,"context_line":"+    external_policy_local: false"},{"line_number":743,"context_line":"+    node_port:"},{"line_number":744,"context_line":"+      enabled: false"},{"line_number":745,"context_line":"+      port: 8778"},{"line_number":746,"context_line":"+"},{"line_number":747,"context_line":"+conf:"},{"line_number":748,"context_line":"+  policy:"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_c605c547","line":745,"updated":"2019-06-11 01:52:51.000000000","message":"So why doesn\u0027t this match the nova values where it was 30778","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":742,"context_line":"+    external_policy_local: false"},{"line_number":743,"context_line":"+    node_port:"},{"line_number":744,"context_line":"+      enabled: false"},{"line_number":745,"context_line":"+      port: 8778"},{"line_number":746,"context_line":"+"},{"line_number":747,"context_line":"+conf:"},{"line_number":748,"context_line":"+  policy:"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_c17fef12","line":745,"in_reply_to":"9fb8cfa7_c605c547","updated":"2019-06-11 02:19:46.000000000","message":"set it to 30778\nand add port:8778 above ingress","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":752,"context_line":"+    default: \u0027rule:admin_or_owner\u0027"},{"line_number":753,"context_line":"+  placement:"},{"line_number":754,"context_line":"+    DEFAULT:"},{"line_number":755,"context_line":"+      debug: true"},{"line_number":756,"context_line":"+      use_syslog: true"},{"line_number":757,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":758,"context_line":"+    placement:"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_263e21da","line":755,"updated":"2019-06-11 01:52:51.000000000","message":"Don\u0027t think we want debug enabled.","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":752,"context_line":"+    default: \u0027rule:admin_or_owner\u0027"},{"line_number":753,"context_line":"+  placement:"},{"line_number":754,"context_line":"+    DEFAULT:"},{"line_number":755,"context_line":"+      debug: true"},{"line_number":756,"context_line":"+      use_syslog: true"},{"line_number":757,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":758,"context_line":"+    placement:"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_81eed7ea","line":755,"in_reply_to":"9fb8cfa7_263e21da","updated":"2019-06-11 02:19:46.000000000","message":"Set to false","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":753,"context_line":"+  placement:"},{"line_number":754,"context_line":"+    DEFAULT:"},{"line_number":755,"context_line":"+      debug: true"},{"line_number":756,"context_line":"+      use_syslog: true"},{"line_number":757,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":758,"context_line":"+    placement:"},{"line_number":759,"context_line":"+      randomize_allocation_candidates: false"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_e62329bc","line":756,"updated":"2019-06-11 01:52:51.000000000","message":"Didn\u0027t think we had this for nova.  We just got logs through the containers default.","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":753,"context_line":"+  placement:"},{"line_number":754,"context_line":"+    DEFAULT:"},{"line_number":755,"context_line":"+      debug: true"},{"line_number":756,"context_line":"+      use_syslog: true"},{"line_number":757,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":758,"context_line":"+    placement:"},{"line_number":759,"context_line":"+      randomize_allocation_candidates: false"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_01b427f1","line":756,"in_reply_to":"9fb8cfa7_e62329bc","updated":"2019-06-11 02:19:46.000000000","message":"set to false","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":755,"context_line":"+      debug: true"},{"line_number":756,"context_line":"+      use_syslog: true"},{"line_number":757,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":758,"context_line":"+    placement:"},{"line_number":759,"context_line":"+      randomize_allocation_candidates: false"},{"line_number":760,"context_line":"+      incomplete_consumer_project_id: 00000000-0000-0000-0000-000000000000"},{"line_number":761,"context_line":"+      incomplete_consumer_user_id: 00000000-0000-0000-0000-000000000000"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_210ccb39","line":758,"updated":"2019-06-11 01:52:51.000000000","message":"Aren\u0027t the values you have here already the default in placement?","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":755,"context_line":"+      debug: true"},{"line_number":756,"context_line":"+      use_syslog: true"},{"line_number":757,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":758,"context_line":"+    placement:"},{"line_number":759,"context_line":"+      randomize_allocation_candidates: false"},{"line_number":760,"context_line":"+      incomplete_consumer_project_id: 00000000-0000-0000-0000-000000000000"},{"line_number":761,"context_line":"+      incomplete_consumer_user_id: 00000000-0000-0000-0000-000000000000"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_418c5f35","line":758,"in_reply_to":"9fb8cfa7_210ccb39","updated":"2019-06-11 02:19:46.000000000","message":"ok, I can delete below 3 lines","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":988,"context_line":"+        rolling_update:"},{"line_number":989,"context_line":"+          max_unavailable: 1"},{"line_number":990,"context_line":"+          max_surge: 3"},{"line_number":991,"context_line":"+      daemonsets:"},{"line_number":992,"context_line":"+        pod_replacement_strategy: RollingUpdate"},{"line_number":993,"context_line":"+        compute:"},{"line_number":994,"context_line":"+          enabled: true"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_215a8b29","line":991,"updated":"2019-06-11 01:52:51.000000000","message":"Do you need daemonsets?  Placement is only a deployment.","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":988,"context_line":"+        rolling_update:"},{"line_number":989,"context_line":"+          max_unavailable: 1"},{"line_number":990,"context_line":"+          max_surge: 3"},{"line_number":991,"context_line":"+      daemonsets:"},{"line_number":992,"context_line":"+        pod_replacement_strategy: RollingUpdate"},{"line_number":993,"context_line":"+        compute:"},{"line_number":994,"context_line":"+          enabled: true"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_c1960f4d","line":991,"in_reply_to":"9fb8cfa7_215a8b29","updated":"2019-06-11 02:19:46.000000000","message":"remove it","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"6b53eb93887dafcc3297717d1dce0ce698837f17","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"+  secret_ingress_tls: true"},{"line_number":1128,"context_line":"+  pdb: true"},{"line_number":1129,"context_line":"+  ingress: true"},{"line_number":1130,"context_line":"+  job_ks_endpoints: true"},{"line_number":1131,"context_line":"+  secret_keystone: true"},{"line_number":1132,"context_line":"+  service_ingress: true"},{"line_number":1133,"context_line":"+  service: true"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_01a3c701","line":1130,"updated":"2019-06-11 01:52:51.000000000","message":"duplicate line","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"3b48590e06eb47e4c30063ffa291e9740755c277","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"+  secret_ingress_tls: true"},{"line_number":1128,"context_line":"+  pdb: true"},{"line_number":1129,"context_line":"+  ingress: true"},{"line_number":1130,"context_line":"+  job_ks_endpoints: true"},{"line_number":1131,"context_line":"+  secret_keystone: true"},{"line_number":1132,"context_line":"+  service_ingress: true"},{"line_number":1133,"context_line":"+  service: true"}],"source_content_type":"text/x-diff","patch_set":9,"id":"9fb8cfa7_a1999b79","line":1130,"in_reply_to":"9fb8cfa7_01a3c701","updated":"2019-06-11 02:19:46.000000000","message":"remove it","commit_id":"87f1aedc1afa4a3be2c39b305afb4de61b741a2b"}],"openstack/openstack-helm/files/0015-Add-Placement-Chart.patch":[{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"dd721b8927a826d2162a32e63b55a52268914e0d","unresolved":false,"context_lines":[{"line_number":758,"context_line":"+      debug: false"},{"line_number":759,"context_line":"+      use_syslog: false"},{"line_number":760,"context_line":"+      log_config_append: /etc/placement/logging.conf"},{"line_number":761,"context_line":"+    placement_database:"},{"line_number":762,"context_line":"+      sync_on_startup: false"},{"line_number":763,"context_line":"+      mysql_sql_mode: TRADITIONAL"},{"line_number":764,"context_line":"+      connection_recycle_time: 3600"}],"source_content_type":"text/x-diff","patch_set":12,"id":"9fb8cfa7_22c3128b","line":761,"updated":"2019-06-14 23:44:16.000000000","message":"All these placement_database options settings look to be the same as the placement default so can also be removed.","commit_id":"d24caf9a734451490171e2e7e7522077603e7444"},{"author":{"_account_id":19124,"name":"Gerry Kopec","email":"gerry.kopec@windriver.com","username":"gkopec"},"change_message_id":"dd721b8927a826d2162a32e63b55a52268914e0d","unresolved":false,"context_lines":[{"line_number":767,"context_line":"+      connection_debug: 0"},{"line_number":768,"context_line":"+      connection_trace: false"},{"line_number":769,"context_line":"+    api:"},{"line_number":770,"context_line":"+      auth_strategy: keystone"},{"line_number":771,"context_line":"+    keystone_authtoken:"},{"line_number":772,"context_line":"+      auth_version: v3"},{"line_number":773,"context_line":"+      auth_type: password"}],"source_content_type":"text/x-diff","patch_set":12,"id":"9fb8cfa7_a23ce292","line":770,"updated":"2019-06-14 23:44:16.000000000","message":"Same as placement default so can be removed.","commit_id":"d24caf9a734451490171e2e7e7522077603e7444"}]}