)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"c51856f96f51e0c4b7422dbb552c706f2134f0b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c12fe1d_088e7284","updated":"2021-11-05 17:13:56.000000000","message":"CentOS:\nDeployed AIO-SX, up to unlocked/enabled. [Degraded unrelated to this work, with one alarm due to low memory assigned to the VM]","commit_id":"8d272eeec41baa91836ec374853efd349fb2206f"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"bedca66c9630e963c8c85f82bee0b231a51105f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c142293_7ff4b650","updated":"2021-11-17 17:51:28.000000000","message":"Debian: built and integrated in the iso.","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9b9a8892a744cc618bcf1b09b531dd63ef79cffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70442293_f86ea0d2","updated":"2021-11-16 22:24:20.000000000","message":"Why are we changing the name of this package from python-keystone (on centos) to keystone? Shouldn\u0027t we be keeping the same name?","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"0335d9985eb6facb1939c0fd1f83aa2fe3700791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bad7b24d_fb740ce0","updated":"2021-11-10 19:05:56.000000000","message":"recheck","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"db1a83709accb7a2bd4c228f299f09cbbed3aa30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"36732b33_1b08f38b","in_reply_to":"3fdfd7c5_c895c478","updated":"2021-11-17 21:21:46.000000000","message":"One of the packages name is changed from openstack-keystone to keystone. \nThe other is providing the python3 version: python3-keystone_18.0.0-3.stx.1_all.deb.\n\nHere the directory name for build changed.","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"24f45943abd9e1f119282aae7ca1bb123b2c86dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fdfd7c5_c895c478","in_reply_to":"70442293_f86ea0d2","updated":"2021-11-17 14:52:53.000000000","message":"No, because then we would be breaking  alot of openstack packages. And cause a huge headache.","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"a167f478f2bf714400fbee3507eb1a174b4ace56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cc0e681a_a6f5b551","updated":"2021-11-23 11:12:57.000000000","message":"Build issue:\nmake: pyversions: No such file or directory\npy3versions: no X-Python3-Version in control file, using supported versions\ndh build --buildsystem\u003dpython_distutils --with python3,sphinxdoc,systemd\n   dh_update_autotools_config -O--buildsystem\u003dpython_distutils\n   dh_autoreconf -O--buildsystem\u003dpython_distutils\n   dh_auto_configure -O--buildsystem\u003dpython_distutils\ndh_auto_configure: warning: Please use the third-party \"pybuild\" build system instead of python-distutils\ndh_auto_configure: warning: This feature will be removed in compat 12.\n   debian/rules override_dh_auto_build\nmake[1]: Entering directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\nmake[1]: pyversions: No such file or directory\npy3versions: no X-Python3-Version in control file, using supported versions\n/usr/share/openstack-pkg-tools/pkgos_insert_include pkgos_func keystone.config\n/usr/share/openstack-pkg-tools/pkgos_insert_include pkgos_func keystone.postinst\nawk: cannot open debian/keystone.postinst.in (No such file or directory)\nmake[1]: *** [debian/rules:40: override_dh_auto_build] Error 2\nmake[1]: Leaving directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\nmake: *** [debian/rules:14: build] Error 2\n\n","commit_id":"e7e6e7fb2552bae28b4a5706e07ede462229b324"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cb49bb4155e6e423e2131c418f30720f8d96be9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3e5be0d8_6b319e32","in_reply_to":"cc0e681a_a6f5b551","updated":"2021-11-23 14:11:48.000000000","message":"Done","commit_id":"e7e6e7fb2552bae28b4a5706e07ede462229b324"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4d7a88137d1d9e6c18174a5ebaaf815e5755b91d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a7fe3bb6_c82f8a9e","updated":"2021-11-25 01:20:22.000000000","message":"I think its fine.\nwould be nice in the future to revisit if some of the modifications can be driven by puppet or ansible","commit_id":"e866623a4fe0cebc0d0f6a7b3384e5c412ed18d0"},{"author":{"_account_id":28424,"name":"Frank Miller","email":"frank.miller@eng.windriver.com","username":"sensfan22"},"change_message_id":"721ccbbe655a24c6ba19122eab82eea389cd9683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e54be4b2_14189f71","updated":"2021-11-24 16:37:04.000000000","message":"Team working on Debian has reviewed and ready for this to merge\nRequest for Cores to review and merge\n","commit_id":"e866623a4fe0cebc0d0f6a7b3384e5c412ed18d0"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"52b9c004ab09eb5ab2f1527df0bc70ab5ab2c3c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"477aed95_3763f40b","updated":"2021-11-23 19:05:24.000000000","message":"We could revisit the \u0027adm\u0027 group discussion later.\nIn my tests \u0027adm\u0027 group is not removed by base-passwd.","commit_id":"e866623a4fe0cebc0d0f6a7b3384e5c412ed18d0"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"958ac1c2ba10475af70562d1bbfa51e81cead34d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b9aee69a_ac42ba9c","in_reply_to":"477aed95_3763f40b","updated":"2021-11-24 17:05:21.000000000","message":"To aid the discussion thread: base-passwd is now updated to not delete the \u0027adm\u0027 group. I don\u0027t have any concerns.","commit_id":"e866623a4fe0cebc0d0f6a7b3384e5c412ed18d0"}],"openstack/keystone/debian/deb_patches/0001-Add-stx-support.patch":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"a04d24cedb0cc8e5bccdf04f698d05a88193b667","unresolved":true,"context_lines":[{"line_number":106,"context_line":"+# Default-Start:     2 3 4 5"},{"line_number":107,"context_line":"+# Default-Stop:      0 1 6"},{"line_number":108,"context_line":"+# Short-Description: OpenStack Keystone"},{"line_number":109,"context_line":"+# Description:       Openstack Identitiy service running on WSGI compatable gunicorn web server "},{"line_number":110,"context_line":"+#                    "},{"line_number":111,"context_line":"+### END INIT INFO"},{"line_number":112,"context_line":"+"}],"source_content_type":"text/x-diff","patch_set":2,"id":"fa8358f4_9988e6b2","line":109,"range":{"start_line":109,"start_character":32,"end_line":109,"end_character":41},"updated":"2021-11-08 22:21:16.000000000","message":"typos: Identity ... compatible ; also extra space at end of line; and at line 110","commit_id":"854fc4d36341e43c37812211f4cb3a3cf88525db"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"b138d226be341b7e5372a22c867c5156f2e0fbb5","unresolved":true,"context_lines":[{"line_number":107,"context_line":"+# Default-Stop:      0 1 6"},{"line_number":108,"context_line":"+# Short-Description: OpenStack Keystone"},{"line_number":109,"context_line":"+# Description:       Openstack Identitiy service running on WSGI compatable gunicorn web server "},{"line_number":110,"context_line":"+#                    "},{"line_number":111,"context_line":"+### END INIT INFO"},{"line_number":112,"context_line":"+"},{"line_number":113,"context_line":"+RETVAL\u003d0"}],"source_content_type":"text/x-diff","patch_set":3,"id":"4fd44863_8ddb1896","line":110,"updated":"2021-11-17 16:17:45.000000000","message":"nit:whitespace","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c8ebc386b11b8c1ce5d6ec11884eb988b06edd8f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"+# Default-Stop:      0 1 6"},{"line_number":108,"context_line":"+# Short-Description: OpenStack Keystone"},{"line_number":109,"context_line":"+# Description:       Openstack Identitiy service running on WSGI compatable gunicorn web server "},{"line_number":110,"context_line":"+#                    "},{"line_number":111,"context_line":"+### END INIT INFO"},{"line_number":112,"context_line":"+"},{"line_number":113,"context_line":"+RETVAL\u003d0"}],"source_content_type":"text/x-diff","patch_set":3,"id":"4a59c6d3_07debd4f","line":110,"in_reply_to":"4fd44863_8ddb1896","updated":"2021-11-18 14:10:22.000000000","message":"Done","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"b138d226be341b7e5372a22c867c5156f2e0fbb5","unresolved":true,"context_lines":[{"line_number":200,"context_line":"+"},{"line_number":201,"context_line":"+stop()"},{"line_number":202,"context_line":"+{"},{"line_number":203,"context_line":"+    if [  -e $PIDFILE_PUBLIC ]; then "},{"line_number":204,"context_line":"+\tstart-stop-daemon --stop --quiet --pidfile $PIDFILE_PUBLIC"},{"line_number":205,"context_line":"+\tRETVAL_PUBLIC\u003d$?"},{"line_number":206,"context_line":"+\t    if [ $RETVAL_PUBLIC -eq 0 ]; then"}],"source_content_type":"text/x-diff","patch_set":3,"id":"90094048_013fab2a","line":203,"updated":"2021-11-17 16:17:45.000000000","message":"nit:whitespace","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c8ebc386b11b8c1ce5d6ec11884eb988b06edd8f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"+"},{"line_number":201,"context_line":"+stop()"},{"line_number":202,"context_line":"+{"},{"line_number":203,"context_line":"+    if [  -e $PIDFILE_PUBLIC ]; then "},{"line_number":204,"context_line":"+\tstart-stop-daemon --stop --quiet --pidfile $PIDFILE_PUBLIC"},{"line_number":205,"context_line":"+\tRETVAL_PUBLIC\u003d$?"},{"line_number":206,"context_line":"+\t    if [ $RETVAL_PUBLIC -eq 0 ]; then"}],"source_content_type":"text/x-diff","patch_set":3,"id":"c0b79fbb_97ff9a5b","line":203,"in_reply_to":"90094048_013fab2a","updated":"2021-11-18 14:10:22.000000000","message":"Done","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"b138d226be341b7e5372a22c867c5156f2e0fbb5","unresolved":true,"context_lines":[{"line_number":209,"context_line":"+        \techo \"Stopping failed - $PIDFILE_PUBLIC\""},{"line_number":210,"context_line":"+\t    fi"},{"line_number":211,"context_line":"+\t    rm -f $PIDFILE_PUBLIC"},{"line_number":212,"context_line":"+    else "},{"line_number":213,"context_line":"+\techo \"Already stopped - $PIDFILE_PUBLIC\""},{"line_number":214,"context_line":"+    fi "},{"line_number":215,"context_line":"+}"}],"source_content_type":"text/x-diff","patch_set":3,"id":"0dfc1e9d_be4d0d76","line":212,"updated":"2021-11-17 16:17:45.000000000","message":"nit:whitespace","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c8ebc386b11b8c1ce5d6ec11884eb988b06edd8f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"+        \techo \"Stopping failed - $PIDFILE_PUBLIC\""},{"line_number":210,"context_line":"+\t    fi"},{"line_number":211,"context_line":"+\t    rm -f $PIDFILE_PUBLIC"},{"line_number":212,"context_line":"+    else "},{"line_number":213,"context_line":"+\techo \"Already stopped - $PIDFILE_PUBLIC\""},{"line_number":214,"context_line":"+    fi "},{"line_number":215,"context_line":"+}"}],"source_content_type":"text/x-diff","patch_set":3,"id":"29d8f393_215b45eb","line":212,"in_reply_to":"0dfc1e9d_be4d0d76","updated":"2021-11-18 14:10:22.000000000","message":"Done","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"b138d226be341b7e5372a22c867c5156f2e0fbb5","unresolved":true,"context_lines":[{"line_number":211,"context_line":"+\t    rm -f $PIDFILE_PUBLIC"},{"line_number":212,"context_line":"+    else "},{"line_number":213,"context_line":"+\techo \"Already stopped - $PIDFILE_PUBLIC\""},{"line_number":214,"context_line":"+    fi "},{"line_number":215,"context_line":"+}"},{"line_number":216,"context_line":"+"},{"line_number":217,"context_line":"+status()"}],"source_content_type":"text/x-diff","patch_set":3,"id":"dc058a34_d3135637","line":214,"updated":"2021-11-17 16:17:45.000000000","message":"nit:whitespace","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c8ebc386b11b8c1ce5d6ec11884eb988b06edd8f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"+\t    rm -f $PIDFILE_PUBLIC"},{"line_number":212,"context_line":"+    else "},{"line_number":213,"context_line":"+\techo \"Already stopped - $PIDFILE_PUBLIC\""},{"line_number":214,"context_line":"+    fi "},{"line_number":215,"context_line":"+}"},{"line_number":216,"context_line":"+"},{"line_number":217,"context_line":"+status()"}],"source_content_type":"text/x-diff","patch_set":3,"id":"7f77afb5_5330011e","line":214,"in_reply_to":"dc058a34_d3135637","updated":"2021-11-18 14:10:22.000000000","message":"Done","commit_id":"2671a31ed3787f800a2602f47b1aa38e72e97ad4"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"7c49ea59d531abf441061d098eb4d1eacf0e656e","unresolved":true,"context_lines":[{"line_number":52,"context_line":"--- a/debian/keystone.install"},{"line_number":53,"context_line":"+++ b/debian/keystone.install"},{"line_number":54,"context_line":"@@ -1,3 +1,8 @@"},{"line_number":55,"context_line":" debian/keystone-uwsgi.ini\t/etc/keystone"},{"line_number":56,"context_line":" etc/default_catalog.templates\t/etc/keystone"},{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"}],"source_content_type":"text/x-diff","patch_set":4,"id":"1bbd4e9d_524c6b49","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":40},"updated":"2021-11-18 15:17:39.000000000","message":"Also /etc/keystone should be 750 %dir %attr(0750, root, keystone) %{_sysconfdir}/keystone\nAnd all files in that dir should inherit the 0 perms for others.","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"e5f398996e4a5a55d3bbe7acfe6171a6a210a576","unresolved":true,"context_lines":[{"line_number":52,"context_line":"--- a/debian/keystone.install"},{"line_number":53,"context_line":"+++ b/debian/keystone.install"},{"line_number":54,"context_line":"@@ -1,3 +1,8 @@"},{"line_number":55,"context_line":" debian/keystone-uwsgi.ini\t/etc/keystone"},{"line_number":56,"context_line":" etc/default_catalog.templates\t/etc/keystone"},{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"}],"source_content_type":"text/x-diff","patch_set":4,"id":"f412ef69_7a6ff4f1","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":40},"in_reply_to":"1bbd4e9d_524c6b49","updated":"2021-11-22 15:16:18.000000000","message":"This is taken care of the keystone.postinst","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"2ea2df52dfafcfd115e35523631b99c08a5caf93","unresolved":false,"context_lines":[{"line_number":52,"context_line":"--- a/debian/keystone.install"},{"line_number":53,"context_line":"+++ b/debian/keystone.install"},{"line_number":54,"context_line":"@@ -1,3 +1,8 @@"},{"line_number":55,"context_line":" debian/keystone-uwsgi.ini\t/etc/keystone"},{"line_number":56,"context_line":" etc/default_catalog.templates\t/etc/keystone"},{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"}],"source_content_type":"text/x-diff","patch_set":4,"id":"26a17751_7f3f7776","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":40},"in_reply_to":"f412ef69_7a6ff4f1","updated":"2021-11-22 15:41:22.000000000","message":"Done","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"104ef8d873b58be65f18d2659d5ebe5124a03dc9","unresolved":true,"context_lines":[{"line_number":56,"context_line":" etc/default_catalog.templates\t/etc/keystone"},{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"},{"line_number":59,"context_line":"+debian/stx/password-rules.conf /etc/keystone"},{"line_number":60,"context_line":"+debian/stx/public.py usr/share/keystone"},{"line_number":61,"context_line":"+debian/stx/keystone.service lib/systemd/system"},{"line_number":62,"context_line":"+debian/stx/keystone-all usr/bin"}],"source_content_type":"text/x-diff","patch_set":4,"id":"dfb4aae5_12899ee1","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":45},"updated":"2021-11-18 14:43:23.000000000","message":"This should be 440\n+# STX: install password rules(readable only)\n+install -p -D -m 440 %{SOURCE102} %{buildroot}%{_sysconfdir}/keystone/password-rules.conf","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"e5f398996e4a5a55d3bbe7acfe6171a6a210a576","unresolved":false,"context_lines":[{"line_number":56,"context_line":" etc/default_catalog.templates\t/etc/keystone"},{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"},{"line_number":59,"context_line":"+debian/stx/password-rules.conf /etc/keystone"},{"line_number":60,"context_line":"+debian/stx/public.py usr/share/keystone"},{"line_number":61,"context_line":"+debian/stx/keystone.service lib/systemd/system"},{"line_number":62,"context_line":"+debian/stx/keystone-all usr/bin"}],"source_content_type":"text/x-diff","patch_set":4,"id":"ae99a4bf_cd4770fa","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":45},"in_reply_to":"dfb4aae5_12899ee1","updated":"2021-11-22 15:16:18.000000000","message":"This is taken care in the keystone.postinst","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"104ef8d873b58be65f18d2659d5ebe5124a03dc9","unresolved":true,"context_lines":[{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"},{"line_number":59,"context_line":"+debian/stx/password-rules.conf /etc/keystone"},{"line_number":60,"context_line":"+debian/stx/public.py usr/share/keystone"},{"line_number":61,"context_line":"+debian/stx/keystone.service lib/systemd/system"},{"line_number":62,"context_line":"+debian/stx/keystone-all usr/bin"},{"line_number":63,"context_line":"diff --git a/debian/keystone.logrotate b/debian/keystone.logrotate"}],"source_content_type":"text/x-diff","patch_set":4,"id":"17ea3057_d4a5b00d","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":40},"updated":"2021-11-18 14:43:23.000000000","message":"Should this get installed in python3-keystone? Permission is different than on centos.\n\n+install -p -D -m 755 %{SOURCE103}  %{buildroot}/%{_datarootdir}/keystone/public.py\n\ncontroller-0:~$ rpm -ql python2-keystone-16.0.0-1.el7.tis.21.noarchls -la ^C\ncontroller-0:~$ ls -la /usr/share/keystone/public.py\n-rwxr-xr-x. 1 root root 743 Jul 29 22:22 /usr/share/keystone/public.py","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"e5f398996e4a5a55d3bbe7acfe6171a6a210a576","unresolved":false,"context_lines":[{"line_number":57,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":58,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"},{"line_number":59,"context_line":"+debian/stx/password-rules.conf /etc/keystone"},{"line_number":60,"context_line":"+debian/stx/public.py usr/share/keystone"},{"line_number":61,"context_line":"+debian/stx/keystone.service lib/systemd/system"},{"line_number":62,"context_line":"+debian/stx/keystone-all usr/bin"},{"line_number":63,"context_line":"diff --git a/debian/keystone.logrotate b/debian/keystone.logrotate"}],"source_content_type":"text/x-diff","patch_set":4,"id":"12552bef_8c7a141f","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":40},"in_reply_to":"17ea3057_d4a5b00d","updated":"2021-11-22 15:16:18.000000000","message":"Done","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"104ef8d873b58be65f18d2659d5ebe5124a03dc9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"+++ b/debian/rules"},{"line_number":82,"context_line":"@@ -83,6 +83,7 @@ endif"},{"line_number":83,"context_line":" \tpkgos-fix-config-default $(CURDIR)/debian/keystone/usr/share/keystone/keystone.conf DEFAULT log_file keystone.log"},{"line_number":84,"context_line":" "},{"line_number":85,"context_line":" \tmkdir -p $(CURDIR)/debian/keystone/etc/keystone/policy.d"},{"line_number":86,"context_line":"+\tmkdir -p $(CURDIR)/debian/keystone/etc/keystone/credential-keys"},{"line_number":87,"context_line":" \tPYTHONPATH\u003d$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages oslopolicy-sample-generator \\"}],"source_content_type":"text/x-diff","patch_set":4,"id":"b73d57d3_67b6c45a","line":84,"updated":"2021-11-18 14:43:23.000000000","message":"I\u0027ll assume this is from git format-patch, so ignore it.","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"104ef8d873b58be65f18d2659d5ebe5124a03dc9","unresolved":true,"context_lines":[{"line_number":83,"context_line":" \tpkgos-fix-config-default $(CURDIR)/debian/keystone/usr/share/keystone/keystone.conf DEFAULT log_file keystone.log"},{"line_number":84,"context_line":" "},{"line_number":85,"context_line":" \tmkdir -p $(CURDIR)/debian/keystone/etc/keystone/policy.d"},{"line_number":86,"context_line":"+\tmkdir -p $(CURDIR)/debian/keystone/etc/keystone/credential-keys"},{"line_number":87,"context_line":" \tPYTHONPATH\u003d$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages oslopolicy-sample-generator \\"},{"line_number":88,"context_line":" \t\t--output-file $(CURDIR)/debian/keystone/etc/keystone/policy.d/00_default_policy.yaml \\"},{"line_number":89,"context_line":" \t\t--format yaml \\"}],"source_content_type":"text/x-diff","patch_set":4,"id":"b95aa270_60717701","line":86,"updated":"2021-11-18 14:43:23.000000000","message":"In the end the perm for credential-keys should be 750.","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"e5f398996e4a5a55d3bbe7acfe6171a6a210a576","unresolved":false,"context_lines":[{"line_number":83,"context_line":" \tpkgos-fix-config-default $(CURDIR)/debian/keystone/usr/share/keystone/keystone.conf DEFAULT log_file keystone.log"},{"line_number":84,"context_line":" "},{"line_number":85,"context_line":" \tmkdir -p $(CURDIR)/debian/keystone/etc/keystone/policy.d"},{"line_number":86,"context_line":"+\tmkdir -p $(CURDIR)/debian/keystone/etc/keystone/credential-keys"},{"line_number":87,"context_line":" \tPYTHONPATH\u003d$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages oslopolicy-sample-generator \\"},{"line_number":88,"context_line":" \t\t--output-file $(CURDIR)/debian/keystone/etc/keystone/policy.d/00_default_policy.yaml \\"},{"line_number":89,"context_line":" \t\t--format yaml \\"}],"source_content_type":"text/x-diff","patch_set":4,"id":"09bddc73_14add029","line":86,"in_reply_to":"b95aa270_60717701","updated":"2021-11-22 15:16:18.000000000","message":"Done","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"104ef8d873b58be65f18d2659d5ebe5124a03dc9","unresolved":true,"context_lines":[{"line_number":106,"context_line":"+# Default-Start:     2 3 4 5"},{"line_number":107,"context_line":"+# Default-Stop:      0 1 6"},{"line_number":108,"context_line":"+# Short-Description: OpenStack Keystone"},{"line_number":109,"context_line":"+# Description:       Openstack Identitiy service running on WSGI compatable gunicorn web server "},{"line_number":110,"context_line":"+#"},{"line_number":111,"context_line":"+### END INIT INFO"},{"line_number":112,"context_line":"+"}],"source_content_type":"text/x-diff","patch_set":4,"id":"2a849b41_be7834e6","line":109,"range":{"start_line":109,"start_character":96,"end_line":109,"end_character":97},"updated":"2021-11-18 14:43:23.000000000","message":"nit:whitespace","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"e5f398996e4a5a55d3bbe7acfe6171a6a210a576","unresolved":false,"context_lines":[{"line_number":106,"context_line":"+# Default-Start:     2 3 4 5"},{"line_number":107,"context_line":"+# Default-Stop:      0 1 6"},{"line_number":108,"context_line":"+# Short-Description: OpenStack Keystone"},{"line_number":109,"context_line":"+# Description:       Openstack Identitiy service running on WSGI compatable gunicorn web server "},{"line_number":110,"context_line":"+#"},{"line_number":111,"context_line":"+### END INIT INFO"},{"line_number":112,"context_line":"+"}],"source_content_type":"text/x-diff","patch_set":4,"id":"053d2358_b66f2ca4","line":109,"range":{"start_line":109,"start_character":96,"end_line":109,"end_character":97},"in_reply_to":"2a849b41_be7834e6","updated":"2021-11-22 15:16:18.000000000","message":"Done","commit_id":"b0249d1d89ee6c4690160c3318c23273debf0f96"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"2ea2df52dfafcfd115e35523631b99c08a5caf93","unresolved":true,"context_lines":[{"line_number":73,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":74,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"},{"line_number":75,"context_line":"+debian/stx/password-rules.conf /etc/keystone"},{"line_number":76,"context_line":"+debian/stx/public.py usr/share/keystone"},{"line_number":77,"context_line":"+debian/stx/keystone.service lib/systemd/system"},{"line_number":78,"context_line":"+debian/stx/keystone-all usr/bin"},{"line_number":79,"context_line":"diff --git a/debian/keystone.logrotate b/debian/keystone.logrotate"}],"source_content_type":"text/x-diff","patch_set":5,"id":"18feb051_b80511ee","line":76,"range":{"start_line":76,"start_character":1,"end_line":76,"end_character":40},"updated":"2021-11-22 15:41:22.000000000","message":"remove this","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"a10690c952a1d9cb1edd0e4ea1c179e9c2a9e4e4","unresolved":false,"context_lines":[{"line_number":73,"context_line":" etc/logging.conf.sample\t/usr/share/doc/keystone"},{"line_number":74,"context_line":"+debian/stx/keystone-fernet-keys-rotate-active usr/bin"},{"line_number":75,"context_line":"+debian/stx/password-rules.conf /etc/keystone"},{"line_number":76,"context_line":"+debian/stx/public.py usr/share/keystone"},{"line_number":77,"context_line":"+debian/stx/keystone.service lib/systemd/system"},{"line_number":78,"context_line":"+debian/stx/keystone-all usr/bin"},{"line_number":79,"context_line":"diff --git a/debian/keystone.logrotate b/debian/keystone.logrotate"}],"source_content_type":"text/x-diff","patch_set":5,"id":"50a20786_30da3395","line":76,"range":{"start_line":76,"start_character":1,"end_line":76,"end_character":40},"in_reply_to":"18feb051_b80511ee","updated":"2021-11-22 15:58:04.000000000","message":"Done","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"75d5467a9b642daf26c55502550a3c5b04076089","unresolved":true,"context_lines":[{"line_number":126,"context_line":"+    fi"},{"line_number":127,"context_line":"+"},{"line_number":128,"context_line":"+    # change the permissions on key directories"},{"line_number":129,"context_line":"+    chown keystone:adm /var/log/keystone"},{"line_number":130,"context_line":"+    chmod 0750 /var/log/keystone"},{"line_number":131,"context_line":"+"},{"line_number":132,"context_line":"+    find /etc/keystone -exec chown keystone:keystone \"{}\" +"}],"source_content_type":"text/x-diff","patch_set":5,"id":"afd0434f_2919f2aa","line":129,"range":{"start_line":129,"start_character":11,"end_line":129,"end_character":23},"updated":"2021-11-22 15:45:53.000000000","message":"I wonder if we should chown keystone:keystone, as the rest of the children nodes are.","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"ce4251c27369e5631f18e0b8655bdd09b3e0207d","unresolved":true,"context_lines":[{"line_number":126,"context_line":"+    fi"},{"line_number":127,"context_line":"+"},{"line_number":128,"context_line":"+    # change the permissions on key directories"},{"line_number":129,"context_line":"+    chown keystone:adm /var/log/keystone"},{"line_number":130,"context_line":"+    chmod 0750 /var/log/keystone"},{"line_number":131,"context_line":"+"},{"line_number":132,"context_line":"+    find /etc/keystone -exec chown keystone:keystone \"{}\" +"}],"source_content_type":"text/x-diff","patch_set":5,"id":"65e746d4_5965c154","line":129,"range":{"start_line":129,"start_character":11,"end_line":129,"end_character":23},"in_reply_to":"21e1a592_4a66baf0","updated":"2021-11-22 16:53:49.000000000","message":"seems we will be removing the adm group: https://review.opendev.org/c/starlingx/integ/+/810563/5..6/base/base-passwd/debian/patches/0001-Change-group-passwd-and-uidgid.patch#28","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"d656c165b0b84035ea381bf814918f9abf9c49b5","unresolved":true,"context_lines":[{"line_number":126,"context_line":"+    fi"},{"line_number":127,"context_line":"+"},{"line_number":128,"context_line":"+    # change the permissions on key directories"},{"line_number":129,"context_line":"+    chown keystone:adm /var/log/keystone"},{"line_number":130,"context_line":"+    chmod 0750 /var/log/keystone"},{"line_number":131,"context_line":"+"},{"line_number":132,"context_line":"+    find /etc/keystone -exec chown keystone:keystone \"{}\" +"}],"source_content_type":"text/x-diff","patch_set":5,"id":"ff41a200_86e91728","line":129,"range":{"start_line":129,"start_character":11,"end_line":129,"end_character":23},"in_reply_to":"65e746d4_5965c154","updated":"2021-11-23 02:02:55.000000000","message":"Why?","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c4515738359ba04d3d165b89a27bcda5d2ac8c9c","unresolved":true,"context_lines":[{"line_number":126,"context_line":"+    fi"},{"line_number":127,"context_line":"+"},{"line_number":128,"context_line":"+    # change the permissions on key directories"},{"line_number":129,"context_line":"+    chown keystone:adm /var/log/keystone"},{"line_number":130,"context_line":"+    chmod 0750 /var/log/keystone"},{"line_number":131,"context_line":"+"},{"line_number":132,"context_line":"+    find /etc/keystone -exec chown keystone:keystone \"{}\" +"}],"source_content_type":"text/x-diff","patch_set":5,"id":"21e1a592_4a66baf0","line":129,"range":{"start_line":129,"start_character":11,"end_line":129,"end_character":23},"in_reply_to":"afd0434f_2919f2aa","updated":"2021-11-22 15:58:18.000000000","message":"It should be fine.","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"2fb9be6832ad229701f5c9c95e0775c9270f53d5","unresolved":true,"context_lines":[{"line_number":126,"context_line":"+    fi"},{"line_number":127,"context_line":"+"},{"line_number":128,"context_line":"+    # change the permissions on key directories"},{"line_number":129,"context_line":"+    chown keystone:adm /var/log/keystone"},{"line_number":130,"context_line":"+    chmod 0750 /var/log/keystone"},{"line_number":131,"context_line":"+"},{"line_number":132,"context_line":"+    find /etc/keystone -exec chown keystone:keystone \"{}\" +"}],"source_content_type":"text/x-diff","patch_set":5,"id":"e285b83c_6a435c0b","line":129,"range":{"start_line":129,"start_character":11,"end_line":129,"end_character":23},"in_reply_to":"ff41a200_86e91728","updated":"2021-11-23 10:28:50.000000000","message":"I\u0027m assuming it is security related.","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"2ea2df52dfafcfd115e35523631b99c08a5caf93","unresolved":true,"context_lines":[{"line_number":420,"context_line":"@@ -1,2 +1,3 @@"},{"line_number":421,"context_line":" usr/bin/*"},{"line_number":422,"context_line":" usr/lib/python3/*"},{"line_number":423,"context_line":"+debian/public.py usr/lib/python3/keystone/public.py"},{"line_number":424,"context_line":"diff --git a/debian/rules b/debian/rules"},{"line_number":425,"context_line":"index 3744142f9..881abf05f 100755"},{"line_number":426,"context_line":"--- a/debian/rules"}],"source_content_type":"text/x-diff","patch_set":5,"id":"1172e12d_850f18b6","line":423,"range":{"start_line":423,"start_character":1,"end_line":423,"end_character":52},"updated":"2021-11-22 15:41:22.000000000","message":"debian/stx/public.py usr/share/keystone","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"a10690c952a1d9cb1edd0e4ea1c179e9c2a9e4e4","unresolved":false,"context_lines":[{"line_number":420,"context_line":"@@ -1,2 +1,3 @@"},{"line_number":421,"context_line":" usr/bin/*"},{"line_number":422,"context_line":" usr/lib/python3/*"},{"line_number":423,"context_line":"+debian/public.py usr/lib/python3/keystone/public.py"},{"line_number":424,"context_line":"diff --git a/debian/rules b/debian/rules"},{"line_number":425,"context_line":"index 3744142f9..881abf05f 100755"},{"line_number":426,"context_line":"--- a/debian/rules"}],"source_content_type":"text/x-diff","patch_set":5,"id":"df1d27eb_45e5a792","line":423,"range":{"start_line":423,"start_character":1,"end_line":423,"end_character":52},"in_reply_to":"1172e12d_850f18b6","updated":"2021-11-22 15:58:04.000000000","message":"Done","commit_id":"3d9e269ed3dc79942d6ba371e7c1bbfa81106616"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4d7a88137d1d9e6c18174a5ebaaf815e5755b91d","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Apply Centos 7 patches to the debian packaging."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Signed-off-by: Charles Short \u003cchucks@redhat.com\u003e"},{"line_number":9,"context_line":"---"},{"line_number":10,"context_line":" debian/control                                |   3 +-"},{"line_number":11,"context_line":" debian/keystone.dirs                          |   1 +"}],"source_content_type":"text/x-diff","patch_set":7,"id":"c9e574d1_e76e6f29","line":8,"range":{"start_line":8,"start_character":30,"end_line":8,"end_character":48},"updated":"2021-11-25 01:20:22.000000000","message":"I was thinking its funny the gerrit email is your new address and this patch email is your old one","commit_id":"e866623a4fe0cebc0d0f6a7b3384e5c412ed18d0"}]}