)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"75baa8890cfea72ea03e3973123608addb3b62da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03fac0d0_0f9420f0","updated":"2023-08-30 19:41:29.000000000","message":"I think we need to split the \u0027upstream\u0027 repo.  perhaps ...\n\nupstream-openstack\nupstream-starlingx\nupstream-common","commit_id":"7462831bf45f28a8166e2776a4fd09769ca10e57"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"d80884ac87449e33d79b86daa9b3e6b375b2b0b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04bb3adf_450303e5","updated":"2023-09-07 17:50:25.000000000","message":"Holding this review until we make sure that we use the python-openstack-client packages upstream packages dependencies, rather than building ones here.","commit_id":"0a490cffc2a762f4727432a832974e63eaa4eddd"}],"debian_iso_image.inc":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"d53a7345fdd1ba3b5a49ba57b94d8817e2b3d576","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#python-openstackclient"},{"line_number":30,"context_line":"python-openstackclient-doc"},{"line_number":31,"context_line":"python3-openstackclient"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#python-osc-lib"},{"line_number":34,"context_line":"python-osc-lib-doc"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"6d75b2f6_d67de8b2","line":31,"updated":"2023-09-07 17:02:14.000000000","message":"Q: I recall that the openstack client may actually rely on these other clients being present even though their services are not used in the platform. That true? For example, what happens if you execue volume/image commands in the openstack client and the underlying cinder/glance clients are not present?","commit_id":"0a490cffc2a762f4727432a832974e63eaa4eddd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"d80884ac87449e33d79b86daa9b3e6b375b2b0b6","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#python-openstackclient"},{"line_number":30,"context_line":"python-openstackclient-doc"},{"line_number":31,"context_line":"python3-openstackclient"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#python-osc-lib"},{"line_number":34,"context_line":"python-osc-lib-doc"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"cec7e379_e7863d36","line":31,"in_reply_to":"663dea45_c8f66a3c","updated":"2023-09-07 17:50:25.000000000","message":"That is a very good point actually.\n\nWell, since the platform only uses a restricted set of openstack services (e.g. keystone, barbican) if the openstack client would throw runtime errors when trying to run volume/image commands, that could be good feedback for an user, right? I mean, if use needs this type of openstack services, the openstack application needs to be installed...\n\nBut looking at the python-openstackclient debian/control file [1] it is possible to verify that all openstack clients are listed under Build-Depends-Indep, so they need to be available in build time.\nAlso, the openstack-client docker image is currently installing other openstack clients using PIP [2].\n\nThe best way to go here is to have a clean build env with this change cherry-picked and ensure that we are not building those clients, but rather downloading it as build dependencies (on the required version).\n\n[1] https://salsa.debian.org/openstack-team/clients/python-openstackclient/-/blob/debian/5.4.0-4/debian/control#L18\n[2] https://opendev.org/starlingx/upstream/src/branch/master/openstack/python-openstackclient/debian/stx-openstackclient.stable_docker_image#L6","commit_id":"0a490cffc2a762f4727432a832974e63eaa4eddd"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"d761017189094168936a9b89202ea455c8a5f399","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#python-openstackclient"},{"line_number":30,"context_line":"python-openstackclient-doc"},{"line_number":31,"context_line":"python3-openstackclient"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#python-osc-lib"},{"line_number":34,"context_line":"python-osc-lib-doc"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"663dea45_c8f66a3c","line":31,"in_reply_to":"6d75b2f6_d67de8b2","updated":"2023-09-07 17:13:11.000000000","message":"If so, then I think we just need to make sure that we use the upstream packages rather than building ones here.","commit_id":"0a490cffc2a762f4727432a832974e63eaa4eddd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"0e17cf7d299b15301693243cbc330bb3206c0dda","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#python-openstackclient"},{"line_number":30,"context_line":"python-openstackclient-doc"},{"line_number":31,"context_line":"python3-openstackclient"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#python-osc-lib"},{"line_number":34,"context_line":"python-osc-lib-doc"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"4f458851_38c1fb9f","line":31,"in_reply_to":"79057be0_792fce83","updated":"2023-09-13 13:47:14.000000000","message":"Done","commit_id":"0a490cffc2a762f4727432a832974e63eaa4eddd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"b0207b7dadd842898a20d30ef187d266bb39e061","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#python-openstackclient"},{"line_number":30,"context_line":"python-openstackclient-doc"},{"line_number":31,"context_line":"python3-openstackclient"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#python-osc-lib"},{"line_number":34,"context_line":"python-osc-lib-doc"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"79057be0_792fce83","line":31,"in_reply_to":"cec7e379_e7863d36","updated":"2023-09-13 13:17:27.000000000","message":"Lucas already updated this commit message with the Depends-On change that includes the hard requirements for openstack client to be installed int our ISO.\nIt seems enough for this change to build and generate testable ISOs from f/antelope for us to isolate any possible side-effects before merging it back to master.\n\nWhat do you thinkg Bob?","commit_id":"0a490cffc2a762f4727432a832974e63eaa4eddd"}]}