)]}'
{"utilities/logmgmt/logmgmt/logmgmt/logmgmt.py":[{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"0c8c4988d87a0567fab53f8b1a5ba4da435b01eb","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.monitored_files \u003d []"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            output \u003d subprocess.check_output([\u0027sudo\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-d\u0027, \u0027/etc/logrotate.conf\u0027],"},{"line_number":123,"context_line":"                                             stderr\u003dsubprocess.STDOUT)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            for line in output.decode().split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_38ca7e19","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":55},"updated":"2020-04-24 07:59:37.000000000","message":"Could you share me why sudo is needed?","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":30967,"name":"Long Li","email":"lilong-neu@neusoft.com","username":"LongLi"},"change_message_id":"3d7733b55b3e7370ba9ff42041306da9db2f2b6f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.monitored_files \u003d []"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            output \u003d subprocess.check_output([\u0027sudo\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-d\u0027, \u0027/etc/logrotate.conf\u0027],"},{"line_number":123,"context_line":"                                             stderr\u003dsubprocess.STDOUT)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            for line in output.decode().split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_1f6823b7","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":55},"in_reply_to":"1f493fa4_38ca7e19","updated":"2020-04-27 06:23:47.000000000","message":"I test it again, \nit is no needed indeed.","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"adf9cac333b15c4742e00e47ca02f6d8723fc1b8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.monitored_files \u003d []"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            output \u003d subprocess.check_output([\u0027sudo\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-d\u0027, \u0027/etc/logrotate.conf\u0027],"},{"line_number":123,"context_line":"                                             stderr\u003dsubprocess.STDOUT)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            for line in output.decode().split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_716edc01","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":55},"in_reply_to":"1f493fa4_38ca7e19","updated":"2020-04-24 14:44:16.000000000","message":"sudo should not be needed. This daemon is run as root.","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":30967,"name":"Long Li","email":"lilong-neu@neusoft.com","username":"LongLi"},"change_message_id":"3d7733b55b3e7370ba9ff42041306da9db2f2b6f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.monitored_files \u003d []"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            output \u003d subprocess.check_output([\u0027sudo\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-d\u0027, \u0027/etc/logrotate.conf\u0027],"},{"line_number":123,"context_line":"                                             stderr\u003dsubprocess.STDOUT)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            for line in output.decode().split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_7f6167d3","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":55},"in_reply_to":"1f493fa4_716edc01","updated":"2020-04-27 06:23:47.000000000","message":"Done","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"0c8c4988d87a0567fab53f8b1a5ba4da435b01eb","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def run_logrotate_forced(self):"},{"line_number":180,"context_line":"        self.last_logrotate \u003d int(time.time())"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            subprocess.check_call([\u0027sudo -v\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-f\u0027, \u0027/etc/logrotate.conf\u0027], shell\u003dTrue)"},{"line_number":183,"context_line":"        except:"},{"line_number":184,"context_line":"            logging.error(\u0027Failed logrotate -f\u0027)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_58f02a68","line":182,"range":{"start_line":182,"start_character":36,"end_line":182,"end_character":46},"updated":"2020-04-24 07:59:37.000000000","message":"could you share me why it is different with upper cmd?","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"9877776c62e34f50fef140385d7dd8dfbfd2d8ea","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def run_logrotate_forced(self):"},{"line_number":180,"context_line":"        self.last_logrotate \u003d int(time.time())"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            subprocess.check_call([\u0027sudo -v\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-f\u0027, \u0027/etc/logrotate.conf\u0027], shell\u003dTrue)"},{"line_number":183,"context_line":"        except:"},{"line_number":184,"context_line":"            logging.error(\u0027Failed logrotate -f\u0027)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_bfc80f22","line":182,"range":{"start_line":182,"start_character":36,"end_line":182,"end_character":46},"in_reply_to":"1f493fa4_1fadc3e8","updated":"2020-04-27 07:06:45.000000000","message":"still not clear why sudo is needed, since it is root process already. Could you help check original python2 code could work or not? And explain why this change is needed in python3.","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":30967,"name":"Long Li","email":"lilong-neu@neusoft.com","username":"LongLi"},"change_message_id":"3d7733b55b3e7370ba9ff42041306da9db2f2b6f","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def run_logrotate_forced(self):"},{"line_number":180,"context_line":"        self.last_logrotate \u003d int(time.time())"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            subprocess.check_call([\u0027sudo -v\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-f\u0027, \u0027/etc/logrotate.conf\u0027], shell\u003dTrue)"},{"line_number":183,"context_line":"        except:"},{"line_number":184,"context_line":"            logging.error(\u0027Failed logrotate -f\u0027)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_1fadc3e8","line":182,"range":{"start_line":182,"start_character":36,"end_line":182,"end_character":46},"in_reply_to":"1f493fa4_58f02a68","updated":"2020-04-27 06:23:47.000000000","message":"this command is different with upper cmd,\nas it is forced to logrotate, extra argument of \u0027-f\u0027\nI test it again, without the change, logmgmt.log will print for \u0027Failed logrotate -f\u0027\nand returned non-zero exit status 1, with the change, it return 0, and no error.","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"42d508a850aa1833817df18caa29383c297cda61","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def run_logrotate_forced(self):"},{"line_number":180,"context_line":"        self.last_logrotate \u003d int(time.time())"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            subprocess.check_call([\u0027sudo -v\u0027, \u0027/usr/sbin/logrotate\u0027, \u0027-f\u0027, \u0027/etc/logrotate.conf\u0027], shell\u003dTrue)"},{"line_number":183,"context_line":"        except:"},{"line_number":184,"context_line":"            logging.error(\u0027Failed logrotate -f\u0027)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_a0fd86b2","line":182,"range":{"start_line":182,"start_character":36,"end_line":182,"end_character":46},"in_reply_to":"1f493fa4_bfc80f22","updated":"2020-04-27 15:06:52.000000000","message":"Did you try running \"logrotate -f /etc/logrotate.conf\" manually in your system? Otherwise, you may want to change this to a check_output and capture/log the stderr and stdout to see what\u0027s actually failing here.\n\nsudo should not be needed.","commit_id":"fd13cfc78edc648d33e39650adf25551ddcff1cd"}]}