)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"1e2783a77865bc52f24fda91572a12731962571f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen, Haochuan Z \u003chaochuan.z.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-26 09:11:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add package python2-oslo-config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: 1920882"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a1f121b9_d5cabf84","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2021-03-26 16:27:30.000000000","message":"This title and commit message is too generic. Add package to what?","commit_id":"43be23116a3240aedc9b928de5e18a7a42387afa"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"43c576f501869dfefbead1d0e49bad0339c05d12","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen, Haochuan Z \u003chaochuan.z.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-26 09:11:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add package python2-oslo-config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: 1920882"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"037c91ac_a846a92e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"a1f121b9_d5cabf84","updated":"2021-03-27 15:25:50.000000000","message":"install python2-oslo-config in docker image stx-ceph-manager","commit_id":"43be23116a3240aedc9b928de5e18a7a42387afa"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"2de4607375ec31ab47d976c7830ad14578c2c638","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen, Haochuan Z \u003chaochuan.z.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-27 23:12:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install package python2-oslo-config, ceph-mgr, ceph-osd and ceph-mon"},{"line_number":8,"context_line":"in stx-ceph-manager docker image. Package install from repo stx-mirror"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Partial-Bug: 1920882"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6fc7609d_e51d3525","line":7,"updated":"2021-03-28 15:05:43.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nTitle line should be brief, single sentence, ideally kept to 50 characters. Fuller description can follow in a separate paragraph.\n\nsuch as:\n\nAdd packages to stx-ceph-manager image\n\nThis update installs python2-oslo-config and ceph packages as part\nof stx-ceph-manager image.","commit_id":"bb1eff7664146b85cb18705dad51c3f84cd36603"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"ce5ce5cdb801abbaac4dc64de37fd57f9ac0c76c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen, Haochuan Z \u003chaochuan.z.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-27 23:12:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install package python2-oslo-config, ceph-mgr, ceph-osd and ceph-mon"},{"line_number":8,"context_line":"in stx-ceph-manager docker image. Package install from repo stx-mirror"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Partial-Bug: 1920882"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"94efa695_c05c3ae7","line":7,"in_reply_to":"6fc7609d_e51d3525","updated":"2021-03-29 11:38:20.000000000","message":"Updated. Thanks","commit_id":"bb1eff7664146b85cb18705dad51c3f84cd36603"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"bca23b34d68f2bdd82bd72d2cbcf441bc325bdfc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add packages to stx-ceph-manager image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This update installs python2-oslo-config and ceph packages as part"},{"line_number":10,"context_line":"of stx-ceph-manager image."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: 1920882"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dedf3f63_054dfc92","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":41},"updated":"2021-04-01 13:20:51.000000000","message":"This is now inaccurate","commit_id":"8278185bbba492c7927c408be94123a724ef1476"}],"ceph/ceph-manager/centos/docker/Dockerfile":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"1e2783a77865bc52f24fda91572a12731962571f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        python-cephclient       \\"},{"line_number":12,"context_line":"        python-oslo-messaging   \\"},{"line_number":13,"context_line":"        python2-eventlet        \\"},{"line_number":14,"context_line":"        python2-oslo-confing    \\"},{"line_number":15,"context_line":"        fm-api                  \\"},{"line_number":16,"context_line":"        fm-core                 \\"},{"line_number":17,"context_line":"        fm-rest-api             \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"1f31117a_eeaa84a1","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":32},"updated":"2021-03-26 16:27:30.000000000","message":"Typo in the module name. Did you test this build?","commit_id":"43be23116a3240aedc9b928de5e18a7a42387afa"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"43c576f501869dfefbead1d0e49bad0339c05d12","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        python-cephclient       \\"},{"line_number":12,"context_line":"        python-oslo-messaging   \\"},{"line_number":13,"context_line":"        python2-eventlet        \\"},{"line_number":14,"context_line":"        python2-oslo-confing    \\"},{"line_number":15,"context_line":"        fm-api                  \\"},{"line_number":16,"context_line":"        fm-core                 \\"},{"line_number":17,"context_line":"        fm-rest-api             \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"48c106de_50353e9c","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":32},"in_reply_to":"1f31117a_eeaa84a1","updated":"2021-03-27 15:25:50.000000000","message":"This is my built image. It could build successfully.\n\nhttps://hub.docker.com/layers/chenhaochuan82/stx-ceph-manager/202103270851/images/sha256-64ce0f3081c9e0512e8786de74ede0f4fa235c9e3b36109055c911692f044183?context\u003dexplore","commit_id":"43be23116a3240aedc9b928de5e18a7a42387afa"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"2de4607375ec31ab47d976c7830ad14578c2c638","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        python-cephclient       \\"},{"line_number":14,"context_line":"        python-oslo-messaging   \\"},{"line_number":15,"context_line":"        python2-eventlet        \\"},{"line_number":16,"context_line":"        python2-oslo-confing    \\"},{"line_number":17,"context_line":"        fm-api                  \\"},{"line_number":18,"context_line":"        fm-core                 \\"},{"line_number":19,"context_line":"        fm-rest-api             \\"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"799e43c9_36d9baaf","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":32},"updated":"2021-03-28 15:05:43.000000000","message":"Again, this module name has a typo and will not install.\n\nTry adding --setopt\u003dskip_missing_names_on_install\u003dFalse to the yum install options, which would catch this sort of error.\n\npython2-oslo-config is getting installed in your image due to dependencies. If you look at your image build logs, you will see an error","commit_id":"bb1eff7664146b85cb18705dad51c3f84cd36603"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"f11da91abba40e646c160fe1db5517432a7acf17","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        python-cephclient       \\"},{"line_number":14,"context_line":"        python-oslo-messaging   \\"},{"line_number":15,"context_line":"        python2-eventlet        \\"},{"line_number":16,"context_line":"        python2-oslo-confing    \\"},{"line_number":17,"context_line":"        fm-api                  \\"},{"line_number":18,"context_line":"        fm-core                 \\"},{"line_number":19,"context_line":"        fm-rest-api             \\"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"de617338_fc47a290","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":32},"in_reply_to":"48ef04bf_853628ff","updated":"2021-03-29 12:44:56.000000000","message":"I tried --setopt\u003dskip_missing_names_on_install\u003dFalse with your update and had a failure because there is no \"fm-core\" package. Please add this option and remove fm-core from the list.\n\nAs well, given that python2-oslo-config was being installed due to dependencies, why explicitly install it? This list of packages should be those that you directly need, and allow dependencies to pull in the other packages that are needed.","commit_id":"bb1eff7664146b85cb18705dad51c3f84cd36603"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"ce5ce5cdb801abbaac4dc64de37fd57f9ac0c76c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        python-cephclient       \\"},{"line_number":14,"context_line":"        python-oslo-messaging   \\"},{"line_number":15,"context_line":"        python2-eventlet        \\"},{"line_number":16,"context_line":"        python2-oslo-confing    \\"},{"line_number":17,"context_line":"        fm-api                  \\"},{"line_number":18,"context_line":"        fm-core                 \\"},{"line_number":19,"context_line":"        fm-rest-api             \\"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"48ef04bf_853628ff","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":32},"in_reply_to":"799e43c9_36d9baaf","updated":"2021-03-29 11:38:20.000000000","message":"Fix typo. Thanks","commit_id":"bb1eff7664146b85cb18705dad51c3f84cd36603"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"15ff4392d9ee307f68b52888a1cf09d5b7d77a12","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        python-cephclient       \\"},{"line_number":15,"context_line":"        python-oslo-messaging   \\"},{"line_number":16,"context_line":"        python2-eventlet        \\"},{"line_number":17,"context_line":"        python2-oslo-config     \\"},{"line_number":18,"context_line":"        fm-api                  \\"},{"line_number":19,"context_line":"        fm-rest-api             \\"},{"line_number":20,"context_line":"        python-fmclient         \\"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"52433b4f_84d5ebff","line":17,"updated":"2021-03-31 03:25:55.000000000","message":"To repeat my previous comment:\n\nGiven that python2-oslo-config was being installed due to dependencies, why explicitly install it? This list of packages should be those that you directly need, and allow dependencies to pull in the other packages that are needed.","commit_id":"213ecf7115bf2f5b5c7e00c8a7f6694042d01f77"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"58089169f1768f6f5e1e57604d0ebf19a2bdbfed","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        python-cephclient       \\"},{"line_number":15,"context_line":"        python-oslo-messaging   \\"},{"line_number":16,"context_line":"        python2-eventlet        \\"},{"line_number":17,"context_line":"        python2-oslo-config     \\"},{"line_number":18,"context_line":"        fm-api                  \\"},{"line_number":19,"context_line":"        fm-rest-api             \\"},{"line_number":20,"context_line":"        python-fmclient         \\"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"4c7bd003_e0036af2","line":17,"in_reply_to":"52433b4f_84d5ebff","updated":"2021-03-31 05:38:47.000000000","message":"I used to use image chenhaochuan82/stx-ceph-manager:202012011338 on docker hub. And find \"import config\" fail. So these day update this image to add this package, and together I add ceph-osd, ceph-mon, and ceph-mgr, but these three package must download from repo stx-mirror-distro(update with \"grep \u0027^name\u003dstx\u0027 ${STX_REPO_FILE}\" in thi command add stx). But maybe change repo to stx-mirror-distro, it will add python2-oslo-config as dependency. Now already remove this package in  Dockerfile and build with this image chenhaochuan82/stx-ceph-manager:202103311317. Image works fine.","commit_id":"213ecf7115bf2f5b5c7e00c8a7f6694042d01f77"}]}